Re: Review Request: Some changes to make Amarok appearance more pretty

2012-06-01 Thread Lucas Gomes
On March 22, 2012, 10:04 p.m., Lucas Gomes wrote: Could you please explain what are the benefits (direct, current - not hypothetical or philosofical) of the TreeItem - NormalTreeItem, MergedTreeItem split? Where exactly is avoids code duplication? Ok, first ignore revision five. In it

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-06-01 Thread Lucas Gomes
On March 22, 2012, 10:04 p.m., Lucas Gomes wrote: Could you please explain what are the benefits (direct, current - not hypothetical or philosofical) of the TreeItem - NormalTreeItem, MergedTreeItem split? Where exactly is avoids code duplication? Lucas Gomes wrote: Ok, first

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-05-26 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review14180 --- This is outstanding since quite some time. I liked it somehow.

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-03-23 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review11771 --- src/browsers/AbstractTreeViewDelegate.h

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-30 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review10222 --- The screenshots look good. Perhaps some font effects (italics,

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-30 Thread Lucas Gomes
On Jan. 30, 2012, 8:17 a.m., Bart Cerneels wrote: The screenshots look good. Perhaps some font effects (italics, bold) can be added to highlight channels with new episodes to make it even more intuitive? Have not take a better look at the code yet. My remark on an early version

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-27 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/ --- (Updated Jan. 27, 2012, 1:11 a.m.) Review request for Amarok and Bart

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-19 Thread Matěj Laitl
On 18. 1. 2012 Lucas Lira Gomes wrote: Hi everyone, Does anybody else but Myriam doesn't liked the extra info on the CollectionBrowser? If you haven't opined yet please let us know what's your opinion and explain why you prefer one way or another. I agree with Myriam. Track count is useful

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-18 Thread Nikita Skovoroda
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review9902 --- I am not a kde developer, but to me it looks like the items on

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-18 Thread Lorenz Röhrl
Hi, So, please help me to improve this feature even more by answering some questions: 1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser too? 2) Is there any extra information that you think it's relevant to be showed somewhere (In QTreeViews)? I really

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-18 Thread Myriam Schweingruber
On Wed, Jan 18, 2012 at 10:56, Lorenz Röhrl sheeps...@gmx.de wrote: Hi, So, please help me to improve this feature even more by answering some questions: 1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser too? 2) Is there any extra information that you think

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-18 Thread Lucas Lira Gomes
Hi everyone, Does anybody else but Myriam doesn't liked the extra info on the CollectionBrowser? If you haven't opined yet please let us know what's your opinion and explain why you prefer one way or another. Maybe Myriam is right, but this feature could be possibly like the album art. You

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-15 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review9846 --- Some problems with plural localization. Apart from that the fix

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-04 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/ --- (Updated Jan. 4, 2012, 12:52 a.m.) Review request for Amarok and Bart

Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/ --- Review request for Amarok and Bart Cerneels. Description --- This is

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/ --- (Updated Jan. 2, 2012, 1:29 a.m.) Review request for Amarok and Bart

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review9423 --- Lucas, thanks for your review request. This is a rather bigger

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/ --- (Updated Jan. 2, 2012, 2:38 p.m.) Review request for Amarok and Bart