Re: Tidying up password storage in Amarok

2012-04-13 Thread Thomas Pfeiffer
On 11.04.2012 22:21, Andrzej J. R. Hunt wrote: Therefore I think it's probably better to work on the assumption that all passwords are stored on disk -- I wouldn't think it too unreasonable to expect those, who want a specific password not to be in plaintext, to go to the bother of setting up

Re: Tidying up password storage in Amarok

2012-04-13 Thread Bart Cerneels
On Thu, Apr 12, 2012 at 22:22, Matěj Laitl ma...@laitl.cz wrote: On 11. 4. 2012 Andrzej J. R. Hunt wrote: I've just been looking at the way all the plugins use their passwords. It seems a redesign would be needed to allow password entry manually: currently the plugins stay disabled until a

Re: Tidying up password storage in Amarok

2012-04-13 Thread Matěj Laitl
On 13. 4. 2012 Bart Cerneels wrote: Incidentally the MySQL configuration interface is implemented using KConfigXT (an xml file which is translated to c++, which then writes to plaintext, if I've understood it correctly), i.e. the settings aren't stored in KWallet. I'll look into

Re: Tidying up password storage in Amarok

2012-04-13 Thread Matěj Laitl
On 13. 4. 2012 Bart Cerneels wrote: I don't think it's really needed to move that to KWallet. What do you mean by that here? Login name? Database name? Database password? database credentials in general. i.e. there is not real need for the database config to use kwallet. I oppose

Re: Tidying up password storage in Amarok

2012-04-12 Thread Andrzej J. R. Hunt
On 10/04/12 20:16, Matěj Laitl wrote: On 10. 4. 2012 Stefan Derkits wrote: Hmm, I may want to allow storing last.fm password in plain-text while disabling to store MySQL pass in plain-text. The confirmation should be probably per-plugin then. that sounds a little bit not so user-friendly

Tidying up password storage in Amarok

2012-04-10 Thread Andrzej J. R. Hunt
Hi, I'd like to propose some changes to password storage in amarok, in particular the way KWallet is dealt with, and what is done if not available. I noticed that there seem to be a number of different ways password storage is done in amarok, with each plugin having some unique way of doing

Re: Tidying up password storage in Amarok

2012-04-10 Thread Matěj Laitl
On 9. 4. 2012 Andrzej J. R. Hunt wrote: I'd like to propose some changes to password storage in amarok, in particular the way KWallet is dealt with, and what is done if not available. Good. This is IMO needed. Most plugins use KWallet, but some resort to plaintext if KWallet isn't available

Re: Tidying up password storage in Amarok

2012-04-10 Thread Stefan Derkits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 04/10/2012 07:21 PM, Matěj Laitl wrote: Hmm, I may want to allow storing last.fm password in plain-text while disabling to store MySQL pass in plain-text. The confirmation should be probably per-plugin then. that sounds a little bit not so

Re: Tidying up password storage in Amarok

2012-04-10 Thread Matěj Laitl
On 10. 4. 2012 Stefan Derkits wrote: Hmm, I may want to allow storing last.fm password in plain-text while disabling to store MySQL pass in plain-text. The confirmation should be probably per-plugin then. that sounds a little bit not so user-friendly (having to confirm secure storage for