This revision was automatically updated to reflect the committed changes.
Closed by commit R181:c9257ade2df7: Fix some deprecation warnings (authored by
malteveerman, committed by markey).
REPOSITORY
R181 Amarok
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11033?vs=28634=28974
markey accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R181 Amarok
BRANCH
kf5
REVISION DETAIL
https://phabricator.kde.org/D11033
To: malteveerman, #amarok, markey
Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar,
On Wed, Mar 07, 2018 at 08:49:43PM +0100, Heiko Becker wrote:
> Hello everybody,
>
> as it may be customary for the upcoming season the Amarok team did some
> spring cleaning and is proud to announce the immediate release of Amarok
> 2.9.0. While we realize that the clock has run out on KDELibs 4
Hi Alex,
> I got the source code right away but when I try to build the kf5 branch I
> get an error that it can't find FindMygpo-qt5.cmake (I installed
> libmygpo-qt5-devel, I'm using Fedora). I searched through my system and
> indeed there's no FindMygpo-qt5. Any idea where I can find that file?
On Wed, Mar 07, 2018 at 10:13:38PM +0100, Heiko Becker wrote:
> Hi Alex,
>
> > I got the source code right away but when I try to build the kf5 branch I
> > get an error that it can't find FindMygpo-qt5.cmake (I installed
> > libmygpo-qt5-devel, I'm using Fedora). I searched through my system and
Hi,
Apparently you need a pretty new libmygpo-qt and add this pull request:
https://github.com/gpodder/libmygpo-qt/pull/12
I finally had time to check out the Merge Request. If nothing else comes
up in the porting, I will soon release a 1.10 version and then KF5
Amarok can depend on this
Hi,
as it turns out merging the kf5 branch into master wasn't that difficult
after all and so I just pushed it to git.kde.org. This means master is
now based on Qt5/KF5.
I also created a 2.9 branch earlier for possible bug fixes for 2.9.0.
Cheers,
Heiko
On 03/07/18 22:44, Alex Arvelaez wrote:
> How do I stop cmake from building the tests? I'm getting an error about
> missing libgmock, I tried passing -DKDE4_BUILD_TESTS=OFF to cmake but
> it didn't do much.
-DBUILD_TESTING=OFF (which is the canonical cmake option for that)
Cheers,
Heiko
