-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100582/#review1728
-----------------------------------------------------------

Ship it!


You can push this without rebasing against IncrementalOpmlDirectory or waiting 
for me to push that. Just merge your branch and I'll rebase on top of that. My 
changes build on top of the OPML stuff you already have so it will be easy to 
merge for me.

- Bart


On March 1, 2011, 11:50 p.m., Stefan Derkits wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100582/
> -----------------------------------------------------------
> 
> (Updated March 1, 2011, 11:50 p.m.)
> 
> 
> Review request for Amarok, Leo Franchi and Bart Cerneels.
> 
> 
> Summary
> -------
> 
> Info about gpodder.net: "gpodder.net is a web service to manage your podcast 
> subscriptions via the web. You can synchronize your devices, view status 
> information and discover new interesting podcasts online."
> 
> Note: not yet ready for integration, only wanted to already open the Review 
> Request to make our work more public and get Feedback
> Additional Note: we've pulled the branch stecchino-IncrementalOpmlDirectory 
> into our Branch ... so the Files related to Opml & the OpmlDirectory are not 
> "up for Review" here and will be removed from the diff sometime in the Future 
> ;)
> 
> Additional Dependency for this Service: libmygpo-qt 
> (http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.0.10.tar.gz or 
> https://github.com/ase23/libmygpo-qt)
> 
> What is added by this Service:
> -) a new ServicePlugin with a Config Dialog for gpodder.net Username 
> (synchronise checkbox doesn't do anything at the moment)
> -) a gpodder Entry (internet/gpodder) where you can find the TopTags & 
> TopPodcasts of these Tags from gpodder.net (not many Tags & Podcast per Tag 
> yet, after testing is done we will set it to 50 or 100)
> -) a PodcastProvider that should display the Podcasts subscribed to on 
> gpodder.net and be able to add a Subscription to gpodder.net (subscribing 
> doesn't work yet and displaying has some Bugs)
> 
> What Features will come in the Future:
> -) display Podcast Data from gpodder.net
> -) synchronization of Episode Status (if you listen to an Episode on your 
> phone, it should show up in Amarok as "not new")
> -) synchronization of Listening Status (you start to listen to an Episode in 
> Amarok, finish it halfways, click pause/stop and 
> 
> 
> Diffs
> -----
> 
>   .gitignore b0ad614ce230efbcfcf4f2a84ee7b499caa09116 
>   CMakeLists.txt 11d4c9d5a296560f1c779e1dee4405c9827dac91 
>   README d8c142968c2da3888a703cc2b2e38d854f5c868b 
>   cmake/modules/FindLibmygpo-qt.cmake PRE-CREATION 
>   src/OpmlOutline.h 8b64dc1c798215e8edbd9081bcd9003a1fe8046e 
>   src/OpmlOutline.cpp 5a3d6532b7d06524aeea30705b32fed04426c50e 
>   src/OpmlParser.h 28c6c0c1d3ec904f418ef6115bc70258e8badd4a 
>   src/OpmlParser.cpp 017c6c28c16079ac62f5a6fc10b225458b26d38e 
>   src/OpmlWriter.h c28e76dc73fb575abbc0d8255f0a1d55ca2b5969 
>   src/OpmlWriter.cpp 13a9bf8196ed2a2d0ec48ba552103badca9f5236 
>   src/browsers/playlistbrowser/PodcastModel.cpp 
> c54ba251d3ebcbef83b7f44110bca5e5a846cd98 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 
> 9784d089292dd8dc35854570db46a801b3daaf16 
>   src/images/CMakeLists.txt 20149eb59120cc5711610908dce8f836d8f0abe3 
>   src/images/emblem-gpodder-scalable.svgz PRE-CREATION 
>   src/images/emblem-gpodder.png PRE-CREATION 
>   src/images/icons/hi16-action-view-services-gpodder-amarok.png PRE-CREATION 
>   src/images/icons/hi22-action-view-services-gpodder-amarok.png PRE-CREATION 
>   src/images/icons/hi32-action-view-services-gpodder-amarok.png PRE-CREATION 
>   src/images/icons/hi48-action-view-services-gpodder-amarok.png PRE-CREATION 
>   src/images/icons/svg/action-view-services-gpodder-amarok.svgz PRE-CREATION 
>   src/services/CMakeLists.txt 1de81f6fb542d3b9046c408d092c16812724f415 
>   src/services/gpodder/CMakeLists.txt PRE-CREATION 
>   src/services/gpodder/GpodderMeta.h PRE-CREATION 
>   src/services/gpodder/GpodderMeta.cpp PRE-CREATION 
>   src/services/gpodder/GpodderPodcastRequestHandler.h PRE-CREATION 
>   src/services/gpodder/GpodderPodcastRequestHandler.cpp PRE-CREATION 
>   src/services/gpodder/GpodderPodcastTreeItem.h PRE-CREATION 
>   src/services/gpodder/GpodderPodcastTreeItem.cpp PRE-CREATION 
>   src/services/gpodder/GpodderService.h PRE-CREATION 
>   src/services/gpodder/GpodderService.cpp PRE-CREATION 
>   src/services/gpodder/GpodderServiceModel.h PRE-CREATION 
>   src/services/gpodder/GpodderServiceModel.cpp PRE-CREATION 
>   src/services/gpodder/GpodderServiceView.h PRE-CREATION 
>   src/services/gpodder/GpodderServiceView.cpp PRE-CREATION 
>   src/services/gpodder/GpodderSortFilterProxyModel.h PRE-CREATION 
>   src/services/gpodder/GpodderSortFilterProxyModel.cpp PRE-CREATION 
>   src/services/gpodder/GpodderTagTreeItem.h PRE-CREATION 
>   src/services/gpodder/GpodderTagTreeItem.cpp PRE-CREATION 
>   src/services/gpodder/GpodderTreeItem.h PRE-CREATION 
>   src/services/gpodder/GpodderTreeItem.cpp PRE-CREATION 
>   src/services/gpodder/amarok_service_gpodder.desktop PRE-CREATION 
>   src/services/gpodder/images/CMakeLists.txt PRE-CREATION 
>   src/services/gpodder/images/mygpo.png PRE-CREATION 
>   src/services/opmldirectory/AddOpmlWidget.ui PRE-CREATION 
>   src/services/opmldirectory/CMakeLists.txt 
> 0ad1a93ce03cda502fa56999922e64e48da8e757 
>   src/services/opmldirectory/OpmlDirectoryDelegate.h PRE-CREATION 
>   src/services/opmldirectory/OpmlDirectoryDelegate.cpp PRE-CREATION 
>   src/services/opmldirectory/OpmlDirectoryModel.h PRE-CREATION 
>   src/services/opmldirectory/OpmlDirectoryModel.cpp PRE-CREATION 
>   src/services/opmldirectory/OpmlDirectoryService.h 
> 978280a36085d8738bb855d76d1aa024d3bc0303 
>   src/services/opmldirectory/OpmlDirectoryService.cpp 
> 735b8c0c49abcb0806179aef3d95be92358075b2 
>   src/services/opmldirectory/OpmlDirectoryView.h PRE-CREATION 
>   src/services/opmldirectory/OpmlDirectoryView.cpp PRE-CREATION 
>   src/services/opmldirectory/podcast_directory.opml PRE-CREATION 
>   
> supplementary_scripts/neon/distros/ubuntu/kdesupport-debian/kde-nightly-kdesupport.install
>  bd570753a0648159935e0c7c12c325f7b5206d9c 
>   
> supplementary_scripts/neon/distros/ubuntu/kdesupport-debian/kde-nightly-kdesupport.install
>  PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100582/diff
> 
> 
> Testing
> -------
> 
> some testing done but still tons of bugs ;)
> 
> 
> Thanks,
> 
> Stefan
> 
>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Reply via email to