Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-09-19 Thread Bruno Léon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112815/ --- Review request for Amarok. Description --- Properly fix read

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-09-19 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112815/#review40349 --- shared/tag_helpers/APETagHelper.cpp

Re: Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

2013-09-19 Thread Alex Busenius
On Sept. 18, 2013, 9:46 p.m., Alex Merry wrote: I'm torn between following Amarok's internals (which you do) and following MPRIS2, meaning it should be called UserRating and return/allow a double between 0.0 and 1.0. There's also the question of how urgent this is, as there's