Coding style says to use 0 instead of null, and there is
KSharedPtr::isNull() which is the preffered one.
- Matěj Laitl
On June 21, 2012, 9:41 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To
g testing.
- Matěj
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14972
---
On June 11, 2012, 3:14 p.m
> On June 21, 2012, 10:27 p.m., Mark Gaiser wrote:
> > Has this been shipped? Just asking since the review is beginning to get
> > somewhat old by now.
>
> Matěj Laitl wrote:
> Not yet, we're waiting for feedback on the bug and for 2.6 to get
> released
On 22. 6. 2012 Sven Krohlas wrote:
> Matěj Laitl wrote:
> > Sven, your fix is actually incorrect. From QDir::separator() documentation:
> >> Returns the native directory separator: "/" under Unix (including Mac OS
> >> X) and "\" under Windows
On 24. 6. 2012 Sven Krohlas wrote:
> Heya,
>
> just found out that amarok wont start on some windows systems
> because of the UAC and some rightsmanagemend (tested on windows 8) because
> amarok tries to write the stuff directly to the installation folder/data
> http://paste.kde.org/~windows/506
y other headers.
tests/core/collections/TestQueryMaker.cpp
<http://git.reviewboard.kde.org/r/105172/#comment11887>
Oh oh oh oh! Why the assignment? Why the dynamic_cast? Do don't need to
assing to m_moctQueryMak
> On June 26, 2012, 9:29 a.m., Matěj Laitl wrote:
> > tests/core/collections/MockQueryMaker.cpp, line 18
> > <http://git.reviewboard.kde.org/r/105172/diff/3/?file=70259#file70259line18>
> >
> > No need to include moc. if the Q_OBJECT is in .h file.
>
tient. :-)
- Matěj Laitl
On June 18, 2012, 10:08 p.m., Alberto Villa wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
tests/mocks/MockQueryMaker.cpp
<http://git.reviewboard.kde.org/r/105172/#comment11894>
Nicpicky: now including this shouldn't be needed.
- Matěj Laitl
On June 26, 2012, 8:05 p.m., Jasneet Bhatti wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105172/#review15195
---
Ship it!
Good work.
- Matěj Laitl
On June 27, 2012, 11:14
.
- Matěj Laitl
On July 2, 2012, 9:05 a.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
/statsyncing/ui/MatchedTracksPage.cpp PRE-CREATION
src/statsyncing/ui/TrackDelegate.h PRE-CREATION
src/statsyncing/ui/TrackDelegate.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105409/diff/
Testing
---
Everything works as described and documented AFAICS.
Thanks,
Matěj
05389/#comment11947>
I think you change iplementation (and documentation!) to something like:
QFETCH( Meta::TrackPtr, workerTrack )
m_track = workerTrack;
tests/mocks/MockTrackForUrlWorker.h
<http://git.reviewboard.kde.org/r/105389/#comment11948>
I don't think this
068>
As I said above, I would put TestTrackForUrlWorker::run() implementation
here and get rid of TestTrackForUrlWorker completely, otherwise this class
usefulness approaches zero.
- Matěj Laitl
On July 5, 2012, 12:07 a.m., Jasneet Bhatti wrote:
>
> -
> On July 5, 2012, 9:29 p.m., Matěj Laitl wrote:
> > tests/core/collections/support/TestTrackForUrlWorker.cpp, line 94
> > <http://git.reviewboard.kde.org/r/105389/diff/2/?file=71362#file71362line94>
> >
> > testCompleteJobKUrl_data() and testCompleteJobQ
eed to mention finishedLookup, I'd rather mention that it fetches the
track from QTest data-driven testing variable named track and assigns it to
m_track.
tests/mocks/MockTrackForUrlWorker.h
<http://git.reviewboard.kde.org/r/105389/#comment12084>
Hmm, if you have a .cpp file, I
ctions/db/sql/SqlScanResultProcessor.cpp
6699b982e124193d068e2bd093bf0d15d6e34a9c
Diff: http://git.reviewboard.kde.org/r/105488/diff/
Testing
---
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/105488/diff/
Testing
---
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
re-impl/collections/db/sql/SqlRegistry.h
8d801178cc070c7772363d28d86ca63467996ebe
src/core-impl/collections/db/sql/SqlRegistry.cpp
1b9efe5490bebc849b6c52c0b0b3fd51a5565418
src/core-impl/collections/db/sql/SqlScanResultProcessor.h
1bd96db03363cf8f760811fb231fd9facf521e8e
Diff: http://git.reviewboard.kde.org/r/105488/
On 9. 7. 2012 Lucas Lira Gomes wrote:
> Hi everyone,
Hi Lucas,
> My amarok repo:
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-ama
> rok.git&a=summary (tomahawk
> branch)
I've checked above repo and the master branch there is polluted with many
Merge branch 'master'
On 10. 7. 2012 Edward Toroshchin wrote:
> G'day,
>
> On Tue, Jul 10, 2012 at 01:25:59PM +0200, Matěj Laitl wrote:
> > I've checked above repo and the master branch there is polluted with many
> > Merge branch 'master' of git://anongit.kde.org/amarok
On 10. 7. 2012 Edward Toroshchin wrote:
> On Tue, Jul 10, 2012 at 03:01:06PM +0200, Matěj Laitl wrote:
> > E.g. `git push` without --rebase in master may still be correct if you
> > don't have own commits so that it results in fast-forward, that's what I
> > want
1a5565418
src/core-impl/collections/db/sql/SqlScanResultProcessor.h
1bd96db03363cf8f760811fb231fd9facf521e8e
src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
6699b982e124193d068e2bd093bf0d15d6e34a9c
Diff: http://git.reviewboard.kde.org/r/105488/diff/
Testing
---
Thanks,
Matěj Laitl
__
ail. To reply, visit:
http://git.reviewboard.kde.org/r/105488/#review15660
-------
On July 10, 2012, 2:54 p.m., Matěj Laitl wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org
f test
tests/core/collections/support/TestTrackForUrlWorker.cpp
<http://git.reviewboard.kde.org/r/105389/#comment12200>
text/test typo
- Matěj Laitl
On July 6, 2012, 5:38 p.m., Jasneet Bhatti wrote:
>
> ---
> Thi
ste output of
> `path/to/build/tests/ -v2` into the Testing done field
> to testcase review requests?
:-)
- Matěj Laitl
On July 11, 2012, 7:31 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mai
On 11. 7. 2012 Ralf Engels wrote:
> Git commit 0066525f8d299a22509818e3814eafd08202945d by Ralf Engels.
> Committed on 10/07/2012 at 11:03.
> Pushed by rengels into branch 'master'.
>
> Fix DynamicModel test
>
> Don't rely on engine controller to be there.
> Don't create actions for a tty applica
On 11. 7. 2012 Ralf Engels wrote:
> Git commit 115cb80f9bd94b23640ca9245c97d6c8e25d2c97 by Ralf Engels.
> Committed on 11/07/2012 at 16:25.
> Pushed by rengels into branch 'master'.
>
> Prevent hang in testmetamultitrack.
>
> The class variable mutex had problems in the destructor.
> The function
/diff/
Testing
---
Works, fixes testm3uplaylist
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
On 12. 7. 2012 Matěj Laitl wrote:
> Because I'm the author of the original change, I'll take responsibility to
> fix the test that is broken by it.
Okay, it is done in http://git.reviewboard.kde.org/r/105524/ - please review.
It removes the mutex altogether and it fixes a co
On 12. 7. 2012 Matěj Laitl wrote:
> Again, place for hard-to-find bugs in future. You should
> Amarok::Compontents::setEngineController( new EngineControllerMock() ) in
> test's initTestCase() instead.
And when https://git.reviewboard.kde.org/r/105524/ is merged, you even can use
rks, fixes testm3uplaylist
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
m3uplaylist
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
not documented and could be surprising
> > for the user in some corner cases.
Resolved by having CollectionManager::trackForUrl() not calling
EngineController at all.
- Matěj
---
This is an automatically generated e-mail. To reply, v
------
On July 12, 2012, 2:15 p.m., Matěj Laitl wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105524/
> ---
roller.h PRE-CREATION
tests/TestEngineController.cpp PRE-CREATION
tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp
4bbf29be01aef9043a64075a196ac04a544134cb
Diff: http://git.reviewboard.kde.org/r/105524/diff/
Testing
---
Works, fixes testm3up
re a sensible cleanup,
> > might we not run into troubles in Amarok itself?
> > Could you add the old comment back?
> > The "Wait for other jobs, ..."
>
> Matěj Laitl wrote:
> Changing TestM3UPlaylist is apparently not needed at all in new patch
d89d9db707f
tests/TestEngineController.h PRE-CREATION
tests/TestEngineController.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105524/diff/
Testing
---
Works, fixes testm3uplaylist
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok
tests/core/meta/support/TestMetaTrackKey.cpp
<http://git.reviewboard.kde.org/r/105454/#comment12390>
nitpicky: perhaps too much blank lines here.
- Matěj Laitl
On July 11, 2012, 8:49 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an
names are rather to be avoided, please
rename the directory.
tests/core/meta/support/TestMetaAlbumKey.cpp
<http://git.reviewboard.kde.org/r/105497/#comment12394>
QCOMPARE? (1 more occurence)
- Matěj Laitl
On July 11, 2012, 8:4
ttp://git.reviewboard.kde.org/r/105454/#comment12396>
nicpicky: QCOMPARE is better here.
- Matěj Laitl
On July 11, 2012, 8:49 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To reply
On 12. 7. 2012 Ralf Engels wrote:
> On 07/12/2012 12:44 PM, ext Matěj Laitl wrote:
> > On 11. 7. 2012 Ralf Engels wrote:
> > > Git commit 0066525f8d299a22509818e3814eafd08202945d by Ralf Engels.
> > > -Amarok::Components::logger()->longMessage(
> > &
2bec1737b3af82d3b
src/core-impl/meta/stream/Stream_p.h 58b715f27cb43d014d5837f1afec9d60cb71cc48
src/playlistmanager/file/PlaylistFileProvider.cpp
bafdf69f24e606e0a1e879fda78cedfef7325cbb
Diff: http://git.reviewboard.kde.org/r/105610/diff/
Testing
---
Thanks,
Matěj Laitl
_
Hi list, Ralf & Bart,
after I've returned from a couple of days of off-line time, I've found out that
Bart wants release a RC before releasing 2.6 - something I strongly support
given the severity of some post-beta changes.
However, IMO this is a great opportunity for us to release a RC with eve
n, too.
- Matěj Laitl
On July 14, 2012, 6:03 a.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboar
oard.kde.org/r/105525/#comment12661>
QVERIFY instead of all these QCOMPAREs?
- Matěj Laitl
On July 12, 2012, 1:10 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
ship after removing the line or
showing me it cannot be removed. ;)
src/core/meta/support/MetaKeys.h
<http://git.reviewboard.kde.org/r/105454/#comment12662>
Same here: is this really needed? "friend class" should be enough IMO, but
I'm too lazy to try. :-|
- Matěj L
On 19. 7. 2012 Bart Cerneels wrote:
> On Wed, Jul 18, 2012 at 10:28 PM, Matěj Laitl wrote:
> > Bart, have you already made the 2.6 RC package? If not, would you bother
> > to retag the RC when above fixes are pushed to master? I can merge them as
> > soon as they're
/TestEngineController.h PRE-CREATION
tests/TestEngineController.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105524/diff/
Testing (updated)
---
Works, fixes testm3uplaylist, should fix bug 303253. (waiting for original
reporte
a78cedfef7325cbb
Diff: http://git.reviewboard.kde.org/r/105610/diff/
Testing
---
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
> On July 18, 2012, 8:50 p.m., Matěj Laitl wrote:
> > src/core/meta/support/MetaKeys.h, line 25
> > <http://git.reviewboard.kde.org/r/105454/diff/3/?file=72593#file72593line25>
> >
> > Same here: is this really needed? "friend class" should
this tests pass as written here)
- Matěj Laitl
On July 20, 2012, 2:13 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.
gt; the database table .svg file in the docs directory.
>
> Matěj Laitl wrote:
> > Looks good for now.
> > What I would really like is some more test cases to check for the
> current problems.
>
> Agreed, but due to their complexity, I won't be able t
aying(), not a
workaround, hold on with reviewing until I update this.
- Matěj Laitl
On July 19, 2012, 7:14 p.m., Matěj Laitl wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
(updated)
---
Works for me, fixes mentioned bug and more smaller glitches.
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
esultProcessor.h
1bd96db03363cf8f760811fb231fd9facf521e8e
src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
689b9006280dba7061a9bd1bf4545fd44ef34106
tests/core-impl/collections/db/sql/TestSqlScanManager.cpp
3974b1d234302110d0e00121be3601a06471163f
Diff: http://git.
viewboard.kde.org/r/105488/#review16264
---
On July 25, 2012, 12:01 a.m., Matěj Laitl wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
215124fee
src/statsyncing/ui/ChooseProvidersPage.ui PRE-CREATION
tests/core-impl/meta/multi/TestMetaMultiTrack.h
61e37627351163a7f2bbae729779900d2abb6ca9
tests/core-impl/meta/multi/TestMetaMultiTrack.cpp
b9d64dee9f8f0880981550aab29b882c4b4bbc31
Diff: http://git.reviewboard.kde.org/r/105722/diff/
T
now.
Full statistics as of today are available at
http://www.laitl.cz/soubory/amarok/amarok-l10n-2.5.96.html
Thanks for translating Amarok,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
sly.
Thanks for packaging,
Matěj Laitl on behalf of The Amarok Team
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp
<http://git.reviewboard.kde.org/r/105823/#comment13080>
Does setCustomWidget() take ownership of the pointer? Probably yes.
- Matěj Laitl
On Aug. 2, 2012, 12:13 p
removing the entry from the
Playlist menu, the toolbar is a better place for it.
- Matěj Laitl
On Aug. 2, 2012, 12:14 p.m., Ralf Engels wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
Giovanni Sora wrote:
> Hi,
> I have seen that interlingua (ia) seems have translated 100%.
>
> As we (the ia team) are still translating amarok, but the work has not yet
> committed, I would like to know if it is a mistake or someone is translating
> in interlingua? In this case, please let her/h
released and I have a
bit more of free time.
- Matěj Laitl
On Aug. 6, 2012, 10:14 a.m., Matthias Berndt wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
tatsyncing/ui/MatchedTracksPage.h PRE-CREATION
src/statsyncing/ui/MatchedTracksPage.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105919/diff/
Testing
---
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde
> On Aug. 8, 2012, 11:36 a.m., Bart Cerneels wrote:
> > I wouldn't do this. Toolbars become less usable the more actions are in it.
> > What is wrong with using the menu with a function that is not supposed to
> > be used to often?
Did you say this with knowing that this doesn't add another too
ds are thread-safe,
then document every thread-safe method)
src/statusbar/CompoundProgressBar.cpp
<http://git.reviewboard.kde.org/r/105942/#comment13405>
Nitpicky: I would personally strip all the added newlines
- Matěj Laitl
On Aug. 9, 2012, 10:36 a.m., Ralf
> On Aug. 9, 2012, 6:52 a.m., David Smith wrote:
> > Ship It!
Hi David, it is usual that only estabilished Amarok developers give "Ship it!"
on review requests. All users are of course encouraged to test review requests
and report their findings.
- Matěj
---
> On Aug. 9, 2012, 10:45 a.m., Matěj Laitl wrote:
> > Looks good, just a few small things. Could you also please describe the
> > steps that lead to the crash in the commit msg?
>
> Ralf Engels wrote:
> Really? It's in the bug report pretty clearly. No nee
SVN commit 1310164 by laitl:
Re-add entities missing from KDE 4.6 to index.docbook
Guys, you broke the Amarok build *again*. Please see
http://websvn.kde.org/trunk/l10n-kde4/nl/docs/extragear-multimedia/amarok/?view=log
and especially http://websvn.kde.org/?view=revision&revision=1308660
for expl
cpp PRE-CREATION
src/statsyncing/ui/TrackDelegate.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105979/diff/
Testing
---
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
On 11. 8. 2012 Valorie Zimmerman wrote:
> Harald told me to uninstall phonon-backend-vlc, and install
> phonon-backend-null, which I did. However, when Amarok starts up,
> after a restart of KDE:
>
> bool Phonon::FactoryPrivate::createBackend() Phonon backend "VLC"
> version "0.5.92" loaded
>
> W
On 10. 8. 2012 Freek de Kruijf wrote:
> Op zaterdag 11 augustus 2012 00:27:42 schreef Matěj Laitl:
> > SVN commit 1310164 by laitl:
> >
> > Re-add entities missing from KDE 4.6 to index.docbook
> >
> > You perhaps update this using a script, so please fi
Git commit 24b3feaf279199100f1a0a41e40e22a5408d7411 by Matěj Laitl.
Committed on 14/08/2012 at 16:22.
Pushed by laitl into branch 'master'.
Merge branch 'liblastfm1'
Amarok developers, users building git: you'll need to upgrade your
liblastfm to >= 1.0.0 for La
t distros. liblastfm seems
installed, but recently we've raised its minimal version to 1.0.0. (2 tests
depend in it) It is okay if you don't want to install some of them system-
wide, tweaking the job to find such packages should be easy.
Thank
wline just below, not above.
- Matěj Laitl
On Aug. 15, 2012, 4:39 p.m., Phalgun Guduthur wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
to I presume we can close
this now.
Ryan, as Bart says, there's some unrelated cleanup in this patch, could you
please submit that as a separate review? Tracks.
- Matěj Laitl
On Feb. 17, 2012, 2:53 a.m., Ryan McCoskrie wrote:
>
>
> On April 22, 2012, 5:28 p.m., Matěj Laitl wrote:
> > This makes sense, give me some time to test it and think about it.
>
> Ralf Engels wrote:
> Thought about it?
> Should we ship it?
The #include fixes are definitly right, including
completely circumvents C
> On Aug. 17, 2012, 12:12 p.m., Ralf Engels wrote:
> > I would like to reject this request. I still don't know what the reason for
> > this change request is (displaying something different somewhere, why?) and
> > the change is done at the wrong place (it breaks the model instead of just
> >
the model instead of just
> > changing the view).
>
> Matěj Laitl wrote:
> Agreed. While I understand the bug, it should be solved at very different
> place.
>
> As Bart says, playlists::description() should be removed entirely (please
> also remove all
On 17. 8. 2012 Edward Toroshchin wrote:
> > Don't take it personally, but if you don't revert I'm going to.
>
> Don't take it personally, but I believe you need at least someone else
> to back you up on this to revert anything. Currently, no one except us
> has expressed their point of view :).
M
code compiles" was with
ENABLE_PLAYGROUND enabled, right? Do you heve developer status on identity.k.o
to commit yourself?
- Matěj Laitl
On Aug. 18, 2012, 1:26 a.m., Ryan McCoskrie wrote:
>
> ---
> This is an automatically g
y the user previously)
- Matěj Laitl
On Aug. 18, 2012, 10:04 a.m., Edward Hades Toroshchin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
> On Aug. 18, 2012, 10:17 a.m., Matěj Laitl wrote:
> > Ship it! Just to be sure, your testing "the code compiles" was with
> > ENABLE_PLAYGROUND enabled, right? Do you heve developer status on
> > identity.k.o to commit yourself?
>
> Ryan McCoskrie w
iceHandler.cpp
74e19bc643d15f0f1473da7a6ca52a31583ffd83
src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.cpp
12d6c2a051f58579f1bdc69abeb7a1b0a049c5fa
Diff: http://git.reviewboard.kde.org/r/106094/diff/
Testing
---
Medium, needs confirmation from bug reporter.
Thanks
s confirmation from bug reporter.
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
> On Aug. 17, 2012, 12:31 p.m., Ralf Engels wrote:
> > Please have a look at the diff in reviewboard. Trailing spaces are
> > hightlighted in red. Nobody likes them.
> >
> > Also the basic issue is still open.
> > We have signals that get send whenever a track is played.
> > I can't understand
the timer
> m_secondTimer; /** This timer is used to refresh the widget every second.
> This is needed so that recent played track times are update as the time
> progresses */)
>
> And the trailing spaces.
>
> Matěj Laitl wrote:
> Hmm, I disagree. No application s
On 20. 8. 2012 Teo Mrnjavac wrote:
> http://wstaw.org/m/2012/08/20/plasma-desktopAH1228.png
Good progress, but again I have to repeat myself: I will oppose merging any
rewrite that will introduce significant feature-loss regressions. Sorry.
Such code should live in a branch until it has general
On 21. 8. 2012 Riccardo Iaconelli wrote:
> On Monday 20 August 2012 14:53:47 Matěj Laitl wrote:
> > Such code should live in a branch until it has general feature parity (in
> > this case: functionality of all meaningful applets that work reliably
> > currently should be p
On 21. 8. 2012 Riccardo Iaconelli wrote:
> On Tuesday 21 August 2012 16:07:27 Matěj Laitl wrote:
> > Then I think a good compromise could be to merge qml branch into master as
> > soon as Level 0 is reasonably completed and with confidence that
> > completing Level 1 would
> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote:
> > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line
> > 71
> > <http://git.reviewboard.kde.org/r/106042/diff/4/?file=79206#file79206line71>
> >
> > This is an important de
/NepomukConstructMetaJob.cpp
<http://git.reviewboard.kde.org/r/106042/#comment14084>
No, you shouldn't add new progress bar operation per every track. Add just
one progress for the whole NepomukConstructMetaJob
- Matěj Laitl
On Aug. 20, 2012, 11:17 a.m., Phalgun Gud
> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote:
> > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line
> > 71
> > <http://git.reviewboard.kde.org/r/106042/diff/4/?file=79206#file79206line71>
> >
> > This is an important de
> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote:
> > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line
> > 71
> > <http://git.reviewboard.kde.org/r/106042/diff/4/?file=79206#file79206line71>
> >
> > This is an important de
> On Aug. 22, 2012, 8:25 a.m., Bart Cerneels wrote:
> > I would like to see the code you are working on that has a need for this
> > change. I still think that it should go directly in core.
Yup. I don't really think we should merge this. `git branch` is much better
tool than CMake variables a
> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote:
> > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line
> > 71
> > <http://git.reviewboard.kde.org/r/106042/diff/4/?file=79206#file79206line71>
> >
> > This is an important de
time-constrained now, please commit this with ChangeLog
entry and appropriate BUG: and FIXED-IN: keywords.
- Matěj Laitl
On Aug. 25, 2012, 12:51 p.m., Milan Izai wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
branch, so please
wait for me. (in worst case 2 weeks, sorry)
- Matěj Laitl
On Aug. 30, 2012, 12:03 p.m., Ralf Engels wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
> On June 27, 2012, 8:29 a.m., Matěj Laitl wrote:
> > I'll review this when 2.6 is released, please be patient. :-)
>
> Alberto Villa wrote:
> Hello!
>
> Any progress on this?
Hi, sorry, for the delays. I'll have this reviewed by
1 - 100 of 714 matches
Mail list logo
