Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-07 Thread Yuri Chornoivan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114282/ --- (Updated Dec. 7, 2013, 5:06 p.m.) Review request for Amarok. Changes

Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-07 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114282/#review45312 --- Ship it! Good to go from me, given all the circumstances. -

Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-07 Thread Matěj Laitl
On Dec. 7, 2013, 6:43 p.m., Matěj Laitl wrote: Good to go from me, given all the circumstances. Please add following tags to the commit message when comitting, also please add a line into Changelog: CCBUG: 305264 FUXED-IN: 2.9 - Matěj

Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114282/#review45315 --- This review has been submitted with commit

Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-07 Thread Yuri Chornoivan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114282/ --- (Updated Dec. 7, 2013, 5:53 p.m.) Status -- This change has been

Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-05 Thread Yuri Chornoivan
On Dec. 3, 2013, 7:42 p.m., Matěj Laitl wrote: This looks worth the complication to me. The renaming on install might be confusing to some, but it is far less worse than shipping untranslated strings. I just propose adding short note into the CMakeCache.txt files mentioning why we do

Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-05 Thread Yuri Chornoivan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114282/ --- (Updated Dec. 6, 2013, 6:02 a.m.) Review request for Amarok. Changes