Re: Review Request 128248: Remove non SSL option for Wikipedia applet

> On June 20, 2016, 10:27 p.m., Matěj Laitl wrote: > > Looks well, one minor thing below - unrelated change. > > > > Also please mention: > > BUG: 348313 > > ..in the commit message and include a ChangeLog entry in the patch. > > Olivier Churlaud wrote: > What is a changelog entry? >

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/ --- (Updated June 21, 2016, 12:17 a.m.) Status -- This change has been

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

> On June 20, 2016, 10:27 p.m., Matěj Laitl wrote: > > src/musicbrainz/MusicDNSAudioDecoder.cpp, line 226 > > > > > > This looks like an unrelated change. Please strip of a probably post as > > a separate

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/#review96755 --- Looks well, one minor thing below - unrelated change. Also

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/#review96754 --- I verified that the patch works, there's a boolean field

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

> On June 19, 2016, 12:37 p.m., Stefano Pettini wrote: > > I'll review this patch soon. Btw there's a file, > > src/musicbrainz/MusicDNSAudioDecoder.cpp, that is not related to this patch. Oh yes, but I could not compile without this change.I can put that in a second review - Olivier

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/#review96712 --- I'll review this patch soon. Btw there's a file,

Review Request 128248: Remove non SSL option for Wikipedia applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/ --- Review request for Amarok and Myriam Schweingruber. Bugs: 349313