Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Luigi Toscano
> On Ott. 16, 2016, 12:06 p.m., Matěj Laitl wrote: > > Looks good, but see one question below. > > > > Also, I wonder what the consequences would be? People loosing custom-set > > file associations? What about shortcuts in panels etc.? > > Matěj Laitl wrote: > I also think

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Ott. 16, 2016, 4:12 p.m.) Review request for Amarok and

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Ott. 16, 2016, 4:10 p.m.) Review request for Amarok and

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matěj Laitl
> On Říj. 16, 2016, 12:06 odp., Matěj Laitl wrote: > > Looks good, but see one question below. > > > > Also, I wonder what the consequences would be? People loosing custom-set > > file associations? What about shortcuts in panels etc.? I also think MediaPlayer2::DesktopEntry() needs to be

Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).

2016-10-16 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129055/#review100036 --- Ship it! Looks good. Feel free to push if you have

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100035 --- Looks good, but see one question below. Also, I wonder

Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).

2016-10-16 Thread Alexandr Akulich
> On Окт. 16, 2016, 3:12 п.п., Matěj Laitl wrote: > > Looks good. Feel free to push if you have commit access. Since kf5 is a > > development branch and there are few people to review, feel free to push to > > it directly unless you explicitly want a review (perhaps for something > >

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matthias Klumpp
> On Oct. 16, 2016, 9:12 p.m., Matthias Klumpp wrote: > > Please rename the .desktop files too, the name of the .desktop file and the > > value of the `` tag must match for this to work. > > The DBus activation and Wayland window mapping will also only work with the > > renamed .desktop files.

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100051 --- Please rename the .desktop files too, the name of the

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Luigi Toscano
> On Ott. 16, 2016, 11:12 p.m., Matthias Klumpp wrote: > > Please rename the .desktop files too, the name of the .desktop file and the > > value of the `` tag must match for this to work. > > The DBus activation and Wayland window mapping will also only work with the > > renamed .desktop