D11299: Fixed a crash in magnatune service

2018-03-13 Thread Malte Veerman
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This fixes a crash in the magnatune service introduced by revision REPOSITORY

D11171: Port NetworkAccessManager to new signal/slot syntax

2018-03-13 Thread Malte Veerman
malteveerman updated this revision to Diff 29438. malteveerman added a comment. Previous diff relied on a function of QMetaObject added in Qt 5.10. This now works with older versions of Qt, too. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D11171: Port NetworkAccessManager to new signal/slot syntax

2018-03-13 Thread Mark Kretschmann
markey requested changes to this revision. markey added a comment. This revision now requires changes to proceed. This does not build for me (GCC 7.2.0). Error: https://pastebin.com/5Pmk1ELp REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11171 To: malteveerman,

D11192: Ported playdar collection away from qjson

2018-03-13 Thread Mark Kretschmann
This revision was automatically updated to reflect the committed changes. Closed by commit R181:16d4997c3792: Ported playdar collection away from qjson (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D11192: Ported playdar collection away from qjson

2018-03-13 Thread Mark Kretschmann
markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11192 To: malteveerman, #amarok, markey Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler,