Review Request: Correctly read save last track played time to/from iPods

2011-06-22 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101723/ --- Review request for Amarok. Summary --- This patch adds capability to

Re: Please join us on IRC and assingements of bugs

2011-10-21 Thread Matěj Laitl
` (the Linux kernel way) d) upload them one-by-one to reviewboard (this one seems little inconvenient) I miss something like pull requests from github where a series of patches can be reviewed without squelching them into one. Regards, Matěj Laitl (aka strohel on IRC

Re: Review Request: Correctly read save last track played time to/from iPods

2011-10-21 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101723/#review7528 --- Ship it! Ship It! - Matěj Laitl On June 22, 2011, noon

Re: Review Request: Fix iphone 3G handling in amarok

2011-10-21 Thread Matěj Laitl
cannot test (no iPhone). I can push it if you other Amarok devs agree. Manu, is there a bugreport for that 0 tracks issue? I haven't found it, could be please open a bugreport on bugs.kde.org and precisely describe the problem? Thanks. - Matěj Laitl On Oct. 14, 2011, 4:59 p.m., Manu Wagner wrote

Review Request: iPod handler: Correctly read save last track played time from/to iPods

2011-10-21 Thread Matěj Laitl
/IpodHandler.cpp 99c6209 Diff: http://git.reviewboard.kde.org/r/102932/diff/diff Testing --- Works on iPod nano 2 gen and iPod Nano 5 gen. Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request: Read and update BPM from/to media devices, including iPods

2011-10-22 Thread Matěj Laitl
c981dcccb650f08b42f201b8bca12345dc67036d Diff: http://git.reviewboard.kde.org/r/102937/diff/diff Testing --- Works with iPod nano 2G and iPod nano 4G. Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org

Re: Review Request: Fix iphone 3G handling in amarok

2011-10-22 Thread Matěj Laitl
/?p=amarok.gita=commith=c408df382f35a2ed4480a095735982dd6031b2e0 I just don't have (yet) permissions to close this request. Manu, I also forgot to mention you as patch author, sorry, should I fix that? - Matěj Laitl On Oct. 14, 2011, 4:59 p.m., Manu Wagner wrote

Re: Review Request: Add keyboard shortcut for collection search

2011-10-24 Thread Matěj Laitl
misleading. (it doesn't search anything it just focuses the bar) src/MainWindow.cpp http://git.reviewboard.kde.org/r/102956/#comment6566 Is the DEBUG_BLOCK necessary here? I think it would just pollute debug log. - Matěj Laitl On Oct. 23, 2011, 8:17 p.m., Silver Juurik wrote

Review Request: iPod connection assistant: rework iPod identification

2011-10-25 Thread Matěj Laitl
/diff/diff Testing --- iPod nano 2G and iPod nano 4G are correctly identified. Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Identifying iPod and iPhone-like devices using Solid (was: Amarok review request)

2011-10-26 Thread Matěj Laitl
to access iPhone-like devices the best way once identified, but let's first solve identification. Regards, Matěj Laitl aka strohel ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman

Review Request: iPod handler: various cleanups (3 commits squashed)

2011-10-26 Thread Matěj Laitl
if someone with iPod shuffle could test, as a part of code only relevant for shuffles is touched. Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-02 Thread Matěj Laitl
Meta::nameForField()? If it can migrated, code duplication would --. - Matěj Laitl On Nov. 1, 2011, 3:09 p.m., Daniel Faust wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103014

Re: Review Request: Add new collection filter to find exact matches

2011-11-02 Thread Matěj Laitl
changes. This patch also needs a soud entry in ChangeLog. - Matěj Laitl On Nov. 1, 2011, 3:02 p.m., Daniel Faust wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102252

Re: Identifying iPod and iPhone-like devices using Solid (was: Amarok review request)

2011-11-05 Thread Matěj Laitl
On 27. 10. 2011 Bart Cerneels wrote: On Wed, Oct 26, 2011 at 16:05, Matěj Laitl ma...@laitl.cz wrote: On 25. 10. 2011 Bart Cerneels wrote: Looks like quite a few pretty ugly hacks are needed for proper iP* detection with the current mediadevice codebase. In the near future (post 2.5

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Matěj Laitl
this. (or, do you have commit access yourself?) - Matěj Laitl On Nov. 6, 2011, 5:45 p.m., Daniel Faust wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103014

Re: Review Request: Warn against build without taglib

2011-11-09 Thread Matěj Laitl
macro_optional_log_feature?) - Matěj Laitl On Nov. 9, 2011, 4:51 a.m., Ryan McCoskrie wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103090

[amarok] /: Revert tag reading/writing support for mod, s3m, it and xm files

2011-12-14 Thread Matěj Laitl
Git commit 62c6a63dbe4fe3db72f52b15a46e0c1ffcee79cf by Matěj Laitl. Committed on 15/12/2011 at 00:43. Pushed by laitl into branch 'master'. Revert tag reading/writing support for mod, s3m, it and xm files This reverts commit 3cae9ba4758c43092cd942a504ea43f5873960f4. This was an erroneous push

Re: 2.5.0 tarball problems

2011-12-17 Thread Matěj Laitl
directory is in the cflags). Attached patch fixes the problem. Indeed, thanks. We'll apply the patch into master, but it isn't probably the reason to respin the tarballs. (let's see what other Amarok devs think) Regards, Matěj Laitl

Re: [amarok] cmake/modules: Revert FindMySQLAmarok.cmake fix argumets when calling mysql_config

2011-12-18 Thread Matěj Laitl
On 18. 12. 2011 Christophe Giboudeaux wrote: Revert FindMySQLAmarok.cmake fix argumets when calling mysql_config This reverts a fix for -Wmissing-include-dirs warnings. MYSQL_INCLUDE_DIR must be a path and not contain -Ipath Sorry about the incorrect fix, I will build with

Re: [amarok] cmake/modules: Revert FindMySQLAmarok.cmake fix argumets when calling mysql_config

2011-12-18 Thread Matěj Laitl
On 19. 12. 2011 Christophe Giboudeaux wrote: On Sunday 18 December 2011 23:27:08 Matej Laitl wrote: Sorry about the incorrect fix, I will build with -Wmissing-include-dirs from now on. However I wonder how to fix the original problem. Your commit doesn't mention the issue you're trying to

Re: Review Request: Fix for USB storage mode media players

2011-12-19 Thread Matěj Laitl
/IpodConnectionAssistant.cpp http://git.reviewboard.kde.org/r/100194/#comment7510 This would break identification of iPods. KDE's solid with udisks udev backend currently doesn't attach PMP interface to them. - Matěj Laitl On Dec. 8, 2010, 9:55 p.m., Lukáš Tinkl wrote

Re: [amarok] cmake/modules: Revert FindMySQLAmarok.cmake fix argumets when calling mysql_config

2011-12-19 Thread Matěj Laitl
kdelibs one, code duplication is never good. Let's do it early in the 2.6 phase to get the most testing. Anyone opposed to me dropping FindMysqlAmarok.cmake in master for now? (can always be reverted if problems arise) Matěj Laitl ___ Amarok

[amarok/strohel-for-2.6] src: Get rid of UpdateCapability entirely - it was no longer used

2011-12-20 Thread Matěj Laitl
Git commit 2e73dd379d51a5df37e996cd392b98fd66191daf by Matěj Laitl. Committed on 10/12/2011 at 17:51. Pushed by laitl into branch 'strohel-for-2.6'. Get rid of UpdateCapability entirely - it was no longer used UpdateCapability was deprecated and thanks to previous commits, all UpdateCapability

Request for review: my patch queue for 2.6

2011-12-20 Thread Matěj Laitl
, thicker bar I would be happy to incorporate your comments and suggestions (please comment by mail, my IRC attendance is irregular) and, if no-one opposes I'd like to merge it to master eventually. Regards, Matěj Laitl ___ Amarok

Re: Amarok out of string freeze, let's plan features

2011-12-21 Thread Matěj Laitl
So what features do you have planned or would strongly suggest to make it into 2.6? Ipod collection rewrite: do not use MediaDevice friends, use MemoryMeta. The plan is: * no regressions over current implementation * working playlists * track transferring that does not suck If time

Re: Request for review: my patch queue for 2.6

2011-12-24 Thread Matěj Laitl
On 20. 12. 2011 Bart Cerneels wrote: Just make sure you squash the commits that belong together :) Do you mean some specific commits? E.g. there are 3 UpdateCapability removal- related commits, but each one stands on its own (with commit message describing the specific change) and everything is

Re: 2.5.0 tarball problems

2011-12-29 Thread Matěj Laitl
not to discourage you from packaging Amarok for Debian. Regards, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Matěj Laitl
change, could you describe what exactly this does and perhaps provide screen-shots that show all the changes? - Matěj Laitl On Jan. 2, 2012, 1:29 a.m., Lucas Gomes wrote: --- This is an automatically generated e-mail. To reply, visit

Re: 2.5.0 tarball problems

2012-01-03 Thread Matěj Laitl
On 3. 1. 2012 Sven Krohlas wrote: Not enough information to check signature validity. Show Details Heya, has that patch already been committed to master? It should be part of 2.5.1. Sven, doc/nl/index.docbook is not a part of amarok master, it is added to amarok releases by release

Review request: MemoryMeta changes and new iPod collection

2012-01-10 Thread Matěj Laitl
in the ipod-rewrite branch [2], which is nearly merge-ready. [2] http://quickgit.kde.org/?p=clones%2Famarok%2Flaitl%2Famarok.gita=shortlogh=refs/heads/ipod- rewrite Regards, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel

Re: How to get the playableUrl only when the track is about to be played?

2012-01-14 Thread Matěj Laitl
On 13. 1. 2012 Dirley wrote: Hello, there. Hi Dirley, I've been hacking into Amarok, trying to add an internet service. Turns out that my service is a little bit... uncommon. When the tracks come from the service, they don't have a playable url. I have to ask the service a url for each

Re: KIO-MTP development

2012-01-14 Thread Matěj Laitl
On 13. 1. 2012 Todd wrote: Philipp Schmidt philschm...@gmx.net wrote: this week I started developing a KIO-Slave for MTP since I now have a Galaxy Nexus and like accessing it via Dolphin and not having to use mtpfs. You can find it on github: So far it can do very little (Basically

Re: How to get the playableUrl only when the track is about to be played?

2012-01-16 Thread Matěj Laitl
On 14. 1. 2012 Dirley wrote: Ok, I tried that, but it didnt work. Right after prepareToPlay, the EngineController calls `play(track.playableUrl())`. Since the playable url is being retrieved, the track playableUrl is still empty. So Amarok stops the playback. I need a way to make the engine

Review Request: MetaFile: guess album artist as in SQL collection scanner, MemoryCollection: use also album artist as identifying key in album map (2 commits squelched just for reviewboard)

2012-01-17 Thread Matěj Laitl
-and-album-artists.png http://git.reviewboard.kde.org/r/103715/s/416/ Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Amarok's iPod Collection: Volunteering to help

2012-01-17 Thread Matěj Laitl
On 17. 1. 2012 Santiago G. wrote: Hi. My name is Santiago, I'm the poster of this bug request: https://bugs.kde.org/show_bug.cgi?id=291722 Hi Santiago! Today I have been fighting all afternoon to be able to transfer music from my music collection to my iPod touch. So far I couldn't not find

Re: Review Request: MetaFile: guess album artist as in SQL collection scanner, MemoryCollection: use also album artist as identifying key in album map (2 commits squelched just for reviewboard)

2012-01-17 Thread Matěj Laitl
:10 p.m., Matěj Laitl wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103715/ --- (Updated Jan. 17, 2012, 2:10 p.m

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-19 Thread Matěj Laitl
On 18. 1. 2012 Lucas Lira Gomes wrote: Hi everyone, Does anybody else but Myriam doesn't liked the extra info on the CollectionBrowser? If you haven't opined yet please let us know what's your opinion and explain why you prefer one way or another. I agree with Myriam. Track count is useful

Re: Review request: MemoryMeta changes and new iPod collection

2012-01-19 Thread Matěj Laitl
On 19. 1. 2012 Bart Cerneels wrote: Bart, do you plan to make the UmsCollection changes or should I add it to my TODO list? I guess it will be faster if you implement it. Gives you a change to spot any mistakes in my coding as well. I'll probably have to little time the next few weeks

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-20 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/ --- (Updated Jan. 20, 2012, 10:43 a.m.) Review request for Amarok and Bart

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-20 Thread Matěj Laitl
/103736/#comment8226 whitespace - Matěj Laitl On Jan. 20, 2012, 10:43 a.m., Volker Christian wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-20 Thread Matěj Laitl
://git.reviewboard.kde.org/r/103741/#comment8227 I don't understand this. Do not add a new playlist if there were no playlists previously? (both new and old approach suffer from this) - Matěj Laitl On Jan. 19, 2012, 9:23 p.m., Jaime Torres Amate wrote

Review Request: Rework transcoding: CollectionLocation asks user, not caller of prepareCopy()

2012-01-20 Thread Matěj Laitl
--- Works as before with SqlCollection, works with iPod collection rewrite that also disables (gays-out) unplayable transcoding options. Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok

Re: Review Request: Rework transcoding: CollectionLocation asks user, not caller of prepareCopy()

2012-01-21 Thread Matěj Laitl
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103752/#review9975 --- On Jan. 21, 2012, 12:47 a.m., Matěj Laitl wrote: --- This is an automatically generated e

Re: [amarok] cmake/modules: Revert FindMySQLAmarok.cmake fix argumets when calling mysql_config

2012-01-24 Thread Matěj Laitl
On 19. 12. 2011 Christophe Giboudeaux wrote: On Monday 19 December 2011 00:38:47 Matěj Laitl wrote: I tried to solve http://mail.kde.org/pipermail/amarok-devel/2011- December/009663.html Specifically, the problem is that mysql_config (at least 5.1.56) doesn't accept --variable

Draft message to packagers: Patch for Amarok 2.5.0 to fix critical usability bug with KDE 4.8

2012-01-26 Thread Matěj Laitl
Hi list, as Myriam repeatedly mentioned, we need to push a patch to packagers so that Amarok can be used with KDE 4.8. Some known Amarok developer (Bart, Ralf, Mark?) should probably send (a variant of) following message to kde-packager list. I've tested the 2.5.0 + attached patch personally

Review Request: Another approach to fix bug 291068, be more permissive

2012-02-03 Thread Matěj Laitl
. Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request: Change GUI strings in Configuration dialog to reduce user confusion

2012-02-05 Thread Matěj Laitl
/smb/amarok_device_smb.desktop 82d5715971e6001d4b1a624f256b48ea121a8155 Diff: http://git.reviewboard.kde.org/r/103871/diff/diff Testing --- Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman

Re: Review Request: Change GUI strings in Configuration dialog to reduce user confusion

2012-02-06 Thread Matěj Laitl
://git.reviewboard.kde.org/r/103871/#review10369 --- On Feb. 5, 2012, 11:56 a.m., Matěj Laitl wrote: --- This is an automatically generated e-mail. To reply, visit: http

Continuous integration for Amarok on build.kde.org

2012-02-11 Thread Matěj Laitl
/maintain Amarok jobs myself. Please let us know whether this would be possible and what can we do for it. Regards, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Continuous integration for Amarok on build.kde.org

2012-02-12 Thread Matěj Laitl
priority. Thanks for your efforts, Matěj Laitl and the Amarok development team ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Bug 173814 - JJ: add keyboard shortcut for Edit Track Information...

2012-02-13 Thread Matěj Laitl
/PlaylistDock.cpp http://git.reviewboard.kde.org/r/103960/#comment8652 Is there any specific reason this call is here? - Matěj Laitl On Feb. 13, 2012, 5:26 a.m., Jasneet Bhatti wrote: --- This is an automatically generated e-mail

Re: Continuous integration for Amarok on build.kde.org

2012-02-14 Thread Matěj Laitl
On 13. 2. 2012 Torgny Nyblom wrote: http://build.kde.org/view/EXTRAGEAR/ Here it is Please let me know if there is anymore I can help with. Superbe, thank you very much. I will look at the test failures and determine where is the problem - the tests all pass when I run them locally.

Re: Dev query : To get the path of the current track playing from ratingValueChanged()

2012-03-04 Thread Matěj Laitl
On 4. 3. 2012 Phalgun Guduthur wrote: Hello I'm trying to write a patch along my GSoC proposal ( I have already mailed in the first rough draft, please review it if possible, any feedback is welcome! ). What I'm trying to do is, when a user changes the rating of a song, the song

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-07 Thread Matěj Laitl
), url, trackName, artistName); - Matěj Laitl On March 7, 2012, 10:30 p.m., Ryan McCoskrie wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-07 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/#review11219 --- Ship it! Good! I will push this tomorrow. - Matěj Laitl

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-08 Thread Matěj Laitl
On March 8, 2012, 1:14 p.m., Bart Cerneels wrote: I feel you should still show the file path in the confirmation dialog. After all, you might have duplicates you want to remove and can't be sure which copy it is. The latest version shows it in all cases. (or you talk about prettyUrl()

Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-09 Thread Matěj Laitl
://git.reviewboard.kde.org/r/104213/s/456/ Changes to the Configure Collection dialog http://git.reviewboard.kde.org/r/104213/s/457/ Revamped Transcode dialog http://git.reviewboard.kde.org/r/104213/s/458/ Thanks, Matěj Laitl ___ Amarok-devel

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-11 Thread Matěj Laitl
On 10. 3. 2012 Julian Simioni wrote: Hi Matěj, Side question: you refer to an in-the-works ipod collection. Is this work in the main amarok git repository? If not, can you tell me where to find it? You can find it in the ipod-rewrite branch (which contains reworked transcoding) of my Amarok

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-14 Thread Matěj Laitl
/#review11394 --- On March 9, 2012, 11:31 p.m., Matěj Laitl wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104213

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-16 Thread Matěj Laitl
) --- Better Organize dialog title http://git.reviewboard.kde.org/r/104213/s/456/ Changes to the Configure Collection dialog http://git.reviewboard.kde.org/r/104213/s/467/ Revamped Transcode dialog http://git.reviewboard.kde.org/r/104213/s/468/ Thanks, Matěj Laitl

Re: Review Request: Fix bug 295275

2012-03-18 Thread Matěj Laitl
(and the newResultReady() and queryDone() slots are activated) before returning the tracks, which is done in the loop this patch removes. I'd suggest using QEventLoop::ExcludeUserInputEvents, too. - Matěj Laitl On March 17, 2012, 11:10 p.m., Alexey Neyman wrote

Re: Review Request: Add composer button to wikipedia applet

2012-03-18 Thread Matěj Laitl
) That way you could also remove the useless debug() message. - Matěj Laitl On March 18, 2012, 6:27 a.m., Ryan McCoskrie wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104327

Re: Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

2012-03-18 Thread Matěj Laitl
the limitation isn't this simple? - Matěj Laitl On March 18, 2012, 1:46 p.m., Daniel Dewald wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104330

Re: Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

2012-03-18 Thread Matěj Laitl
On March 18, 2012, 2:10 p.m., Matěj Laitl wrote: I've tried the patch. Previously the spectrum analyzer said: no sample buffer support. Now it pretends it is working but shows nothing or just some corrupted image that doesn't update. Following messages appear in debug output

GSoC Proposal: Statistics synchronization for pluggable devices and Last.fm

2012-03-20 Thread Matěj Laitl
Hi Teo, Bart and list, as suggested by Teo, I've decided to try to take part in GSoC 2012 working as a student on Amarok. My idea is not on the KDE Ideas page, but I've been playing with (a variant of it) for months. Continues a very draft of my GSoC proposal. I'd be very grateful for any

Re: GSoC Proposal: Statistics synchronization for pluggable devices and Last.fm

2012-03-21 Thread Matěj Laitl
On 21. 3. 2012 Christoph Obexer wrote: Thats an awesome idea! You could solve last.fm's downsides with ownCloud. Yup, thinking about this, I can hide Last.fm behind a thin abstraction layer, let's say ScrobblingService abstract class, then Last.fm, libre.fm and ownCloud could be just its

Re: GSoC Proposal: Statistics synchronization for pluggable devices and Last.fm

2012-03-21 Thread Matěj Laitl
On 21. 3. 2012 Bart Cerneels wrote: On Wed, Mar 21, 2012 at 00:06, Matěj Laitl ma...@laitl.cz wrote: Project Goals This project will implement: * track statistics synchronization between Amarok collections that support statistics; these are currently Local Collection

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-22 Thread Matěj Laitl
these, too) src/widgets/BookmarkTriangle.h http://git.reviewboard.kde.org/r/104307/#comment9331 What if slider width changes during the bookmark lifetime? Also, please also document new (or better, even the old) parameters. - Matěj Laitl On March 22, 2012, 8:33 p.m., Jasneet Bhatti wrote

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-03-23 Thread Matěj Laitl
be left at 34 pixels (i.e. untouched). Could you please explain what are the benefits (direct, current - not hypothetical or philosofical) of the TreeItem - NormalTreeItem, MergedTreeItem split? Where exactly is avoids code duplication? - Matěj Laitl On Jan. 29, 2012, 6:42 p.m., Lucas Gomes

Re: GSoC 2012 : Improvised proposal for 'Semantic Collection for Amarok'

2012-03-24 Thread Matěj Laitl
On 2012-03-22, Phalgun Guduthur phalgun.gudut...@gmail.com wrote: I have been working towards the 2012 GSoC idea 'Semantic Collection for Amarok' since a month now. I have already sent in my first rough draft of the proposal. At that time, I promised a proof of Concept and you can it

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Matěj Laitl
On March 22, 2012, 9:46 p.m., Matěj Laitl wrote: src/amarokurls/BookmarkModel.cpp, line 571 http://git.reviewboard.kde.org/r/104307/diff/1/?file=53588#file53588line571 Please don't add DEBUG_BLOCKs and debug() for code that you are not actually debugging. (I know, it is in other

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Matěj Laitl
://git.reviewboard.kde.org/r/104307/#comment9364 Documented attributes, good! src/widgets/BookmarkTriangle.cpp http://git.reviewboard.kde.org/r/104307/#comment9366 Minor things: trailing whitespace, excessive debugging. - Matěj Laitl On March 23, 2012, 10:50 p.m., Jasneet Bhatti wrote

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Matěj Laitl
of minor issues; when there are resolved, it will be perfect. - Matěj Laitl On March 23, 2012, 10:50 p.m., Jasneet Bhatti wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104307

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-25 Thread Matěj Laitl
be glad to commit more your review requests, Jasneet, pick any little bug that annoys you. - Matěj Laitl On March 24, 2012, 12:03 p.m., Jasneet Bhatti wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: GSoC 2012 : Improvised proposal for 'Semantic Collection for Amarok'

2012-03-26 Thread Matěj Laitl
On 26. 3. 2012 Teo Mrnjavac wrote: 2) Can you please be a little more elaborate on why NepomukCollection it can't be completed before NepomukQueryMaker? What will you return in Collection's queryMaker() method? A collection without a querymaker is virtually unusable, it won't be shown in

Re: Review Request: Prevent amarok from merging tracks with same title but different track numbers

2012-03-28 Thread Matěj Laitl
number to the track key too? I can imagine a multi disc album with following tracks: CD1 01 Intro (...) CD2 01 Intro src/core/meta/support/MetaKeys.h http://git.reviewboard.kde.org/r/104423/#comment9458 very minor: this could be removed now - Matěj Laitl On March 27, 2012, 6:16 a.m., Alexey

GSoC Proposal v2: Statistics synchronization for pluggable devices and Last.fm

2012-03-28 Thread Matěj Laitl
that support them (local, iPod) in its first part. Second part is to implement synchronization of the statistics from scrobbling services such as Last.fm to Amarok. (other way around already partially works) Contact === Name: Matěj Laitl Email Address: ma...@laitl.cz Freenode IRC Nick

Re: Review Request: Diagnostics Dialog for Amarok.

2012-04-02 Thread Matěj Laitl
the QWeakPointer is used? If there is none, plain pointer should be used instead. - Matěj Laitl On March 31, 2012, 6:15 p.m., Andrzej Hunt wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request: RFC patch: distinguish between mp4, m4a, m4v types in Amarok::FileType

2012-04-03 Thread Matěj Laitl
/FileType.h 5c8081fa10fe227855a8de6a31fca17ebac5f0e5 shared/FileType.cpp a6e25d5661dc60c40cd78a933c2697e26d4e8f64 shared/tag_helpers/TagHelper.cpp 4c0fb2b0e6361ead03d2b569499d6828858b1c67 Diff: http://git.reviewboard.kde.org/r/104481/diff/ Testing --- Thanks, Matěj Laitl

Re: Review Request: Some changes to the handling of cover art reading and writing

2012-04-10 Thread Matěj Laitl
and fixing its bugs is of course welcome. - Matěj Laitl On April 8, 2012, 5:54 p.m., Daniel Faust wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104513

Re: Review Request: Some changes to the handling of cover art reading and writing

2012-04-10 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104513/ --- (Updated April 10, 2012, 5:01 p.m.) Review request for Amarok. Changes

Re: Tidying up password storage in Amarok

2012-04-10 Thread Matěj Laitl
On 9. 4. 2012 Andrzej J. R. Hunt wrote: I'd like to propose some changes to password storage in amarok, in particular the way KWallet is dealt with, and what is done if not available. Good. This is IMO needed. Most plugins use KWallet, but some resort to plaintext if KWallet isn't available

Re: Tidying up password storage in Amarok

2012-04-10 Thread Matěj Laitl
On 10. 4. 2012 Stefan Derkits wrote: Hmm, I may want to allow storing last.fm password in plain-text while disabling to store MySQL pass in plain-text. The confirmation should be probably per-plugin then. that sounds a little bit not so user-friendly (having to confirm secure storage for

Re: Review Request: Some changes to the handling of cover art reading and writing

2012-04-11 Thread Matěj Laitl
On April 10, 2012, 4:57 p.m., Matěj Laitl wrote: I agree that current hard-coded value of 200px is a bit suboptimal. But I doubt there is a significant group of users that makes use of multiple per-file covers. When I order Amarok to replace track cover, I want Amarok to make

Re: Tidying up password storage in Amarok

2012-04-13 Thread Matěj Laitl
On 13. 4. 2012 Bart Cerneels wrote: Incidentally the MySQL configuration interface is implemented using KConfigXT (an xml file which is translated to c++, which then writes to plaintext, if I've understood it correctly), i.e. the settings aren't stored in KWallet. I'll look into

Re: Tidying up password storage in Amarok

2012-04-13 Thread Matěj Laitl
On 13. 4. 2012 Bart Cerneels wrote: I don't think it's really needed to move that to KWallet. What do you mean by that here? Login name? Database name? Database password? database credentials in general. i.e. there is not real need for the database config to use kwallet. I oppose

Re: [amarok] src/browsers/playlistbrowser: Fix invalid assertion in PlaylistBrowserView::slotActivated()

2012-04-14 Thread Matěj Laitl
On 13. 4. 2012 Myriam Schweingruber wrote: On Thu, Apr 12, 2012 at 22:09, Matěj Laitl ma...@laitl.cz wrote: Git commit 233004d4ab4620946c7dd61e09a8ec1b146673d9 by Matěj Laitl. Committed on 12/04/2012 at 21:05. Pushed by laitl into branch 'master'. Fix invalid assertion

Re: Review Request: Some changes to the handling of cover art reading and writing

2012-04-14 Thread Matěj Laitl
that someone at least a bit experienced in UI design should review the UI. - Matěj Laitl On April 13, 2012, 7:42 p.m., Daniel Faust wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Release plan for 2.6

2012-04-29 Thread Matěj Laitl
On 29. 4. 2012 Myriam Schweingruber wrote: since we need to decide on a release plan for 2.6 let me make a suggestion: To give Matej some more time for his tests we could release a 2.6 beta on June 4th, then do the release 2 weeks later, on June 18th. What do you all think? The iPod

[amarok] src: Meta::Album: introduce canUpdateCompilation(), setCompilation()

2012-05-01 Thread Matěj Laitl
Git commit 59fa0ee6d3f2cbbe1298e74b7fc56f838712fa0e by Matěj Laitl. Committed on 01/05/2012 at 18:14. Pushed by laitl into branch 'master'. Meta::Album: introduce canUpdateCompilation(), setCompilation() and convert subclasses to use these. Many many subclasses already had equivalent methods

Re: Review Request: Fix Transcoding to iPods/iPhone with ffmpeg 0.10

2012-05-03 Thread Matěj Laitl
to merge this. - Matěj Laitl On May 3, 2012, 11:07 a.m., Julian Simioni wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104839

Re: Release plan for 2.6

2012-05-08 Thread Matěj Laitl
On 8. 5. 2012 Myriam Schweingruber wrote: OK, do we have many new strings to translate? If not, 3 weeks should suffice, so let's agree on this schedule: I don't know the counts, but there's a bunch of new strings in iPod collection and in reworked transcoding. 28. May - 2.6 beta I think we

Re: Review Request: Improve automatic scrolling of text in Lyrics applet

2012-05-14 Thread Matěj Laitl
the rounding error won't be noticeable. - Matěj Laitl On May 13, 2012, 11:42 p.m., Alexander Potashev wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104935

Re: Review Request: DB: change lyrics table: text url - integer url pointing to the urls table

2012-05-22 Thread Matěj Laitl
://git.reviewboard.kde.org/r/104966/diff/ Testing --- Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: GSoC report

2012-06-03 Thread Matěj Laitl
On 3. 6. 2012 Riccardo Iaconelli wrote: Hi, just a quick note to follow up the weekly schedule: this week i've been busy with upcoming exams, and so I haven't done a real lot. I will start committing to Amarok (in a branch) soonish. Hi Riccardo, in a branch in my personal repository clone

Re: [amarok] /: EditablePlaylistCapability is IMO nonsense, remove it altogether

2012-06-06 Thread Matěj Laitl
On 6. 6. 2012 Bart Cerneels wrote: Agreed. The whole Capability idea needs to be re-evaluated. Makes little sense outside of Loving tracks in Last.fm streams I think. What design pattern is that anyway? Agreed. Well, I don't think it should go away, but it is currently designed in a rather

Re: Amarok totally broken since yesterday's commits

2012-06-07 Thread Matěj Laitl
On 7. 6. 2012 Myriam Schweingruber wrote: Hi everyone, folks, something is going totally wrong here, the Collection Browser has become totally unusable: - impossible to see anything but in the Merged View: the space below the header when unfolded briefly flashes up and disappears This is

Re: Build failed in Jenkins: amarok_master #132

2012-06-08 Thread Matěj Laitl
On 8. 6. 2012 Jenkins CI Daemon wrote: See http://build.kde.org/job/amarok_master/132/ Wow, I always wanted build failures to be mailed to amarok-devel (and in future, test failure regressions, too). Thanks to whoever who have set this up. Matěj

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-11 Thread Matěj Laitl
final. - Matěj Laitl On June 11, 2012, 3:14 p.m., Matěj Laitl wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221

Re: Review Request: Do not return collectionFolders() unless ready.

2012-06-14 Thread Matěj Laitl
the _caller_ to ensure that MountPointManager is ready. - Matěj Laitl On June 13, 2012, 8:44 p.m., Edward Hades Toroshchin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105246

  1   2   3   4   5   6   >