D10708: New context area

2018-02-23 Thread Mark Kretschmann 
markey closed this revision.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D10708

To: malteveerman, #amarok, markey
Cc: asturmlechner, heikobecker, #amarok, paul, yaohanchen, malteveerman, 
markey, cochise, tbettler, Smar, ricktimmis, schweingruber

D10708: New context area

2018-02-23 Thread Mark Kretschmann 
markey accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R181 Amarok

BRANCH
  kf5

REVISION DETAIL
  https://phabricator.kde.org/D10708

To: malteveerman, #amarok, markey
Cc: asturmlechner, heikobecker, #amarok, paul, yaohanchen, malteveerman, 
markey, cochise, tbettler, Smar, ricktimmis, schweingruber

D10708: New context area

2018-02-21 Thread Malte Veerman 
malteveerman added a comment.


  I have no idea why the vlc backend doesn't work. But I think it's a bug in 
the backend, not the analyzer.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D10708

To: malteveerman, #amarok
Cc: heikobecker, #amarok, paul, yaohanchen, malteveerman, markey, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber

D10708: New context area

2018-02-21 Thread Heiko Becker 
heikobecker added a comment.


  In D10708#211228 , @malteveerman 
wrote:
  
  > Analyzer should work as well, if you are using the gstreamer phonon 
backend. Vlc backend doesn't work unfortunately.
  
  
  Ok, I indeed use the vlc backend.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D10708

To: malteveerman, #amarok
Cc: heikobecker, #amarok, paul, yaohanchen, malteveerman, markey, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber

D10708: New context area

2018-02-21 Thread Malte Veerman 
malteveerman added a comment.


  Analyzer should work as well.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D10708

To: malteveerman, #amarok
Cc: heikobecker, #amarok, paul, yaohanchen, malteveerman, markey, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber

D10708: New context area

2018-02-21 Thread Heiko Becker 
heikobecker added a comment.


  FWIW: It builds and Albums, Current Track and Lyrics work.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D10708

To: malteveerman, #amarok
Cc: heikobecker, #amarok, paul, yaohanchen, malteveerman, markey, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber

D10708: New context area

2018-02-21 Thread Malte Veerman 
malteveerman edited the summary of this revision.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D10708

To: malteveerman, #amarok
Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, 
ricktimmis, asturmlechner, schweingruber

D10708: New context area

2018-02-21 Thread Malte Veerman 
malteveerman updated this revision to Diff 27699.
malteveerman added a comment.


  Added resizing of applets in config mode

REPOSITORY
  R181 Amarok

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10708?vs=27670&id=27699

BRANCH
  kf5

REVISION DETAIL
  https://phabricator.kde.org/D10708

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/MainWindow.cpp
  src/SvgHandler.cpp
  src/SvgHandler.h
  src/amarok-contextapplet.desktop
  src/amarokurls/ContextUrlGenerator.cpp
  src/amarokurls/ContextUrlRunner.cpp
  src/browsers/CollectionTreeView.cpp
  src/browsers/filebrowser/FileView.cpp
  src/browsers/playlistbrowser/PlaylistBrowserView.cpp
  src/context/AmarokContextPackageStructure.cpp
  src/context/AmarokContextPackageStructure.h
  src/context/Applet.cpp
  src/context/Applet.h
  src/context/AppletLoader.cpp
  src/context/AppletLoader.h
  src/context/AppletModel.cpp
  src/context/AppletModel.h
  src/context/CMakeLists.txt
  src/context/Containment.cpp
  src/context/Containment.h
  src/context/Context.h
  src/context/ContextDock.cpp
  src/context/ContextDock.h
  src/context/ContextObserver.cpp
  src/context/ContextObserver.h
  src/context/ContextScene.cpp
  src/context/ContextScene.h
  src/context/ContextView.cpp
  src/context/ContextView.h
  src/context/DataEngine.h
  src/context/DataSource.h
  src/context/Svg.h
  src/context/Theme.h
  src/context/ToolbarView.cpp
  src/context/ToolbarView.h
  src/context/amarokapplets.knsrc
  src/context/applets/CMakeLists.txt
  src/context/applets/albums/AlbumItem.cpp
  src/context/applets/albums/AlbumItem.h
  src/context/applets/albums/Albums.cpp
  src/context/applets/albums/Albums.h
  src/context/applets/albums/AlbumsDefs.h
  src/context/applets/albums/AlbumsModel.cpp
  src/context/applets/albums/AlbumsModel.h
  src/context/applets/albums/AlbumsView.cpp
  src/context/applets/albums/AlbumsView.h
  src/context/applets/albums/CMakeLists.txt
  src/context/applets/albums/TrackItem.cpp
  src/context/applets/albums/TrackItem.h
  src/context/applets/albums/amarok-albums.svg
  src/context/applets/albums/amarok-context-applet-albums.desktop
  src/context/applets/albums/package/contents/images/amarok-albums.svg
  src/context/applets/albums/package/contents/ui/main.qml
  src/context/applets/albums/package/metadata.desktop
  src/context/applets/albums/plugin/AlbumItem.cpp
  src/context/applets/albums/plugin/AlbumItem.h
  src/context/applets/albums/plugin/AlbumsDefs.h
  src/context/applets/albums/plugin/AlbumsEngine.cpp
  src/context/applets/albums/plugin/AlbumsEngine.h
  src/context/applets/albums/plugin/AlbumsModel.cpp
  src/context/applets/albums/plugin/AlbumsModel.h
  src/context/applets/albums/plugin/AlbumsPlugin.cpp
  src/context/applets/albums/plugin/TrackItem.cpp
  src/context/applets/albums/plugin/TrackItem.h
  src/context/applets/albums/plugin/qmldir
  src/context/applets/analyzer/ASCIIAnalyzer.cpp
  src/context/applets/analyzer/ASCIIAnalyzer.h
  src/context/applets/analyzer/AnalyzerApplet.cpp
  src/context/applets/analyzer/AnalyzerApplet.h
  src/context/applets/analyzer/AnalyzerBase.cpp
  src/context/applets/analyzer/AnalyzerBase.h
  src/context/applets/analyzer/BallsAnalyzer.cpp
  src/context/applets/analyzer/BallsAnalyzer.h
  src/context/applets/analyzer/BlockAnalyzer.cpp
  src/context/applets/analyzer/BlockAnalyzer.h
  src/context/applets/analyzer/CMakeLists.txt
  src/context/applets/analyzer/DiscoAnalyzer.cpp
  src/context/applets/analyzer/DiscoAnalyzer.h
  src/context/applets/analyzer/amarok-context-applet-analyzer.desktop
  src/context/applets/analyzer/fht.cpp
  src/context/applets/analyzer/fht.h
  src/context/applets/analyzer/package/contents/ui/main.qml
  src/context/applets/analyzer/package/metadata.desktop
  src/context/applets/analyzer/plugin/ASCIIAnalyzer.cpp
  src/context/applets/analyzer/plugin/ASCIIAnalyzer.h
  src/context/applets/analyzer/plugin/AnalyzerBase.cpp
  src/context/applets/analyzer/plugin/AnalyzerBase.h
  src/context/applets/analyzer/plugin/AnalyzerPlugin.cpp
  src/context/applets/analyzer/plugin/AnalyzerWorker.cpp
  src/context/applets/analyzer/plugin/AnalyzerWorker.h
  src/context/applets/analyzer/plugin/BallsAnalyzer.cpp
  src/context/applets/analyzer/plugin/BallsAnalyzer.h
  src/context/applets/analyzer/plugin/BlockAnalyzer.cpp
  src/context/applets/analyzer/plugin/BlockAnalyzer.h
  src/context/applets/analyzer/plugin/BlockRenderer.h
  src/context/applets/analyzer/plugin/BlockWorker.cpp
  src/context/applets/analyzer/plugin/BlockWorker.h
  src/context/applets/analyzer/plugin/DiscoAnalyzer.cpp
  src/context/applets/analyzer/plugin/DiscoAnalyzer.h
  src/context/applets/analyzer/plugin/qmldir
  src/context/applets/currenttrack/CMakeLists.txt
  src/context/applets/currenttrack/CurrentTrack.cpp
  src/context/applets/currenttrack/CurrentTrack.h
  src/context/applets/currenttrack/amarok-context-applet-currenttrack.desktop
  src/context/applets/currenttrack/amarok-currenttrack.svg
  src/context/applets/currenttrack/currentTrackSetting

D10708: New context area

2018-02-21 Thread Malte Veerman 
malteveerman created this revision.
malteveerman added a reviewer: Amarok.
malteveerman added a project: Amarok.
malteveerman requested review of this revision.

REVISION SUMMARY
  This patch adds a new context area and some of the most important applets for 
it. The context and applets are written in QML and integrated with a 
QQuickWidget subclass. Applets consist of a KPackage with their QML files and 
optionally a QML plugin written in C++ to interface with the core application. 
It's not very pretty yet and I'm still working on some functionality like 
dynamic applet height but I think this is a good start worth sharing.

REPOSITORY
  R181 Amarok

BRANCH
  kf5

REVISION DETAIL
  https://phabricator.kde.org/D10708

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/MainWindow.cpp
  src/SvgHandler.cpp
  src/SvgHandler.h
  src/amarok-contextapplet.desktop
  src/amarokurls/ContextUrlGenerator.cpp
  src/amarokurls/ContextUrlRunner.cpp
  src/browsers/CollectionTreeView.cpp
  src/browsers/filebrowser/FileView.cpp
  src/browsers/playlistbrowser/PlaylistBrowserView.cpp
  src/context/AmarokContextPackageStructure.cpp
  src/context/AmarokContextPackageStructure.h
  src/context/Applet.cpp
  src/context/Applet.h
  src/context/AppletLoader.cpp
  src/context/AppletLoader.h
  src/context/AppletModel.cpp
  src/context/AppletModel.h
  src/context/CMakeLists.txt
  src/context/Containment.cpp
  src/context/Containment.h
  src/context/Context.h
  src/context/ContextDock.cpp
  src/context/ContextDock.h
  src/context/ContextObserver.cpp
  src/context/ContextObserver.h
  src/context/ContextScene.cpp
  src/context/ContextScene.h
  src/context/ContextView.cpp
  src/context/ContextView.h
  src/context/DataEngine.h
  src/context/DataSource.h
  src/context/Svg.h
  src/context/Theme.h
  src/context/ToolbarView.cpp
  src/context/ToolbarView.h
  src/context/amarokapplets.knsrc
  src/context/applets/CMakeLists.txt
  src/context/applets/albums/AlbumItem.cpp
  src/context/applets/albums/AlbumItem.h
  src/context/applets/albums/Albums.cpp
  src/context/applets/albums/Albums.h
  src/context/applets/albums/AlbumsDefs.h
  src/context/applets/albums/AlbumsModel.cpp
  src/context/applets/albums/AlbumsModel.h
  src/context/applets/albums/AlbumsView.cpp
  src/context/applets/albums/AlbumsView.h
  src/context/applets/albums/CMakeLists.txt
  src/context/applets/albums/TrackItem.cpp
  src/context/applets/albums/TrackItem.h
  src/context/applets/albums/amarok-albums.svg
  src/context/applets/albums/amarok-context-applet-albums.desktop
  src/context/applets/albums/package/contents/images/amarok-albums.svg
  src/context/applets/albums/package/contents/ui/main.qml
  src/context/applets/albums/package/metadata.desktop
  src/context/applets/albums/plugin/AlbumItem.cpp
  src/context/applets/albums/plugin/AlbumItem.h
  src/context/applets/albums/plugin/AlbumsDefs.h
  src/context/applets/albums/plugin/AlbumsEngine.cpp
  src/context/applets/albums/plugin/AlbumsEngine.h
  src/context/applets/albums/plugin/AlbumsModel.cpp
  src/context/applets/albums/plugin/AlbumsModel.h
  src/context/applets/albums/plugin/AlbumsPlugin.cpp
  src/context/applets/albums/plugin/TrackItem.cpp
  src/context/applets/albums/plugin/TrackItem.h
  src/context/applets/albums/plugin/qmldir
  src/context/applets/analyzer/ASCIIAnalyzer.cpp
  src/context/applets/analyzer/ASCIIAnalyzer.h
  src/context/applets/analyzer/AnalyzerApplet.cpp
  src/context/applets/analyzer/AnalyzerApplet.h
  src/context/applets/analyzer/AnalyzerBase.cpp
  src/context/applets/analyzer/AnalyzerBase.h
  src/context/applets/analyzer/BallsAnalyzer.cpp
  src/context/applets/analyzer/BallsAnalyzer.h
  src/context/applets/analyzer/BlockAnalyzer.cpp
  src/context/applets/analyzer/BlockAnalyzer.h
  src/context/applets/analyzer/CMakeLists.txt
  src/context/applets/analyzer/DiscoAnalyzer.cpp
  src/context/applets/analyzer/DiscoAnalyzer.h
  src/context/applets/analyzer/amarok-context-applet-analyzer.desktop
  src/context/applets/analyzer/fht.cpp
  src/context/applets/analyzer/fht.h
  src/context/applets/analyzer/package/contents/ui/main.qml
  src/context/applets/analyzer/package/metadata.desktop
  src/context/applets/analyzer/plugin/ASCIIAnalyzer.cpp
  src/context/applets/analyzer/plugin/ASCIIAnalyzer.h
  src/context/applets/analyzer/plugin/AnalyzerBase.cpp
  src/context/applets/analyzer/plugin/AnalyzerBase.h
  src/context/applets/analyzer/plugin/AnalyzerPlugin.cpp
  src/context/applets/analyzer/plugin/AnalyzerWorker.cpp
  src/context/applets/analyzer/plugin/AnalyzerWorker.h
  src/context/applets/analyzer/plugin/BallsAnalyzer.cpp
  src/context/applets/analyzer/plugin/BallsAnalyzer.h
  src/context/applets/analyzer/plugin/BlockAnalyzer.cpp
  src/context/applets/analyzer/plugin/BlockAnalyzer.h
  src/context/applets/analyzer/plugin/BlockRenderer.h
  src/context/applets/analyzer/plugin/BlockWorker.cpp
  src/context/applets/analyzer/plugin/BlockWorker.h
  src/context/applets/analyzer/plugin/DiscoAnalyzer.cpp
  src/context/a