D11868: Reduce interface stuttering

2018-04-04 Thread Mark Kretschmann
markey closed this revision.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D11868

To: malteveerman, #amarok, markey
Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, 
cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker


D11868: Reduce interface stuttering

2018-04-04 Thread Mark Kretschmann
markey accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R181 Amarok

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11868

To: malteveerman, #amarok, markey
Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, 
cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker


D11868: Reduce interface stuttering

2018-04-01 Thread Malte Veerman
malteveerman updated this revision to Diff 31135.
malteveerman added a comment.


  Put some more image savings out of the GUI thread.

REPOSITORY
  R181 Amarok

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11868?vs=31107&id=31135

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11868

AFFECTED FILES
  src/EngineController.cpp
  src/context/applets/currenttrack/plugin/CurrentEngine.cpp
  src/core-impl/collections/db/sql/SqlMeta.cpp
  src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
  src/core/meta/support/MetaUtility.cpp
  src/covermanager/CoverCache.cpp
  src/services/ServiceAlbumCoverDownloader.cpp

To: malteveerman, #amarok
Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, 
cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker


D11868: Reduce interface stuttering

2018-04-01 Thread Malte Veerman
malteveerman created this revision.
malteveerman added a reviewer: Amarok.
malteveerman added a project: Amarok.
malteveerman requested review of this revision.

REVISION SUMMARY
  This reduces interface stuttering when playing new tracks or updating the 
collection. 
  I have about 9000 tracks on a NFS drive. Previously updating that folder let 
Amarok's interface hang for about 20 seconds. Now it just stutters a little bit.
  This  further improves the situation, 
because it makes the loading of lyrics async.

REPOSITORY
  R181 Amarok

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11868

AFFECTED FILES
  src/EngineController.cpp
  src/context/applets/currenttrack/plugin/CurrentEngine.cpp
  src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
  src/core/meta/support/MetaUtility.cpp

To: malteveerman, #amarok
Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, 
cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker