D11968: More interface stuttering work
markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11968 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker
D11968: More interface stuttering work
markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11968 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker
D11968: More interface stuttering work
malteveerman updated this revision to Diff 31909. malteveerman added a comment. Added a few random improvements and compilation warning fixes. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11968?vs=31413=31909 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11968 AFFECTED FILES src/CMakeLists.txt src/OpmlParser.h src/OpmlWriter.h src/amarokurls/BookmarkGroup.cpp src/amarokurls/BookmarkModel.cpp src/amarokurls/BookmarkTreeView.cpp src/browsers/CollectionSortFilterProxyModel.cpp src/browsers/CollectionSortFilterProxyModel.h src/browsers/CollectionTreeItemModelBase.cpp src/browsers/CollectionTreeItemModelBase.h src/configdialog/ConfigDialog.h src/configdialog/dialogs/CollectionConfig.h src/configdialog/dialogs/DatabaseConfig.h src/configdialog/dialogs/GeneralConfig.h src/configdialog/dialogs/MetadataConfig.h src/configdialog/dialogs/NotificationsConfig.h src/configdialog/dialogs/PlaybackConfig.h src/configdialog/dialogs/PluginsConfig.h src/configdialog/dialogs/ScriptsConfig.h src/context/AmarokContextPackageStructure.h src/context/AppletModel.h src/context/ContextView.cpp src/context/LyricsManager.cpp src/context/LyricsManager.h src/context/applets/albums/plugin/AlbumItem.h src/context/applets/albums/plugin/AlbumsModel.h src/context/applets/albums/plugin/AlbumsPlugin.cpp src/context/applets/albums/plugin/TrackItem.h src/context/applets/analyzer/plugin/AnalyzerBase.cpp src/context/applets/analyzer/plugin/AnalyzerBase.h src/context/applets/analyzer/plugin/AnalyzerPlugin.cpp src/context/applets/analyzer/plugin/BlockAnalyzer.h src/context/applets/analyzer/plugin/BlockRenderer.h src/context/applets/analyzer/plugin/BlockWorker.h src/context/applets/currenttrack/plugin/CurrentPlugin.cpp src/context/applets/info/plugin/InfoPlugin.cpp src/context/applets/lyrics/plugin/LyricsEngine.cpp src/context/applets/lyrics/plugin/LyricsEngine.h src/context/applets/lyrics/plugin/LyricsPlugin.cpp src/context/applets/photos/plugin/PhotosPlugin.cpp src/context/applets/wikipedia/plugin/WikipediaPlugin.cpp src/context/qml_plugin/src/PixmapItem.h src/context/qml_plugin/src/Plugin.cpp src/context/qml_plugin/src/RatingItem.h src/core-impl/collections/daap/daapreader/Reader.h src/core-impl/collections/db/sql/SqlMeta.cpp src/core-impl/collections/db/sql/SqlMeta.h src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.h src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.h src/core-impl/collections/ipodcollection/jobs/IpodWriteDatabaseJob.h src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.cpp src/core-impl/collections/mtpcollection/handler/MtpHandler.h src/core-impl/collections/nepomukcollection/NepomukInquirer.h src/core-impl/collections/playdarcollection/PlaydarCollection.cpp src/core-impl/collections/support/MemoryQueryMaker.h src/core-impl/collections/support/jobs/WriteTagsJob.h src/core-impl/meta/proxy/MetaProxyWorker.h src/core-impl/meta/timecode/TimecodeMeta.cpp src/core-impl/playlists/types/file/PlaylistFileLoaderJob.h src/core/support/Debug_p.h src/covermanager/CoverFetchQueue.cpp src/covermanager/CoverFetchQueue.h src/covermanager/CoverFetcher.cpp src/covermanager/CoverFetcher.h src/dialogs/TagDialog.cpp src/dialogs/TagDialog.h src/dynamic/BiasSolver.h src/lyrics/LyricsManager.cpp src/lyrics/LyricsManager.h src/musicbrainz/MusicBrainzXmlParser.h src/musicbrainz/MusicDNSAudioDecoder.h src/musicbrainz/MusicDNSXmlParser.h src/playlist/PlaylistController.cpp src/playlistgenerator/ConstraintSolver.h src/playlistmanager/PlaylistManager.cpp src/scanner/AbstractDirectoryWatcher.h src/scanner/GenericScannerJob.h src/scripting/scriptengine/AmarokLyricsScript.cpp src/scripting/scriptengine/AmarokLyricsScript.h src/scripting/scriptmanager/ScriptItem.cpp src/scripting/scripts/CMakeLists.txt src/scripting/scripts/lyrics_lyricwiki/CMakeLists.txt src/scripting/scripts/lyrics_lyricwiki/main.js src/scripting/scripts/lyrics_lyricwiki/script.desktop src/services/ServiceSqlQueryMaker.cpp src/services/ampache/AmpacheSettings.h src/services/gpodder/GpodderServiceSettings.h src/services/jamendo/JamendoXmlParser.h src/services/magnatune/MagnatuneDatabaseWorker.h src/services/magnatune/MagnatuneInfoParser.cpp src/services/magnatune/MagnatuneStore.cpp src/services/magnatune/MagnatuneXmlParser.h src/services/mp3tunes/Mp3tunesWorkers.h src/statsyncing/jobs/MatchTracksJob.h src/statsyncing/jobs/SynchronizeTracksJob.h src/widgets/BoxWidget.h src/widgets/PrettyTreeRoles.h To: malteveerman, #amarok Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar,
D11968: More interface stuttering work
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This includes the C++ implementation of the lyrics functionality, which is now async. Also includes a fix for SqlAlbumTest, which failed since my last stuttering revision. The biggest change though is in CollectionTreeItemModelBase. It now loads an album's tracks in a Threadweaver job and CollectionSortFilterProxyModel filters unloaded albums. This makes the CollectionTreeView seem to grow when expanding an artist with many albums like "Various Artists" instead of freezing for a while depending on your collection size. The CollectionTreeView must be set to display album years for this to take effect. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11968 AFFECTED FILES src/CMakeLists.txt src/browsers/CollectionSortFilterProxyModel.cpp src/browsers/CollectionSortFilterProxyModel.h src/browsers/CollectionTreeItemModelBase.cpp src/browsers/CollectionTreeItemModelBase.h src/context/LyricsManager.cpp src/context/LyricsManager.h src/context/applets/lyrics/plugin/LyricsEngine.cpp src/context/applets/lyrics/plugin/LyricsEngine.h src/core-impl/collections/db/sql/SqlMeta.cpp src/core-impl/collections/db/sql/SqlMeta.h src/covermanager/CoverFetchQueue.cpp src/covermanager/CoverFetchQueue.h src/covermanager/CoverFetcher.cpp src/covermanager/CoverFetcher.h src/dialogs/TagDialog.cpp src/dialogs/TagDialog.h src/lyrics/LyricsManager.cpp src/lyrics/LyricsManager.h src/scripting/scriptengine/AmarokLyricsScript.cpp src/scripting/scriptengine/AmarokLyricsScript.h src/scripting/scriptmanager/ScriptItem.cpp src/scripting/scripts/CMakeLists.txt src/scripting/scripts/lyrics_lyricwiki/CMakeLists.txt src/scripting/scripts/lyrics_lyricwiki/main.js src/scripting/scripts/lyrics_lyricwiki/script.desktop src/widgets/PrettyTreeRoles.h To: malteveerman, #amarok Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker
