D13438: Removed obsolete PackagePath role from AppletModel
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R181:cc57275e701c: Removed obsolete PackagePath role from AppletModel (authored by malteveerman, committed by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13438?vs=68430=76118#toc REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13438?vs=68430=76118 REVISION DETAIL https://phabricator.kde.org/D13438 AFFECTED FILES src/SvgHandler.cpp src/SvgTinter.cpp src/context/AppletModel.cpp src/context/AppletModel.h src/context/applets/currenttrack/package/contents/ui/main.qml src/context/context_qml_package/contents/ui/main.qml src/context/context_qml_package/contents/ui/toolbar/AppletToolbar.qml src/context/context_qml_package/contents/ui/toolbar/AppletToolbarAppletItem.qml src/context/qml_plugin/Applet.qml To: malteveerman, #amarok, heikobecker Cc: heikobecker, kde-doc-english, amarok-devel, #amarok, gennad, fbampaloukas, skadinna
D13438: Removed obsolete PackagePath role from AppletModel
heikobecker requested changes to this revision. heikobecker added a comment. This revision now requires changes to proceed. I'm sorry for stepping in soo late, but this has really become too huge to review and does multiple things at once. Could you please split it up? I'll push an older diff, without the unrelated changes, which were added later. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D13438 To: malteveerman, #amarok, heikobecker Cc: heikobecker, kde-doc-english, amarok-devel, #amarok, gennad, fbampaloukas, skadinna
D13438: Removed obsolete PackagePath role from AppletModel
malteveerman updated this revision to Diff 68430. malteveerman added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Made SvgHandler handle QRC resource files. - Removed "PackagePath" data role from AppletModel. - Moved applet view from ListView to Flickable. - Made applet loading synchronous. - Fixed qrc resource url handling. - Restricted context flicking to vertical direction. Rebased against current master REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13438?vs=36046=68430 BRANCH context REVISION DETAIL https://phabricator.kde.org/D13438 AFFECTED FILES .gitignore .reviewboardrc CMakeLists.txt ChangeLog HACKING/building_amarok2_in_home.txt INSTALL Messages.sh README cmake/modules/CMakeLists.txt cmake/modules/CheckQtGlib.cmake cmake/modules/FindFFTW3.cmake cmake/modules/FindGDKPixBuf.cmake cmake/modules/FindGooglemock.cmake cmake/modules/FindHUpnp.cmake cmake/modules/FindLibLastFm.cmake cmake/modules/FindLibOFA.cmake cmake/modules/FindMtp.cmake cmake/modules/FindMySQL.cmake cmake/modules/FindMySQLAmarok.cmake cmake/modules/FindQJSON.cmake cmake/modules/FindQtScriptQtBindings.cmake cmake/modules/FindTaglib-Extras.cmake cmake/modules/FindTaglib.cmake cmake/modules/bindingstest/CMakeLists.txt cmake/modules/bindingstest/QtScriptBindingsTest.cpp data/CMakeLists.txt data/amarok.notifyrc doc/CMakeLists.txt doc/amarok.txt doc/amarok_2-8_nepomukindexfolders_dialog_kde_4-11.png doc/amaroknepomukcollectionbrowser2-7.png doc/index.docbook images/CMakeLists.txt images/icons/48-actions-amarok_lyrics.png images/icons/48-actions-current-track-amarok.png images/icons/48-actions-media-album-cover-manager-amarok.png images/icons/48-actions-photos-amarok.png images/icons/48-actions-view-media-analyzer-amarok.png images/icons/CMakeLists.txt playground/src/context/applets/coverbling/CMakeLists.txt playground/src/context/applets/coverbling/CoverBling.h playground/src/context/applets/coverbling/ImageLoader.h playground/src/context/applets/coverbling/PhotoBrowser.h playground/src/context/applets/coverbling/SearchBarTextItem.h playground/src/context/applets/coverbling/amarok-context-applet-coverbling.desktop playground/src/context/applets/coverbling/pictureflow.h playground/src/context/applets/covergrid/AlbumItem.h playground/src/context/applets/covergrid/CMakeLists.txt playground/src/context/applets/covergrid/amarok-context-applet-covergrid.desktop playground/src/scripts/bbc_service/CMakeLists.txt playground/src/scripts/copycover/CMakeLists.txt playground/src/scripts/danish_streams_service/CMakeLists.txt playground/src/scripts/encoding_fixer/CMakeLists.txt playground/src/scripts/npr_service/CMakeLists.txt playground/src/scripts/seeqpod_service/CMakeLists.txt release_scripts/RELEASE_HOWTO shared/CMakeLists.txt shared/FileType.cpp shared/FileTypeResolver.cpp shared/FileTypeResolver.h shared/MetaReplayGain.cpp shared/MetaTagLib.cpp shared/MetaTagLib.h shared/TagsFromFileNameGuesser.cpp shared/TagsFromFileNameGuesser.h shared/Version.h shared/amarokshared_export.h shared/collectionscanner/Album.cpp shared/collectionscanner/BatchFile.cpp shared/collectionscanner/BatchFile.h shared/collectionscanner/Directory.cpp shared/collectionscanner/Directory.h shared/collectionscanner/Playlist.cpp shared/collectionscanner/Playlist.h shared/collectionscanner/Track.cpp shared/collectionscanner/Track.h shared/config.h.cmake shared/tag_helpers/APETagHelper.h shared/tag_helpers/ASFTagHelper.cpp shared/tag_helpers/ASFTagHelper.h shared/tag_helpers/ID3v2TagHelper.cpp shared/tag_helpers/ID3v2TagHelper.h shared/tag_helpers/MP4TagHelper.h shared/tag_helpers/StringHelper.cpp shared/tag_helpers/StringHelper.h shared/tag_helpers/TagHelper.cpp shared/tag_helpers/TagHelper.h shared/tag_helpers/VorbisCommentTagHelper.h src/ActionClasses.cpp src/ActionClasses.h src/AmarokMimeData.cpp src/AmarokMimeData.h src/AmarokProcess.cpp src/AmarokProcess.h src/AmarokSharedPointer.h src/App.cpp src/App.h src/CMakeLists.txt src/EngineController.cpp src/EngineController.h src/GlobalCollectionActions.cpp src/GlobalCollectionActions.h src/GlobalCurrentTrackActions.cpp src/GlobalCurrentTrackActions.h src/KNotificationBackend.cpp src/LastfmReadLabelCapability.h src/MainWindow.cpp src/MainWindow.h src/MediaDeviceCache.cpp src/MediaDeviceMonitor.cpp src/MediaDeviceMonitor.h src/OpmlOutline.h src/OpmlParser.cpp src/OpmlParser.h src/OpmlWriter.cpp src/OpmlWriter.h src/PaletteHandler.cpp src/PaletteHandler.h src/PluginManager.cpp src/PluginManager.h src/PopupDropperFactory.h src/QStringx.cpp src/QStringx.h src/SvgHandler.cpp src/SvgHandler.h src/SvgTinter.cpp src/TrayIcon.cpp src/TrayIcon.h
D13438: Removed obsolete PackagePath role from AppletModel
malteveerman updated this revision to Diff 36046. malteveerman added a comment. Fixed some issues with newer kf5 and qt versions. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13438?vs=35861=36046 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13438 AFFECTED FILES src/SvgHandler.cpp src/SvgTinter.cpp src/context/AppletModel.cpp src/context/AppletModel.h src/context/applets/currenttrack/package/contents/ui/main.qml src/context/context_qml_package/contents/ui/main.qml src/context/context_qml_package/contents/ui/toolbar/AppletToolbar.qml src/context/context_qml_package/contents/ui/toolbar/AppletToolbarAppletItem.qml src/context/qml_plugin/Applet.qml To: malteveerman, #amarok Cc: amarok-devel, #amarok
D13438: Removed obsolete PackagePath role from AppletModel
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. Restricted Application removed a project: Amarok. Restricted Application added a subscriber: amarok-devel. malteveerman requested review of this revision. REVISION SUMMARY This removes the old PackagePath role from AppletModel and improves SvgHandler to handle qrc urls. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D13438 AFFECTED FILES src/SvgHandler.cpp src/SvgTinter.cpp src/context/AppletModel.cpp src/context/AppletModel.h src/context/applets/currenttrack/package/contents/ui/main.qml src/context/context_qml_package/contents/ui/main.qml src/context/qml_plugin/Applet.qml To: malteveerman, #amarok Cc: amarok-devel, #amarok
