Re: [PATCH] drm/amdgpu: fix SI display support

2016-08-19 Thread Alex Deucher
I've squashed this patch into my si tree and also fixed the cursor. Updated tree: https://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-4.9-si Alex On Fri, Aug 19, 2016 at 5:01 AM, Marek Olšák wrote: > From: Marek Olšák > > The tiling flags use the

RE: [PATCH xf86-video-ati 3/3] Track damage accurately for RandR 1.4 slave scanout

2016-08-19 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Friday, August 19, 2016 6:01 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-ati 3/3] Track damage accurately for RandR 1.4 > slave scanout > >

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-19 Thread Emil Velikov
On 19 August 2016 at 03:09, Michel Dänzer wrote: > On 19/08/16 11:02 AM, Yu, Qiang wrote: >> >> Each point of the patch set is not broken. Patches are arranged like >> this to show how I do it: >> 1. create a pageflip.c to host common page flip code >> 2. copy amdgpu DDX DRI2

[PATCH libdrm 2/2] radeon: sync radeon_drm.h with the kernel

2016-08-19 Thread Marek Olšák
From: Marek Olšák the CIK tile mode definitions are moved out, userspace doesn't use them --- include/drm/radeon_drm.h | 51 +++- radeon/radeon_surface.c | 8 2 files changed, 50 insertions(+), 9 deletions(-) diff

[PATCH libdrm 1/2] amdgpu: sync amdgpu_drm.h with the kernel

2016-08-19 Thread Marek Olšák
From: Marek Olšák --- include/drm/amdgpu_drm.h | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 92f5970..d192052 100644 --- a/include/drm/amdgpu_drm.h

RE: [PATCH 0/1] AMDGPU SI support almost fixed

2016-08-19 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Marek Olšák > Sent: Friday, August 19, 2016 5:25 AM > To: Michel Dänzer > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 0/1] AMDGPU SI support almost fixed > > I've added this. The

Re: [PATCH libdrm 1/2] amdgpu: add SI support

2016-08-19 Thread Marek Olšák
On Fri, Aug 19, 2016 at 11:04 AM, Marek Olšák wrote: > From: Ronie Salgado > > --- > amdgpu/amdgpu_gpu_info.c | 18 +++--- > include/drm/amdgpu_drm.h | 1 + > 2 files changed, 12 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH v2 xserver 3/5] modesetting: move common page flip handle to pageflip.c

2016-08-19 Thread StDenis, Tom
Sorry, disregard. The pointer doesn't point inside the struct. That part of the patch is fine. Tom From: amd-gfx on behalf of StDenis, Tom Sent: Friday, August 19, 2016 07:30 To: Yu, Qiang;

Re: [PATCH v2 xserver 3/5] modesetting: move common page flip handle to pageflip.c

2016-08-19 Thread StDenis, Tom
In ms_pageflip_free() you cannot free the parent structure before freeing things it points to. That's undefined behaviour. Tom From: amd-gfx on behalf of Qiang Yu Sent: Friday, August 19, 2016 08:50

[PATCH v2 xserver 4/5] modesetting: add DRI2 page flip support

2016-08-19 Thread Qiang Yu
Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/dri2.c | 230 -- 1 file changed, 221 insertions(+), 9 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/hw/xfree86/drivers/modesetting/dri2.c index 83cb3e0..acbb980

[PATCH v2 xserver 5/5] modesetting: exclude DRI2 and prensent page flip

2016-08-19 Thread Qiang Yu
Signed-off-by: Qiang Yu Reviewed-by: Michel Dänzer --- hw/xfree86/drivers/modesetting/dri2.c| 11 +-- hw/xfree86/drivers/modesetting/driver.h | 5 +++-- hw/xfree86/drivers/modesetting/drmmode_display.h | 3 +++

[PATCH v2 xserver 2/5] modesetting: move ms_do_pageflip to pageflip.c

2016-08-19 Thread Qiang Yu
Signed-off-by: Qiang Yu Reviewed-by: Michel Dänzer --- hw/xfree86/drivers/modesetting/Makefile.am | 1 + hw/xfree86/drivers/modesetting/driver.h| 48 ++ hw/xfree86/drivers/modesetting/pageflip.c | 251

[PATCH xf86-video-amdgpu] Fix cursor size for SI

2016-08-19 Thread Marek Olšák
From: Marek Olšák This doesn't fix the missing cursor, which seems to be a kernel issue, because it's missing with modesetting as well. --- src/amdgpu_kms.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c

Re: [PATCH 0/1] AMDGPU SI support almost fixed

2016-08-19 Thread Marek Olšák
On Fri, Aug 19, 2016 at 12:04 PM, Michel Dänzer wrote: > On 19/08/16 07:00 PM, Marek Olšák wrote: >> On Fri, Aug 19, 2016 at 11:45 AM, Michel Dänzer wrote: >>> On 19/08/16 06:24 PM, Marek Olšák wrote: I've added this. The dmesg message is gone, but

Re: [PATCH 0/1] AMDGPU SI support almost fixed

2016-08-19 Thread Michel Dänzer
On 19/08/16 07:00 PM, Marek Olšák wrote: > On Fri, Aug 19, 2016 at 11:45 AM, Michel Dänzer wrote: >> On 19/08/16 06:24 PM, Marek Olšák wrote: >>> I've added this. The dmesg message is gone, but the cursor is still missing. >>> >>> diff --git a/src/amdgpu_kms.c

[PATCH xf86-video-ati 2/3] Handle RandR 1.4 slave dirty updates via radeon_drm_queue

2016-08-19 Thread Michel Dänzer
From: Michel Dänzer This reduces PCIe bandwidth usage and tearing. Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 94 +--- 1 file changed, 90 insertions(+), 4 deletions(-) diff --git

[PATCH xf86-video-ati 3/3] Track damage accurately for RandR 1.4 slave scanout

2016-08-19 Thread Michel Dänzer
From: Michel Dänzer This further reduces the PCIe bandwidth usage. Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 82 1 file changed, 71 insertions(+), 11 deletions(-) diff --git

Re: [PATCH 0/1] AMDGPU SI support almost fixed

2016-08-19 Thread Marek Olšák
On Fri, Aug 19, 2016 at 11:45 AM, Michel Dänzer wrote: > On 19/08/16 06:24 PM, Marek Olšák wrote: >> I've added this. The dmesg message is gone, but the cursor is still missing. >> >> diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c >> index 9ee48df..d9f15a4 100644 >> ---

Re: [PATCH xserver 3/6] modesetting: add DRI2 page flip support

2016-08-19 Thread Yu, Qiang
> +static Bool > +can_exchange(ScrnInfoPtr scrn, DrawablePtr draw, > + DRI2BufferPtr front, DRI2BufferPtr back) > +{ [...] > +if (!update_front(draw, front)) > +return FALSE; I know you just copied this from -ati/amdgpu, but: I don't think can_exchange should call