Sorry mi-read your email.
From: StDenis, Tom
Sent: Friday, August 26, 2016 12:50 PM
To: Deucher, Alexander; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/amd/powerplay: Only load MEC firmware once on
Stoney
Patch #3 is correct but missing the SDMA0 duplicate which I amended locally
Patch #3 is correct but missing the SDMA0 duplicate which I amended locally. I
only noticed it after I hit send.
From: Deucher, Alexander
Sent: Friday, August 26, 2016 12:49
To: StDenis, Tom; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH 3/3] drm/amd/powerpl
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Tom St Denis
> Sent: Friday, August 26, 2016 12:46 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: StDenis, Tom
> Subject: [PATCH 3/3] drm/amd/powerplay: Only load MEC firmware once on
> Stoney
>
Wrong patch? ;)
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of
StDenis, Tom
Sent: Friday, August 26, 2016 12:48 PM
To: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/amd/powerplay: Only load MEC firmware once on
Stoney
I swear this isn't intentional but I
I swear this isn't intentional but I just realized that SDMA0 was loaded twice
too only after hitting send-email. I've amended my patch locally to avoid
loading SDMA0 twice too..
Tom
From: Tom St Denis
Sent: Friday, August 26, 2016 12:46
To: amd-gfx@lists.fr
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
index cc94c4fcbbbd..f51bd8de2f69 10064
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
index e6464e21f9b2..cc94c4f
The first two patches fix up code style and error return codes.
The third patch avoids loading the MEC1 firmware twice on Stoney
parts.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Only load the MEC1 firmware once in the Carrizo SMU manager
driver.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
b/drivers/gpu/drm/amd/pow
Yes. We only need to call it once for STONEY.
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of
StDenis, Tom
Sent: Friday, August 26, 2016 12:38 PM
To: amd-gfx list
Subject: cz smu cleanups
Still on the topic of the smu code I see (in cz_smu_construct_toc_for_bootup())
Still on the topic of the smu code I see (in cz_smu_construct_toc_for_bootup())
cz_smu_populate_single_ucode_load_task(smumgr,
CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT1, false);
if (smumgr->chip_id == CHIP_STONEY)
cz_smu_populate_single_ucode_load_task(smumgr,
CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT1, fal
Thanks. I like v4 better because it prints a message if the initial load op
fails. I'll push that.
Tom
From: Deucher, Alexander
Sent: Friday, August 26, 2016 11:15
To: 'Tom St Denis'; amd-gfx@lists.freedesktop.org
Cc: StDenis, Tom
Subject: RE: [PATCH] drm/amd
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Tom St Denis
> Sent: Friday, August 26, 2016 11:13 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: StDenis, Tom
> Subject: [PATCH] drm/amd/powerplay: Fix CZ SMU firmware load check (v4)
>
> Remo
Remove an errant return in the middle of the check
function as well as check for success in the start
function.
(v2) Add return check to smu_load_fw()
(v3) Don't return early if SMU load check fails
(v4) No returns! :-)
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/powerplay/smumgr/cz_sm
Thanks. I sent out a v2 where it adds a check to the load call as well.
Tom
From: Deucher, Alexander
Sent: Friday, August 26, 2016 10:42
To: 'Tom St Denis'; amd-gfx@lists.freedesktop.org
Cc: StDenis, Tom
Subject: RE: [PATCH] drm/amd/powerplay: Fix CZ SMU firmwa
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Tom St Denis
> Sent: Friday, August 26, 2016 11:05 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: StDenis, Tom
> Subject: [PATCH] drm/amd/powerplay: Fix CZ SMU firmware load check (v3)
>
> Remo
Remove an errant return in the middle of the check
function as well as check for success in the start
function.
(v2) Add return check to smu_load_fw()
(v3) Don't return early if SMU load check fails
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 10 ++
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Tom St Denis
> Sent: Friday, August 26, 2016 10:55 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: StDenis, Tom
> Subject: [PATCH] drm/amd/powerplay: Fix CZ SMU firmware load check (v2)
>
> Remo
Remove an errant return in the middle of the check
function as well as check for success in the start
function.
(v2) Add return check to smu_load_fw()
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 14 +-
1 file changed, 9 insertions(+), 5 deletio
From: satsahu
Signed-off-by: Alex Deucher
---
tests/util/kms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/util/kms.c b/tests/util/kms.c
index 650b23b..c20134e 100644
--- a/tests/util/kms.c
+++ b/tests/util/kms.c
@@ -127,6 +127,7 @@ const char *util_lookup_connector_type_name(unsi
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Tom St Denis
> Sent: Friday, August 26, 2016 10:35 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: StDenis, Tom
> Subject: [PATCH] drm/amd/powerplay: Fix CZ SMU firmware load check
>
> Remove
Remove an errant return in the middle of the check
function as well as check for success in the start
function.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerpla
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Friday, August 26, 2016 5:30 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH xf86-video-ati] Fix build against xserver < 1.13
>
> From: Michel Dänzer
>
> pScr
Yes, I think it should be removed.
Alex
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of
StDenis, Tom
Sent: Friday, August 26, 2016 9:07 AM
To: amd-gfx list
Subject: Errant return in Carrizo SMU code
In the function
static int cz_check_fw_load_finish(struct pp_smumgr
In the function
static int cz_check_fw_load_finish(struct pp_smumgr *smumgr,
uint32_t firmware);
On line 198 of powerplay/smumgr/cz_smumgr.c there is an unconditional return in
the middle of the function. Is that an error or is the code after it truly
dead code?
Tom
___
From: Michel Dänzer
pScreen->isGPU was only introduced in 1.13.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97490
Signed-off-by: Michel Dänzer
---
src/drmmode_display.c | 5 -
src/radeon_kms.c | 5 -
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/drm
Am 26.08.2016 um 08:39 schrieb Monk Liu:
job->ctx actually is a fence_context of the entity
it belongs to, naming it as ctx is too vague, and
we'll need add amdgpu_ctx into the job structure
later.
Change-Id: I71e73912e26372639ea44a18d9e36d58d936f19a
Signed-off-by: Monk Liu
Reviewed-by: Chris
27 matches
Mail list logo
