Re: [PATCH 2/2] drm/amdgpu/si_dpm: workaround for SI kickers

2016-10-26 Thread Huang Rui
On Wed, Oct 26, 2016 at 03:28:26PM -0400, Alex Deucher wrote: > Consolidate existing quirks. Fixes stability issues > on some kickers. > > Signed-off-by: Alex Deucher Acked-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/si_dpm.c | 59 > +++-- > 1 file change

[PATCH xf86-video-ati] Require xserver 1.10 or newer

2016-10-26 Thread Michel Dänzer
From: Michel Dänzer 1.10.0 was released in February 2011. We've been accidentally requiring 1.10 or newer since 121a6de72da5 ("Keep track of damage event related flushes per-client v2"). Signed-off-by: Michel Dänzer --- configure.ac | 2 +- src/drmmode_display.c | 7 --- src/dr

[PATCH xf86-video-amdgpu] present: Check tiling info for flips

2016-10-26 Thread Michel Dänzer
From: Michel Dänzer The kernel driver doesn't handle flipping between buffers with different tiling parameters correctly. Fixes display corruption with fullscreen apps using different tiling modes (e.g. due to R600_DEBUG=notiling or R600_DEBUG=no2d) via DRI3. Signed-off-by: Michel Dänzer ---

[PATCH 2/2] drm/amdgpu/si_dpm: workaround for SI kickers

2016-10-26 Thread Alex Deucher
Consolidate existing quirks. Fixes stability issues on some kickers. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 59 +++-- 1 file changed, 43 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/

Re: [PATCH] drm/amdgpu: use failed label to handle context init failure

2016-10-26 Thread Alex Deucher
On Wed, Oct 26, 2016 at 5:11 AM, Huang Rui wrote: > Signed-off-by: Huang Rui Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c > b/drive

Re: [PATCH 1/6] drm/amdgpu: when suspend, set boot state instand of disable dpm.

2016-10-26 Thread Alex Deucher
On Wed, Oct 26, 2016 at 7:00 AM, Christian König wrote: > Patch #1-#4 are Acked-by: Christian König . > > You already send a v2 for patch #5. > > Where is patch #6 in this series? Strangely, I didn't get it either, but it showed up in the archives. Anyway, Patches 1-4, 5(v2), 6: Reviewed-by: Al

Re: [PATCH xf86-video-amdgpu 4/4] Consume all available udev events at once

2016-10-26 Thread Alex Deucher
On Wed, Oct 26, 2016 at 3:24 AM, Michel Dänzer wrote: > From: Michel Dänzer > > We get multiple udev events for actions like docking a laptop into its > station or plugging a monitor to the station. By consuming as many > events as we can, we reduce the number of output re-evalutions. > > It depe

RE: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring funcs as well

2016-10-26 Thread Yu, Xiangliang
> Hi Xiangliang, > > NAK, we agreed upon moving the constant data into the functions structure > as well. > > How about renaming the amdgpu_ring_funcs structure to make clear that it > isn't only functions any more? Something amdgpu_ring_params or > something like that? Why not create a new stru

Re: [PATCH 1/6] drm/amdgpu: when suspend, set boot state instand of disable dpm.

2016-10-26 Thread Christian König
Patch #1-#4 are Acked-by: Christian König . You already send a v2 for patch #5. Where is patch #6 in this series? Regards, Christian. Am 26.10.2016 um 12:21 schrieb Rex Zhu: fix pm-hibernat bug, when suspend/resume, dpm start failed. Change-Id: I0ec39c72b9c38778c01f88283caa14f115db8f4c Signe

Re: [PATCH 5/6] [V2]drm/amdgpu: disable dpm before turn off clock when vce idle.

2016-10-26 Thread Christian König
Am 26.10.2016 um 12:46 schrieb Zhu, Rex: Signed-off-by: Rex Zhu It's good practice to add a short note what changed with v2 of the patch in the commit message, e.g. something like "v2: move return value check as well". With that fixed that patch is Reviewed-by: Christian König . Regards

[PATCH 5/6] [V2]drm/amdgpu: disable dpm before turn off clock when vce idle.

2016-10-26 Thread Zhu, Rex
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c index 54a7019..8f6e7a0 100644 --- a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c +++ b/driver

[PATCH 5/6] drm/amdgpu: disable dpm before turn off clock when vce idle.

2016-10-26 Thread Rex Zhu
Change-Id: I34354c3aec5d43aa259e572fca94f66cb9935170 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c index 54a7019..5b41198 100644 --- a/

[PATCH 4/6] drm/amdgpu: enable uvd bypass mode for CI/VI.

2016-10-26 Thread Rex Zhu
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 25 ++--- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 18 ++ drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 9 - 3 files changed, 44 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 1/6] drm/amdgpu: when suspend, set boot state instand of disable dpm.

2016-10-26 Thread Rex Zhu
fix pm-hibernat bug, when suspend/resume, dpm start failed. Change-Id: I0ec39c72b9c38778c01f88283caa14f115db8f4c Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 2 ++ drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 17 + 2 files changed, 15 insertions(+), 4 deleti

[PATCH 3/6] drm/amdgpu: just not load smc firmware if smu is already running

2016-10-26 Thread Rex Zhu
Change-Id: I8ce8b16e77cacc914982fa0986b055eb31d6a390 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c index 34e5b67..54a7019 100644 -

[PATCH 2/6] drm/amd/powerplay: fix bug get wrong evv voltage of Polaris.

2016-10-26 Thread Rex Zhu
Change-Id: Ic9917080d30f0c60587e4ada2455bccf1ad7 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmg

Re: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring funcs as well

2016-10-26 Thread Christian König
Hi Xiangliang, NAK, we agreed upon moving the constant data into the functions structure as well. How about renaming the amdgpu_ring_funcs structure to make clear that it isn't only functions any more? Something amdgpu_ring_params or something like that? Regards, Christian. Am 26.10.2016

[PATCH] drm/amdgpu: use failed label to handle context init failure

2016-10-26 Thread Huang Rui
Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c index 6d90d7b..d7df6e0 100644 --- a/drivers/gpu/drm/amd/am

RE: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring funcs as well

2016-10-26 Thread Yu, Xiangliang
Hi Christian, Could you help put type, aligan_mask, nop of amdgpu_ring_funcs struct field into amdgpu_ring struct? I think amdgpu_ring_funcs should include function pointer, not attribute. Your patches is not follow the struct design, and the amdgpu_ring will lost the meaning. Thanks! Xian

[PATCH xf86-video-amdgpu 3/4] PRIME: Fix swapping of provider sink / source capabilities

2016-10-26 Thread Michel Dänzer
From: Hans de Goede When a card has import capability it can be an offload _sink_, not a source and vice versa for export capability. This went unnoticed sofar because most gpus have both import and export capability. Signed-off-by: Hans de Goede (Ported from xserver commit 94a1c77259ce39ba59a

[PATCH xf86-video-amdgpu 4/4] Consume all available udev events at once

2016-10-26 Thread Michel Dänzer
From: Michel Dänzer We get multiple udev events for actions like docking a laptop into its station or plugging a monitor to the station. By consuming as many events as we can, we reduce the number of output re-evalutions. It depends on the timing how many events can be consumed at once. (Inspir

[PATCH xf86-video-amdgpu 2/4] Always call PixmapStopDirtyTracking in drmmode_set_scanout_pixmap

2016-10-26 Thread Michel Dänzer
From: Michel Dänzer Otherwise, we may leak screen->pixmap_dirty_list entries if drmmode_set_scanout_pixmap is called repatedly with ppix != NULL, which can happen from RRReplaceScanoutPixmap. (Inspired by xserver commit b773a9c8126222e5fed2904d012fbf917a9f22fd) (Ported from radeon commit 6c94044

[PATCH xf86-video-amdgpu 1/4] Don't rely on randr_crtc->scanout_pixmap in drmmode_set_scanout_pixmap

2016-10-26 Thread Michel Dänzer
From: Michel Dänzer RRReplaceScanoutPixmap may set randr_crtc->scanout_pixmap = NULL before we get here. (Inspired by xserver commit f4c377953df1fe0e3196eda452acf0078e61) v2: Always return TRUE in the if (!ppix) block. (Cherry picked from radeon commit 61df12e2377cbb19a19ca9d5624df8959822da9