Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-28 Thread Mario Kleiner
On 10/28/2016 03:34 AM, Michel Dänzer wrote: On 27/10/16 10:33 PM, Mike Lothian wrote: Just another gentle ping to see where you are with this? I haven't got a chance to look into this any further. Fwiw., as a proof of concept, the attached experimental patch does work as tested on Int

[PATCH] drm/amdgpu: add support for new smc firmware on iceland

2016-10-28 Thread Alex Deucher
Newer iceland parts require new smc firmware. Reviewed-by: Huang Rui Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 7 ++- drivers/gpu/drm/amd/amdgpu/vi.c | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH] amdgpu: check parameters in amdgpu_query_gpu_info

2016-10-28 Thread Alex Deucher
Make sure they aren't NULL. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=97993 Signed-off-by: Alex Deucher --- This bug probably needs to be fixed in the OCL driver, but this patch fixes the acute problem and may be enough to fix the bug overall. Needs further investigation by the OCL tea

Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-28 Thread Mike Lothian
Hi Mario That fixes the tearing, it's been replaced with a strange stutter, like it's only showing half the number of frames being reported - it's really noticeable in tomb raider Thanks for your work on this, the stutter is much more manageable than the tearing was I've attached the patch that

Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-28 Thread Christian König
Am 28.10.2016 um 19:37 schrieb Mario Kleiner: On 10/28/2016 03:34 AM, Michel Dänzer wrote: On 27/10/16 10:33 PM, Mike Lothian wrote: Just another gentle ping to see where you are with this? I haven't got a chance to look into this any further. Fwiw., as a proof of concept, the attached

RE: [PATCH] drm/amdgpu: add some error hanbdling to amdgpu_init

2016-10-28 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Friday, October 28, 2016 11:40 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: add some error hanbdling to amdgpu_init > > From: Christian König

RE: [PATCH] drm/amd: fix scheduler fence teardown order

2016-10-28 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Friday, October 28, 2016 11:09 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amd: fix scheduler fence teardown order > > From: Christian König > > So

Re: [PATCH] drm/amd: fix scheduler fence teardown order

2016-10-28 Thread Grazvydas Ignotas
On Fri, Oct 28, 2016 at 6:08 PM, Christian König wrote: > From: Christian König > > Some fences might be alive even after we have stopped the scheduler leading > to warnings about leaked objects from the SLUB allocator. > > Fix this by allocating/freeing the SLUB allocator from the module > init/

[PATCH] drm/amdgpu: add some error hanbdling to amdgpu_init

2016-10-28 Thread Christian König
From: Christian König Just to be clean should we ever run into -ENOMEM during module init. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH] drm/amd: fix scheduler fence teardown order

2016-10-28 Thread Christian König
From: Christian König Some fences might be alive even after we have stopped the scheduler leading to warnings about leaked objects from the SLUB allocator. Fix this by allocating/freeing the SLUB allocator from the module init/finfi functions just like we do it for hw fences. Reported-by: Grazv

Re: [PATCH] drm/amdgpu: release parent fence reference

2016-10-28 Thread Christian König
Am 28.10.2016 um 13:47 schrieb Christian König: Am 24.10.2016 um 11:43 schrieb Grazvydas Ignotas: On Mon, Oct 24, 2016 at 12:13 PM, Christian König wrote: Am 24.10.2016 um 04:25 schrieb zhoucm1: On 2016年10月24日 02:31, Grazvydas Ignotas wrote: It's done in amd_sched_hw_job_reset(), but not in

Re: [PATCH] drm/amdgpu: release parent fence reference

2016-10-28 Thread Christian König
Am 24.10.2016 um 11:43 schrieb Grazvydas Ignotas: On Mon, Oct 24, 2016 at 12:13 PM, Christian König wrote: Am 24.10.2016 um 04:25 schrieb zhoucm1: On 2016年10月24日 02:31, Grazvydas Ignotas wrote: It's done in amd_sched_hw_job_reset(), but not in normal job processing. Leak reported by CONFIG_

RE: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring funcs as well

2016-10-28 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Friday, October 28, 2016 6:13 PM > To: Yu, Xiangliang ; Alex Deucher > > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring > funcs as well > > Am

Re: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring funcs as well

2016-10-28 Thread Christian König
Am 28.10.2016 um 04:06 schrieb Yu, Xiangliang: NAK, we agreed upon moving the constant data into the functions structure as well. How about renaming the amdgpu_ring_funcs structure to make clear that it isn't only functions any more? Something amdgpu_ring_params or something like that? What ben