Re: amdgpu: Corrupted video on 32 bit systems (possible fix)

2017-01-19 Thread Nils Holland
On Fri, Jan 20, 2017 at 11:47:53AM +0900, Michel Dänzer wrote: > On 20/01/17 04:35 AM, Nils Holland wrote: > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c2016-12-11 > > 20:17:54.0 +0100 > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c2017-01-19 > > 15:38:56.972034489

Re: [PATCH libdrm 1/3] amdgpu: verify the tested device

2017-01-19 Thread zhoucm1
some small nitpick... On 2017年01月20日 06:53, Alex Xie wrote: Verify the vender ID and driver name. Open all AMDGPU devices. Provide an option to open render node. Tested as root: PASS Tested as non-privileged user: All tests failed as expected Signed-off-by: Alex Xie --- tests/amdgpu/amdgpu_

Re: amdgpu: Corrupted video on 32 bit systems (possible fix)

2017-01-19 Thread Michel Dänzer
On 20/01/17 04:35 AM, Nils Holland wrote: > Hi folks, > > there seems to be an issue on 32 bit kernels which makes graphics > output look all messed up under X when using the amdgpu drm kernel > driver. > > In fact, the same issue was present at some time in 2015 using the > radeon driver too, bu

[PATCH libdrm 3/3] amdgpu: A new option to run tests on render node

2017-01-19 Thread Alex Xie
Tested: 1. As root, tests passed on primary. 2. As root, BO export/import failed on render node as expected. 3. As non-privileged user, tests failed on primary as expected. 4. As non-privileged user, only BO export/import failed on render node as expected. Signed-off-by: Alex Xie --- tests/am

[PATCH libdrm 1/3] amdgpu: verify the tested device

2017-01-19 Thread Alex Xie
Verify the vender ID and driver name. Open all AMDGPU devices. Provide an option to open render node. Tested as root: PASS Tested as non-privileged user: All tests failed as expected Signed-off-by: Alex Xie --- tests/amdgpu/amdgpu_test.c | 144 + 1 fi

[PATCH libdrm 2/3] amdgpu: A new option to choose which device to run most tests

2017-01-19 Thread Alex Xie
This can be used to test multiple GPUs Signed-off-by: Alex Xie --- tests/amdgpu/amdgpu_test.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/tests/amdgpu/amdgpu_test.c b/tests/amdgpu/amdgpu_test.c index e42ef9d..2437db4 100644 --- a/tests/amdgpu/am

[pull] radeon and amdgpu drm-fixes-4.10

2017-01-19 Thread Alex Deucher
Hi Dave, A little bigger than usual since it's two weeks worth. Highlights: - Add support for new smc firmware on some new hainan variants - add support for SI chips that require special mc firmware - remove workarounds for issues fixed by new mc firmware - fix a regression in cursor handling - v

Re: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB(v3)

2017-01-19 Thread Grazvydas Ignotas
On Thu, Jan 19, 2017 at 4:32 PM, Christian König wrote: > Am 19.01.2017 um 14:51 schrieb Grazvydas Ignotas: >> >> On Thu, Jan 19, 2017 at 11:10 AM, Christian König >> wrote: >>> >>> Am 18.01.2017 um 12:42 schrieb Monk Liu: @@ -6743,6 +6741,15 @@ static void gfx_v8_ring_emit_cntxcntl(str

Re: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB(v3)

2017-01-19 Thread Christian König
Am 19.01.2017 um 14:51 schrieb Grazvydas Ignotas: On Thu, Jan 19, 2017 at 11:10 AM, Christian König wrote: Am 18.01.2017 um 12:42 schrieb Monk Liu: @@ -6743,6 +6741,15 @@ static void gfx_v8_ring_emit_cntxcntl(struct amdgpu_ring *ring, uint32_t flags) if (amdgpu_sriov_vf(ring->adev))

RE: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB(v3)

2017-01-19 Thread Liu, Monk
And with more think on it, even the very first UMD cmd start with wptr at 256/512 position ( because ib test ends up at 255 aligned position), your approach still cannot satisfy 128 DW between SWTICH_BUFFER and Preamble IB (if no vm_flush) or 128 Nops before VM_flush (if needed) for the next fra

RE: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB(v3)

2017-01-19 Thread Liu, Monk
Christian I just found one issue in your previous patch ( the one you remove inserting 128nop before vm_fush and meanwhile set align_mask of GFX ring to 0xff) Because I checked amdgpu_ring_commit() again, this function will not guarantee current submit size aligned with 256 dw, instead it only

Re: [PATCH 1/1] drm/amdgpu: fix unload driver issue for virtual display

2017-01-19 Thread Alex Deucher
On Wed, Jan 18, 2017 at 9:03 PM, Xiangliang Yu wrote: > Virtual display doesn't allocate amdgpu_encoder when initializing, > so will get invaild pointer if try to free amdgpu_encoder when > unloading driver. > > Signed-off-by: Xiangliang Yu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/am

Re: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB(v3)

2017-01-19 Thread Grazvydas Ignotas
On Thu, Jan 19, 2017 at 11:10 AM, Christian König wrote: > Am 18.01.2017 um 12:42 schrieb Monk Liu: >> @@ -6743,6 +6741,15 @@ static void gfx_v8_ring_emit_cntxcntl(struct >> amdgpu_ring *ring, uint32_t flags) >> if (amdgpu_sriov_vf(ring->adev)) >> gfx_v8_0_ring_emit_de_meta

[PATCH v3 2/3] drm/amd/display: Switch to using atomic_helper for flip.

2017-01-19 Thread Andrey Grodzovsky
v3: Remove white space change. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c| 89 ++ 2 files changed, 5 insertions(+), 85 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

Re: [PATCH] drm/amdgpu/virt: increase mailbox timeout value

2017-01-19 Thread Christian König
Acked-by: Christian König . Am 19.01.2017 um 11:56 schrieb Ding, Pixel: Reviewed-by: Pixel Ding — Sincerely Yours, Pixel On 19/01/2017, 5:46 PM, "amd-gfx on behalf of Xiangliang Yu" wrote: If start all VFs at same time, the GPU hypervisor need more time to handle mailbox access. Se

Re: [PATCH] drm/amdgpu/virt: increase mailbox timeout value

2017-01-19 Thread Ding, Pixel
Reviewed-by: Pixel Ding — Sincerely Yours, Pixel On 19/01/2017, 5:46 PM, "amd-gfx on behalf of Xiangliang Yu" wrote: >If start all VFs at same time, the GPU hypervisor need more time >to handle mailbox access. Set it to five seconds according to >test experience. > >Signed-off-by: Xi

[PATCH] drm/amdgpu/virt: increase mailbox timeout value

2017-01-19 Thread Xiangliang Yu
If start all VFs at same time, the GPU hypervisor need more time to handle mailbox access. Set it to five seconds according to test experience. Signed-off-by: Xiangliang Yu --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/d

Re: 答复: 答复: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB

2017-01-19 Thread Christian König
so the conclusion is if we have vm-flush, we make sure 128dw between vm flush and CE ib, if we don't insert vm flush we stil make sure 128 DW between SWITCH_BUFFER and CE ib. Good point. if you reject this patch, please give me a solution to fix above VM fault Well, we could follow the wind

Re: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB(v3)

2017-01-19 Thread Christian König
Am 18.01.2017 um 12:42 schrieb Monk Liu: previously we always insert 128nops behind vm_flush, which may lead to DAMframe size above 256 dw and automatially aligned to 512 dw. now we calculate how many DWs already inserted after vm_flush and make up for the reset to pad up to 128dws before emit_i

Re: [PATCH 1/1] drm/amdgpu: fix unload driver issue for virtual display

2017-01-19 Thread Christian König
Am 19.01.2017 um 03:03 schrieb Xiangliang Yu: Virtual display doesn't allocate amdgpu_encoder when initializing, so will get invaild pointer if try to free amdgpu_encoder when unloading driver. Signed-off-by: Xiangliang Yu Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/dce_virt