Re: PRT support for amdgpu

2017-02-01 Thread Dave Airlie
>> answered better by Dave. > > > Yeah, though so as well. Dave can you comment? I think we would require a fully open source user for this sort of thing, there are way to many corner cases for us to fall down here, prematurely pushing the API without a proven test suite running on it would be

Re: [Mesa-dev] [PATCH] drm/radeon: Fix vram_size/visible values in DRM_RADEON_GEM_INFO ioctl

2017-02-01 Thread Marek Olšák
On Tue, Jan 31, 2017 at 11:23 PM, Alex Deucher wrote: > On Tue, Jan 31, 2017 at 5:06 PM, Emil Velikov > wrote: >> On 31 January 2017 at 15:43, Deucher, Alexander >> wrote: -Original Message- From:

Re: [PATCH v4 1/3] drm/atomic: Save flip flags in drm_crtct_state

2017-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2017 at 12:03:34PM -0500, Andrey Grodzovsky wrote: > Allows using atomic flip helpers for drivers > using ASYNC flip. > Remove ASYNC_FLIP restriction in helpers and > caches the page flip flags in drm_crtc_state > to be used in the low level drivers. > > v2: > Resending the patch

[PATCH v4 3/3] drm/amd/display: Switch to using atomic_helper for flip.

2017-02-01 Thread Andrey Grodzovsky
v2: Modify for movig pflip flags to crtc_state v4: Fix identation. Change-Id: I25dae6d8c29de5d022a42aa99a18a32674b56cda Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c

[PATCH v4 0/3] Allow ASYNC flip with atomic helpers.

2017-02-01 Thread Andrey Grodzovsky
This series is a folow-up on https://patchwork.kernel.org/patch/9501787/ The first patch makes changes to atomic helpers to allow for drives with ASYNC flip support to use them. Patch 2 is to use this in AMDGPU/DC. Patch 3 is possible cleanup in nouveau/kms who seems to have to duplicate the

[PATCH v4 1/3] drm/atomic: Save flip flags in drm_crtct_state

2017-02-01 Thread Andrey Grodzovsky
Allows using atomic flip helpers for drivers using ASYNC flip. Remove ASYNC_FLIP restriction in helpers and caches the page flip flags in drm_crtc_state to be used in the low level drivers. v2: Resending the patch since the original was broken. v3: Save flag in crtc_state instead of plane_state

Re: [PATCH v2 0/2] drm amdgpu/radeon: clean up d3_delay usage

2017-02-01 Thread Andreas Boll
For the series: Reviewed-by: Andreas Boll 2017-02-01 17:22 GMT+01:00 Bjorn Helgaas : > amdgpu doesn't need to touch pdev->d3_delay at all. > > radeon has a d3_delay quirk for MacBook Pro, but it only affects > radeon_switcheroo_set_state(). I

[PATCH v2 0/2] drm amdgpu/radeon: clean up d3_delay usage

2017-02-01 Thread Bjorn Helgaas
amdgpu doesn't need to touch pdev->d3_delay at all. radeon has a d3_delay quirk for MacBook Pro, but it only affects radeon_switcheroo_set_state(). I think it should affect wakeups done by the PCI core as well. Changes from v1 to v2: - Fix accidental removal of "{ 0, 0, 0, 0, 0 }" quirk list

[PATCH v2 1/2] drm/amdgpu: remove unnecessary save/restore of pdev->d3_delay

2017-02-01 Thread Bjorn Helgaas
Remove unnecessary save/restore of pdev->d3_delay. The only assignments to pdev->d3_delay are in radeon_switcheroo_set_state() and some quirks, none of which should be relevant in the amdgpu_switcheroo_set_state() path. Signed-off-by: Bjorn Helgaas Acked-by: Alex Deucher

[PATCH v2 2/2] drm/radeon: make MacBook Pro d3_delay quirk more generic

2017-02-01 Thread Bjorn Helgaas
The PCI Power Management Spec, r1.2, sec 5.6.1, requires a 10 millisecond delay when powering on a device, i.e., transitioning from state D3hot to D0. Apparently some devices require more time, and d1f9809ed131 ("drm/radeon: add quirk for d3 delay during switcheroo poweron for apple macbooks")

Re: [PATCH v1 2/2] drm/radeon: make MacBook Pro d3_delay quirk more generic

2017-02-01 Thread Bjorn Helgaas
On Wed, Feb 01, 2017 at 04:45:42PM +0100, Andreas Boll wrote: > 2017-01-30 21:41 GMT+01:00 Bjorn Helgaas : > > The PCI Power Management Spec, r1.2, sec 5.6.1, requires a 10 millisecond > > delay when powering on a device, i.e., transitioning from state D3hot to > > D0. > > > >

[PATCH] drm/amdgpu: shut up #warning for compile testing

2017-02-01 Thread Arnd Bergmann
My randconfig tests on linux-next showed a newly introduced warning: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function 'amdgpu_bo_create_restricted': drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:377:2: error: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance

Re: [PATCH v1 2/2] drm/radeon: make MacBook Pro d3_delay quirk more generic

2017-02-01 Thread Andreas Boll
2017-01-30 21:41 GMT+01:00 Bjorn Helgaas : > The PCI Power Management Spec, r1.2, sec 5.6.1, requires a 10 millisecond > delay when powering on a device, i.e., transitioning from state D3hot to > D0. > > Apparently some devices require more time, and d1f9809ed131 ("drm/radeon:

Re: [PATCH 4/4] drm/amdgpu: extend profiling mode.

2017-02-01 Thread Andy Furniss
Alex Deucher wrote: On Tue, Jan 31, 2017 at 6:19 PM, Andy Furniss wrote: Andy Furniss wrote: Rex Zhu wrote: in profiling mode, powerplay will fix power state as stable as possible.and disable gfx cg and LBPW feature. profile_standard: as a prerequisite, ensure power

Re: [PATCH 4/4] drm/amdgpu: extend profiling mode.

2017-02-01 Thread Alex Deucher
On Tue, Jan 31, 2017 at 6:19 PM, Andy Furniss wrote: > Andy Furniss wrote: >> >> Rex Zhu wrote: >>> >>> in profiling mode, powerplay will fix power state >>> as stable as possible.and disable gfx cg and LBPW feature. >>> >>> profile_standard: as a prerequisite, ensure power

Re: [PATCH libdrm 0/3] some -pro patches for integration

2017-02-01 Thread Emil Velikov
On 28 January 2017 at 19:49, Grazvydas Ignotas wrote: > I've taken several patches from amdgpu-pro libdrm that look useful > to me and I think can be applied already. The only things I did was > rebasing, fixing some typos and dropping Change-Id. > > Alex Xie (3): > amdgpu:

Re: [v3 PATCH 3/3] drm/amd/display: Switch to using atomic_helper for flip.

2017-02-01 Thread Laurent Pinchart
Hi Harry, On Monday 30 Jan 2017 10:38:47 Harry Wentland wrote: > On 2017-01-28 09:26 PM, Andrey Grodzovsky wrote: > > Swicth to use atomic helper. > > Start using actual user's given target_vblank value for flip > > instead of current value. > > > > v3: > > Update for movig pflip flags to

Re: PRT support for amdgpu

2017-02-01 Thread Nicolai Hähnle
On 31.01.2017 17:28, Christian König wrote: Am 31.01.2017 um 14:06 schrieb Bas Nieuwenhuizen: So this API seems usable, and I think this is something we can use for radv. However, I'm not sure how much time it takes for us to implement, as the TFE variants are not in LLVM yet and I haven't

Re: [v3 PATCH 3/3] drm/amd/display: Switch to using atomic_helper for flip.

2017-02-01 Thread Andrzej Hajda
Hi Andrey, On 29.01.2017 03:26, Andrey Grodzovsky wrote: > Swicth to use atomic helper. > Start using actual user's given target_vblank value for flip > instead of current value. > > v3: > Update for movig pflip flags to crtc_state > > Change-Id: I25dae6d8c29de5d022a42aa99a18a32674b56cda >

Re: [v3 PATCH 1/3] drm/atomic: Save flip flags in drm_crtct_state

2017-02-01 Thread Laurent Pinchart
Hi Andrey, (by the way there's a typo in the subject) On Monday 30 Jan 2017 19:42:23 Grodzovsky, Andrey wrote: > On Monday, January 30, 2017 6:05 AM Laurent Pinchart wrote: > > On Saturday 28 Jan 2017 21:26:49 Andrey Grodzovsky wrote: > >> Allows using atomic flip helpers for drivers using ASYNC