RE: [PATCH] drm/ttm:fix missing inc bo_count

2017-08-23 Thread Liu, Monk
Thanks,that one is somehow missed ! Just pushed -Original Message- From: Deucher, Alexander Sent: Wednesday, August 23, 2017 9:34 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: RE: [PATCH] drm/ttm:fix missing inc bo_count >

Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS

2017-08-23 Thread Michel Dänzer
On 24/08/17 03:12 AM, Kent Russell wrote: > This won't change after initialization, so we can add the information > when we parse the atombios information. This ensures that we can find > out the VBIOS, even when the dmesg buffer fills up, and makes it easier > to associate which VBIOS is for

[PATCH] drm/amdgpu: Add sysfs file for VBIOS

2017-08-23 Thread Kent Russell
This won't change after initialization, so we can add the information when we parse the atombios information. This ensures that we can find out the VBIOS, even when the dmesg buffer fills up, and makes it easier to associate which VBIOS is for which GPU on mGPU configurations. Set the size to 20

Re: [PATCH][drm-next] drm/amdgpu: remove duplicate return statement

2017-08-23 Thread Felix Kuehling
I must have added that accidentally when cherry-picking an internal patch for upstreaming. Thanks for catching it. Reviewed-by: Felix Kuehling Regards, Felix On 2017-08-23 09:17 AM, Colin King wrote: > From: Colin Ian King > > Remove a

RE: [PATCH 1/3] drm/amdgpu: remove the GART copy hack

2017-08-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Wednesday, August 23, 2017 5:03 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/3] drm/amdgpu: remove the GART copy hack > > From: Christian König

Re: [PATCH] drm/amdgpu: disable DC on KB/ML for now

2017-08-23 Thread Harry Wentland
On 2017-08-23 09:48 AM, Alex Deucher wrote: > Until I've had time to test it better. >> bug: https://bugs.freedesktop.org/show_bug.cgi?id=102372 > Looks like just one missing piece in dce110_opp_power_on_regamma_lut > Signed-off-by: Alex Deucher Reviewed-by: Harry

[PATCH] drm/amdgpu: check memory allocation failure

2017-08-23 Thread Christophe JAILLET
Check memory allocation failure and return -ENOMEM in such a case. 'num_post_dep_syncobjs' still has to be set to 0 before the test in order to have it initialized if 'amdgpu_cs_parser_fini()' is called to free resources. The calling graph would be, in such a case! failure in

[PATCH][drm-next] drm/amdgpu: remove duplicate return statement

2017-08-23 Thread Colin King
From: Colin Ian King Remove a redundant identical return statement, it has no use. Detected by CoverityScan, CID#1454586 ("Structurally dead code") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 1 - 1

[PATCH] drm/amdgpu: disable DC on KB/ML for now

2017-08-23 Thread Alex Deucher
Until I've had time to test it better. bug: https://bugs.freedesktop.org/show_bug.cgi?id=102372 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

RE: [PATCH] drm/ttm:fix missing inc bo_count

2017-08-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Sunday, August 13, 2017 11:44 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH] drm/ttm:fix missing inc bo_count > > From: Monk Liu

RE: [PATCH 3/3] drm/amdgpu: inline amdgpu_ttm_do_bind again

2017-08-23 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, August 23, 2017 5:03 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 3/3] drm/amdgpu:

RE: [PATCH 1/3] drm/amdgpu: remove the GART copy hack

2017-08-23 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, August 23, 2017 5:03 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 1/3] drm/amdgpu:

RE: [PATCH] drm/amdkfd: fix bug device is not added to supported_devices

2017-08-23 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Wang Hongcheng Sent: Wednesday, August 23, 2017 4:58 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Annie Subject: [PATCH]

[PATCH] drm/amdkfd: fix bug device is not added to supported_devices

2017-08-23 Thread Wang Hongcheng
Add Tonga passthrough device 0x6929 to kfd device table. BUG:SWDEV-130471 Signed-off-by: Wang Hongcheng --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c

[PATCH 2/3] drm/amdgpu: fix amdgpu_ttm_bind

2017-08-23 Thread Christian König
From: Christian König Use ttm_bo_mem_space instead of manually allocating GART space. This allows us to evict BOs when there isn't enought GART space any more. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c |

[PATCH 3/3] drm/amdgpu: inline amdgpu_ttm_do_bind again

2017-08-23 Thread Christian König
From: Christian König The function is called only once and doesn't do anything special. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 45 + 1 file changed, 18 insertions(+), 27

[PATCH 1/3] drm/amdgpu: remove the GART copy hack

2017-08-23 Thread Christian König
From: Christian König This isn't used since we don't map evicted BOs to GART any more. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-)

Re: [PATCH] drm/amdgpu: check memory allocation failure

2017-08-23 Thread Christian König
Am 23.08.2017 um 07:52 schrieb Christophe JAILLET: Check memory allocation failure and return -ENOMEM in such a case. 'num_post_dep_syncobjs' still has to be set to 0 before the test in order to have it initialized if 'amdgpu_cs_parser_fini()' is called to free resources. The calling graph

Re: [PATCH] drm/amdgpu: set sched_hw_submission higher for KIQ (v2)

2017-08-23 Thread Christian König
As noted in the otehr thread we could set it to 256 as well and still only use one page, but 16 is fine with me as well. Patch is Reviewed-by: Christian König Regards, Christian. Am 23.08.2017 um 04:25 schrieb Felix Kuehling: This change is Reviewed-by: Felix

Re: [PATCH] drm/amdgpu: set sched_hw_submission higher for KIQ

2017-08-23 Thread Christian König
Am 22.08.2017 um 23:34 schrieb Jay Cornwall: On Tue, Aug 22, 2017, at 16:17, Felix Kuehling wrote: Thanks Alex! Jay, do you think this is enough? This bumps the number of concurrent operations on KIQ to 4 by default. I'm not sure what the best number is. Up to 8 KFD processes is common

Re: [PATCH] drm/amdgpu: discard commands of killed processes

2017-08-23 Thread William Lewis
On 08/21/2017 07:58 AM, Christian König wrote: > From: Christian König > > When a process is killed we shouldn't submit all waiting jobs, but instead > clean up as fast as possible. > > Signed-off-by: Christian König > --- >