Re: [PATCH 00/24] KFD fixes, cleanups, features to make the runtime happy

Update on KV testing with upstream kernel code: I was able to make OpenCL work with a simple change. I compiled it from the open-source version available on GitHub (https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime) and applied the change below. I'm running the SHOC benchmark right now,

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

I think this change could use a little more explanation. I also have some ideas for simplifying the code and making it easier to understand. See comments inline. But it looks good to me otherwise. Reviewed-by: Felix Kuehling Regards, Felix On 2017-09-08 08:18 AM,

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

The hang seems to be gone with this patch. Marek On Fri, Sep 8, 2017 at 2:26 PM, Christian König wrote: > Marek this one will most likely fix your issues with always valid BOs on > Raven. > > Please give it a try when you have time. > > Thanks, > Christian. > > > Am

[PATCH 16/16] drm/amd/powerplay: Tidy up vega10_thermal_initialize()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 13/16] drm/amd/powerplay: Fix indentation in vega10_fan_ctrl_reset_fan_speed_to_default()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 14/16] drm/amd/powerplay: Tidy up vega10_fan_ctrl_set_fan_speed_rpm()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 10/16] drm/amd/powerplay: Tidy up vega10_fan_ctrl_set_static_mode()

Signed-off-by: Tom St Denis --- .../gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c| 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 11/16] drm/amd/powerplay: Tidy up vega10_fan_ctrl_set_default_mode()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 06/16] drm/amd/powerplay: Port vega10_hwmgr.c over to PP_CAP

Replace and cleanup lengthy phm_cap_enabled() sequences with PP_CAP. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 91 -- 1 file changed, 32 insertions(+), 59 deletions(-) diff --git

[PATCH 07/16] drm/amd/powerplay: Port vega10_powertune.c over to PP_CAP

Signed-off-by: Tom St Denis --- .../gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c | 47 ++ 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c

Various vega10 hwmgr cleanups

These patches introduce a couple of new macro sets to help and tidy up the hwmgr code for powerplay. Applied only to the vega10 drivers so far. Should be no functional changes but there are a few re-arrangements of existing code. ___ amd-gfx mailing

[PATCH 09/16] drm/amd/powerplay: Tidy up vega10_fan_ctrl_get_fan_speed_rpm()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 01/16] drm/amd/powerplay: Simplify vega10_patch_voltage_dependency_tables_with_lookup_table()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 75 +++--- 1 file changed, 23 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c

[PATCH 05/16] drm/amd/powerplay: Add PP_CAP() macro

To replace common lengthy sequence that would create really long lines all over. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/inc/hardwaremanager.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/inc/hardwaremanager.h

[PATCH 03/16] drm/amd/powerplay: Introduction of bitmask macros for registers

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/include/cgs_common.h | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/amd/include/cgs_common.h b/drivers/gpu/drm/amd/include/cgs_common.h index 0214f63f52fc..92eaa81f9fcb 100644 ---

[PATCH 15/16] drm/amd/powerplay: Tidy up vega10_thermal_set_temperature_range()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 12/16] drm/amd/powerplay: Tidy up vega10_fan_ctrl_set_fan_speed_percent()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 04/16] drm/amd/powerplay: Port vega10_didt_set_mask() to new macros

Start using new CGS bitmask macros. Signed-off-by: Tom St Denis --- .../gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c | 60 -- 1 file changed, 20 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c

[PATCH 02/16] drm/amd/powerplay: Simplify vega10_acg_disable()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c index

[PATCH 08/16] drm/amd/powerplay: Port vega10_thermal.c over to PP_CAP

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

[PATCH 2/2] drm/amdgpu: move MMU notifier related defines to amdgpu_mn.h

From: Christian König Just some cleanup. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 25 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 52 ++ 2 files changed, 53

[PATCH 1/2] drm/amdgpu: move amdgpu_ttm_tt_* declarations into amdgpu_ttm.h

From: Christian König Just some cleanup. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 15 --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 16 2 files changed, 16 insertions(+), 15

Re: [PATCH 0/6] Ground foundation for VCE 1 implementation

Am 08.09.2017 um 13:55 schrieb Alexandre Demers: Hi Christian! On 2017-09-08 04:24, Christian König wrote: First of all please prefix all subject lines for amdgpu kernel patches with drm/amdgpu. You're right, I forgot. Additional to that I think we won't accept loading firmware files in the

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

Marek this one will most likely fix your issues with always valid BOs on Raven. Please give it a try when you have time. Thanks, Christian. Am 08.09.2017 um 14:18 schrieb Christian König: From: Christian König All users of a VM must always wait for updates with

[PATCH] drm/amdgpu: fix VM sync with always valid BOs

From: Christian König All users of a VM must always wait for updates with always valid BOs to be completed. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 14 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

Re: [PATCH] drm/radeon: Small precision when failing to load UVD legacy firmware.

Am 08.09.2017 um 14:10 schrieb Alexandre Demers: Signed-off-by: Alexandre Demers Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/radeon: Small precision when failing to load UVD legacy firmware.

Signed-off-by: Alexandre Demers --- drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c index 7431eb4a11b7..b4fb07ad9f4a 100644 ---

Re: [PATCH 0/6] Ground foundation for VCE 1 implementation

Oh and patch 3 "Small precision when failing to load legacy firmware" should have been a standalone patch, it is related to the radeon driver. I'll send it as so with drm/radeon in the title. Alexandre Demers On 2017-09-08 07:55, Alexandre Demers wrote: > Hi Christian! > > On 2017-09-08 04:24,

Re: [PATCH 0/6] Ground foundation for VCE 1 implementation

Hi Christian! On 2017-09-08 04:24, Christian König wrote: > First of all please prefix all subject lines for amdgpu kernel patches > with drm/amdgpu. You're right, I forgot. > > Additional to that I think we won't accept loading firmware files in > the old format. Instead please just add the

Re: [PATCH 0/6] Ground foundation for VCE 1 implementation

First of all please prefix all subject lines for amdgpu kernel patches with drm/amdgpu. Additional to that I think we won't accept loading firmware files in the old format. Instead please just add the header to the files. If that turns out to be problematic I can start looking into providing

[ANNOUNCE] xf86-video-ati 7.10.0

I'm pleased to announce the 7.10.0 release of xf86-video-ati, the Xorg driver for ATI/AMD Radeon GPUs supported by the radeon kernel driver. This release supports xserver versions 1.13-1.19. Highlights: * Clients can now use DRI page flipping even while TearFree is enabled for any CRTC. This

Re: [PATCH 6/6] drm/amdgpu: Add gem_prime_mmap support

Am 08.09.2017 um 00:17 schrieb Samuel Li: >>+if (write) >>+amdgpu_asic_invalidate_hdp(adev); > You can drop the HDP invalidation here. amdgpu_gem_prime_pin() will pin the BO into system memory. My understanding here is between CPU and GPU access, the invalidate/flush is still

[ANNOUNCE] xf86-video-amdgpu 1.4.0

I'm pleased to announce the 1.4.0 release of xf86-video-amdgpu, the Xorg driver for AMD Radeon GPUs supported by the amdgpu kernel driver. This release supports xserver versions 1.13-1.19. Highlights: * Clients can now use DRI page flipping even while TearFree is enabled for any CRTC. This

[PATCH 2/2] drm/amd/powerplay: fix spelling typo in function name

Change-Id: Ic1b96b6efd2997240a26b6d8bc00e69f05ea4676 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 8 drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 1/2] drm/amdgpu: add support for request SI/CI firmware in CGS

Change-Id: If3ab520f8c65bec070e97cd8787041919d687ad3 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 79 + 1 file changed, 79 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c

Re: [PATCH 1/2] dma-buf: make reservation_object_copy_fences rcu save

On Thu, Sep 07, 2017 at 09:13:32AM +0200, Christian König wrote: > Ping? David can you take a look? > > Alex is on vacation and that is a rather important bug fix. Works better when you cc Gustavo/Maarten/Sumits/Chris I think, for anything dma-buf review needing. -Daniel > > Thanks, >