Re: [PATCH 1/1] amdgpu: move asic id table to a separate file

looks fine to me, feel free to add my RB. Reviewed-by: Junwei Zhang BTW, we also has 1 or 2 patch to improve the name parsing. Please also take a look. Jerry On 05/11/2017 05:10 AM, Li, Samuel wrote: Also attach a sample ids file for reference. The names are from

Re: [PATCH] drm/amdgpu/psp: declare raven psp firmware

On 09/16/2017 05:37 AM, Alex Deucher wrote: So it gets picked up properly by the kernel. Signed-off-by: Alex Deucher Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] drm/amdkfd: check for null dev to avoid a null pointer dereference

On Fri, Sep 8, 2017 at 5:13 PM, Colin King wrote: > From: Colin Ian King > > The call to kfd_device_by_id can potentially return null, so check that > dev is null and return with -EINVAL to avoid a null pointer dereference. > > Detected by

Re: [PATCH 10/11] drm/amdkfd: Print event limit messages only once per process

On Sat, Sep 16, 2017 at 2:43 AM, Felix Kuehling wrote: > To avoid spamming the log. > > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_events.c | 5 - > drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 1 + > 2 files changed, 5

Re: [PATCH 09/11] drm/amdkfd: Fix kernel-queue wrapping bugs

On Sat, Sep 16, 2017 at 2:43 AM, Felix Kuehling wrote: > From: Yong Zhao > > Avoid intermediate negative numbers when doing calculations with a mix > of signed and unsigned variables where implicit conversions can lead > to unexpected results. > > When

Re: [PATCH 08/11] drm/amdkfd: Drop _nocpsch suffix from shared functions

On Sat, Sep 16, 2017 at 2:42 AM, Felix Kuehling wrote: > From: Yong Zhao > > Several functions in DQM are shared between cpsch and nocpsch code. > Remove the misleading _nocpsch suffix from their names. > > Signed-off-by: Yong Zhao >

Re: [PATCH 05/11] drm/amdkfd: Fix incorrect destroy_mqd parameter

On Sat, Sep 16, 2017 at 2:42 AM, Felix Kuehling wrote: > When uninitializing a kernel queue. > > Signed-off-by: Yong Zhao > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 2 +- > 1 file

Re: [PATCH 04/11] drm/amdkfd: Adjust dequeue latencies and timeouts

On Sat, Sep 16, 2017 at 2:42 AM, Felix Kuehling wrote: > Adjust latencies and timeouts for dequeueing with HWS and consolidate > them in one place. Make them longer to allow long running waves to > complete without causing a timeout. The timeout is twice as long as the >

Re: [PATCH 02/11] drm/amdkfd: Fix suspend/resume issue on Carrizo

On Sat, Sep 16, 2017 at 2:42 AM, Felix Kuehling wrote: > From: Yong Zhao > > When we do suspend/resume through "sudo pm-suspend" while there is > HSA activity running, upon resume we will encounter HWS hanging, which > is caused by memory read/write

Re: [PATCH 01/11] drm/amdkfd: Reorganize kfd resume code

On Sat, Sep 16, 2017 at 2:42 AM, Felix Kuehling wrote: > From: Yong Zhao > > The idea is to let kfd init and resume function share the same code path > as much as possible, rather than to have two copies of almost identical > code. That way improves the

Re: [PATCH 07/11] drm/amdkfd: Reuse CHIP_* from amdgpu

On Sat, Sep 16, 2017 at 2:42 AM, Felix Kuehling wrote: > From: Yong Zhao > > There are already CHIP_* definitions under amd_shared.h file on amdgpu > side, so KFD should reuse them rather than defining new ones. > > Using enum for asic type requires