Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

Could you test and review it? On hand, I have no env. Regards, David Zhou 发自坚果 Pro Marek Ol?醟 于 2017年9月30日 下午11:56写道： The idea sounds good. Marek On Sat, Sep 30, 2017 at 3:55 AM, Chunming Zhou wrote: > My mean is like the attached, I revert part of

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

The idea sounds good. Marek On Sat, Sep 30, 2017 at 3:55 AM, Chunming Zhou wrote: > My mean is like the attached, I revert part of yours. > > Regards, > > David zhou > > > > On 2017年09月29日 22:15, Marek Olšák wrote: >> >> On Fri, Sep 29, 2017 at 4:13 PM, Marek Olšák

Re: [PATCH] drm/radeon/dp: make radeon_dp_get_dp_link_config static

Am 29.09.2017 um 17:54 schrieb Alex Deucher: It's not used outside this file any longer. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/radeon/atombios_dp.c | 8

Re: [PATCH 1/2] drm/amdgpu: potential uninitialized variable in amdgpu_vce_ring_parse_cs()

Am 30.09.2017 um 10:13 schrieb Dan Carpenter: We shifted some code around in commit 9cca0b8e5df0 ("drm/amdgpu: move amdgpu_cs_sysvm_access_required into find_mapping") and now my static checker complains that "r" might not be initialized at the end of the function. I've reviewed the code, and

[PATCH 1/2] drm/amdgpu: potential uninitialized variable in amdgpu_vce_ring_parse_cs()

We shifted some code around in commit 9cca0b8e5df0 ("drm/amdgpu: move amdgpu_cs_sysvm_access_required into find_mapping") and now my static checker complains that "r" might not be initialized at the end of the function. I've reviewed the code, and that seems possible, but it's also possible I may

RE: some more powerplay/pwr virus size reduction patches

Hi Alex, We can use Polaris's PwrVirusTable on Fiji. So can remove fiji_pwrvirus.h Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Friday, September 29, 2017 11:13 AM To: 'Dave Airlie'; amd-gfx mailing list; Alex Deucher; Zhu, Rex Subject: RE: some more

RE: [PATCH 2/2] drm/amd/powerplay: fix ret checks in amd_powerplay.c

Series are reviewed-by: Evan Quan Regards, Evan >-Original Message- >From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex >Zhu >Sent: Saturday, September 30, 2017 10:50 AM >To: amd-gfx@lists.freedesktop.org >Cc: Zhu, Rex

[PATCH 10/12] drm/amdgpu/sriov:implement guilty ctx for loose reset

Change-Id: I7904f362aa0f578a5cbf5d40c7a242c2c6680a92 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 16 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 1 +

[PATCH 09/12] drm/amdgpu/sriov:return -ENODEV if gpu reseted

for SRIOV strict mode gpu reset: In kms open we mark the latest adev->gpu_reset_counter in fpriv we return -ENODEV in cs_ioctl or info_ioctl if they found fpriv->gpu_reset_counter != adev->gpu_reset_counter. this way we prevent a potential bad process/FD from submitting cmds and notify userspace

[PATCH 12/12] drm/amdgpu/sriov:no shadow buffer recovery

1, we have deadlock unresloved between shadow bo recovery and ctx_do_release, 2, for loose mode gpu reset we always assume VRAM not lost so there is no need to do that from begining Change-Id: I5259f9d943239bd1fa2e45eb446ef053299fbfb1 Signed-off-by: Monk Liu ---

[PATCH 05/12] drm/amdgpu/sriov:accurate description for sriov_gpu_reset

Change-Id: I4120f146e68cb38db69418426740d409de86101a Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index

[PATCH 11/12] drm/amdgpu/sriov:show error if ib test failed

fix loose mode gpu reset ib test result incorrect message Change-Id: Ic4e3b51e4ff77c5e08d268a4a5ca32e7c882367c Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 08/12] drm/amdgpu:explicitly call fence_process

this way no need to wait timer triggered to save time Change-Id: Ie96fd2fc1f6054ebc1e58c3d703471639371ee22 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH 07/12] drm/amdgpu/sriov:implement strict gpu reset

changes: 1)implement strict mode sriov gpu reset 2)always call sriov_gpu_reset_strict if hypervisor notify FLR 3)in strict reset mode, set error to all fences. 4)change fence_wait/cs_wait functions to return -ENODEV if fence signaled with error == -ETIME, Since after strict gpu reset we consider

[PATCH 06/12] drm/amdgpu/sriov:handle more jobs hang in different ring case

quit first and try later if gpu_reset is already running, this way we can handle different jobs hang on different ring and crash each other on the same time Change-Id: I0c6bc8d76959c5053e7523c41b2305032fc6b79a Signed-off-by: Monk Liu ---

[PATCH 04/12] drm/amdgpu/sriov:cleanup gpu rest mlock

this mutex lock is for preventing multi-thread concurrrently executing the sriov_gpu_reset, now we use atomic_add_unless to replace it. Change-Id: Id07e364764252a631cb75b01c7b7ff8d173d6c95 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ---

[PATCH 00/12] *** SRIOV GPU RESET PATCHES ***

implement strict mode gpu reset, and some changes for loose mode reset Monk Liu (12): drm/amdgpu/sriov:now must reinit psp drm/amdgpu/sriov:fix memory leak in psp_load_fw drm/amdgpu/sriov:use atomic type for sriov_reset drm/amdgpu/sriov:cleanup gpu rest mlock drm/amdgpu/sriov:accurate

[PATCH 01/12] drm/amdgpu/sriov:now must reinit psp

otherwise after VF FLR the KIQ cannot work Change-Id: Icb18e794b5e4dccfd70c811c138c7102df874203 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 03/12] drm/amdgpu/sriov:use atomic type for sriov_reset

Change-Id: If33ebac11c93ce2753c30bbe0d51b594449e2e7f Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 4 ++--

[PATCH 02/12] drm/amdgpu/sriov:fix memory leak in psp_load_fw

when doing gpu reset this routine shouldn't do anything resource allocating otherwise SRIOV gpu reset will cause memory leak Change-Id: I25da3a5b475196c75c7e639adc40751754625968 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 20 1