[PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address(v2) -v2: update the ring_buffer_end address

Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 16 ++-- 2 files changed, 28 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 2/2] drm/amdgpu: allow GTT overcommit during bind

On 2017年10月16日 19:40, Christian König wrote: Am 16.10.2017 um 11:42 schrieb Chunming Zhou: On 2017年10月16日 17:26, Christian König wrote: From: Christian König While binding BOs to GART we need to allow a bit overcommit in the GTT domain. If allowing overcommit,

[PATCH 2/2] drm/amd/display: Add bunch of missing license headers in DML

All files should have MIT headers. Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/dc/dml/display_mode_vba.c | 25 ++ .../gpu/drm/amd/display/dc/dml/display_mode_vba.h | 24 ++--- 2 files changed, 46 insertions(+), 3

[PATCH 1/2] amdgpu/dc: inline a bunch of the dml wrappers.

This reduces the code size. This is basically a redo of Dave's change with the same name on top of the latest DML. Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/dc/dml/display_mode_vba.c | 2 + .../drm/amd/display/dc/dml/display_rq_dlg_calc.c | 2 +

Re: [PATCH] drm/amd/display: Small comment on dc_commit_planes_to_stream

On 2017-10-16 08:11 PM, Harry Wentland wrote: Having one struct on the stack was somewhat confusing. Also mention that the whole function should eventually go. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++ 1 file changed, 7

Upstream repo for libhsakmt

Hi Felix, What do you think about merging your fxkamd/drm-next-wip into the master branch of the hsakmt repository of freedesktop[1]? Fedora is already packaging code from the freedesktop repository, and it might help to distinguish between the ROCm thunk and the upstream thunk by keeping them

[PATCH] drm/amd/display: Small comment on dc_commit_planes_to_stream

Having one struct on the stack was somewhat confusing. Also mention that the whole function should eventually go. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH 15/20] drm/amd/display: Reduce stack size of commit_planes_to_stream

On 2017-10-16 07:51 PM, Harry Wentland wrote: On 2017-10-16 06:51 PM, andrey wrote: On 2017-10-16 04:31 PM, Harry Wentland wrote: This function likes to blow 1024 stack size when something is added to the addr struct. For now just dynamically allocate. Signed-off-by: Harry Wentland

Re: [PATCH 15/20] drm/amd/display: Reduce stack size of commit_planes_to_stream

On 2017-10-16 06:51 PM, andrey wrote: > > > On 2017-10-16 04:31 PM, Harry Wentland wrote: >> This function likes to blow 1024 stack size when something is >> added to the addr struct. For now just dynamically allocate. >> >> Signed-off-by: Harry Wentland >> Reviewed-by:

Re: [PATCH 15/20] drm/amd/display: Reduce stack size of commit_planes_to_stream

On 2017-10-16 04:31 PM, Harry Wentland wrote: This function likes to blow 1024 stack size when something is added to the addr struct. For now just dynamically allocate. Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland

Re: [PATCH 07/20] drm/amd/display: Add chip mask to HDMI retimer/redriver check

On Mon, Oct 16, 2017 at 4:31 PM, Harry Wentland wrote: > From: Andrew Jiang > > There were cases where the chip caps held additional bits that led to > the retimer/redriver check failing; use the proper mask to ensure that > we have only the bits

Re: [PATCH v3] drm/amd/powerplay: Remove unnecessary cast on void pointer

Hi Harsha, [auto build test WARNING on v4.14-rc3] [cannot apply to drm/drm-next next-20171013] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 02/20] drm/amd/display: Fix warning about uninitialized variable

Signed-off-by: Harry Wentland Reviewed-by: Bhawanpreet Lakha Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/20] drm/amd/display: WA for 3 display play video hot plug.

From: Yongqiang Sun Three monitor connected and playing a video will occupy all 4 pipes, if hot plug forth display, commit streams will be failed due to no free pipe can be found. Work around: When forth monitor connected,

[PATCH 14/20] drm/amd/display: Fix one more place for dc_stream_state leak

One more thing that happened due to uneven applying of patches. This mirrors what Darren Salt fixed. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 13/20] drm/amd/display: Move OS types to os_types.h

Some of this stuff is not really dm_services Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dm_services.h | 41

[PATCH 11/20] drm/amd/display: DAL 3.1.06

From: Tony Cheng Raven bug fixes - RS3 MPO stability improvement - SLS fixes - AM4 fixes DAL 3.1 - merge in upstream patches from DRM maintainer Dave Arilie - hubp, dpp HW objects Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng

[PATCH 01/20] drm/amd/display: Don't set cursor address is 0 logging as errors

From: Andrew Jiang This actually happens quite a bit, and having it as an error causes false positive messages when running tests. Signed-off-by: Andrew Jiang Reviewed-by: Tony Cheng Acked-by: Harry Wentland

[PATCH 20/20] drm/amd/display: Minor update to DML

From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 ++-

[PATCH 00/20] DC Linux Patches Oct 16, 2017

Mostly Raven (DCN1) work this time around, beside a bunch of minor cleanups and a minor update to DML. Andrew Jiang (4): drm/amd/display: Don't set cursor address is 0 logging as errors drm/amd/display: Correct timings in build scaling params drm/amd/display: Add chip mask to HDMI

[PATCH 03/20] drm/amd/display: Fix up some whitespace in handle_cursor_update

Use combo of tabs and spaces Signed-off-by: Harry Wentland Acked-by: Alex Deucher Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8

[PATCH 19/20] drm/amd/display: change dml numdpp var to uint

From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 14 +++---

[PATCH 16/20] drm/amd/display: dal 3.1.07

From: Tony Cheng - regression fixes in dal 3.1.06 - more linux upstream backport Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 3 +-- 1

[PATCH 05/20] drm/amd/display: check SR_WATERMARK regs prior to write

From: Eric Bernstein Signed-off-by: Eric Bernstein Reviewed-by: Charlene Liu Acked-by: Harry Wentland --- .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 144 +++-- 1 file

[PATCH 18/20] drm/amd/display: default force_single_disp_pipe_split = 1 on RV

From: Tony Cheng 1080p idle, stutter efficiency goes up from 95.8% to 97.8% result in 5mW saving from APU and 8mW saving from DDR4 Signed-off-by: Tony Cheng Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland

[PATCH 15/20] drm/amd/display: Reduce stack size of commit_planes_to_stream

This function likes to blow 1024 stack size when something is added to the addr struct. For now just dynamically allocate. Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland ---

[PATCH 06/20] drm/amd/display: Correct timings in build scaling params

From: Andrew Jiang A previous patch set the addressable timing as active + border, when in fact, the VESA standard specifies active as equal to addressable + border. This patch makes the fix more correct and in line with the standard. Signed-off-by: Andrew Jiang

[PATCH 10/20] drm/amd/display: rename dscl functions

From: Yue Hin Lau Signed-off-by: Yue Hin Lau Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 10 +-- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.h

[PATCH 12/20] drm/amd/display: LGD panel willl flash line under window

From: Hersen Wu Signed-off-by: Hersen Wu Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 9 + 1 file changed, 9 insertions(+) diff

[PATCH 17/20] drm/amd/display: Remove redundant condition in dml vba

Found by 0-day https://lists.freedesktop.org/archives/dri-devel/2017-October/154698.html Signed-off-by: Harry Wentland Reviewed-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland

[PATCH 04/20] drm/amd/display: drop display_pipe_clocks.c.

From: Dave Airlie This code isn't used at all in the kernel tree, perhaps it can wait to be imported when it is. It also does a lot of floating point calcs, so probably good to drop it until it's needed and we can ensure proper fpu accessors. Signed-off-by: Dave Airlie

[PATCH 08/20] drm/amd/display: Add DIGD case when getting retimer settings

From: Andrew Jiang One of the HDMI ports map to DIGD, which we did not map to DP3 ext HDMI settings. Add the DIGD case so that we can get proper retimer settings from SBIOS for that port. Signed-off-by: Andrew Jiang Reviewed-by: Charlene Liu

[PATCH 07/20] drm/amd/display: Add chip mask to HDMI retimer/redriver check

From: Andrew Jiang There were cases where the chip caps held additional bits that led to the retimer/redriver check failing; use the proper mask to ensure that we have only the bits that we care about for the check in question. Signed-off-by: Andrew Jiang

Re: [PATCH v3] drm/amd/powerplay: Remove unnecessary cast on void pointer

Hi Harsha, [auto build test ERROR on v4.14-rc3] [cannot apply to drm/drm-next next-20171013] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

RE: [PATCH 7/7] drm/amd/powerplay: Tidy up cz_dpm_powerup_vce()

> -Original Message- > From: StDenis, Tom > Sent: Monday, October 16, 2017 2:25 PM > To: Deucher, Alexander; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 7/7] drm/amd/powerplay: Tidy up > cz_dpm_powerup_vce() > > On 16/10/17 02:23 PM, Deucher, Alexander wrote: > >> -Original

RE: Simple cleanups for cz_hwmgr.c

Please provide a commit message for each patch. E.g., something like: Fix up whitespace and use new PP_CAP macro. No function change intended. With that fixed, patches 1-5 are: Reviewed-by: Alex Deucher The new indentation looks wrong on patches 6 and 7. Alex >

Re: [PATCH 7/7] drm/amd/powerplay: Tidy up cz_dpm_powerup_vce()

On 16/10/17 02:23 PM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Monday, October 16, 2017 1:55 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH 7/7] drm/amd/powerplay: Tidy

RE: [PATCH 7/7] drm/amd/powerplay: Tidy up cz_dpm_powerup_vce()

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Monday, October 16, 2017 1:55 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 7/7] drm/amd/powerplay: Tidy up cz_dpm_powerup_vce() > >

RE: [PATCH 6/7] drm/amd/powerplay: Tidy up cz_dpm_powerdown_vce()

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Monday, October 16, 2017 1:55 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 6/7] drm/amd/powerplay: Tidy up > cz_dpm_powerdown_vce() > >

[PATCH 3/7] drm/amd/powerplay: Tidy up cz_dpm_powerup_uvd()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c index

[PATCH 4/7] drm/amd/powerplay: Tidy up cz_dpm_update_uvd_dpm()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c index

[PATCH 7/7] drm/amd/powerplay: Tidy up cz_dpm_powerup_vce()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c index

Simple cleanups for cz_hwmgr.c

Small set of simple cleanups with no functional changes. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 5/7] drm/amd/powerplay: Tidy up cz_dpm_update_vce_dpm()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c index

[PATCH 1/7] drm/amd/powerplay: Tidy up cz_start_dpm()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c index

RE: [PATCH 1/2] drm/amdgpu: linear validate first then bind to GART

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Monday, October 16, 2017 5:27 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/2] drm/amdgpu: linear validate first then bind to GART > > From: Christian

Re: amdgpu: DRI3 with EGL?

Hey Michel, Michel Dänzer wrote on 16.10.2017 18:05: > On 16/10/17 05:53 PM, Kai Wasserbäch wrote: >> [Please CC me on all replies, I'm not subscribed to amd-gfx.] >> >> Hey, >> I'm not sure whether this is a bug or if I'm just missing something. I've got >> the following stack (Debian testing as

Re: amdgpu: DRI3 with EGL?

On 16/10/17 05:53 PM, Kai Wasserbäch wrote: > [Please CC me on all replies, I'm not subscribed to amd-gfx.] > > Hey, > I'm not sure whether this is a bug or if I'm just missing something. I've got > the following stack (Debian testing as a base): > GPU: Hawaii PRO [Radeon R9 290] (ChipID =

amdgpu: DRI3 with EGL?

[Please CC me on all replies, I'm not subscribed to amd-gfx.] Hey, I'm not sure whether this is a bug or if I'm just missing something. I've got the following stack (Debian testing as a base): GPU: Hawaii PRO [Radeon R9 290] (ChipID = 0x67b1) Mesa: Git:master/c7a81dcea9 libdrm: 2.4.84-2 LLVM:

Re: [PATCH] drm/amdgpu: use ARRAY_SIZE

On Mon, Oct 16, 2017 at 3:48 AM, Christian König wrote: > Am 16.10.2017 um 04:29 schrieb Jérémy Lefaure: >> >> Using the ARRAY_SIZE macro improves the readability of the code. >> >> Found with Coccinelle with the following semantic patch: >> @r depends on (org ||

Re: [PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address

On Mon, Oct 16, 2017 at 5:09 AM, Evan Quan wrote: > Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 > Signed-off-by: Evan Quan Please provide a more detailed commit message. Seems like we should look at converting the psp to use the common ring

Re: [PATCH v2] drm/amd/display: Fix warning about overflow

On 2017-10-16 04:56 AM, Michel Dänzer wrote: > On 13/10/17 09:02 PM, Harry Wentland wrote: >> v2: convert value to bool using !! >> >> Signed-off-by: Harry Wentland >> --- >> drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 +- >> 1 file changed, 5

Re: [PATCH 2/6] drm/amd/display: Use new DRM API where possible

On 2017-10-13 08:39 AM, William Lewis wrote: On 10/12/2017 04:15 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" To conform to DRM's new API, we should not be accessing a DRM object's internal state directly. Rather, the DRM for_each_old/new_* iterators, and

[PATCH] drm/amdgpu: use ARRAY_SIZE

Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Reviewed-by: Thierry

[PATCH v4] drm/amd/powerplay: Remove unnecessary cast on void pointer

Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- Changes in v4: -Removed git diff warning "No newline at end of file" Changes in

[PATCH umr] remove --vram-* commands finally

Signed-off-by: Tom St Denis --- src/app/main.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/src/app/main.c b/src/app/main.c index 0a44c4399bb8..a05fd7f475fa 100644 --- a/src/app/main.c +++ b/src/app/main.c @@ -382,17 +382,7 @@

Re: [PATCH 2/2] drm/amdgpu: allow GTT overcommit during bind

Am 16.10.2017 um 11:42 schrieb Chunming Zhou: On 2017年10月16日 17:26, Christian König wrote: From: Christian König While binding BOs to GART we need to allow a bit overcommit in the GTT domain. If allowing overcommit, will the new node not over the GART mc range?

RE: [PATCH 4/4] drm/amdgpu: busywait KIQ register accessing

alright, go for unify scheme then, use busy wait for all user. -Original Message- From: Ding, Pixel Sent: 2017年10月16日 16:55 To: Liu, Monk Cc: Li, Bingley ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amdgpu: busywait KIQ register

Re: [PATCH 2/2] drm/amdgpu: allow GTT overcommit during bind

On 2017年10月16日 17:26, Christian König wrote: From: Christian König While binding BOs to GART we need to allow a bit overcommit in the GTT domain. If allowing overcommit, will the new node not over the GART mc range? Which is also allowed? Regards, David Zhou

[PATCH 2/2] drm/amdgpu: allow GTT overcommit during bind

From: Christian König While binding BOs to GART we need to allow a bit overcommit in the GTT domain. Otherwise we can never use the full GART space when GART size=GTT size. Signed-off-by: Christian König ---

[PATCH 1/2] drm/amdgpu: linear validate first then bind to GART

From: Christian König For VM emulation for old UVD/VCE we need to validate the BO with linear VRAM flag set first and then eventually bind it to GART. Validating with linear VRAM flag set can move the BO to GART making UVD/VCE read/write from an unbound GART BO.

[PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address

Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 31 --- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 31 --- 2 files changed, 40 insertions(+), 22

Re: [PATCH v2] drm/amd/display: Fix warning about overflow

On 13/10/17 09:02 PM, Harry Wentland wrote: > v2: convert value to bool using !! > > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH 4/4] drm/amdgpu: busywait KIQ register accessing

Hi Monk, So far I notice that it’s almost impossible to have both methods working together. For example, if the num_fence_mask is 2, and there’re a series of sequence number like “fence seq 1, busy wait seq 2, busy wait seq 3, fence seq 4”. Then if IRQ handler for seq 1 catch the HW seq

Re: [PATCH] drm/amdgpu: use ARRAY_SIZE

Am 16.10.2017 um 04:29 schrieb Jérémy Lefaure: Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) |