From: pding
kgd field is dependent on kgd device_init. Move the assignment
to kfd device_init.
Signed-off-by: pding
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 6 +++---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 8
drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 6
From: pding
Move kfd probe prior to device init. Release exclusive mode
after hw_init if kfd is not enabled.
v2:
- pass pdev param
Signed-off-by: pding
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 5 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 3 ++-
drivers/gpu/drm/amd/amdgpu/amd
Hi Oded,
Please review.
[PATCH 1/2] drm/amdkfd: initialise kgd field inside kfd device_init
As you suggested, move kgd assignment to device_init
[PATCH 2/2] drm/amdgpu: release exclusive mode after hw_init if no
We still need this change because pdev is passed in.
___
Change-Id: I6a268903465004d6e8f65f135734094772b9f614
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 -
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 3 +++
3 files changed, 8 insertions(+), 5 deletions(-)
diff -
Yeah, I'll cleanup them before pushing
-Original Message-
From: Deucher, Alexander
Sent: 2017年10月31日 23:01
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Cc: Liu, Monk
Subject: RE: [PATCH 1/2] drm/amdgpu:add fw-vram-usage for atomfirmware
> -Original Message-
> From: amd-gfx [ma
The thing is triggering gpu_recover() in irq routine give you NULL for the
@bad/job parameter, so gpu_recover() actually did nothing meaningful, it just
repeat scheduling un-signaled jobs again and again, and finally your GPU is
stuck with infinite recovering
here is my initial thought:
In
Reviewed-by: Rex Zhu
Best Regards
Rex
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Eric
Huang
Sent: Wednesday, November 01, 2017 5:40 AM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, JinHuiEric
Subject: [PATCH] drm/amd/powerplay: fix memory
I’m not for sure about this case you talked about. Assume that it could happen
and the KFD probe and init are invoked when loading it manually.
For baremetal device, it’s always correct.
For SRIOV virtual function, it doesn’t behave correctly with or without this
patch. KFD initialization also n
Signed-off-by: Eric Huang
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index d4ff742..9d3bdad 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_p
On Mon, Oct 30, 2017 at 6:56 AM, Roman Kapl wrote:
> The function for byteswapping the data send to/from atombios was buggy for
> num_bytes not divisible by four. The function must be aware of the fact
> that after byte-swapping the u32 units, valid bytes might end up after the
> num_bytes boundar
From: "Leo (Sunpeng) Li"
Now that the registers exist, assign them to the resource_straps struct.
v2: Fix indentation
Signed-off-by: Leo (Sunpeng) Li
---
.../gpu/drm/amd/display/dc/dce120/dce120_resource.c| 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --gi
On 2017-10-31 04:28 PM, sunpeng...@amd.com wrote:
> From: "Leo (Sunpeng) Li"
>
> Now that the registers exist, assign them to the resource_straps struct.
>
> Signed-off-by: Leo (Sunpeng) Li
> ---
> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 15 +--
> 1 file changed,
From: "Leo (Sunpeng) Li"
Now that the registers exist, assign them to the resource_straps struct.
Signed-off-by: Leo (Sunpeng) Li
---
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/
From: "Leo (Sunpeng) Li"
We need them for initializing audio properly.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Harry Wentland
Acked-by: Alex Deucher
---
drivers/gpu/drm/amd/include/asic_reg/vega10/DC/dce_12_0_offset.h | 4
drivers/gpu/drm/amd/include/asic_reg/vega10/DC/dce_12_0_sh
From: "Leo (Sunpeng) Li"
This series properly enables audio on DCE12 by adding the relevant registers,
and reading them into the software structs.
Previously, this was only working because the registers were being ignored.
Now that they're being considered, HDMI audio on DCE12 stopped working du
On 25/10/17 05:43 PM, Michel Dänzer wrote:
>
> KASAN caught another use-after-free on my development machine today, see
> the attached dmesg excerpt. There haven't been any related changes in
> amd-staging-drm-next since yesterday, so maybe userspace is just
> tickling the kernel differently (e.g.
I addressed the feedback and pushed the patch.
Marek
On Tue, Oct 31, 2017 at 4:50 PM, Michel Dänzer wrote:
> On 31/10/17 04:40 PM, Andrey Grodzovsky wrote:
>> Signed-off-by: Andrey Grodzovsky
>
> [...]
>
>> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
>> b/src/gallium/winsys/amdgpu/d
On 2017-10-31 11:50 AM, Samuel Pitoiset wrote:
On 10/31/2017 04:40 PM, Andrey Grodzovsky wrote:
Signed-off-by: Andrey Grodzovsky
---
configure.ac | 2 +-
src/gallium/drivers/radeon/r600_pipe_common.c | 1 +
src/gallium/drivers/radeon/r600_pipe_common.h |
On 31/10/17 04:40 PM, Andrey Grodzovsky wrote:
> Signed-off-by: Andrey Grodzovsky
[...]
> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
> b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
> index 8f43e93..1155492 100644
> --- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
> +++ b/src/gallium/wi
On 10/31/2017 04:40 PM, Andrey Grodzovsky wrote:
Signed-off-by: Andrey Grodzovsky
---
configure.ac | 2 +-
src/gallium/drivers/radeon/r600_pipe_common.c | 1 +
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
Signed-off-by: Andrey Grodzovsky
---
configure.ac | 2 +-
src/gallium/drivers/radeon/r600_pipe_common.c | 1 +
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 8
src/gallium/winsys/amdgpu/drm/amdgpu_cs.
On 31/10/17 04:25 PM, Christian König wrote:
> Am 31.10.2017 um 16:14 schrieb Michel Dänzer:
>> On 31/10/17 04:03 PM, Christian König wrote:
>>> Am 31.10.2017 um 09:43 schrieb Michel Dänzer:
On 31/10/17 09:37 AM, Christian König wrote:
> From: Christian König
>
> The bo structure
Am 31.10.2017 um 16:14 schrieb Michel Dänzer:
On 31/10/17 04:03 PM, Christian König wrote:
Am 31.10.2017 um 09:43 schrieb Michel Dänzer:
On 31/10/17 09:37 AM, Christian König wrote:
From: Christian König
The bo structure is freed up in case of an error, so we can't do any
accounting if that
On 31/10/17 04:14 PM, Michel Dänzer wrote:
> On 31/10/17 04:03 PM, Christian König wrote:
>> Am 31.10.2017 um 09:43 schrieb Michel Dänzer:
>>> On 31/10/17 09:37 AM, Christian König wrote:
From: Christian König
The bo structure is freed up in case of an error, so we can't do any
On 31/10/17 04:03 PM, Christian König wrote:
> Am 31.10.2017 um 09:43 schrieb Michel Dänzer:
>> On 31/10/17 09:37 AM, Christian König wrote:
>>> From: Christian König
>>>
>>> The bo structure is freed up in case of an error, so we can't do any
>>> accounting if that happens.
>>>
>>> Signed-off-by:
On 10/30/2017 12:57 AM, Pixel Ding wrote:
> From: pding
>
> Move kfd probe prior to device init. Release exclusive mode
> after hw_init if kfd is not enabled.
>
What happens if only the amdgpu module is loaded at startup, and then the
user manually loads the amdkfd module at some point later on
Am 31.10.2017 um 09:43 schrieb Michel Dänzer:
On 31/10/17 09:37 AM, Christian König wrote:
From: Christian König
The bo structure is freed up in case of an error, so we can't do any
accounting if that happens.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c |
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, October 31, 2017 7:55 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 1/2] drm/amdgpu:add fw-vram-usage for atomfirmware
>
> otherwise PF &
Am 31.10.2017 um 12:55 schrieb Monk Liu:
trigger gpu reset/recovery from illegle instruction IRQ
is deprecated long time ago, we already switch to recover
gpu by TDR triggering.
now please set lockup_timeout to non-zero value
in driver loading to enable TDR.
The patch is ok, but NAK to the gener
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
libdrm 2.4.87 has been released.
Marek Olšák (2):
amdgpu: fix 32-bit build
configure.ac: bump version for release
git tag: libdrm-2.4.87
https://dri.freedesktop.org/libdrm/libdrm-2.4.87.tar.bz2
MD5: b4f9063838559d08649d45fec2d1184a lib
Am 31.10.2017 um 11:44 schrieb Oded Gabbay:
Don't have any strong objection, but I just want to ask if current
users can just move to using amdgpu on KV and their current usermode
stack will work as usual.
Yes, I think so.
btw, are there any "current users" that you are aware of ?
Not the s
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
libdrm 2.4.86 has been released.
Andrey Grodzovsky (2):
amdgpu: Add wrappers for AMDGPU_VM IOCTL.
amdgpu: Add VMID reservation per GPU context test.
Dave Airlie (2):
drm: sync drm headers from drm-next.
drm/syncobj: fix some
trigger gpu reset/recovery from illegle instruction IRQ
is deprecated long time ago, we already switch to recover
gpu by TDR triggering.
now please set lockup_timeout to non-zero value
in driver loading to enable TDR.
Change-Id: I45a576a97fd9859e1098e785ce857c2cf5adfba5
Signed-off-by: Monk Liu
-
otherwise PF & VF exchange is broken
Change-Id: Icbb44e640ba1c6e61914cbd234e92de001496195
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 26
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_a
>@@ -450,7 +450,7 @@ static int xgpu_vi_send_access_requests(struct
>amdgpu_device *adev,
> pr_err("Doesn't get ack from pf, continue\n");
Why don't return error in this place?
> }
>
>- return 0;
>+ return r;
>}
static int xgpu_vi_request_reset(struct a
Don't have any strong objection, but I just want to ask if current
users can just move to using amdgpu on KV and their current usermode
stack will work as usual.
btw, are there any "current users" that you are aware of ?
On Mon, Oct 30, 2017 at 3:16 PM, Christian König
wrote:
> From: Christian K
I sent you an answer in the other email thread
On Tue, Oct 31, 2017 at 9:06 AM, Ding, Pixel wrote:
> Hi Oded,
>
> Would you please help reviewing the V2 patch?
>
> —
> Sincerely Yours,
> Pixel
>
>
>
>
>
>
>
>
> On 31/10/2017, 9:47 AM, "Pixel Ding" wrote:
>
>>From: pding
>>
>>Move kfd probe prio
I would pass only pdev to kgd2kfd_probe, instead of adev.
Then, I would initialize adev inside kgd2kfd_device_init
That way, you can call kgd2kfd_probe before device_init of amdgpu and
you can know if amdkfd is supposed to handle this device.
Does that make sense ?
On Mon, Oct 30, 2017 at 11:13 AM
Reviewed-By: Xiangliang Yu
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Pixel
Ding
Sent: Tuesday, October 31, 2017 4:17 PM
To: amd-gfx@lists.freedesktop.org; Yu, Xiangliang
Cc: Ding, Pixel
Subject: [PATCH 1/2] drm/amdgpu: return error wh
RB-by: Xiangliang Yu
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Pixel
Ding
Sent: Tuesday, October 31, 2017 3:11 PM
To: amd-gfx@lists.freedesktop.org
Cc: Ding, Pixel
Subject: [PATCH 2/2] drm/amdgpu: retry init if exclusive mode request i
On 2017年10月31日 16:55, Christian König wrote:
Am 31.10.2017 um 09:51 schrieb Chunming Zhou:
On 2017年10月31日 16:43, Christian König wrote:
The amdgpu issue to also need signaled fences in the reservation
objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet f
Am 31.10.2017 um 09:51 schrieb Chunming Zhou:
On 2017年10月31日 16:43, Christian König wrote:
The amdgpu issue to also need signaled fences in the reservation objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet fences around.
v2: temporary put the signaled fen
On 2017年10月31日 16:43, Christian König wrote:
The amdgpu issue to also need signaled fences in the reservation objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet fences around.
v2: temporary put the signaled fences at the end of the new container
Signed-off
On 31/10/17 09:42 AM, Christian König wrote:
> Looks like v2 never made it to the list. I've just send the V2 patches
> once more.
FWIW, I received your v2 patches yesterday, and now twice today.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusia
On 31/10/17 09:37 AM, Christian König wrote:
> From: Christian König
>
> The bo structure is freed up in case of an error, so we can't do any
> accounting if that happens.
>
> Signed-off-by: Christian König
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +++---
> 1 file changed, 3 inse
The amdgpu issue to also need signaled fences in the reservation objects should
be fixed by now.
Optimize the handling by replacing a signaled fence when adding a new
shared one.
Signed-off-by: Christian König
---
drivers/dma-buf/reservation.c | 18 +++---
1 file changed, 15 inserti
The amdgpu issue to also need signaled fences in the reservation objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet fences around.
v2: temporary put the signaled fences at the end of the new container
Signed-off-by: Christian König
---
drivers/dma-buf/reserv
Looks like v2 never made it to the list. I've just send the V2 patches
once more.
Christian.
Am 31.10.2017 um 08:26 schrieb Chunming Zhou:
Any update?
On 2017年10月25日 15:28, Christian König wrote:
Am 25.10.2017 um 08:42 schrieb Chunming Zhou:
On 2017年10月24日 21:55, Christian König wrote:
From: Christian König
The amdgpu issue to also need signaled fences in the reservation objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet fences around.
v2: temporary put the signaled fences at the end of the new container
Signed-off-by: Christian König
---
From: Christian König
The amdgpu issue to also need signaled fences in the reservation objects should
be fixed by now.
Optimize the handling by replacing a signaled fence when adding a new
shared one.
Signed-off-by: Christian König
---
drivers/dma-buf/reservation.c | 18 +++---
1
From: Christian König
The bo structure is freed up in case of an error, so we can't do any
accounting if that happens.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amd
hi,all:
Now if the GPU hypervisor driver supporting amdgpu SRIOV ? which patch?
which kernel version ?
maok...@126.com
From: Yu, Xiangliang
Date: 2017-09-15 10:15
To: maok...@126.com; amd-gfx
Subject: RE: Can you tell me which driver supports AMD's sriov?
Need GPU hypervisor driver if
From: pding
v2:
- readable
Reported-by: Sun Gary
Signed-off-by: pding
---
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
index 818ec0f..2b435c0 1006
Any update?
On 2017年10月25日 15:28, Christian König wrote:
Am 25.10.2017 um 08:42 schrieb Chunming Zhou:
On 2017年10月24日 21:55, Christian König wrote:
From: Christian König
The amdgpu issue to also need signaled fences in the reservation
objects
should be fixed by now.
Optimize the list b
From: pding
This is caused of that hypervisor fails to handle request, one known
issue is MMIO unblocking timeout. In theory we can retry init here.
Signed-off-by: pding
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/g
From: pding
Reported-by: Sun Gary
Signed-off-by: pding
---
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
index 818ec0f..f291fb2 100644
--- a/drivers/gpu/dr
Hi Oded,
Would you please help reviewing the V2 patch?
—
Sincerely Yours,
Pixel
On 31/10/2017, 9:47 AM, "Pixel Ding" wrote:
>From: pding
>
>Move kfd probe prior to device init. Release exclusive mode
>after hw_init if kfd is not enabled.
>
>v2:
> - pass pdev param
>
>Signed-off-by: pd
57 matches
Mail list logo
