RE: [PATCH] drm/amdgpu: correct vce4.0 fw config for SRIOV (V2)

Hi Christian, I have talked with hw team for the reason why adding the masks. the answer is "bits 24-27 of the VCE_VCPU_CACHE_OFFSETx registers should be set to the cache window # (0 for window 0, 1 for window 1, etc.)" Best Regards, Frank -邮件原件- 发件人: Min, Frank 发送时间: 2017年11月23日

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

-Original Message- From: Koenig, Christian Sent: Tuesday, November 28, 2017 6:01 PM To: He, Roger ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only Am 28.11.2017 um 10:40 schrieb Roger He: >

[PATCH 1/1] drm/amdgpu: Pin to gtt before cpu accesses dma buf.

To improve cpu read performance. This is implemented for APUs currently. Change-Id: I300a7daed8f2b0ba6be71a43196a6b8617ddc62e --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

Re: Fixes for 4.15-rc1

On 2017 Nov 28, Harry Wentland wrote: > Hi Alex, > > I cherry-picked a bunch of fixes for 4.15. These can be found at > hwentlan/4.15-rc1-fixes. > > Of the changes the highlighted ones (with *) in particular are highly > recommended, but even the other ones are probably good to have. > > *

Re: [PATCH v2 2/2] drm/amd/display: Don't call dm_log_to_buffer directly in dc_conn_log

On Tue, Nov 28, 2017 at 6:09 AM, Michel Dänzer wrote: > > Ping on this series. > > This patch is v2 of a previously single patch, which was reviewed by Harry. > > Series is: Reviewed-by: Alex Deucher > On 2017-11-23 06:48 PM, Michel Dänzer wrote:

Fixes for 4.15-rc1

Hi Alex, I cherry-picked a bunch of fixes for 4.15. These can be found at hwentlan/4.15-rc1-fixes. Of the changes the highlighted ones (with *) in particular are highly recommended, but even the other ones are probably good to have. 1086abf3e8ab drm/amd/display: USB-C / thunderbolt dock

[PATCH umr] Add more detail and colour to the ring decoder

Now you can use '-O use_colour' to spruce up the ring/ib decoder. You can previously use '-O bits' to decode register writes which has also been cleaned up. Assumes a wide display which for a graphics company is probably safe to assume you're not on an 80x25 MDA display. Signed-off-by: Tom St

Re: [Xen-devel] [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

>>> On 28.11.17 at 10:12, wrote: > In theory the BIOS would search for address space and won't find > anything, so the hotplug operation should fail even before it reaches > the kernel in the first place. How would the BIOS know what the OS does or plans to do? I

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

On Tue, Nov 28, 2017 at 12:30:30PM +, Sudip Mukherjee wrote: > On Tue, Nov 28, 2017 at 12:32:38PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 11:22:17AM +0100, Daniel Vetter wrote: > > > On Mon, Nov 27, 2017 at 08:52:19PM +, Sudip Mukherjee wrote: > > > > On Mon, Nov 27, 2017 at

Re: [Xen-devel] [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

>>> On 28.11.17 at 11:17, wrote: > Am 28.11.2017 um 10:46 schrieb Jan Beulich: > On 28.11.17 at 10:12, wrote: >>> In theory the BIOS would search for address space and won't find >>> anything, so the hotplug operation should fail even

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

On Tue, Nov 28, 2017 at 11:22:17AM +0100, Daniel Vetter wrote: > On Mon, Nov 27, 2017 at 08:52:19PM +, Sudip Mukherjee wrote: > > On Mon, Nov 27, 2017 at 11:27:59AM +0100, Daniel Vetter wrote: > > > On Fri, Nov 24, 2017 at 06:53:31PM +0100, Michał Mirosław wrote: > > > > Almost all drivers

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

On Tue, Nov 28, 2017 at 12:32:38PM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 11:22:17AM +0100, Daniel Vetter wrote: > > On Mon, Nov 27, 2017 at 08:52:19PM +, Sudip Mukherjee wrote: > > > On Mon, Nov 27, 2017 at 11:27:59AM +0100, Daniel Vetter wrote: > > > > On Fri, Nov 24, 2017 at

Re: [amdgpu] script to generate a VCE 1.0 amdgpu compatible firmware

Am 28.11.2017 um 17:34 schrieb Alexandre Demers: On 2017-11-23 00:53, Alexandre Demers wrote: Hi, I just want to let you know that I'm still alive and still committed to porting VCE 1.0 from radeon to amdgpu. However, for many reasons, I've been pretty much unable to work on the code since my

Re: [amdgpu] script to generate a VCE 1.0 amdgpu compatible firmware

On 2017-11-23 00:53, Alexandre Demers wrote: > Hi, > > I just want to let you know that I'm still alive and still committed to > porting VCE 1.0 from radeon to amdgpu. However, for many reasons, I've > been pretty much unable to work on the code since my last communication. > > That being said,

Re: [PATCH] drm/amd/display: Print type if we get wrong ObjectID from bios

On 11/27/2017 05:23 PM, Shawn Starr wrote: Hi Harry, here's dmesg from kernel with dc=1 with patch applied, this is against Linus's 4.15-rc1 git tag. Thanks, Shawn. Hi Harry, Here some background from an issue I encountered last summer: These two patches were used

[PATCH libdrm] amdgpu: Add explicit dependency test.

The test is as following: 1) Create context A & B 2) Send a command submission using context A which fires up a compute shader. 3) The shader wait a bit and then write a value to a memory location. 4) Send a command submission using context B which writes another value to the same memory

Re: [bug report] drm/amd/amdgpu: Add debugfs support for reading GPRs (v2)

On 28/11/17 09:29 AM, Dan Carpenter wrote: Hello Tom St Denis, The patch c5a60ce81b49: "drm/amd/amdgpu: Add debugfs support for reading GPRs (v2)" from Dec 5, 2016, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3774 amdgpu_debugfs_gpr_read()

Re: [PATCH libdrm] [drm] - Adding amdgpu_cs_create_syncobj2 to create syncobj as signaled initially

You need a freedesktop.org account: https://www.freedesktop.org/wiki/AccountRequests/ Marek On Tue, Nov 28, 2017 at 2:32 PM, Mao, David wrote: > I have never tried to commit the change before. So I guess the answer is no. > Could you let me know, how I can apply for the

Re: [PATCH] drm/amd/display: Fix potential NULL pointer dereferences in amdgpu_dm_atomic_commit_tail

Reviewed-by: Andrey Grodzovsky Thanks, Andrey On 11/27/2017 09:57 AM, Gustavo A. R. Silva wrote: dm_new_crtc_state->stream and disconnected_acrtc are being dereferenced before they are null checked, hence there is a potential null pointer dereference. Fix this by

[bug report] drm/amd/amdgpu: Add debugfs support for reading GPRs (v2)

Hello Tom St Denis, The patch c5a60ce81b49: "drm/amd/amdgpu: Add debugfs support for reading GPRs (v2)" from Dec 5, 2016, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3774 amdgpu_debugfs_gpr_read() error: buffer overflow 'data' 1024

RE: [PATCH libdrm] [drm] - Adding amdgpu_cs_create_syncobj2 to create syncobj as signaled initially

I have never tried to commit the change before. So I guess the answer is no. Could you let me know, how I can apply for the commit right? Thanks. Best Regards, David -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Tuesday, November 28, 2017

Re: [PATCH libdrm] [drm] - Adding amdgpu_cs_create_syncobj2 to create syncobj as signaled initially

Reviewed-by: Christian König But in general for libdrm changes I would ping Marek, Nicolai, Michel and in this special case Dave Airlie because he added the patch with the missing flags field. And I strongly assume you don't have commit rights, don't you? Regards,

RE: [PATCH libdrm] [drm] - Adding amdgpu_cs_create_syncobj2 to create syncobj as signaled initially

Anyone can help to review the change? Thanks. Best Regards, David -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of David Mao Sent: Tuesday, November 28, 2017 11:26 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH libdrm] [drm] - Adding

Re: [PATCH libdrm 1/2] amdgpu: Switch amdgpu CS tests enabling to new API.

Am 27.11.2017 um 13:31 schrieb Andrey Grodzovsky: Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- tests/amdgpu/amdgpu_test.c | 2 +- tests/amdgpu/amdgpu_test.h | 5 tests/amdgpu/cs_tests.c| 64

Re: [Xen-devel] [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

Am 28.11.2017 um 11:53 schrieb Jan Beulich: On 28.11.17 at 11:17, wrote: Am 28.11.2017 um 10:46 schrieb Jan Beulich: On 28.11.17 at 10:12, wrote: In theory the BIOS would search for address space and won't find anything, so the hotplug

Re: [PATCH v2 2/2] drm/amd/display: Don't call dm_log_to_buffer directly in dc_conn_log

Ping on this series. This patch is v2 of a previously single patch, which was reviewed by Harry. On 2017-11-23 06:48 PM, Michel Dänzer wrote: > From: Michel Dänzer > > dm_log_to_buffer logs unconditionally, so calling it directly resulted > in the main message being

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

On Mon, Nov 27, 2017 at 08:52:19PM +, Sudip Mukherjee wrote: > On Mon, Nov 27, 2017 at 11:27:59AM +0100, Daniel Vetter wrote: > > On Fri, Nov 24, 2017 at 06:53:31PM +0100, Michał Mirosław wrote: > > > Almost all drivers using remove_conflicting_framebuffers() wrap it with > > > the same code.

Re: [Xen-devel] [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

Am 28.11.2017 um 10:46 schrieb Jan Beulich: On 28.11.17 at 10:12, wrote: In theory the BIOS would search for address space and won't find anything, so the hotplug operation should fail even before it reaches the kernel in the first place. How would the BIOS know what

Re: [PATCH 1/7] drm/amdgpu: fix VM PD addr shift

Am 28.11.2017 um 03:42 schrieb Chunming Zhou: On 2017年11月28日 00:02, Christian König wrote: The block size only affects the leave nodes, everything else is fixed. This is not true, block size affects every level entries, see the register explains for VM_CONTEXTx_CNTL.PAGE_TABLE_BLOCK_SIZE:

Re: [PATCH 10/14] drm/amdkfd: Use ref count to prevent kfd_process destruction

Am 28.11.2017 um 00:29 schrieb Felix Kuehling: Use a reference counter instead of a lock to prevent process destruction while functions running out of process context are using the kfd_process structure. In many cases these functions don't need the structure to be locked. In the few cases that

[PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

Change-Id: Ib634375b90d875fe04a890fc82fb1e3b7112676a Signed-off-by: Roger He --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

Re: [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

Am 27.11.2017 um 19:30 schrieb Boris Ostrovsky: On 11/23/2017 09:12 AM, Boris Ostrovsky wrote: On 11/23/2017 03:11 AM, Christian König wrote: Am 22.11.2017 um 18:27 schrieb Boris Ostrovsky: On 11/22/2017 11:54 AM, Christian König wrote: Am 22.11.2017 um 17:24 schrieb Boris Ostrovsky: On