Looks good, Acked-by: Chunming Zhou
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Emily
Deng
Sent: Thursday, May 17, 2018 11:05 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deng, Emily
Subject: [PATCH]
To free the fence from the amdgpu_fence_slab, need twice call_rcu, to avoid
the amdgpu_fence_slab_fini call kmem_cache_destroy(amdgpu_fence_slab) before
kmem_cache_free(amdgpu_fence_slab, fence), add rcu_barrier after
drm_sched_entity_fini.
The kmem_cache_free(amdgpu_fence_slab, fence)'s call
Yes, every thing is clear, Acked-by: Chunming Zhou
On 2018年05月16日 23:33, Andrey Grodzovsky wrote:
This spinlock is superfluous, any call to drm_sched_entity_push_job
should already be under a lock together with matching drm_sched_job_init
to match the order of insertion
On 2018-05-16 10:12 AM, Alex Deucher wrote:
> Leftover from bringup. No need to keep it around for
> upstream.
>
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/Kconfig
On 2018-05-16 04:37 PM, Alex Deucher wrote:
> - Remove unused ASICREV_IS_VEGA12_p() macro
> - Fix ASICREV_IS_VEGA12_P() macro to properly check against vega20
>
> Signed-off-by: Alex Deucher
Both patches are
Reviewed-by: Harry Wentland
Harry
Hi Oded,
Thanks for working on this! The Makefile changes look good.
Instead of checking and calling function pointers in amdgpu_amdkfd_...
functions at runtime, couldn't you just define empty stub functions in
amdgpu_amdkfd.h if KFD is not enabled? I think that would make the code
shorter and
Needed for proper memory setup depending on whether ECC is
enabled on a particular board.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/df_v1_7.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/df_v1_7.c
The ForceParWrRMW setting needs to be enabled for ECC, but disabled
when ECC is not enabled.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
The vbios mistakenly sets this bit on some boards without ECC.
This can lead to reduced performance in some workloads. Disable
the bit if the board does not have ECC.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 +
1 file changed, 1
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/include/asic_reg/df/df_1_7_offset.h | 4
drivers/gpu/drm/amd/include/asic_reg/df/df_1_7_sh_mask.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/amd/include/asic_reg/df/df_1_7_offset.h
Leftover from bringup. No need to keep it around for
upstream.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/Kconfig| 8 -
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 -
drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c|
- Remove unused ASICREV_IS_VEGA12_p() macro
- Fix ASICREV_IS_VEGA12_P() macro to properly check against vega20
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/include/dal_asic_id.h | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
On 2018-05-14 09:17 AM, Alex Deucher wrote:
> On Mon, May 14, 2018 at 4:06 AM, Rex Zhu wrote:
>> Screen flickering observed while running 1080p video using
>> MPV_VAAPI/VDPAU with 4x4K@60 monitors
>>
>> Need to set higher mclk in this configuration.
>>
>> Signed-off-by: Rex Zhu
On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote:
> From: "Leo (Sunpeng) Li"
>
> This will persist color management properties on a CRTC across DPMS
> state changes.
>
> Signed-off-by: Leo (Sunpeng) Li
> ---
> src/drmmode_display.c | 6 ++
> 1 file
On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote:
> From: "Leo (Sunpeng) Li"
>
> The dpms_mode flag on the driver-private CRTC was not being set when
> it's DPMS state is set to off. This causes some problems when toggling
> it back on, as some conditionals check this flag.
>
On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote:
> From: "Leo (Sunpeng) Li"
>
> The properties on an RandR output needs to stay consistent throughout
> it's lifecycle. However, we cannot list color properties on an output if
> there is no CRTC attached.
>
> Therefore,
On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote:
> From: "Leo (Sunpeng) Li"
>
> Push staged values on the driver-private CRTC, to kernel DRM when it's
> initialized. This is to flush out any previous state that hardware was
> in, and set them to their default values.
>
>
On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote:
> From: "Leo (Sunpeng) Li"
>
> Non-legacy color management consists of 3 properties on the CRTC:
> Degamma LUT, Color Transformation Matrix (CTM), and Gamma LUT.
>
> Add these properties to the driver-private CRTC, and
On 2018-05-03 08:31 PM, sunpeng...@amd.com wrote:
>
> 3. The three color management properties (Degamma LUT, Color Transform Matrix
>(CTM), and Gamma LUT) are hard-coded into the DDX driver, to be listed (as
>disabled) regardless of whether a CRTC is attached on the output, or
> whether
On Wed, May 16, 2018 at 8:52 AM, Rex Zhu wrote:
> Signed-off-by: Rex Zhu
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/include/amd_shared.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
On Wed, May 16, 2018 at 8:52 AM, Rex Zhu wrote:
> Signed-off-by: Rex Zhu
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 25
> ++-
> 1 file changed, 24 insertions(+), 1
On Wed, May 16, 2018 at 8:52 AM, Rex Zhu wrote:
> Signed-off-by: Rex Zhu
Please add a patch description. E.g., something like:
VCN clockgating is handled manually like VCE and UVD.
With that fixed:
Reviewed-by: Alex Deucher
> ---
>
On Wed, May 16, 2018 at 8:53 AM, Rex Zhu wrote:
> Signed-off-by: Rex Zhu
Please add a better patch description. E.g.,
drm/amdgpu: Add runtime vcn cg/pg enablement
Enable support for dynamically powering up/down VCN on demand.
Signed-off-by: Rex Zhu
On Wed, May 16, 2018 at 8:53 AM, Rex Zhu wrote:
> Signed-off-by: Rex Zhu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 11 ++
> drivers/gpu/drm/amd/amdgpu/soc15.c | 3 +-
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 183
>
On Wed, May 16, 2018 at 8:53 AM, Rex Zhu wrote:
> Signed-off-by: Rex Zhu
> ---
> drivers/gpu/drm/amd/amdgpu/soc15.c| 3 ++-
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 16
> 2 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git
On Wed, May 16, 2018 at 10:51 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Shorter and sweeter. :)
>
> Signed-off-by: Michel Dänzer
Reviewed-by: Alex Deucher
> ---
> src/amdgpu_bo_helper.c
This spinlock is superfluous, any call to drm_sched_entity_push_job
should already be under a lock together with matching drm_sched_job_init
to match the order of insertion into queue with job's fence seqence
number.
v2:
Improve patch description.
Add functions documentation describing the
From: Michel Dänzer
Shorter and sweeter. :)
Signed-off-by: Michel Dänzer
---
src/amdgpu_bo_helper.c | 10 --
src/amdgpu_dri2.c| 10 +-
src/amdgpu_glamor.c | 2 +-
src/amdgpu_glamor_wrappers.c | 2 +-
On 05/16/2018 09:16 AM, Lucas Stach wrote:
Am Mittwoch, den 16.05.2018, 15:10 +0200 schrieb Christian König:
Am 16.05.2018 um 15:00 schrieb Lucas Stach:
Am Mittwoch, den 16.05.2018, 14:32 +0200 schrieb Christian König:
Am 16.05.2018 um 14:28 schrieb Lucas Stach:
Am Mittwoch, den
On 2018-05-16 04:12 PM, Alex Deucher wrote:
> Leftover from bringup. No need to keep it around for
> upstream.
>
> Signed-off-by: Alex Deucher
Nice, thanks.
Reviewed-by: Michel Dänzer
--
Earthling Michel Dänzer |
Leftover from bringup. No need to keep it around for
upstream.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/Kconfig | 7 ---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4
Am Mittwoch, den 16.05.2018, 15:10 +0200 schrieb Christian König:
> Am 16.05.2018 um 15:00 schrieb Lucas Stach:
> > Am Mittwoch, den 16.05.2018, 14:32 +0200 schrieb Christian König:
> > > Am 16.05.2018 um 14:28 schrieb Lucas Stach:
> > > > Am Mittwoch, den 16.05.2018, 14:08 +0200 schrieb Christian
Am 16.05.2018 um 15:00 schrieb Lucas Stach:
Am Mittwoch, den 16.05.2018, 14:32 +0200 schrieb Christian König:
Am 16.05.2018 um 14:28 schrieb Lucas Stach:
Am Mittwoch, den 16.05.2018, 14:08 +0200 schrieb Christian König:
Yes, exactly.
For normal user space command submission we should have
Signed-off-by: Tom St Denis
---
scripts/soc15_asic.sh | 3 +-
src/lib/asic/CMakeLists.txt | 1 +
src/lib/asic/vega20.c | 51
src/lib/asic/vega20.i | 189
src/lib/discover_by_did.c | 6 ++
Am Mittwoch, den 16.05.2018, 14:32 +0200 schrieb Christian König:
> Am 16.05.2018 um 14:28 schrieb Lucas Stach:
> > Am Mittwoch, den 16.05.2018, 14:08 +0200 schrieb Christian König:
> > > Yes, exactly.
> > >
> > > For normal user space command submission we should have tons of
> > > locks
> > >
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 11 ++
drivers/gpu/drm/amd/amdgpu/soc15.c | 3 +-
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 183 ++--
3 files changed, 187 insertions(+), 10 deletions(-)
diff --git
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
index 58e4953..8b0d491 100644
---
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/include/amd_shared.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/include/amd_shared.h
b/drivers/gpu/drm/amd/include/amd_shared.h
index 33de330..b178176 100644
---
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/soc15.c| 3 ++-
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 16
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
b/drivers/gpu/drm/amd/amdgpu/soc15.c
index
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 25 ++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
index
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index fcd4bb2..25bee46 100644
---
Am 16.05.2018 um 14:28 schrieb Lucas Stach:
Am Mittwoch, den 16.05.2018, 14:08 +0200 schrieb Christian König:
Yes, exactly.
For normal user space command submission we should have tons of
locks
guaranteeing that (e.g. just the VM lock should do).
For kernel moves we have the mutex for the GTT
Am Mittwoch, den 16.05.2018, 14:08 +0200 schrieb Christian König:
> Yes, exactly.
>
> For normal user space command submission we should have tons of
> locks
> guaranteeing that (e.g. just the VM lock should do).
>
> For kernel moves we have the mutex for the GTT windows which protects
> it.
>
On Wed, May 16, 2018 at 2:11 PM, Grazvydas Ignotas wrote:
> On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote:
>> From: Shaoyun Liu
>>
>> v2: cleanups (Alex)
>> v3: make it vega20 only (Alex)
>>
>> Signed-off-by: Shaoyun Liu
Yes, exactly.
For normal user space command submission we should have tons of locks
guaranteeing that (e.g. just the VM lock should do).
For kernel moves we have the mutex for the GTT windows which protects it.
The could be problems with the UVD/VCE queues to cleanup the handles
when an
So are you saying that you expect this to be already in code for any
usage of drm_sched_fence_create and drm_sched_entity_push_job ?
lock()
drm_sched_fence_create()
... (some code)
drm_sched_entity_push_job()
unlock()
Andrey
On 05/16/2018 07:23 AM, Christian König wrote:
drm_sched_fence_create() assigns a sequence number to the fence it creates.
Now drm_sched_fence_create() is called by drm_sched_job_init() to
initialize the jobs we want to push on the scheduler queue.
When you now call drm_sched_entity_push_job() without a protecting lock
it can happen that
Can you please elaborate more, maybe give an example - I don't
understand yet the problematic scenario.
Andrey
On 05/16/2018 02:50 AM, Christian König wrote:
No, that spinlock is indeed incorrect. I
See even when we protect the spsc queue with a spinlock that doesn't
make it correct. It
On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote:
> From: Shaoyun Liu
>
> v2: cleanups (Alex)
> v3: make it vega20 only (Alex)
>
> Signed-off-by: Shaoyun Liu
> Acked-by: Alex Deucher
> Signed-off-by:
On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote:
> From: Feifei Xu
>
> Signed-off-by: Feifei Xu
> Reviewed-by: Alex Deucher
> Reviewed-by: Hawking Zhang
> Signed-off-by: Alex
On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote:
> From: Roman Li
>
> Updating dce12 register headers by adding dc registers
> required for potential DP LTTPR support.
>
> Signed-off-by: Roman Li
> Acked-by: Alex Deucher
On Wed, May 16, 2018 at 1:08 AM, Felix Kuehling wrote:
> On 2018-05-15 05:41 AM, Dave Airlie wrote:
>>> +static int kgd_hqd_load(struct kgd_dev *kgd, void *mqd, uint32_t pipe_id,
>>> + uint32_t queue_id, uint32_t __user *wptr,
>>> +
Am 15.05.2018 um 21:42 schrieb Alex Deucher:
On Tue, May 15, 2018 at 3:31 PM, Andrey Grodzovsky
wrote:
Follwoing change 75fbed2 we need to skip KIQ ring when iterating
amdgpu_ctx's scheduler entites.
Signed-off-by: Andrey Grodzovsky
Typo
Dear Michel,
Am 15.05.2018 um 10:41 schrieb Michel Dänzer:
On 2018-05-15 08:38 AM, Paul Menzel wrote:
On 2018-05-14 10:44, Michel Dänzer wrote:
On 2018-05-13 11:01 AM, Paul Menzel wrote:
There is a regression introduced by a commit after Linux 4.17-rc4
causing the X.Org X server start to
No, that spinlock is indeed incorrect.
See even when we protect the spsc queue with a spinlock that doesn't
make it correct. It can happen that the jobs pushed to the queue are
reversed in their sequence order and that can cause severe problems in
the memory management.
Christian.
Am
55 matches
Mail list logo