I always confuse any bits definiation about some feature mask. such as
ip_block_mask, pg_mask, cg_mask, pp_feature_mask. I think other people who is
not familiar with amdgpu driver may have the same problem.
So, is it possible to detail every bit mask of features?
Thanks
JimQu
On 07/04/2018 04:06 AM, Sonny Jiang wrote:
Signed-off-by: Sonny Jiang
Acked-by: Junwei Zhang
---
Documentation/gpu/amdgpu.rst| 7 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 222 +++-
2 files changed, 222 insertions(+), 7 deletions(-)
diff
From: Michel Dänzer
Without this, there could not be enough slots, which could trigger the
BUG_ON in reservation_object_add_shared_fence.
v2:
* Jump to the error label instead of returning directly (Jerry Zhang)
v3:
* Reserve slots for command submission after VM updates (Christian König)
Cc:
Signed-off-by: Sonny Jiang
---
Documentation/gpu/amdgpu.rst| 7 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 222 +++-
2 files changed, 222 insertions(+), 7 deletions(-)
diff --git a/Documentation/gpu/amdgpu.rst b/Documentation/gpu/amdgpu.rst
index
On 2018-07-03 06:53 PM, Tom St Denis wrote:
> On 07/03/2018 12:50 PM, Bridgman, John wrote:
>> I have seen a couple of reports that booting Raven desktop parts
>> requires disabling DC, although I'm not sure if that actually makes
>> sense (I didn't think we implemented non-DC display paths for
>>
On 07/03/2018 12:50 PM, Bridgman, John wrote:
I have seen a couple of reports that booting Raven desktop parts
requires disabling DC, although I'm not sure if that actually makes
sense (I didn't think we implemented non-DC display paths for Vega/Raven).
Might be specific to people with a
I have seen a couple of reports that booting Raven desktop parts requires
disabling DC, although I'm not sure if that actually makes sense (I didn't
think we implemented non-DC display paths for Vega/Raven).
Might be specific to people with a dGPU plugged in, I guess ?
On Tue, Jul 3, 2018 at 12:36 PM, Michel Dänzer wrote:
> On 2018-07-03 06:13 PM, Felix Kuehling wrote:
>> On 2018-07-03 10:19 AM, Tom St Denis wrote:
>>> Hi all,
>>>
>>> This block
>>>
>>> #if defined(CONFIG_DRM_AMD_DC)
>>> else if (amdgpu_device_has_dc_support(adev))
>>>
On 2018-07-03 06:13 PM, Felix Kuehling wrote:
> On 2018-07-03 10:19 AM, Tom St Denis wrote:
>> Hi all,
>>
>> This block
>>
>> #if defined(CONFIG_DRM_AMD_DC)
>> else if (amdgpu_device_has_dc_support(adev))
>> amdgpu_device_ip_block_add(adev, _ip_block);
>> #else
>> # warning
On Tue, Jul 3, 2018 at 5:46 AM, Rex Zhu wrote:
> powerplay/dpm export all interfaces in struct amd_pm_funcs.
> so call common exported interfaces instand of powerplay inner interfaces
typo: instand ->instead
With that fixed:
Acked-by: Alex Deucher
>
> Also not include header file hwmgr.h
>
>
On Tue, Jul 3, 2018 at 5:46 AM, Rex Zhu wrote:
> powerplay can notify smu to recalculates the maximum deep-sleep
> divider that display allowed.
>
> Signed-off-by: Rex Zhu
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 13 -
> 1 file
On Tue, Jul 3, 2018 at 5:46 AM, Rex Zhu wrote:
> Set memory clocks same as soc clocks
>
> Signed-off-by: Rex Zhu
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On Tue, Jul 3, 2018 at 5:46 AM, Rex Zhu wrote:
> From: Rex Zhu
>
> Display can notify smu to enable pwe after gpu suspend.
> It is used in case when display resumes from S3 and wants to start
> audio driver by enabling pwe
>
> Signed-off-by: Rex Zhu
Acked-by: Alex Deucher
> ---
>
Hi Felix,
I can (v2) the patch I sent to the list. Ultimately a build warning
alone I think is the wrong approach.
Cheers,
Tom
On 07/03/2018 12:13 PM, Felix Kuehling wrote:
On 2018-07-03 10:19 AM, Tom St Denis wrote:
Hi all,
This block
#if defined(CONFIG_DRM_AMD_DC)
else if
On Mon, Jul 2, 2018 at 5:48 PM, Daniel Kurtz wrote:
> Hi Alex,
>
> On Sun, Apr 15, 2018 at 9:48 PM Agrawal, Akshu wrote:
>>
>>
>>
>> On 4/13/2018 9:45 PM, Daniel Kurtz wrote:
>> > Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for
>> > stoney/cz") added support for the "BT_I2S"
On 2018-07-03 10:19 AM, Tom St Denis wrote:
> Hi all,
>
> This block
>
> #if defined(CONFIG_DRM_AMD_DC)
> else if (amdgpu_device_has_dc_support(adev))
> amdgpu_device_ip_block_add(adev, _ip_block);
> #else
> # warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15."
Hey, if you haven't been following xorg-devel@, we're planning to move
our repository hosting to freedesktop's gitlab instance. This is
basically transparent from the client side, your git urls won't change,
but you get continuous integration hooks for free if you want them.
Longer term, we'd like
Use DRM_WARN instead of preprocessor warning so that pre-built kernels
will warn if DC is disabled on SOC15 ASICs.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
Hi all,
This block
#if defined(CONFIG_DRM_AMD_DC)
else if (amdgpu_device_has_dc_support(adev))
amdgpu_device_ip_block_add(adev, _ip_block);
#else
# warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15."
#endif
in soc15_set_ip_blocks()
Reviewed-by: James Zhu for the series
On 2018-06-25 01:42 PM, Alex Deucher wrote:
Set the me instance in early init and use that rather than
calculating the instance based on the ring pointer.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 12 ++--
powerplay can notify smu to recalculates the maximum deep-sleep
divider that display allowed.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git
From: Rex Zhu
delete the same struct define in powerplay, share the struct
with display.
Acked-by: Alex Deucher
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/include/dm_pp_interface.h | 37 ++-
drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 2 +-
Set memory clocks same as soc clocks
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c
powerplay/dpm export all interfaces in struct amd_pm_funcs.
so call common exported interfaces instand of powerplay inner interfaces
Also not include header file hwmgr.h
Signed-off-by: Rex Zhu
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 80 +++---
1 file changed,
From: Rex Zhu
Display can notify smu to enable pwe after gpu suspend.
It is used in case when display resumes from S3 and wants to start
audio driver by enabling pwe
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/include/kgd_pp_interface.h | 7 ---
On 07/03/2018 04:42 PM, Christian König wrote:
Am 03.07.2018 um 10:12 schrieb Zhang, Jerry (Junwei):
On 07/03/2018 02:58 PM, Christian König wrote:
Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei):
On 07/02/2018 05:23 PM, Christian König wrote:
[SNIP]
The
Am 03.07.2018 um 10:12 schrieb Zhang, Jerry (Junwei):
On 07/03/2018 02:58 PM, Christian König wrote:
Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei):
On 07/02/2018 05:23 PM, Christian König wrote:
[SNIP]
The reservation_object_reserve_shared() function needs to be called
before you make
On 07/03/2018 04:28 PM, Michel Dänzer wrote:
On 2018-07-03 10:12 AM, Zhang, Jerry (Junwei) wrote:
BTW, reservation_object_reserve_shared() will extend the max num as 2
times if it's not enough.
(default value is 4)
That's an implementation detail and depends on the circumstances. The
only
On 2018-07-03 10:12 AM, Zhang, Jerry (Junwei) wrote:
>
> BTW, reservation_object_reserve_shared() will extend the max num as 2
> times if it's not enough.
> (default value is 4)
That's an implementation detail and depends on the circumstances. The
only guarantee is that there's space for at
On 07/03/2018 02:58 PM, Christian König wrote:
Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei):
On 07/02/2018 05:23 PM, Christian König wrote:
Am 25.06.2018 um 11:07 schrieb Michel Dänzer:
From: Michel Dänzer
Without this, there could not be enough slots, which could trigger the
BUG_ON
Sure, bisecting gets me 6e65fb862064663ad3a08f964af1e8f3f2abf688 .
In drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c,
get_firmware_info_v3_1() works but get_firmware_info_v3_2() does not
do the right thing for my Vega.
Could I break my GPU if I were to set some bad/wrong frequency there?
Yeah, not 100% sure if that doesn't result in any problems in practice.
But I agree that this risk of breaking things is minimal and if that
breaks the ones to blame are really our firmware guys because they
created not backward compatible firmware changes.
So this step is really necessary
Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei):
On 07/02/2018 05:23 PM, Christian König wrote:
Am 25.06.2018 um 11:07 schrieb Michel Dänzer:
From: Michel Dänzer
Without this, there could not be enough slots, which could trigger the
BUG_ON in reservation_object_add_shared_fence.
v2:
*
33 matches
Mail list logo
