Re: [PATCH v3 2/2] drm/admgpu: Present amdgpu_task_info in VM_FAULTS.

2018-07-08 Thread Zhang, Jerry (Junwei)
On 07/06/2018 03:27 AM, Andrey Grodzovsky wrote: Extract and present the reposnsible process and thread when VM_FAULT happens. v2: Use getter and setter functions. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c

Re: [PATCH libdrm] amdgpu: don't call add_handle_to_table for KMS BO exports

2018-07-08 Thread Zhang, Jerry (Junwei)
On 07/07/2018 04:16 AM, Marek Olšák wrote: From: Marek Olšák --- amdgpu/amdgpu_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index 9e37b14..9e7f958 100644 --- a/amdgpu/amdgpu_bo.c +++ b/amdgpu/amdgpu_bo.c @@ -233,21 +233,21

RE: [PATCH 10/10] drm/amd/powerplay: no need to mask workable gfxoff feature for vega12

2018-07-08 Thread Quan, Evan
Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 10/10] drm/amd/powerplay: no need to mask workable > gfxoff feature for vega12 > > Gfxoff feature for

RE: [PATCH 08/10] drm/amdgpu: use the accessible target rlc safe mode Apis directly

2018-07-08 Thread Quan, Evan
Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 08/10] drm/amdgpu: use the accessible target rlc safe mode > Apis directly > > No need to do double

RE: [PATCH 06/10] drm/amdgpu: no touch for the reserved bit of RLC_CGTT_MGCG_OVERRIDE

2018-07-08 Thread Quan, Evan
Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 06/10] drm/amdgpu: no touch for the reserved bit of > RLC_CGTT_MGCG_OVERRIDE > > On vega12, the bit0 of

RE: [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has to wait before request CGCG

2018-07-08 Thread Quan, Evan
Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has to > wait before request CGCG > > Gfxoff feature

RE: [PATCH 04/10] drm/amdgpu: correct direct reg list length for v2_0 rlc

2018-07-08 Thread Quan, Evan
As discussed for patch3, reg_list_format_direct_reg_list_length is newly introduced by rlc v2_1. For ASICs(vega10/12/20) with rlc v2_0, it's not a good idea to use reg_list_format_direct_reg_list_length. Regards, Evan > -Original Message- > From: Huang Rui [mailto:ray.hu...@amd.com] >

RE: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and pg status

2018-07-08 Thread Quan, Evan
Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:09 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and > pg status > > CSIB init has no relation

RE: [PATCH 03/10] drm/amdgpu: init rlc save restore as long as the lists exist

2018-07-08 Thread Quan, Evan
Hi Ray, After reconsideration, I think for the rlc save restore related, there are the following issues: 1. To use adev->gfx.rlc.reg_list_format_direct_reg_list_length or GFX9_RLC_FORMAT_DIRECT_REG_LIST_LENGTH? -> "reg_list_format_direct_reg_list_length" is new introduced by rlc v2_1. To back

Re: [PATCH v3] drm/amdgpu: Verify root PD is mapped into kernel address space.

2018-07-08 Thread Zhang, Jerry (Junwei)
On 07/07/2018 05:21 PM, Christian König wrote: Am 06.07.2018 um 22:12 schrieb Andrey Grodzovsky: Problem: When PD/PT update made by CPU root PD was not yet mapped causing page fault. Fix: Verify root PD is mapped into CPU address space. v2: Make sure that we add the root PD to the relocated