Find out DCE version

2018-08-21 Thread Paul Menzel
Dear Linux folks, How do I easily determine from a running system what version of the DCE (DisplayCore Engine?) the graphics device is? Kind regards, Paul ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

Re: [PATCH] drm/amdgpu: Fix page fault and kasan warning on pci device remove.

2018-08-21 Thread Paul Menzel
Dear Andrey, Am 21.08.2018 um 23:23 schrieb Andrey Grodzovsky: Problem: When executing echo 1 > /sys/class/drm/card0/device/remove kasan warning as bellow and page fault happen because adev->gart.pages already freed by the time amdgpu_gart_unbind is called. BUG: KASAN: user-memory-access in

[PATCH 2/3] drm/amdgpu: Don't use kiq in interrupt

2018-08-21 Thread Emily Deng
Don't use kiq interrupt, as it might sleep. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index fcdbacb..f49f5f3

[PATCH 3/3] drm/amdgpu: Use warn to replace error report

2018-08-21 Thread Emily Deng
When kiq flush fail, it could fallback to mmio flush, so don't report an error, just a warning. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

[PATCH 1/3] drm/amdgpu: Don't use kiq in gpu reset

2018-08-21 Thread Emily Deng
When in gpu reset, don't use kiq, it will generate more TDR. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

Re: [PATCH v4 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v4)

2018-08-21 Thread Huang Rui
On Tue, Aug 21, 2018 at 03:54:28PM +0200, Christian König wrote: > Am 21.08.2018 um 15:43 schrieb Huang Rui: > >On Mon, Aug 20, 2018 at 09:17:12PM +0800, Christian König wrote: > >>Am 20.08.2018 um 08:05 schrieb Huang Rui: > >>>On Fri, Aug 17, 2018 at 06:38:16PM +0800, Koenig, Christian wrote: >

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-21 Thread Zhang, Jerry (Junwei)
On 08/22/2018 05:25 AM, Felix Kuehling wrote: Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This

Re: [PATCH] drm/amdgpu: Fix page fault and kasan warning on pci device remove.

2018-08-21 Thread Zhang, Jerry (Junwei)
On 08/22/2018 05:23 AM, Andrey Grodzovsky wrote: Problem: When executing echo 1 > /sys/class/drm/card0/device/remove kasan warning as bellow and page fault happen because adev->gart.pages already freed by the time amdgpu_gart_unbind is called. BUG: KASAN: user-memory-access in

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-21 Thread Felix Kuehling
This patch is meant for amd-staging-drm-next. It's part of my effort to reduce differences between kfd-staging and upstream and eventually replace all our memory manager hacks with upstream solutions. This commit should only affect GFXv8 and older. It should not have any negative impact, except

[PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-21 Thread Felix Kuehling
Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This makes more VM space available for ROCm

[PATCH] drm/amdgpu: Fix page fault and kasan warning on pci device remove.

2018-08-21 Thread Andrey Grodzovsky
Problem: When executing echo 1 > /sys/class/drm/card0/device/remove kasan warning as bellow and page fault happen because adev->gart.pages already freed by the time amdgpu_gart_unbind is called. BUG: KASAN: user-memory-access in amdgpu_gart_unbind+0x98/0x180 [amdgpu] Write of size 8 at addr

Re: [PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-21 Thread Harry Wentland
On 2018-08-21 03:47 PM, Alex Deucher wrote: > On Tue, Aug 21, 2018 at 3:38 PM Harry Wentland wrote: >> >> On 2018-08-16 04:38 PM, Alex Deucher wrote: >>> Seems to cause blank screens. >>> >>> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940 >>> Signed-off-by: Alex Deucher >> >> Your SOB

Re: [PATCH] drm/amdgpu/display: add support for LVDS (v5)

2018-08-21 Thread Harry Wentland
On 2018-08-21 03:45 PM, Alex Deucher wrote: > On Tue, Aug 21, 2018 at 3:36 PM Harry Wentland wrote: >> >> >> >> On 2018-08-16 09:31 AM, Alex Deucher wrote: >>> This adds support for LVDS displays. >>> >>> v2: add support for spread spectrum, sink detect >>> v3: clean up enable_lvds_output >>> v4:

Re: [PATCH] drm/amdgpu: fix sdma doorbell range setting

2018-08-21 Thread Deucher, Alexander
Yes, this is for amd-staging-drm-next and ultimately upstream. Alex From: Kuehling, Felix Sent: Tuesday, August 21, 2018 4:10:07 PM To: Quan, Evan; amd-gfx@lists.freedesktop.org; Russell, Kent Cc: Deucher, Alexander; Zhang, Hawking Subject: Re: [PATCH]

Re: [PATCH] drm/amdgpu: fix sdma doorbell range setting

2018-08-21 Thread Felix Kuehling
[+Kent] Which branch is this for? amd-staging-drm-next doesn't have Shaoyun's other changes for changing the doorbell layout, so this change looks reasonable for amd-staging-drm-next. Kent, we should not merge this change into amd-kfd-staging, because it would break KFD's 8 SDMA queues per

Re: [PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-21 Thread Alex Deucher
On Tue, Aug 21, 2018 at 3:38 PM Harry Wentland wrote: > > On 2018-08-16 04:38 PM, Alex Deucher wrote: > > Seems to cause blank screens. > > > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940 > > Signed-off-by: Alex Deucher > > Your SOB is using a different email from the author. Mind

Re: [PATCH] drm/amdgpu/display: add support for LVDS (v5)

2018-08-21 Thread Alex Deucher
On Tue, Aug 21, 2018 at 3:36 PM Harry Wentland wrote: > > > > On 2018-08-16 09:31 AM, Alex Deucher wrote: > > This adds support for LVDS displays. > > > > v2: add support for spread spectrum, sink detect > > v3: clean up enable_lvds_output > > v4: fix up link_detect > > v5: remove assert on 888

Re: [PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-21 Thread Harry Wentland
On 2018-08-16 04:38 PM, Alex Deucher wrote: > Seems to cause blank screens. > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940 > Signed-off-by: Alex Deucher Your SOB is using a different email from the author. Mind if I change it to your gmail? Harry > --- >

Re: [PATCH] drm/amdgpu/display: add support for LVDS (v5)

2018-08-21 Thread Harry Wentland
On 2018-08-16 09:31 AM, Alex Deucher wrote: > This adds support for LVDS displays. > > v2: add support for spread spectrum, sink detect > v3: clean up enable_lvds_output > v4: fix up link_detect > v5: remove assert on 888 format > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=105880 >

Re: [PATCH] drm/amdgpu: fix preamble handling

2018-08-21 Thread Alex Deucher
On Tue, Aug 21, 2018 at 9:11 AM Christian König wrote: > > At this point the command submission can still be interrupted. > > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 16 +--- > 1 file changed, 9 insertions(+), 7

Re: [PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-21 Thread Harry Wentland
On 2018-08-16 04:38 PM, Alex Deucher wrote: > Seems to cause blank screens. > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940 > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++- > 1 file

Re: [PATCH] drm/amd/display: indent an if statement

2018-08-21 Thread Harry Wentland
On 2018-08-14 05:09 AM, Dan Carpenter wrote: > The if statement isn't indented and it makes static checkers complain. > > Signed-off-by: Dan Carpenter Reviewed-by: Harry Wentland Harry > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c >

Re: [PATCH] drm/amd/display: fix a compile warning

2018-08-21 Thread Alex Deucher
On Fri, Aug 17, 2018 at 3:01 PM Randy Dunlap wrote: > > On 08/16/2018 08:09 PM, Wen Yang wrote: > > Fix comile warning like, > > CC [M] drivers/gpu/drm/i915/gvt/execlist.o > > CC [M] drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.o > > CC [M] drivers/gpu/drm/radeon/btc_dpm.o > > CC

Re: [PATCH] drm/amdgpu: fix sdma doorbell range setting

2018-08-21 Thread Deucher, Alexander
Alternatively, we could cherry-pick the change to the doorbell ranges from Shaoyun. Might also be useful to leave a comment here about the doorbell range for vega20 sdma. Alex From: Zhang, Hawking Sent: Tuesday, August 21, 2018 5:02:24 AM To: Quan, Evan;

Re: [PATCH v4 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v4)

2018-08-21 Thread Christian König
Am 21.08.2018 um 15:43 schrieb Huang Rui: On Mon, Aug 20, 2018 at 09:17:12PM +0800, Christian König wrote: Am 20.08.2018 um 08:05 schrieb Huang Rui: On Fri, Aug 17, 2018 at 06:38:16PM +0800, Koenig, Christian wrote: Am 17.08.2018 um 12:08 schrieb Huang Rui: I continue to work for bulk moving

Re: [PATCH v4 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v4)

2018-08-21 Thread Huang Rui
On Mon, Aug 20, 2018 at 09:17:12PM +0800, Christian König wrote: > Am 20.08.2018 um 08:05 schrieb Huang Rui: > > On Fri, Aug 17, 2018 at 06:38:16PM +0800, Koenig, Christian wrote: > >> Am 17.08.2018 um 12:08 schrieb Huang Rui: > >>> I continue to work for bulk moving that based on the proposal by

[PATCH] drm/amdgpu: fix preamble handling

2018-08-21 Thread Christian König
At this point the command submission can still be interrupted. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

Re: [PATCH v4] drm/amdgpu/sriov: Only sriov runtime support use kiq

2018-08-21 Thread Christian König
Am 21.08.2018 um 12:03 schrieb Emily Deng: Use adev->gfx.kiq.ring.ready directly. For sriov, don't use kiq in exclusive mode, as don't know how long time it will take, some times it will occur exclusive timeout. Signed-off-by: Emily Deng Reviewed-by: Christian König ---

Re: [PATCH] drm/amdgpu: add ip_block_mask user option for static builds

2018-08-21 Thread Vishwakarma, Pratik
s/blokcs/blocks s/dyanamic/dynamic Regards Pratik On 8/21/2018 3:23 PM, Shirish S wrote: This patch extends amdgpu.ip_block_mask to a Kconfig option as well, that can be altered by user at build time for OS' that do not permit passing dyanamic loading of amdgpu driver and also passing

Re: [PATCH] drm/amdgpu: add ip_block_mask user option for static builds

2018-08-21 Thread Michel Dänzer
On 2018-08-21 11:53 a.m., Shirish S wrote: > This patch extends amdgpu.ip_block_mask to a Kconfig option as > well, that can be altered by user at build time for OS' that > do not permit passing dyanamic loading of amdgpu driver and also > passing command line arguments. > > Note: This option to

[PATCH v4] drm/amdgpu/sriov: Only sriov runtime support use kiq

2018-08-21 Thread Emily Deng
Use adev->gfx.kiq.ring.ready directly. For sriov, don't use kiq in exclusive mode, as don't know how long time it will take, some times it will occur exclusive timeout. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 15 --- 1 file changed, 8 insertions(+), 7

[PATCH] drm/amdgpu: add ip_block_mask user option for static builds

2018-08-21 Thread Shirish S
This patch extends amdgpu.ip_block_mask to a Kconfig option as well, that can be altered by user at build time for OS' that do not permit passing dyanamic loading of amdgpu driver and also passing command line arguments. Note: This option to be used purely for debugging purposes and amdgpu driver

RE: [PATCH v3] drm/amdgpu/sriov: Only sriov runtime support use kiq

2018-08-21 Thread Deng, Emily
>-Original Message- >From: Christian König >Sent: Tuesday, August 21, 2018 5:05 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH v3] drm/amdgpu/sriov: Only sriov runtime support use kiq > >Am 21.08.2018 um 10:41 schrieb Emily Deng: >> Move the check into the caller

Re: [PATCH v3] drm/amdgpu/sriov: Only sriov runtime support use kiq

2018-08-21 Thread Christian König
Am 21.08.2018 um 10:41 schrieb Emily Deng: Move the check into the caller instead of returning an error code here For sriov, don't use kiq in exclusive mode, as don't know how long time it will take, some times it will occur exclusive timeout. Signed-off-by: Emily Deng ---

RE: [PATCH] drm/amdgpu: fix sdma doorbell range setting

2018-08-21 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: 2018年8月21日 16:21 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: fix sdma doorbell range setting Use the old

[PATCH v3] drm/amdgpu/sriov: Only sriov runtime support use kiq

2018-08-21 Thread Emily Deng
Move the check into the caller instead of returning an error code here For sriov, don't use kiq in exclusive mode, as don't know how long time it will take, some times it will occur exclusive timeout. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 19 +++

[PATCH] drm/amdgpu: fix sdma doorbell range setting

2018-08-21 Thread Evan Quan
Use the old doorbell range setting until the driver is able to support more sdma queues. Change-Id: I80fc067fc64878d3c7dc3d38bbe1c6c94bec397f Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

RE: [PATCH v2] drm/amdgpu/sriov: Only sriov runtime support use kiq

2018-08-21 Thread Deng, Emily
>-Original Message- >From: Christian König >Sent: Tuesday, August 21, 2018 3:51 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH v2] drm/amdgpu/sriov: Only sriov runtime support use kiq > >Am 21.08.2018 um 07:16 schrieb Emily Deng: >> Refine the code style, add

Re: [PATCH v2] drm/amdgpu/sriov: Only sriov runtime support use kiq

2018-08-21 Thread Christian König
Am 21.08.2018 um 07:16 schrieb Emily Deng: Refine the code style, add brackets. For sriov, don't use kiq in exclusive mode, as don't know how long time it will take, some times it will occur exclusive timeout. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1