Make sense to me.
I will update the patch accordingly.
Regards,
Evan
> -Original Message-
> From: Alex Deucher
> Sent: 2018年8月31日 12:19
> To: Quan, Evan
> Cc: amd-gfx list ; Deucher, Alexander
> ; Zhu, Rex
> Subject: Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support
>
> On
On Thu, Aug 30, 2018 at 5:34 PM Bhawanpreet Lakha
wrote:
>
> From: Dmytro Laktyushkin
>
> Change-Id: Id1e7c39db419f13cf478c6a0c6f4b84c039acffe
> Signed-off-by: Dmytro Laktyushkin
> Reviewed-by: Charlene Liu
> Acked-by: Bhawanpreet Lakha
> ---
>
On Thu, Aug 30, 2018 at 11:47 PM Quan, Evan wrote:
>
> > If so, we should separate them and
> > use something like my earlier proposal where we separate the voltage
> > curve from the clk settings.
> There is one more thing. Previously these OD APIs mix clock and voltage
> settings together.
>
Signed-off-by: Michał Mirosław
Acked-by: Bartlomiej Zolnierkiewicz
Acked-by: Daniel Vetter
---
drivers/video/fbdev/core/fbmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index
Remove duplicated call, while at it.
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +
drivers/gpu/drm/mgag200/mgag200_main.c | 9 -
2 files changed, 1 insertion(+), 29 deletions(-)
diff --git
Signed-off-by: Michał Mirosław
Acked-by: Alex Deucher
Acked-by: Daniel Vetter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
Interpret (otherwise-invalid) NULL apertures argument to mean all-memory
range. This will allow to remove several duplicates of this code from
drivers in following patches.
Signed-off-by: Michał Mirosław
[for v1]
Acked-by: Bartlomiej Zolnierkiewicz
---
v2: added kerneldoc to corresponding DRM
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c
b/drivers/gpu/drm/cirrus/cirrus_drv.c
index 69c4e352dd78..85ed8657c862
Use remove_conflicting_framebuffers(NULL) instead of open-coding it.
Signed-off-by: Michał Mirosław
Acked-by: Eric Anholt
Acked-by: Daniel Vetter
---
drivers/gpu/drm/vc4/vc4_drv.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git
Use remove_conflicting_framebuffers(NULL) instead of duplicating it.
Signed-off-by: Michał Mirosław
Acked-by: Maxime Ripard
Acked-by: Daniel Vetter
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git
Kick out firmware fb when loading Tegra driver.
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/tegra/drm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 7afe2f635f74..b51ec138fed2 100644
---
This series cleans up duplicated code for replacing firmware FB
driver with proper DRI driver and adds handover support to
Tegra driver.
This is a sligtly updated version of a series sent on 24 Nov 2017.
v2:
- rebased on current drm-next
- dropped staging/sm750fb changes
- added kernel docs
Almost all PCI drivers using remove_conflicting_framebuffers() wrap it
with the same code.
Signed-off-by: Michał Mirosław
[for v1]
Acked-by: Bartlomiej Zolnierkiewicz
---
v2: add kerneldoc for DRM helper
---
drivers/video/fbdev/core/fbmem.c | 22 ++
Signed-off-by: Michał Mirosław
Acked-by: Alex Deucher
Acked-by: Daniel Vetter
---
drivers/gpu/drm/radeon/radeon_drv.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
b/drivers/gpu/drm/radeon/radeon_drv.c
index
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 +++-
1 file changed, 3 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c
b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c
index
> If so, we should separate them and
> use something like my earlier proposal where we separate the voltage
> curve from the clk settings.
There is one more thing. Previously these OD APIs mix clock and voltage
settings together.
That is "s/m level clock voltage". Do you think whether we should
Hi Alex,
comment inline
> -Original Message-
> From: Alex Deucher
> Sent: 2018年8月30日 23:25
> To: Quan, Evan
> Cc: amd-gfx list ; Deucher, Alexander
> ; Zhu, Rex
> Subject: Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support
>
> On Thu, Aug 30, 2018 at 1:56 AM Quan, Evan
On 08/30/2018 10:53 PM, Alex Deucher wrote:
No functional change, just rework it in order to adjust the
behavior on a per asic level. The problem is that on vega10,
something corrupts the lower 8 MB of vram on the second
resume from S3. This does not seem to affect Raven, other
gmc9 based
On 08/30/2018 10:53 PM, Alex Deucher wrote:
Raven does not appear to be affected by the same issue
as vega10. Enable the full stolen memory handling on
Raven. Reserve the appropriate size at init time to avoid
display artifacts and then free it at the end of init once
the new FB is up and
Patch 1~5 are
Reviewed-by: Junwei Zhang
Patch 6 is
Acked-by: Junwei Zhang
BTW, [PATCH 4/6] drm/amdgpu: manually map the shadow BOs again
with this patch, the user cannot create a shadow bo with gart address.
anyway, I cannot image that use case either.
Regards,
Jerry
On 08/30/2018 08:14
On 08/30/2018 08:15 PM, Christian König wrote:
Am 30.08.2018 um 05:20 schrieb Zhang, Jerry (Junwei):
On 08/29/2018 10:08 PM, Christian König wrote:
Start to use the old AGP aperture for system memory access.
v2: Move that to amdgpu_ttm_alloc_gart
Signed-off-by: Christian König
---
From: Tony Cheng
Change-Id: I3f84e63a59d037656f50f51870eb67c941b344cd
Signed-off-by: Tony Cheng
Reviewed-by: Steven Chiu
Acked-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
From: Hersen Wu
[why]
AMD Stoney reference board, there are only 2 pipes (not include
underlay), and 3 connectors. resource creation, only
2 I2C/AUX engines are created. Within dc_link_aux_transfer, when
pin_data_en =2, refer to enengines[ddc_pin->pin_data->en] = NULL.
NULL point is referred
From: Leo Li
[Why]
Our implementation is functionally identical to DRM's
Note that instead of checking if the provided id is 0, the helper
follows through with the mode object search. However, It will still
return NULL, since 0 is not a valid object id, and missed searches
will return NULL.
From: Derek Lai
Some display need disconnect delay. Adding this parameter for future use
Change-Id: I0075cf2be0fe658f07425f80d23c592726929a76
Signed-off-by: Derek Lai
Reviewed-by: Charlene Liu
Acked-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/display/dc/dc_types.h | 1 +
1 file changed, 1
From: Gary Kattan
[Why]Update Code to get DTN golden log check to pass for tests run after
DAL217 tests.
[How]Change how dcn10_log_hw_state function prints HW state info
(CM_GAMUT_REMAP_Cx_Cx registers) when GAMUT REMAP is in bypass mode.
Change-Id: I2c116ab220a7c2582c011474f6e5d7ab3018cde6
From: Chiawen Huang
[Why]
There are same purpose transition events.
[How]
remove the redundant event log.
Change-Id: I90faf48f7c0c492b7b753ebbeb819a08c5f074e5
Signed-off-by: Chiawen Huang
Reviewed-by: Tony Cheng
Acked-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/display/dc/dm_event_log.h
From: David Francis
[Why]
The extraneous call to amdgpu_pm_compute_clocks is deprecated.
[How]
Remove it.
Change-Id: I0bfee7f1aca4184b441c39efbdc580394bdd1020
Signed-off-by: David Francis
Signed-off-by: Leo Li
Reviewed-by: David Francis
Acked-by: Bhawanpreet Lakha
---
From: David Francis
[Why]
The i2c and aux engines are similar, and should be placed
next to eachother for readability
[How]
Reorder the elements of the resource_pool struct
Change-Id: I74bb54c9bd8d08cf51013fc597c54d33e379f8a5
Signed-off-by: David Francis
Reviewed-by: Tony Cheng
Acked-by:
From: Dmytro Laktyushkin
Change-Id: Id1e7c39db419f13cf478c6a0c6f4b84c039acffe
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Charlene Liu
Acked-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 1177
From: Eric Yang
[Why]
Virtual sink is used when set mode happens on a disconnected display
to allow the mode set to proceed. This did not work with MST because
the logic for acquiring stream encoder uses stream signal to determine
the special handling is required, and stream signal is virtual
Summary of Changes
*Add DP YCbCr 4:2:0 support
*Clean up unused code
*Refactor code in DM
Bhawanpreet Lakha (1):
drm/amd/display: Build stream update and plane updates in dm
Chiawen Huang (2):
drm/amd/display: add aux transition event log.
drm/amd/display: clean code for transition event
From: Jun Lei
Although 4 unique register values exist for gamma modes, two are
actually the same (the two RAMs) It’s not possible for caller to
understand this HW specific behavior, so some parsing is necessary
in driver
Change-Id: I073e0f67aed5c9bc8760e89d7755e6399b3687e2
Signed-off-by: Jun
From: Tony Cheng
Change-Id: I4b6cd9df9e84fb000df61aba22d42dc64b45ca70
Signed-off-by: Tony Cheng
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index
From: Eric Bernstein
[Why]
For supporting DP YCbCr 4:2:0 output.
[How]
Update mod_build_vsc_infopacket to support Pixel
Encoding/Colorimetry Format indication for VSC SDP rev5.
Change-Id: Id6035c6a954bc698e379fe43cc8079e29d7dd765
Signed-off-by: Eric Bernstein
Reviewed-by: Dmytro Laktyushkin
From: Dmytro Laktyushkin
Change-Id: I54e39a4387c5abeec56a53e1a0a094a51b9839fe
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Charlene Liu
Acked-by: Bhawanpreet Lakha
---
.../gpu/drm/amd/display/dc/dce/dce_clock_source.c | 87 +-
[Why]
We currently lock modeset by setting a boolean in dm. We want to lock
Based on what DC tells us.
[How]
Build stream_updates and plane_update based on what changed. Then we
call check_update_surfaces_for_stream() to get the update type
We lock only if update_type is not fast
Change-Id:
From: Chiawen Huang
[Why]
Enhance aux transition debugging information.
[How]
Added Aux request and reply event log.
Change-Id: I19f3fd904089f57f0eaebbcc0cb613430c11b5b0
Signed-off-by: Chiawen Huang
Reviewed-by: Tony Cheng
Acked-by: Bhawanpreet Lakha
---
This patch is Reviewed-by: Felix Kuehling
The rest of the series is Acked-by me.
Regards,
Felix
On 2018-08-30 08:14 AM, Christian König wrote:
> Helper to figure out the location of the AGP BAR.
>
> v2: fix a couple of bugs
> v3: correctly add one to vram_end
>
> Signed-off-by: Christian
On Thu, Aug 30, 2018 at 1:56 AM Quan, Evan wrote:
>
> Hi Alex,
>
> OK, I got your concern. Then how about the followings?
>
> If user want to change the FMin and FMax, they just need to pass in the new
> clock values.
> E.g, "s 0 350 10" will update the Fmin to 350Mhz and increase its voltage by
Vega20 does not appear to be affected by the same issue
as vega10. Enable the full stolen memory handling on
vega20. Reserve the appropriate size at init time to avoid
display artifacts and then free it at the end of init once
the new FB is up and running.
Signed-off-by: Alex Deucher
---
Can
vega12 does not appear to be affected by the same issue
as vega10. Enable the full stolen memory handling on
vega12. Reserve the appropriate size at init time to avoid
display artifacts and then free it at the end of init once
the new FB is up and running.
Signed-off-by: Alex Deucher
---
Can
Raven does not appear to be affected by the same issue
as vega10. Enable the full stolen memory handling on
Raven. Reserve the appropriate size at init time to avoid
display artifacts and then free it at the end of init once
the new FB is up and running.
Bug:
No functional change, just rework it in order to adjust the
behavior on a per asic level. The problem is that on vega10,
something corrupts the lower 8 MB of vram on the second
resume from S3. This does not seem to affect Raven, other
gmc9 based asics need testing.
Signed-off-by: Alex Deucher
On 2018-08-30 1:51 p.m., Christian König wrote:
> Fixes the LRU corruption, we accidentially tried to move things on the
> LRU after dropping the reservation lock.
>
> Signed-off-by: Christian König
While this patch survived piglit significantly longer than before, it
doesn't fully fix the
Michel can you give this one a try as well?
If I'm not completely mistaken it should fix the LRU problems.
Christian.
Am 30.08.2018 um 13:51 schrieb Christian König:
Fixes the LRU corruption, we accidentially tried to move things on the
LRU after dropping the reservation lock.
Signed-off-by:
Am 30.08.2018 um 05:29 schrieb Zhang, Jerry (Junwei):
On 08/29/2018 10:08 PM, Christian König wrote:
Otherwise we won't be able to use the AGP aperture.
do you mean we use AGP for GTT shadow only now?
No, on older hw generations the page tables are usually larger than one
PAGE.
So we
Am 30.08.2018 um 05:20 schrieb Zhang, Jerry (Junwei):
On 08/29/2018 10:08 PM, Christian König wrote:
Start to use the old AGP aperture for system memory access.
v2: Move that to amdgpu_ttm_alloc_gart
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 23 ++
Otherwise we won't be able to use the AGP aperture.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git
Start to use the old AGP aperture for system memory access.
v2: Move that to amdgpu_ttm_alloc_gart
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 23 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 58
Helper to figure out the location of the AGP BAR.
v2: fix a couple of bugs
v3: correctly add one to vram_end
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 43 +
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 5 +++
2 files changed, 48
Correct sign extend the GMC addresses to 48bit.
v2: sign extending turned out easier than thought.
v3: clean up the defines and move them into amdgpu_gmc.h as well
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
Enable the old AGP aperture to avoid GART mappings.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 10 +-
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c| 1 +
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 10 +-
3 files changed, 11 insertions(+), 10
Not 100% sure if that is a good idea or not. In theory only the writeback BO
should be read most of the time, but who knows?
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Fixes the LRU corruption, we accidentially tried to move things on the
LRU after dropping the reservation lock.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
Am 30.08.2018 um 10:49 schrieb Michel Dänzer:
On 2018-08-30 10:08 a.m., Christian König wrote:
This reverts commit 1156da3d4034957e7927ea68007b981942f5cbd5.
We should review reverts as well cause that one only added an incomplete band
aided to the problem.
Sorry about that. I didn't notice
[SNIP]
+
+struct drm_syncobj_wait_pt {
+ struct drm_syncobj_stub_fence base;
+ u64 value;
+ struct rb_node node;
+};
+struct drm_syncobj_signal_pt {
+ struct drm_syncobj_stub_fence base;
+ struct dma_fence *signal_fence;
+ struct dma_fence *pre_pt_base;
+ struct
On 2018年08月30日 15:25, Christian König wrote:
Am 30.08.2018 um 05:50 schrieb zhoucm1:
On 2018年08月29日 19:42, Christian König wrote:
Am 29.08.2018 um 12:44 schrieb Chunming Zhou:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an
integer payload
Am 30.08.2018 um 08:45 schrieb Christian König:
[...]
>> or create their private instance.
>
> That doesn't sounds good. Drivers should not be allowed to create their
> own private instance of that.
OK, will be changed in the patchset.
Best regards
Thomas
>
> Thanks for doing this,
>
If nothing is found, error should be returned.
v2: udpate the error value different from parameter check
Signed-off-by: Junwei Zhang
Reviewed-by: Christian König
Reviewed-by: Michel Dänzer
---
amdgpu/amdgpu_bo.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
On 08/30/2018 03:50 PM, Christian König wrote:
This reverts commit a7f91061c60ad9cac2e6a03b642be6a4f88b3662.
Felix pointed out that we need to have the BOs mapped even before
amdgpu_vm_update_directories is called.
Signed-off-by: Christian König
Acked-by: Junwei Zhang
---
On 08/30/2018 04:57 PM, Michel Dänzer wrote:
On 2018-08-30 10:50 a.m., Junwei Zhang wrote:
If nothing is found, error should be returned.
Signed-off-by: Junwei Zhang
[...]
@@ -577,10 +578,11 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle
dev,
} else {
I just sent out a V2 patch which adds the clock overdrive and fixes some minor
issues pointed out by Paul.
Regards,
Evan
> -Original Message-
> From: Quan, Evan
> Sent: 2018年8月30日 13:56
> To: 'Alex Deucher'
> Cc: amd-gfx list ; Deucher, Alexander
> ; Zhu, Rex
> Subject: RE: [PATCH]
Added vega20 overdrive support based on existing OD sysfs
APIs. However, the OD logics are simplified on vega20. So,
the behavior will be a little different and works only on
some limited levels.
V2: fix typo
fix commit description
revise error logs
add support for clock OD
On 2018-08-30 10:50 a.m., Junwei Zhang wrote:
> If nothing is found, error should be returned.
>
> Signed-off-by: Junwei Zhang
>
> [...]
>
> @@ -577,10 +578,11 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle
> dev,
> } else {
> *buf_handle = NULL;
>
Am 30.08.2018 um 10:50 schrieb Junwei Zhang:
If nothing is found, error should be returned.
Signed-off-by: Junwei Zhang
Reviewed-by: Christian König
---
amdgpu/amdgpu_bo.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
If nothing is found, error should be returned.
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu_bo.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
index 2f4f90f..3812c5e 100644
--- a/amdgpu/amdgpu_bo.c
+++ b/amdgpu/amdgpu_bo.c
@@
On 2018-08-30 10:08 a.m., Christian König wrote:
> This reverts commit 1156da3d4034957e7927ea68007b981942f5cbd5.
>
> We should review reverts as well cause that one only added an incomplete band
> aided to the problem.
Sorry about that. I didn't notice any issues with the same testing
procedure
On Wed, Aug 29, 2018 at 8:28 PM, Andrey Grodzovsky
wrote:
> Actually, I've just spotted this drm_dev_unplug, does it make sense to use
> it in our pci_driver.remove hook
>
> instead of explicitly doing drm_dev_unregister and drm_dev_put(dev) ?
>
> This way at least any following IOCTL will fail
This reverts commit 1156da3d4034957e7927ea68007b981942f5cbd5.
We should review reverts as well cause that one only added an incomplete band
aided to the problem.
Correctly disable bulk moves until we have figured out why they corrupt
the lists.
Signed-off-by: Christian König
---
This reverts commit a7f91061c60ad9cac2e6a03b642be6a4f88b3662.
Felix pointed out that we need to have the BOs mapped even before
amdgpu_vm_update_directories is called.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 13 -
1 file changed, 4 insertions(+),
On 08/30/2018 02:48 PM, Christian König wrote:
Am 30.08.2018 um 04:43 schrieb Zhang, Jerry (Junwei):
On 08/29/2018 05:39 PM, Christian König wrote:
Am 29.08.2018 um 04:03 schrieb Zhang, Jerry (Junwei):
On 08/28/2018 08:17 PM, Christian König wrote:
Correct sign extend the GMC addresses to
Am 30.08.2018 um 08:48 schrieb Chunming Zhou:
That is certainly totally nonsense. dma_fence_enable_sw_signaling()
is the function who is calling this callback.
Signed-off-by: Chunming Zhou
Cc: Jason Ekstrand
Reviewed-by: Christian König
Acked-by: Daniel Vetter
If there are no objections
Am 30.08.2018 um 05:50 schrieb zhoucm1:
On 2018年08月29日 19:42, Christian König wrote:
Am 29.08.2018 um 12:44 schrieb Chunming Zhou:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an
integer payload
identifying a point in a timeline. Such timeline
Am 30.08.2018 um 04:43 schrieb Zhang, Jerry (Junwei):
On 08/29/2018 05:39 PM, Christian König wrote:
Am 29.08.2018 um 04:03 schrieb Zhang, Jerry (Junwei):
On 08/28/2018 08:17 PM, Christian König wrote:
Correct sign extend the GMC addresses to 48bit.
Could you explain a bit more why to
we can place a fence to a timeline point after expanded.
v2: change func parameter order
Signed-off-by: Chunming Zhou
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
drivers/gpu/drm/drm_syncobj.c | 14 --
we can fetch timeline point fence after expanded.
v2: The parameter fence is the result of the function and should come last.
Signed-off-by: Chunming Zhou
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
drivers/gpu/drm/drm_syncobj.c | 5 +++--
moved to front of file.
stub fence will be used by timeline syncobj as well.
Signed-off-by: Chunming Zhou
Cc: Jason Ekstrand
Reviewed-by: Christian König
---
drivers/gpu/drm/drm_syncobj.c | 53 +++
1 file changed, 29 insertions(+), 24 deletions(-)
diff --git
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an integer payload
identifying a point in a timeline. Such timeline semaphores support the
following operations:
* CPU query - A host operation that allows querying the payload of the
timeline semaphore.
That is certainly totally nonsense. dma_fence_enable_sw_signaling()
is the function who is calling this callback.
Signed-off-by: Chunming Zhou
Cc: Jason Ekstrand
Reviewed-by: Christian König
Acked-by: Daniel Vetter
---
drivers/gpu/drm/drm_syncobj.c | 1 -
1 file changed, 1 deletion(-)
diff
Hi Felix,
ah, crap you are right.
I moved the kmap to amdgpu_vm_update_directories() because I thought
that it would be cleaner to have that closer where it is used.
But that sounds like it doesn't work as intended. Going to revert that
patch.
Thanks,
Christian.
Am 30.08.2018 um 00:30
Hi Thomas,
Am 30.08.2018 um 08:34 schrieb Thomas Zimmermann:
Hi Christian,
I just wanted to ask if there's something else required to get this
patch set reviewed and landed.
I just need to find some time to review them.
On top of these two patches, I have a patch set that replaces the
As explained before we don't need a GART mapping any more for small
allocations.
Additional to that we want it to support early bringup where no VRAM is
attached to the ASIC.
Regards,
Christian.
Am 30.08.2018 um 05:48 schrieb Xiao, Jack:
Can you explain what the benefits can be gained from
Hi Christian,
I just wanted to ask if there's something else required to get this
patch set reviewed and landed.
On top of these two patches, I have a patch set that replaces the
driver-specific global-bo-and-mem combos with a single struct ttm_global
structure. It further merges struct
84 matches
Mail list logo
