RE: two KASANs in TTM logic

2018-09-06 Thread Huang, Ray
Hi Tom, Thanks to trace this issue. I am trying to reproduce it on amd-staging-drm-next with piglit. May I know the steps/configurations to repro it? Thanks, Ray -Original Message- From: amd-gfx On Behalf Of Tom St Denis Sent: Wednesday, September 5, 2018 9:27 PM To: Koenig, Christian

Re: [PATCH 07/13] drm/amdgpu: Add place holder functions for xgmi topology interface with psp

2018-09-06 Thread Kuehling, Felix
This is on purpose. These functions for now are place holders because the PSP firmware interface is not ready yet, and we want to start testing XGMI with higher level code with some hard-coded topology. Once we have proper PSP firmware, these place holders will be filled in. Regards, Felix _

Re: [RFC] drm/amdgpu: Add macros and documentation for format modifiers.

2018-09-06 Thread Marek Olšák
Hopefully this answers some questions. Other parameters that affect tiling layouts are GB_ADDR_CONFIG (all chips) and MC_ARB_RAMCFG (GFX6-8 only), and those vary with each chip. Some 32bpp 1D tiling layouts are compatible across all chips (1D display tiling is the same as SW_256B_D if Bpp == 4).

Re: [PATCH 1/2] drm/amdgpu: Moved fault hash table to amdgpu vm

2018-09-06 Thread ozeng
Hi Christian, In this implementation, fault hash is made per vm, not per pasid as suggested, based on below considerations: * Delay the destroy of hash introduces more effort like how to set the proper grace period after which no retry interrupt will be generated. We want to avoid those

Re: [PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase v2

2018-09-06 Thread Christian König
Am 06.09.2018 um 16:32 schrieb Felix Kuehling: The intent of two commits was lost in the last rebase: 810955b drm/amdgpu: Fix acquiring VM on large-BAR systems b5d21aa drm/amdgpu: Don't use shadow BO for compute context This commit restores the original behaviour: * Don't set AMDGPU_GEM_CREATE_

[PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase v2

2018-09-06 Thread Felix Kuehling
The intent of two commits was lost in the last rebase: 810955b drm/amdgpu: Fix acquiring VM on large-BAR systems b5d21aa drm/amdgpu: Don't use shadow BO for compute context This commit restores the original behaviour: * Don't set AMDGPU_GEM_CREATE_NO_CPU_ACCESS for page directories to allow the

RE: [PATCH] drm/amd/powerplay: fix compile warning for wrong data type V2

2018-09-06 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of Evan > Quan > Sent: Wednesday, September 5, 2018 1:19 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: [PATCH] drm/amd/powerplay: fix compile warning for wrong data > type V2 > > do_div expects the

Re: [PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase

2018-09-06 Thread Christian König
Am 06.09.2018 um 13:46 schrieb Russell, Kent: -Original Message- From: Christian König Sent: Thursday, September 06, 2018 3:36 AM To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: Re: [PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase Am 06.09.2

RE: [PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase

2018-09-06 Thread Russell, Kent
-Original Message- From: Christian König Sent: Thursday, September 06, 2018 3:36 AM To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: Re: [PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase Am 06.09.2018 um 02:28 schrieb Felix Kuehling: > The int

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-09-06 Thread Christian König
Am 06.09.2018 um 12:02 schrieb Huang Rui: On Fri, Aug 31, 2018 at 05:17:33PM +0200, Christian König wrote: Am 31.08.2018 um 17:15 schrieb Michel Dänzer: On 2018-08-31 3:10 p.m., Christian König wrote: Staring at the function for six hours, just to essentially move one line of code. That sucks

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-09-06 Thread Huang Rui
On Fri, Aug 31, 2018 at 05:17:33PM +0200, Christian König wrote: > Am 31.08.2018 um 17:15 schrieb Michel Dänzer: > >On 2018-08-31 3:10 p.m., Christian König wrote: > >>Staring at the function for six hours, just to essentially move one line > >>of code. > >That sucks, but the commit log should desc

[PATCH] drm/amdgpu: Fix wornings while make xmldocs

2018-09-06 Thread Masanari Iida
This patch fixes following wornings. ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3011: warning: Excess function parameter 'dev' description in 'amdgpu_vm_get_task_info' ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3012: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_get_task_in

amdgpu fails compilation with CONFIG_FORTIFY_SOURCE

2018-09-06 Thread Ján Kosterec
amdgpu driver fails compilation when compiling with CONFIG_FORTIFY_SOURCE kernel option: In function ‘memmove’, inlined from ‘append_entry’ at drivers/gpu/drm/amd/amdgpu/../display/dc/basics/logger.c:258:2, inlined from ‘dm_logger_append_va.part.5’ at drivers/gpu/drm/amd/amdgpu/../display/

[PATCH 3/3] drm: add timeline syncobj payload query ioctl

2018-09-06 Thread Chunming Zhou
user mode can query timeline payload. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c| 2 ++ drivers/gpu/drm/drm_syncobj.c | 53 ++ include/uapi/drm/drm.h | 11 +++ 4 files changed, 68 insertio

[PATCH 2/3] drm: add support of syncobj timeline point wait v2

2018-09-06 Thread Chunming Zhou
points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 79 +

[PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-06 Thread Chunming Zhou
VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * CPU query - A host operation that allows querying the payload of the timeline semaphore.

Re: [PATCH 10/13] drm/amdgpu: get_hive_id from amdgpu side

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:31 schrieb shaoyunl: From: Shaoyun Liu Retrieve hive_id from amdgpu device Change-Id: I9bb4d87870edf638b477a9088f14bc84b70e71e2 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling Patches #10-#13 are Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH 08/13] drm/amdgpu : Generate XGMI topology info from driver level

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:31 schrieb shaoyunl: From: Shaoyun Liu Driver will save an array of XGMI hive info, each hive will have a list of devices that have the same hive ID. Change-Id: Ia2934d5b624cffa3283bc0a37679eddbd387cbdd Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers

Re: [PATCH 09/13] drm/amd/include: Add get_hive_id interface in kfd2kgd

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:31 schrieb shaoyunl: From: Shaoyun Liu KFD need to get hive id from amdgpu to build up the XGMI topology Change-Id: If68ea8fd7fb17b7ffb581f45d8406925578d96b8 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling Acked-by: Christian König --- drivers/gpu/drm/amd/in

Re: [PATCH 07/13] drm/amdgpu: Add place holder functions for xgmi topology interface with psp

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:30 schrieb shaoyunl: From: Shaoyun Liu Add dummy function for xgmi function interface with psp Change-Id: I01f35baf5a4b96e9654d448c9892be3cd72c05b7 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling Well NAK. We usually don't add dummy functions and that completely

Re: [PATCH 06/13] drm/amdgpu : Add psp function interfaces for XGMI support

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:30 schrieb shaoyunl: From: Shaoyun Liu Place holder for XGMI support Change-Id: I924fa3693366409de0218009c7f709cb464854cc Signed-off-by: Shaoyun Liu Reviewed-by: Huang Rui Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 34 ++

Re: [PATCH 05/13] drm/amdgpu/gmc9: populate xgmi info for vega20

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:30 schrieb shaoyunl: From: Alex Deucher Call the new gfxhub 1.1 function to get the xgmi info. Acked-by: Huang Rui Acked-by: Slava Abramov Reviewed-by :Shaoyun liu Signed-off-by: Alex Deucher Reviewed-by: Christian König , could probably be squashed into patch #3.

Re: [PATCH 04/13] drm/amdgpu/gmc9: Adjust xgmi offset

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:29 schrieb shaoyunl: From: Alex Deucher On hives with xgmi enabled, the fb_location aperture is a size which defines the total framebuffer size of all nodes in the hive. Each GPU in the hive has the same view via the fb_location aperture. GPU0 starts at offset (0 * segment

Re: [PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase

2018-09-06 Thread Christian König
Am 06.09.2018 um 02:28 schrieb Felix Kuehling: The intent of two commits was lost in the last rebase: 810955b drm/amdgpu: Fix acquiring VM on large-BAR systems b5d21aa drm/amdgpu: Don't use shadow BO for compute context This commit restores the original behaviour: * Don't set AMDGPU_GEM_CREATE_

Re: [PATCH 03/13] drm/amdgpu/gmc9: add a new gfxhub 1.1 helper for xgmi

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:28 schrieb shaoyunl: From: Alex Deucher Used to populate the xgmi info on vega20. v2: PF_MAX_REGION is val - 1 (Ray) Acked-by: Huang Rui Acked-by: Slava Abramov Reviewed-by :Shaoyun liu Signed-off-by: Alex Deucher Acked-by: Christian König Change-Id: Ia7b7f112880

Re: [PATCH 02/13] drm/amdgpu/gmc: add initial xgmi structure to amdgpu_gmc structure

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:28 schrieb shaoyunl: From: Alex Deucher Initial pass at a structure to store xgmi info. xgmi is a high speed cross gpu interconnect. Acked-by: Huang Rui Acked-by: Slava Abramov Reviewed-by :Shaoyun liu Signed-off-by: Alex Deucher Change-Id: I8b373bd847c857dd7cbefa55d1

Re: [PATCH 01/13] drm/amd/include: update the bitfield define for PF_MAX_REGION

2018-09-06 Thread Christian König
Am 05.09.2018 um 17:28 schrieb shaoyunl: From: Shaoyun Liu Correct the definition based on vega20 register spec Change-Id: Ifde296134d00423cdf1078c8249d044f5b5cf5a5 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling Acked-by: Christian König --- drivers/gpu/drm/amd/include/asic_re

Re: [PATCH 2/3] drm: add support of syncobj timeline point wait

2018-09-06 Thread Christian König
Am 06.09.2018 um 08:25 schrieb Chunming Zhou: points array is one-to-one match with syncobjs array. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncobj.c | 23 --- include/uapi/drm/drm.h| 2 ++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --g

Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-06 Thread Christian König
Am 06.09.2018 um 08:25 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the Drop the term semaphore here, better use syncobj. following operations