Re: [pull] amdgpu/kfd, radeon, ttm, scheduler drm-next-4.20

2018-09-19 Thread Alex Deucher
On Thu, Sep 20, 2018 at 12:09 AM Dave Airlie wrote: > > On Thu, 20 Sep 2018 at 14:03, Dave Airlie wrote: > > > > On my 32-bit arm build > > > > MODPOST 1797 modules > > ERROR: "__aeabi_uldivmod" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > > > > Somebody added a ul/ul without using the do_

Re: [pull] amdgpu/kfd, radeon, ttm, scheduler drm-next-4.20

2018-09-19 Thread Dave Airlie
On Thu, 20 Sep 2018 at 14:03, Dave Airlie wrote: > > On my 32-bit arm build > > MODPOST 1797 modules > ERROR: "__aeabi_uldivmod" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > > Somebody added a ul/ul without using the do_div stuff. > > I won't pull this until it's fixed. It seems to be the

Re: [pull] amdgpu/kfd, radeon, ttm, scheduler drm-next-4.20

2018-09-19 Thread Dave Airlie
On my 32-bit arm build MODPOST 1797 modules ERROR: "__aeabi_uldivmod" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Somebody added a ul/ul without using the do_div stuff. I won't pull this until it's fixed. Dave. On Sat, 15 Sep 2018 at 01:52, Alex Deucher wrote: > > Hi Dave, > > First pull

Re: [PATCH] drm/amdgpu: add new polaris pci id

2018-09-19 Thread Zhu, Rex
Reviewed-by: Rex Zhu Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Thursday, September 20, 2018 11:05 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; sta...@vger.kernel.org Subject: [PATCH] drm/amdgpu: add new polaris pci id Add new

[PATCH] drm/amdgpu: add new polaris pci id

2018-09-19 Thread Alex Deucher
Add new pci id. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 14 -- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/driver

[PATCH] drm/amd/powerplay: enable fan RPM and pwm settings

2018-09-19 Thread Evan Quan
Manual fan RPM and pwm setting on vega20 are available now. Change-Id: Iad45a169d6984acc091c4efaf46973619fe43a29 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Reviewed-by: Rex Zhu --- .../include/asic_reg/thm/thm_11_0_2_offset.h | 12 ++ .../include/asic_reg/thm/thm_11_0_2_sh_mask.h |

[PATCH] drm/amdgpu: added vega20 LBPW support

2018-09-19 Thread Evan Quan
Enable LBPW support on vega20. Change-Id: I9fe3458207f958cb500ca34b8d807a7b96d3df74 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 103 +- 1 file changed, 102 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/a

[PATCH] drm/amd/powerplay: correct the hwmon interface ppt limit output

2018-09-19 Thread Evan Quan
The ppt limit read out by hwmon interface is always 0. Correct this hwmon interface output. Change-Id: I2c537cacda04034201120b9c1ea82d113d99ced8 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Reviewed-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 8 drivers

Re: [PATCH 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check() (fwd)

2018-09-19 Thread Julia Lawall
[auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on v4.19-rc4 next-20180919] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lyude-Paul/Fix-legacy-DPMS-changes-with-MS

[PATCH v2 6/6] drm/amdgpu/dm/mst: Use drm_dp_mst_connector_atomic_check()

2018-09-19 Thread Lyude Paul
Hook this into amdgpu's atomic check for their connectors so they never get modesets on no-longer-present MST connectors. We'll also expand on this later once we add DP MST fallback retraining support. As well, turns out that the only atomic DRM driver without the ->best_encoder() bug is amdgpu. C

[PATCH v2 5/6] drm/i915: Fix intel_dp_mst_best_encoder()

2018-09-19 Thread Lyude Paul
Currently, i915 appears to rely on blocking modesets on no-longer-present MSTB ports by simply returning NULL for ->best_encoder(), which in turn causes any new atomic commits that don't disable the CRTC to fail. This is wrong however, since we still want to allow userspace to disable CRTCs on no-l

[PATCH v2 4/6] drm/i915: Skip vcpi allocation for MSTB ports that are gone

2018-09-19 Thread Lyude Paul
Since we need to be able to allow DPMS on->off prop changes after an MST port has disappeared from the system, we need to be able to make sure we can compute a config for the resulting atomic commit. Currently this is impossible when the port has disappeared, since the VCPI slot searching we try to

[PATCH v2 2/6] drm/nouveau: Unbreak nv50_mstc->best_encoder()

2018-09-19 Thread Lyude Paul
As mentioned in the previous commit, we currently prevent new modesets on recently-removed MST connectors by returning no encoder from our ->best_encoder() callback once the MST port has disappeared. This is wrong however, because it prevents legacy modesetting users from being able to disable CRTC

[PATCH v2 3/6] drm/i915: Leave intel_conn->mst_port set, use mst_port_gone instead

2018-09-19 Thread Lyude Paul
Currently we set intel_connector->mst_port to NULL to signify that the MST port has been removed from the system so that we can prevent further action on the port such as connector probes, mode probing, etc. However, we're going to need access to intel_connector->mst_port in order to fixup ->best_e

[PATCH v2 0/6] Fix legacy DPMS changes with MST

2018-09-19 Thread Lyude Paul
There's two major things this patchset does: - Add drm_dp_mst_connector_atomic_check() so drivers don't need to use ->best_encoder() to prevent modesets on zombie MST connectors. We'll use this later for implementing MST fallback retraining as well. - Fix DPMS on->off changes failing with l

[PATCH v2 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check()

2018-09-19 Thread Lyude Paul
Currently the way that we prevent userspace from performing new modesets on MST connectors that have just been destroyed is rather broken. There's nothing in the actual DRM DP MST topology helpers that checks whether or not a connector still exists, instead each DRM driver does this on it's own, us

Re: [PATCH 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check() (fwd)

2018-09-19 Thread Lyude Paul
g, > intel-...@lists.freedesktop.org, amd-gfx@lists.freedesktop.org > CC: David Airlie , linux-ker...@vger.kernel.org, > sta...@vger.kernel.org, Sean Paul > > Hi Lyude, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on drm-inte

Making use of more Gitlab features for xf86-video-amdgpu

2018-09-19 Thread Michel Dänzer
With the 18.1.0 release out the door, I want to start making use of more Gitlab features for xf86-video-amdgpu development. I've already enabled merge requests (MRs) at https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu . From now on, patches should primarily be submitted and reviewed a

Re: [PATCH] drm/amdgpu: disable KIQ IB tests on Polaris for now

2018-09-19 Thread Alex Deucher
On Wed, Sep 19, 2018 at 5:59 AM Christian König wrote: > > KIQ interrupts doesn't seem to work on Polaris. > > Signed-off-by: Christian König Maybe just skip IB tests for KIQ in general. I don't think we ever submit IBs to the KIQ anyway. As long as the ring test passes, I think we are fine. I

Re: [Linux-v4.18-rc6] modpost-errors when compiling with clang-7 and CONFIG_DRM_AMDGPU=m

2018-09-19 Thread Sedat Dilek
On Sun, Jul 29, 2018 at 4:39 PM, Christian König wrote: >> Do you need further informations? > > No, that is a known issue. > > Regards, > Christian. > Hi Christian, is/was this issue fixed? Regards, - Sedat - > > Am 29.07.2018 um 15:52 schrieb Sedat Dilek: >> >> Hi, >> >> when compiling with

Virtualization in vega10 devices

2018-09-19 Thread Alexander Frolov
Hi all! Does GIM (gim.ko) works with vega10 ? if not, what should be used to enable vf in vega10? Thank you! Best,  Alexander ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu: disable KIQ IB tests on Polaris for now

2018-09-19 Thread Christian König
KIQ interrupts doesn't seem to work on Polaris. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index 470dc80f4fe7..5e6a8af380af 10064

[PATCH libdrm 5/5] [libdrm] add syncobj timeline tests

2018-09-19 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- tests/amdgpu/Makefile.am | 3 +- tests/amdgpu/amdgpu_test.c | 12 ++ tests/amdgpu/amdgpu_test.h | 21 +++ tests/amdgpu/meson.build | 2 +- tests/amdgpu/syncobj_tests.c | 259 +++ 5 files changed, 295 insertions(+),

[PATCH libdrm 3/5] [libdrm]: add timeline wait/query ioctl

2018-09-19 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- xf86drm.c | 44 xf86drm.h | 6 ++ 2 files changed, 50 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index b2388194..0cd1cb75 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4249,3 +4249,47 @@ int drmSyncobjSignal(in

[PATCH libdrm 4/5] [libdrm]: wrap syncobj timeline query and wait for amdgpu v2

2018-09-19 Thread Chunming Zhou
v2: symbos are stored in lexical order. Signed-off-by: Chunming Zhou --- amdgpu/amdgpu-symbol-check | 2 ++ amdgpu/amdgpu.h| 39 ++ amdgpu/amdgpu_cs.c | 24 +++ 3 files changed, 65 insertions(+) diff --git a/amdgpu/amd

[PATCH libdrm 2/5] [libdrm] addr cs chunk for syncobj timeline

2018-09-19 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/amdgpu_drm.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index c363b67f..b9f99587 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -482,6 +482,8 @@ struct dr

[PATCH libdrm 1/5] [libdrm] sync drm.h for syncobj part

2018-09-19 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/drm.h | 24 1 file changed, 24 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index f0bd91de..d1688269 100644 --- a/include/drm/drm.h +++ b/include/drm/drm.h @@ -695,6 +695,7 @@ struct drm_prime_handle { str

[PATCH 2/6] [RFC]drm: add syncobj timeline support v7

2018-09-19 Thread Chunming Zhou
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called syncobj in kernel side: This extension introduces a new type of syncobj that has an integer payload identifying a point in a timeline. Such timeline syncobjs support the following operations: * CPU query - A host operati

[PATCH 6/6] drm/amdgpu: update version for timeline syncobj support in amdgpu

2018-09-19 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 6870909da926..58cba492ba55 100644 --- a/drivers/gpu/drm/amd/amdgp

[PATCH 2/6] [RFC]drm: add syncobj timeline support v7

2018-09-19 Thread Chunming Zhou
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called syncobj in kernel side: This extension introduces a new type of syncobj that has an integer payload identifying a point in a timeline. Such timeline syncobjs support the following operations: * CPU query - A host operati

[PATCH 3/6] drm: add support of syncobj timeline point wait v2

2018-09-19 Thread Chunming Zhou
points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 99 +

[PATCH 5/6] drm/amdgpu: add timeline support in amdgpu CS

2018-09-19 Thread Chunming Zhou
syncobj wait/signal operation is appending in command submission. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 114 +++-- include/uapi/drm/amdgpu_drm.h | 10 +++ 3 files changed, 104 inser

[PATCH 1/6] drm: add flags to drm_syncobj_find_fence

2018-09-19 Thread Chunming Zhou
flags can be used by driver to decide whether need to block wait submission. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 4 ++-- drivers/gpu/drm/v3d/v3d_gem.c | 4 ++-- drivers/gpu/drm/vc4/vc4_gem.c |

[PATCH 4/6] drm: add timeline syncobj payload query ioctl

2018-09-19 Thread Chunming Zhou
user mode can query timeline payload. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c| 2 ++ drivers/gpu/drm/drm_syncobj.c | 53 ++ include/uapi/drm/drm.h | 11 +++ 4 files changed, 68 insertio

Re: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

2018-09-19 Thread zhoucm1
On 2018年09月19日 16:07, Christian König wrote: Am 19.09.2018 um 10:03 schrieb Zhou, David(ChunMing): -Original Message- From: amd-gfx On Behalf Of Christian K?nig Sent: Wednesday, September 19, 2018 3:45 PM To: Zhou, David(ChunMing) ; Zhou, David(ChunMing) ; dri- de...@lists.freedeskt

Re: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

2018-09-19 Thread Christian König
Am 19.09.2018 um 10:03 schrieb Zhou, David(ChunMing): -Original Message- From: amd-gfx On Behalf Of Christian K?nig Sent: Wednesday, September 19, 2018 3:45 PM To: Zhou, David(ChunMing) ; Zhou, David(ChunMing) ; dri- de...@lists.freedesktop.org Cc: Dave Airlie ; Rakos, Daniel ; Daniel

RE: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

2018-09-19 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Wednesday, September 19, 2018 3:45 PM > To: Zhou, David(ChunMing) ; Zhou, > David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; Daniel Vetter ; amd- > g...@lists.freedesktop

Re: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

2018-09-19 Thread Christian König
Am 19.09.2018 um 09:32 schrieb zhoucm1: On 2018年09月19日 15:18, Christian König wrote: Am 19.09.2018 um 06:26 schrieb Chunming Zhou: [snip]   *fence = NULL;   drm_syncobj_add_callback_locked(syncobj, cb, func); @@ -164,6 +177,153 @@ void drm_syncobj_remove_callback(struct drm_

Re: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

2018-09-19 Thread zhoucm1
On 2018年09月19日 15:18, Christian König wrote: Am 19.09.2018 um 06:26 schrieb Chunming Zhou: [snip]   *fence = NULL;   drm_syncobj_add_callback_locked(syncobj, cb, func); @@ -164,6 +177,153 @@ void drm_syncobj_remove_callback(struct drm_syncobj *syncobj,   spin_unlock(&syn

Re: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

2018-09-19 Thread zhoucm1
On 2018年09月19日 15:18, Christian König wrote: Am 19.09.2018 um 06:26 schrieb Chunming Zhou: [snip]   *fence = NULL;   drm_syncobj_add_callback_locked(syncobj, cb, func); @@ -164,6 +177,153 @@ void drm_syncobj_remove_callback(struct drm_syncobj *syncobj,   spin_unlock(&syn

Re: [PATCH] [RFC]drm: add syncobj timeline support v5

2018-09-19 Thread Christian König
Am 19.09.2018 um 05:20 schrieb zhoucm1: On 2018年09月18日 16:32, Christian König wrote: +    for (i = 0; i < args->count_handles; i++) { +    if (syncobjs[i]->type == DRM_SYNCOBJ_TYPE_TIMELINE) { +    DRM_ERROR("timeline syncobj cannot reset!\n"); Why not? I mean that should still

Re: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

2018-09-19 Thread Christian König
Am 19.09.2018 um 06:26 schrieb Chunming Zhou: This patch is for VK_KHR_timeline_semaphore extension, semaphore is called syncobj in kernel side: This extension introduces a new type of syncobj that has an integer payload identifying a point in a timeline. Such timeline syncobjs support the follo