On 03.12.2018 22:38, Ville Syrjälä wrote:
> On Thu, Nov 29, 2018 at 10:08:07AM +0100, Andrzej Hajda wrote:
>> On 21.11.2018 19:19, Laurent Pinchart wrote:
>>> Hi Ville,
>>>
>>> Thank you for the patch.
>>>
>>> On Tuesday, 20 November 2018 18:13:42 EET Ville Syrjala wrote:
From: Ville Syrjälä
Hi Yongjun,
This issue has been fixed.
Thanks.
Best Regards
Rex
commit 51f1f6f51712aade68cabb145ed8bab4a6c3997e
Author: Rex Zhu
Date: Fri Nov 23 18:52:21 2018 +0800
drm/amdgpu: Fix static checker warning
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c:49
Am 03.12.18 um 21:14 schrieb Eric Anholt:
> With DEBUG_SLAB (poisoning on free) enabled, I could quickly produce
> an oops when tracing V3D.
Good catch, but the solution is a clear NAK.
drm_sched_entity_add_dependency_cb() can result in setting
entity->dependency to NULL. That in turn can lead
On 03.12.2018 22:48, Ville Syrjälä wrote:
> On Thu, Nov 29, 2018 at 09:46:16AM +0100, Andrzej Hajda wrote:
>> Quite late, hopefully not too late.
>>
>>
>> On 21.11.2018 12:51, Ville Syrjälä wrote:
>>> On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote:
> return;
> diff
On 2018年12月04日 14:39, Wei Yongjun wrote:
Fix the return value check which testing the wrong variable
in amdgpu_allocate_static_csa().
Fixes: 7946340fa389 ("drm/amdgpu: Move csa related code to separate file")
Signed-off-by: Wei Yongjun
---
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 2 +-
1
> -Original Message-
> From: Christian König
> Sent: Monday, December 03, 2018 9:56 PM
> To: Zhou, David(ChunMing) ; Koenig, Christian
> ; dri-de...@lists.freedesktop.org; amd-
> g...@lists.freedesktop.org
> Subject: Re: [PATCH 02/11] dma-buf: add new dma_fence_chain container
> v2
>
>
On 12/4/18 12:21 AM, Alex Deucher wrote:
Adjust limits for newer polaris variants.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git
On 12/4/18 12:21 AM, Alex Deucher wrote:
Update switch limit on newer polaris variants. This may fix
flickering with high refresh rates with mclk switching enabled.
Signed-off-by: Alex Deucher
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 5 -
1
See comments inline. I didn't review the amdgpu_cs and amdgpu_gem parts
as I don't know them very well.
On 2018-12-03 3:19 p.m., Yang, Philip wrote:
> Use HMM helper function hmm_vma_fault() to get physical pages backing
> userptr and start CPU page table update track of those pages. Then use
>
Ping. Any comments, R-b, A-b?
On 2018-11-20 10:07 p.m., Kuehling, Felix wrote:
> This round adds support for more ROCm memory manager features:
> * VRAM limit checking to avoid overcommitment
> * DMABuf import for graphics interoperability
> * Support for mapping doorbells into GPUVM address
On Thu, Nov 29, 2018 at 09:46:16AM +0100, Andrzej Hajda wrote:
> Quite late, hopefully not too late.
>
>
> On 21.11.2018 12:51, Ville Syrjälä wrote:
> > On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote:
> >>
> >>> return;
> >>> diff --git
On Thu, Nov 29, 2018 at 10:08:07AM +0100, Andrzej Hajda wrote:
> On 21.11.2018 19:19, Laurent Pinchart wrote:
> > Hi Ville,
> >
> > Thank you for the patch.
> >
> > On Tuesday, 20 November 2018 18:13:42 EET Ville Syrjala wrote:
> >> From: Ville Syrjälä
> >>
> >> Make life easier for drivers by
I'm ok with that change .
Regards
shaoyun.liu
On 2018-12-03 3:32 p.m., Kuehling, Felix wrote:
> Shaoyun, FYI
>
>
> Acked-by: Felix Kuehling
>
>
> On 2018-12-03 3:28 p.m., Deucher, Alexander wrote:
>> Acked-by: Alex Deucher
>>
>>
On 2018-11-28 4:14 a.m., Joonas Lahtinen wrote:
> Quoting Ho, Kenny (2018-11-27 17:41:17)
>> On Tue, Nov 27, 2018 at 4:46 AM Joonas Lahtinen
>> wrote:
>>> I think a more abstract property "% of GPU (processing power)" might
>>> be a more universal approach. One can then implement that through
Shaoyun, FYI
Acked-by: Felix Kuehling
On 2018-12-03 3:28 p.m., Deucher, Alexander wrote:
>
> Acked-by: Alex Deucher
>
>
> *From:* amd-gfx on behalf of
> Andrey Grodzovsky
> *Sent:* Monday, December 3, 2018 3:03:41 PM
Acked-by: Alex Deucher
From: amd-gfx on behalf of Andrey
Grodzovsky
Sent: Monday, December 3, 2018 3:03:41 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander; Grodzovsky, Andrey
Subject: [PATCH] drm/amdgpu: Update XGMI node print
Use HMM helper function hmm_vma_fault() to get physical pages backing
userptr and start CPU page table update track of those pages. Then use
hmm_vma_range_done() to check if those pages are updated before
amdgpu_cs_submit for gfx or before user queues are resumed for kfd.
If userptr pages are
Replace our MMU notifier with hmm_mirror_ops.sync_cpu_device_pagetables
callback. Enable CONFIG_HMM and CONFIG_HMM_MIRROR as a dependency in
DRM_AMDGPU_USERPTR Kconfig.
It supports both KFD userptr and gfx userptr paths.
The depdent HMM patchsets from Jérôme Glisse are all merged into 4.20.0
With DEBUG_SLAB (poisoning on free) enabled, I could quickly produce
an oops when tracing V3D.
Signed-off-by: Eric Anholt
---
I think this patch is correct (though maybe a bigger refactor could
avoid the extra get/put?), but I've still got this with "vblank_mode=0
perf record -a -e v3d:.\* -e
amdgpu_xgmi_update_topology is called both on device registration
and reset. Fix misleading print since the device is added only once to
the hive on registration and not on reset.
Signed-off-by: Andrey Grodzovsky
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 2 +-
1 file changed, 1
[WHY] clarify dal input parameters to pplib interface, remove
un-used parameters. dal knows exactly which parameters needed
and their effects at pplib and smu sides.
current dal sequence for dcn1_update_clock to pplib:
1.smu10_display_clock_voltage_request for dcefclk
On Mon, Dec 03, 2018 at 06:46:01AM +, Ho, Kenny wrote:
> Hey Matt,
>
> On Fri, Nov 30, 2018 at 5:22 PM Matt Roper wrote:
> > I think Joonas is describing something closer in
> > design to the cgroup-v2 "cpu" controller, which partitions the general
> > time/usage allocated to via cgroup;
Am 03.12.18 um 18:06 schrieb Chris Wilson:
Quoting Christian König (2018-12-03 16:12:14)
Am 03.12.18 um 17:08 schrieb Eric Anholt:
Christian König writes:
Extract of useful code from the timeline work. This provides a function
to return a stub or dummy fence which is always signaled.
Quoting Christian König (2018-12-03 16:12:14)
> Am 03.12.18 um 17:08 schrieb Eric Anholt:
> > Christian König writes:
> >
> >> Extract of useful code from the timeline work. This provides a function
> >> to return a stub or dummy fence which is always signaled.
> >>
> >> Signed-off-by: Christian
Christian König writes:
> Am 03.12.18 um 17:08 schrieb Eric Anholt:
>> Christian König writes:
>>
>>> Extract of useful code from the timeline work. This provides a function
>>> to return a stub or dummy fence which is always signaled.
>>>
>>> Signed-off-by: Christian König
>>> ---
>>>
Ah! Never mind, now I see it what you mean!
I accidentally added my debug change DRM_DEBUG->DRM_ERROR to this patch
as well.
Sorry for the noise,
Christian.
Am 03.12.18 um 17:35 schrieb Christian König:
>> No. As far as I can tell, you're missing these two:
>>
>>
No. As far as I can tell, you're missing these two:
GFX_9_0__SRCID__CP_BAD_OPCODE_ERROR (183)
GFX_9_0__SRCID__SQ_INTERRUPT_ID (239)
239 is used for signaling events from shaders and can be very frequent.
Triggering an error message on those interrupts would be bad.
Mhm, then why didn't those
On 2018-12-01 9:11 a.m., Christian König wrote:
>> Won't this break VM fault handling in KFD?
> No, we still send all VM faults to KFD after processing them. Only
> filtered retries are not send to the KFD any more.
OK, I missed that src->funcs->process returning 0 means "not handled",
>0 means
Am 03.12.18 um 15:47 schrieb Alex Deucher:
Some variants require different MC firmware images.
Reviewed-by: Junwei Zhang
Signed-off-by: Alex Deucher
Acked-by: Christian König for the series.
---
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 29 -
1 file changed,
Adjust limits for newer polaris variants.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
Update switch limit on newer polaris variants. This may fix
flickering with high refresh rates with mclk switching enabled.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Quoting Eric Anholt (2018-12-03 16:08:40)
> Christian König writes:
>
> > Extract of useful code from the timeline work. This provides a function
> > to return a stub or dummy fence which is always signaled.
> >
> > Signed-off-by: Christian König
> > ---
> > drivers/dma-buf/dma-fence.c | 36
Am 03.12.18 um 17:08 schrieb Eric Anholt:
Christian König writes:
Extract of useful code from the timeline work. This provides a function
to return a stub or dummy fence which is always signaled.
Signed-off-by: Christian König
---
drivers/dma-buf/dma-fence.c | 36
Christian König writes:
> Extract of useful code from the timeline work. This provides a function
> to return a stub or dummy fence which is always signaled.
>
> Signed-off-by: Christian König
> ---
> drivers/dma-buf/dma-fence.c | 36 +++-
>
Quoting Christian König (2018-12-03 13:07:58)
> Extract of useful code from the timeline work. Let's use just a single
> stub fence instance instead of allocating a new one all the time.
>
> Signed-off-by: Chunming Zhou
> Signed-off-by: Christian König
Reviewed-by: Chris Wilson
-Chris
Quoting Christian König (2018-12-03 13:07:57)
> Extract of useful code from the timeline work. This provides a function
> to return a stub or dummy fence which is always signaled.
>
> Signed-off-by: Christian König
Reviewed-by: Chris Wilson
-Chris
___
Boris Brezillon writes:
> On Mon, 3 Dec 2018 16:40:11 +0200
> Ville Syrjälä wrote:
>
>> On Thu, Nov 22, 2018 at 12:23:29PM +0100, Boris Brezillon wrote:
>> > @@ -924,6 +978,29 @@ struct drm_connector {
>> > */
>> >struct drm_property_blob *path_blob_ptr;
>> >
>> > + /**
>> > + *
On Mon, 3 Dec 2018 16:40:11 +0200
Ville Syrjälä wrote:
> On Thu, Nov 22, 2018 at 12:23:29PM +0100, Boris Brezillon wrote:
> > @@ -924,6 +978,29 @@ struct drm_connector {
> > */
> > struct drm_property_blob *path_blob_ptr;
> >
> > + /**
> > +* @underscan_mode_property: Optional
Some power features rely on the driver loaded version so always
load the MC firmware from the driver even if the vbios loaded
a version already.
Reviewed-by: Junwei Zhang
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 9 +
1 file changed, 1 insertion(+), 8
Some variants require different MC firmware images.
Reviewed-by: Junwei Zhang
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
On Thu, Nov 22, 2018 at 12:23:29PM +0100, Boris Brezillon wrote:
> @@ -924,6 +978,29 @@ struct drm_connector {
>*/
> struct drm_property_blob *path_blob_ptr;
>
> + /**
> + * @underscan_mode_property: Optional connector underscan mode. Used by
> + * the driver to scale
Patches 1, 2:
Reviewed-by: Alex Deucher
Patch 3:
Acked-by: Alex Deucher
From: amd-gfx on behalf of Andrey
Grodzovsky
Sent: Friday, November 30, 2018 4:41:10 PM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander; Wang, Ken;
Am 03.12.18 um 14:44 schrieb Chunming Zhou:
在 2018/12/3 21:28, Christian König 写道:
Am 03.12.18 um 14:18 schrieb Chunming Zhou:
在 2018/12/3 19:00, Christian König 写道:
Am 03.12.18 um 06:25 schrieb zhoucm1:
On 2018年11月28日 22:50, Christian König wrote:
Lockless container implementation similar
在 2018/12/3 21:28, Christian König 写道:
> Am 03.12.18 um 14:18 schrieb Chunming Zhou:
>>
>> 在 2018/12/3 19:00, Christian König 写道:
>>> Am 03.12.18 um 06:25 schrieb zhoucm1:
On 2018年11月28日 22:50, Christian König wrote:
> Lockless container implementation similar to a dma_fence_array,
Am 03.12.18 um 14:18 schrieb Chunming Zhou:
在 2018/12/3 19:00, Christian König 写道:
Am 03.12.18 um 06:25 schrieb zhoucm1:
On 2018年11月28日 22:50, Christian König wrote:
Lockless container implementation similar to a dma_fence_array, but
with
only two elements per node and automatic garbage
Extract of useful code from the timeline work. This provides a function
to return a stub or dummy fence which is always signaled.
Signed-off-by: Christian König
---
drivers/dma-buf/dma-fence.c | 36 +++-
include/linux/dma-fence.h | 1 +
2 files changed, 36
Am 02.12.18 um 21:52 schrieb Thomas Meyer:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Thomas Meyer
Reviewed-by: Christian König
> ---
>
> diff -u -p a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> ---
Am 03.12.18 um 04:00 schrieb wentalou:
KIQ in VF’s init delayed by another VF’s reset,
which would cause late_init failed occasionally.
MAX_KIQ_REG_TRY enlarged from 20 to 80 would fix this issue.
Change-Id: Iac680af3cbd6afe4f8e408785f0795e1b23dba83
Signed-off-by: wentalou
Your full name
Am 03.12.18 um 06:25 schrieb zhoucm1:
On 2018年11月28日 22:50, Christian König wrote:
Lockless container implementation similar to a dma_fence_array, but with
only two elements per node and automatic garbage collection.
v2: properly document dma_fence_chain_for_each, add
49 matches
Mail list logo
