Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 16.01.19 um 18:17 schrieb Grodzovsky, Andrey: On 01/16/2019 11:02 AM, Koenig, Christian wrote: Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey: On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky

Re: [PATCH] drm/amdgpu: csa_vaddr should not larger than AMDGPU_GMC_HOLE_START

Am 17.01.19 um 04:17 schrieb Lou, Wentao: Hi Christian, Your solution as: addr = (max_pfn - (AMDGPU_VA_RESERVED_SIZE >> AMDGPU_PAGE_SHIFT)) << AMDGPU_PAGE_SHIFT; now max_pfn = 0x10 , AMDGPU_VA_RESERVED_SIZE = 0x10 , AMDGPU_PAGE_SHIFT = 12 Still got addr = 0x FFF0 , which

答复: [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop

Reviewed-by: Jim Qu Thanks JimQu 发件人: amd-gfx 代表 Alex Deucher 发送时间: 2019年1月17日 0:05:14 收件人: amd-gfx@lists.freedesktop.org 抄送: Deucher, Alexander; sta...@vger.kernel.org 主题: [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop Needs ATPX rather than

RE: [PATCH] drm/amdgpu: csa_vaddr should not larger than AMDGPU_GMC_HOLE_START

Hi Christian, Your solution as: addr = (max_pfn - (AMDGPU_VA_RESERVED_SIZE >> AMDGPU_PAGE_SHIFT)) << AMDGPU_PAGE_SHIFT; now max_pfn = 0x10 , AMDGPU_VA_RESERVED_SIZE = 0x10 , AMDGPU_PAGE_SHIFT = 12 Still got addr = 0x FFF0 , which would cause ring gfx timeout. Before commit

[pull] amdgpu, amdkfd drm-fixes-5.0

Hi Dave, Daniel, Fixes for 5.0: - Fix KFD on ARM64 - Fix KFD topology with mixed APU and dGPU systems - Powerplay fix for vega12 - DC Raven fixes - Freesync fix The following changes since commit e2d3c414ec0f9d1557c8c5ff2c32166e68bbc4ad: Merge tag 'drm-intel-fixes-2019-01-11' of

Re: [PATCH] drm/amdgpu: Replace kzalloc with kcalloc

On Tue, Jan 15, 2019 at 2:58 AM Gustavo A. R. Silva wrote: > > Replace kzalloc() function with its 2-factor argument form, kcalloc(). > > This patch replaces cases of: > > kzalloc(a * b, gfp) > > with: > kcalloc(a, b, gfp) > > Also, improve the coding style and the use of sizeof

Re: [PATCH] drm: radeon: annotate implicit fall through

On Mon, Jan 14, 2019 at 3:29 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > This commit remove the following warning: > > drivers/gpu/drm/radeon/evergreen_cs.c:1301:11: warning: this

Re: [PATCH libdrm] amdgpu: add a faster BO list API

FYI, I've pushed the patch because it helps simplify our the amdgpu winsys code and I already have code that depends on it that I don't wanna rewrite. Marek On Wed, Jan 16, 2019 at 12:39 PM Marek Olšák wrote: > On Wed, Jan 16, 2019 at 9:43 AM Christian König < >

Re: [PATCH] drm: Split out drm_probe_helper.h

Hi Daniel. > v5: Actually try to sort them, and while at it, sort all the ones I > touch. Applied this variant on top of drm-misc and did a build test. Looked good for ia64, x86 and alpha. Took a closer look at the changes to atmel_hlcd - and they looked OK. But I noticed that atmel_hlcdc uses

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019 at 9:43 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 16.01.19 um 15:39 schrieb Marek Olšák: > > > > On Wed, Jan 16, 2019, 9:34 AM Koenig, Christian wrote: > >> Am 16.01.19 um 15:31 schrieb Marek Olšák: >> >> >> >> On Wed, Jan 16, 2019, 7:55 AM Christian

Re: [PATCH libdrm] amdgpu: update amdgpu_drm.h

On 2019-01-16 5:56 p.m., Marek Olšák wrote: > On Wed, Jan 16, 2019 at 11:25 AM Koenig, Christian > wrote: >> Am 16.01.19 um 17:15 schrieb Marek Olšák: >> On Wed, Jan 16, 2019 at 2:37 AM Christian König < >> ckoenig.leichtzumer...@gmail.com> wrote: >> >>> Am 15.01.19 um 20:25 schrieb Marek Olšák:

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/16/2019 11:02 AM, Koenig, Christian wrote: Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey: On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: On 01/11/2019 02:11 PM, Koenig, Christian wrote:

Re: [PATCH libdrm] amdgpu: update amdgpu_drm.h

On Wed, Jan 16, 2019 at 11:25 AM Koenig, Christian wrote: > Am 16.01.19 um 17:15 schrieb Marek Olšák: > > On Wed, Jan 16, 2019 at 2:37 AM Christian König < > ckoenig.leichtzumer...@gmail.com> wrote: > >> Am 15.01.19 um 20:25 schrieb Marek Olšák: >> > From: Marek Olšák >> >> Maybe note in the

Re: [PATCH libdrm] amdgpu: update amdgpu_drm.h

On 1/16/19 11:24 AM, Koenig, Christian wrote: > Am 16.01.19 um 17:15 schrieb Marek Olšák: >> On Wed, Jan 16, 2019 at 2:37 AM Christian König >> > > wrote: >> >> Am 15.01.19 um 20:25 schrieb Marek Olšák: >> > From: Marek Olšák

Re: [PATCH libdrm] amdgpu: update amdgpu_drm.h

Am 16.01.19 um 17:15 schrieb Marek Olšák: On Wed, Jan 16, 2019 at 2:37 AM Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote: Am 15.01.19 um 20:25 schrieb Marek Olšák: > From: Marek Olšák mailto:marek.ol...@amd.com>> Maybe note in the commit message from which upstream kernel. No

Re: [PATCH libdrm] amdgpu: update amdgpu_drm.h

On Wed, Jan 16, 2019 at 2:37 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 15.01.19 um 20:25 schrieb Marek Olšák: > > From: Marek Olšák > > Maybe note in the commit message from which upstream kernel. > No upstream kernel. It's from amd-staging-drm-next. Marek

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019 at 10:15 AM Bas Nieuwenhuizen wrote: > On Wed, Jan 16, 2019 at 3:38 PM Marek Olšák wrote: > > > > > > > > On Wed, Jan 16, 2019, 7:46 AM Bas Nieuwenhuizen wrote: > >> > >> So random questions: > >> > >> 1) In this discussion it was mentioned that some Vulkan drivers still >

[PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop

Needs ATPX rather than _PR3 for dGPU power control. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=202263 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey: On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: On 01/11/2019 02:11 PM, Koenig, Christian wrote: Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey:

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: On 01/11/2019 02:11 PM, Koenig, Christian wrote: Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: On 01/11/2019 04:42 AM, Koenig, Christian

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019 at 3:38 PM Marek Olšák wrote: > > > > On Wed, Jan 16, 2019, 7:46 AM Bas Nieuwenhuizen wrote: >> >> So random questions: >> >> 1) In this discussion it was mentioned that some Vulkan drivers still >> use the bo_list interface. I think that implies radv as I think we're >>

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Am 16.01.19 um 15:39 schrieb Marek Olšák: On Wed, Jan 16, 2019, 9:34 AM Koenig, Christian mailto:christian.koe...@amd.com> wrote: Am 16.01.19 um 15:31 schrieb Marek Olšák: On Wed, Jan 16, 2019, 7:55 AM Christian König mailto:ckoenig.leichtzumer...@gmail.com> wrote:

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019, 9:34 AM Koenig, Christian Am 16.01.19 um 15:31 schrieb Marek Olšák: > > > > On Wed, Jan 16, 2019, 7:55 AM Christian König < > ckoenig.leichtzumer...@gmail.com wrote: > >> Well if you ask me we should have the following interface for >> negotiating memory management with the

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019, 7:46 AM Bas Nieuwenhuizen So random questions: > > 1) In this discussion it was mentioned that some Vulkan drivers still > use the bo_list interface. I think that implies radv as I think we're > still using bo_list. Is there any other API we should be using? (Also, > with

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Am 16.01.19 um 15:31 schrieb Marek Olšák: On Wed, Jan 16, 2019, 7:55 AM Christian König mailto:ckoenig.leichtzumer...@gmail.com> wrote: Well if you ask me we should have the following interface for negotiating memory management with the kernel: 1. We have per process BOs which can't be shared

[PATCH] drm/amdgpu: cleanup amdgpu_ih_process a bit more

Remove the callback and call the dispatcher directly. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 4 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 48 +

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019, 7:55 AM Christian König < ckoenig.leichtzumer...@gmail.com wrote: > Well if you ask me we should have the following interface for > negotiating memory management with the kernel: > > 1. We have per process BOs which can't be shared between processes. > > Those are always

Re: [PATCH 2/2] drm/amdgpu: fix wrong APU judgement

Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Wednesday, January 16, 2019 1:16:15 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amdgpu: fix wrong APU judgement Fix the APU judgement to make it

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Well if you ask me we should have the following interface for negotiating memory management with the kernel: 1. We have per process BOs which can't be shared between processes. Those are always valid and don't need to be mentioned in any BO list whatsoever. If we knew that a per process BO

Re: [PATCH libdrm] amdgpu: add a faster BO list API

So random questions: 1) In this discussion it was mentioned that some Vulkan drivers still use the bo_list interface. I think that implies radv as I think we're still using bo_list. Is there any other API we should be using? (Also, with VK_EXT_descriptor_indexing I suspect we'll be moving more

Re: [PATCH] drm/amdgpu: csa_vaddr should not larger than AMDGPU_GMC_HOLE_START

Hi Wentao, well the problem is you don't seem to understand how the hardware works. See the engines see an MC address space with a hole in the middle, similar to the how x86 64bit CPU address space works. But the page tables are programmed linearly. So the calculation in

RE: [PATCH] drm/amdgpu: csa_vaddr should not larger than AMDGPU_GMC_HOLE_START

Hi Christian, Now vm_size was set to 0x4 GB by below commit: 1bf621c42137926ac249af761c0190a9258aa0db drm/amdgpu: Remove unnecessary VM size calculations So that max_pfn would be 0x10 . amdgpu_csa_vaddr would make max_pfn << 12 to get 0x1 , and then minus

xf86-video-amdgpu merge request !21 is ready for review

https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu/merge_requests/21 Thanks in advance for taking a look! -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer