Re: Screen goes sleep on Xorg randomly and system freezes with radeon RV515 driver

2019-03-05 Thread Koenig, Christian
Hi Oscar, Alex already answered on your bug report that RV515 is pretty old hardware. I have strong doubts that anybody has the time nor the hardware to look into this. The only thing you can do is to try to narrow down the bug and then we could look at what exactly changed. Regards,

RE: [PATCH v2] tests/amdgpu: add deadlock test for sdma

2019-03-05 Thread Quan, Evan
Reviewed-and-tested-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Cui, > Flora > Sent: Wednesday, March 06, 2019 2:37 PM > To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Cui, Flora > Subject: [PATCH v2] tests/amdgpu: add deadlock test for

[PATCH v2] tests/amdgpu: add deadlock test for sdma

2019-03-05 Thread Cui, Flora
deadlock test for sdma will cause gpu recoverty. disable the test for now until GPU reset recovery could survive at least 1000 times test. v2: add modprobe parameter Change-Id: I9adac63c62db22107345eddb30e7d81a1bda838c Signed-off-by: Flora Cui --- tests/amdgpu/amdgpu_test.c| 4 ++

[PATCH libdrm] tests/amdgpu: add deadlock test for sdma

2019-03-05 Thread Cui, Flora
deadlock test for sdma will cause gpu recoverty. disable the test for now until GPU reset recovery could survive at least 1000 times test. Change-Id: I9adac63c62db22107345eddb30e7d81a1bda838c Signed-off-by: Flora Cui --- tests/amdgpu/amdgpu_test.c| 4 ++ tests/amdgpu/deadlock_tests.c |

Re: [PATCH] drm/amdkfd: Add curly braces around idr_for_each_entry_continue loop

2019-03-05 Thread Kuehling, Felix
On 2019-03-05 6:20 a.m., Michel Dänzer wrote: > From: Michel Dänzer > > The compiler pointed out that one if block unintentionally wasn't part > of the loop: > > In file included from ./include/linux/kernfs.h:14, > from ./include/linux/sysfs.h:16, > from

Screen goes sleep on Xorg randomly and system freezes with radeon RV515 driver

2019-03-05 Thread Oscar Megia
Hi I filled up a bug at https://bugzilla.kernel.org/show_bug.cgi?id=202599 but nobody answer. I think that all information you need is there. You are in MAINTAINERS file for RADEON and AMDGPU DRM DRIVERS. I guess that all users with my video card will have the same issue, so is important to

[PATCH 19/20] drm/amdkfd: add RAS capabilities in topology for Vega20 (v2)

2019-03-05 Thread Alex Deucher
From: Eric Huang It is to collaborate with HSA_CAPABILITY in libhsakmt. v2: squash in NULL pointer check Signed-off-by: Eric Huang Reviewed-by: Felix Kuehling Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 16

[PATCH 20/20] drm/amdkfd: add RAS ECC event support (v2)

2019-03-05 Thread Alex Deucher
From: Eric Huang RAS ECC event will combine with GPU reset event, due to ECC interrupts are caused by uncorrectable error that triggers GPU reset. v2: Fix misleading-indentation warning Signed-off-by: Eric Huang Reviewed-by: Felix Kuehling Reviewed-by: Alex Deucher Signed-off-by: Alex

[PATCH 18/20] drm/amdgpu: add human readable debugfs control support (v2)

2019-03-05 Thread Alex Deucher
From: xinhui pan Currently, the debugfs control node can't parse bash-like commands. Now add such support for any tester that uses scripts. v2: squash in fixes for input validation Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher ---

[PATCH 12/20] drm/amdgpu: enable ras on sdma4

2019-03-05 Thread Alex Deucher
From: xinhui pan register IH, enable ras features on sdma. create sysfs debugfs file for sdma. Signed-off-by: xinhui pan Signed-off-by: Feifei Xu Signed-off-by: Eric Huang Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 4 +

[PATCH 17/20] drm/amdgpu: skip gpu reset when ras error occured

2019-03-05 Thread Alex Deucher
From: xinhui pan gpu reset is not stable on vega20 A1. Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h

[PATCH 16/20] drm/amdgpu: add ioctl query for enabled ras features (v2)

2019-03-05 Thread Alex Deucher
From: xinhui pan Add a query for userspace to check which RAS features are enabled. v2: squash in warning fix Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 10 include/uapi/drm/amdgpu_drm.h |

[PATCH 11/20] drm/amdgpu: reserve bad pages during recovery

2019-03-05 Thread Alex Deucher
From: xinhui pan Mark vram pages with errors as bad and prevent the driver from using them. Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH 09/20] drm/amdgpu: add amdgpu_ras.c to support ras (v2)

2019-03-05 Thread Alex Deucher
From: xinhui pan add obj management. add feature control. add debugfs infrastructure. add sysfs infrastructure. add IH infrastructure. add recovery infrastructure. It is a framework. Other IPs need call amdgpu_ras_xxx function instead of psp_ras_xxx functions. v2: squash in warning fixes

[PATCH 10/20] drm/amdgpu: add debugfs ctrl node

2019-03-05 Thread Alex Deucher
From: xinhui pan allow userspace enable/disable ras Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 122 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 9 ++ 2 files changed, 121

[PATCH 08/20] drm/amdgpu: add psp cmd submit timeout

2019-03-05 Thread Alex Deucher
From: xinhui pan Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

[PATCH 07/20] drm/amdgpu: add psp v11 ras callback

2019-03-05 Thread Alex Deucher
From: xinhui pan Add trigger_error and cure_posion. Acked-by: Hawking Zhang Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 50 ++ 1 file changed, 50 insertions(+) diff --git

[PATCH 00/20] RAS support for amdgpu

2019-03-05 Thread Alex Deucher
This patch set adds initial RAS (Reliability, Availability, Serviceability) support to amdgpu on supported boards. Features include SRAM and VRAM ECC, bad page tracking, and error containment. Eric Huang (2): drm/amdkfd: add RAS capabilities in topology for Vega20 (v2) drm/amdkfd: add RAS

[PATCH 03/20] drm/amdgpu: add module parameters for ras

2019-03-05 Thread Alex Deucher
From: xinhui pan Allow RAS feature enable/disable via boot parameter. Signed-off-by: xinhui pan Reviewed-by: Hawking Zhang Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 17

[PATCH 15/20] drm/amdgpu: Add a new flag to AMDGPU_CTX_OP_QUERY_STATE2

2019-03-05 Thread Alex Deucher
From: xinhui pan Add AMDGPU_CTX_QUERY2_FLAGS_RAS_CE/UE which indicate if any error happened between previous query and this query. Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 17 +

[PATCH 14/20] drm/amdgpu: enable ras on gmc9

2019-03-05 Thread Alex Deucher
From: xinhui pan Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 2 + drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 276 2 files changed, 278 insertions(+) diff --git

[PATCH 04/20] drm/amdgpu: add ta_ras_if.h

2019-03-05 Thread Alex Deucher
From: xinhui pan Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/ta_ras_if.h | 108 + 1 file changed, 108 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/ta_ras_if.h diff --git

[PATCH 06/20] drm/amdgpu: add psp ras subsystem infrastructure (v2)

2019-03-05 Thread Alex Deucher
From: xinhui pan Add ras fw loading, init, terminate. Add ras cmd submit helper. Add ras feature enable/disable common function. v2: squash in unused variable warning fix Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher ---

[PATCH 13/20] drm/amdgpu: enable ras on gfx9 (v2)

2019-03-05 Thread Alex Deucher
From: Feifei Xu Register ecc interrupts and ecc interrupt handler on gfx9. Add ras support on gfx9 v2: squash in warning fix Signed-off-by: Feifei Xu Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 +

[PATCH 05/20] drm/amdgpu: add psp ras callback func and macro

2019-03-05 Thread Alex Deucher
From: xinhui pan Define the driver side interface for ras ta. Acked-by: Hawking Zhang Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH 02/20] drm/amdgpu: export ta fw info

2019-03-05 Thread Alex Deucher
From: xinhui pan Output the ta fw, aka xgmi/ras, via debugfs. Signed-off-by: xinhui pan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 21 + include/uapi/drm/amdgpu_drm.h | 1 + 2 files changed, 22

[PATCH v2] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread Andrey Grodzovsky
For each device a file xgmi_device_id is created. On the first device a subdirectory named xgmi_hive_info is created, It contains a file named hive_id and symlinks named node 1-4 linking to each device in the hive. v2: Return error codes instead of '-1' and few misspellings. Signed-off-by:

[PATCH] drm/amdkfd: Fix "-Wmisleading-indentation" warning

2019-03-05 Thread sunpeng.li
From: Leo Li The following warning is seen during compile: ./include/linux/idr.h:212:2: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation] for ((entry) = idr_get_next((idr), &(id)); \ ^ drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_events.c:1038:3: note: in expansion of

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread Grodzovsky, Andrey
In each /sys/class/drm/cardX/device/ device you will see the following xgmi_device_id /* contains the device id within the hive */ xgmi_hive_info -> ../../../../:00:01.1/:02:00.0/:03:00.0/:04:00.0/xgmi_hive_info/ /* hive info folder */ inside xgmi_hive_info are back pointers to

Re: [PATCH] drm/amd/display: don't call dm_pp_ function from an fpu block

2019-03-05 Thread Wentland, Harry
On 2019-02-26 4:24 p.m., Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v4.20.12, v4.19.25,

Re: randr: Virtual monitor not present with MST display

2019-03-05 Thread Alex Deucher
On Tue, Mar 5, 2019 at 1:16 PM Paul Menzel wrote: > > Dear Linux folks, > > > Using the MST display Dell UP3214Q (two panels) with an AMD system, > the virtual monitor object is not created. GDM and Xfce consider both > panels as separate screens (`xrandr --listmonitors`). > > [0.00]

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread Koenig, Christian
Am 05.03.19 um 19:36 schrieb Grodzovsky, Andrey: > On 3/5/19 1:26 PM, Koenig, Christian wrote: >> Am 05.03.19 um 19:24 schrieb Grodzovsky, Andrey: >>> On 3/5/19 1:18 PM, Koenig, Christian wrote: Am 05.03.19 um 18:47 schrieb Andrey Grodzovsky: > For each device a file xgmi_device_id is

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread Grodzovsky, Andrey
On 3/5/19 1:26 PM, Koenig, Christian wrote: > Am 05.03.19 um 19:24 schrieb Grodzovsky, Andrey: >> On 3/5/19 1:18 PM, Koenig, Christian wrote: >>> Am 05.03.19 um 18:47 schrieb Andrey Grodzovsky: For each device a file xgmi_device_id is created. On the first device a subdirectory named

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread Koenig, Christian
Am 05.03.19 um 19:24 schrieb Grodzovsky, Andrey: > On 3/5/19 1:18 PM, Koenig, Christian wrote: >> Am 05.03.19 um 18:47 schrieb Andrey Grodzovsky: >>> For each device a file xgmi_device_id is created. >>> On the first device a subdirectory named xgmi_hive_info is created, >>> It contains a file

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread Grodzovsky, Andrey
On 3/5/19 1:18 PM, Koenig, Christian wrote: > Am 05.03.19 um 18:47 schrieb Andrey Grodzovsky: >> For each device a file xgmi_device_id is created. >> On the first device a subdirectory named xgmi_hive_info is created, >> It contains a file named hive_id and symlinks named node 1-4 linking >> to

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread StDenis, Tom
Couple of comments inline. Since I don't have any XGMI gear it would probably help to see what the final directory layout/contents look like so I can update umr to automagically scan all of this. Tom On 2019-03-05 12:47 p.m., Andrey Grodzovsky wrote: > For each device a file xgmi_device_id is

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread Koenig, Christian
Am 05.03.19 um 18:47 schrieb Andrey Grodzovsky: > For each device a file xgmi_device_id is created. > On the first device a subdirectory named xgmi_hive_info is created, > It contains a file named hive_id and symlinks named node 1-4 linking > to each device in the hive. > > Signed-off-by: Andrey

randr: Virtual monitor not present with MST display

2019-03-05 Thread Paul Menzel
Dear Linux folks, Using the MST display Dell UP3214Q (two panels) with an AMD system, the virtual monitor object is not created. GDM and Xfce consider both panels as separate screens (`xrandr --listmonitors`). [0.00] Linux version 4.20.13.mx64.248 (r...@holidayincambodia.molgen.mpg.de)

[PATCH 2/3] drm/amdgpu: support userptr cross VMAs case with HMM

2019-03-05 Thread Yang, Philip
userptr may cross two VMAs if the forked child process (not call exec after fork) malloc buffer, then free it, and then malloc larger size buf, kerenl will create new VMA adjacent to old VMA which was cloned from parent process, some pages of userptr are in the first VMA, the rest pages are in the

[PATCH 1/3] drm/amdkfd: support concurrent userptr update for HMM

2019-03-05 Thread Yang, Philip
Userptr restore may have concurrent userptr invalidation after hmm_vma_fault adds the range to the hmm->ranges list, needs call hmm_vma_range_done to remove the range from hmm->ranges list first, then reschedule the restore worker. Otherwise hmm_vma_fault will add same range to the list, this will

[PATCH 0/3] handle userptr corner cases with HMM path

2019-03-05 Thread Yang, Philip
Those corner cases are found by kfdtest.KFDIPCTest. Philip Yang (3): drm/amdkfd: support concurrent userptr update for HMM drm/amdgpu: support userptr cross VMAs case with HMM drm/amdgpu: more descriptive message if HMM not enabled .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 28 +++-

[PATCH 3/3] drm/amdgpu: more descriptive message if HMM not enabled

2019-03-05 Thread Yang, Philip
If using old kernel config file, CONFIG_ZONE_DEVICE is not selected, so CONFIG_HMM and CONFIG_HMM_MIRROR is not enabled, the current driver error message "Failed to register MMU notifier" is not clear. Inform user with more descriptive message on how to fix the missing kernel config option.

[PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

2019-03-05 Thread Andrey Grodzovsky
For each device a file xgmi_device_id is created. On the first device a subdirectory named xgmi_hive_info is created, It contains a file named hive_id and symlinks named node 1-4 linking to each device in the hive. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c |

Re: [PATCH] drm/amd/display: Don't ASSERT when total_planes == AMDGPU_MAX_PLANES

2019-03-05 Thread Michel Dänzer
On 2019-03-05 6:24 p.m., Nicholas Kazlauskas wrote: > [Why] > Can happen on ASICs with 6 planes, but this isn't a bug since we haven't > written outside the array. > > [How] > Use <= instead of <. > > Cc: Leo Li > Cc: Michel Dänzer > Reported-by: Michel Dänzer > Signed-off-by: Nicholas

[PATCH] drm/amd/display: Don't ASSERT when total_planes == AMDGPU_MAX_PLANES

2019-03-05 Thread Nicholas Kazlauskas
[Why] Can happen on ASICs with 6 planes, but this isn't a bug since we haven't written outside the array. [How] Use <= instead of <. Cc: Leo Li Cc: Michel Dänzer Reported-by: Michel Dänzer Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1

Re: [PATCH 06/18] drm/amd/display: Drop underlay plane support

2019-03-05 Thread Kazlauskas, Nicholas
On 3/5/19 12:09 PM, Michel Dänzer wrote: > On 2019-02-25 11:46 p.m., Bhawanpreet Lakha wrote: >> From: Nicholas Kazlauskas >> >> [Why] >> Primary and underlay planes were previously exposed to DRM by using >> max_planes and max_slave_planes. >> >> The value for max_planes was always pipe_count +

Re: [PATCH 06/18] drm/amd/display: Drop underlay plane support

2019-03-05 Thread Michel Dänzer
On 2019-02-25 11:46 p.m., Bhawanpreet Lakha wrote: > From: Nicholas Kazlauskas > > [Why] > Primary and underlay planes were previously exposed to DRM by using > max_planes and max_slave_planes. > > The value for max_planes was always pipe_count + has_underlay. > If there was an underlay pipe,

Re: [PATCH] drm/amd/display: Drop atomic_obj_lock for private obj

2019-03-05 Thread Li, Sun peng (Leo)
On 2019-03-05 9:14 a.m., Nicholas Kazlauskas wrote: > [Why] > New DRM versions manage locking for private objects for us, so this > is no longer needed. > > This also prevents a WARN_ON from occurring when the private object is > duplicated during the forced atomic commit that occurs from the

[PATCH libdrm] amdgpu: add marketing name for AMD Radeon VII

2019-03-05 Thread Alex Deucher
Signed-off-by: Alex Deucher --- data/amdgpu.ids | 1 + 1 file changed, 1 insertion(+) diff --git a/data/amdgpu.ids b/data/amdgpu.ids index d24c7ee6..f61497e4 100644 --- a/data/amdgpu.ids +++ b/data/amdgpu.ids @@ -45,6 +45,7 @@ 6665, 83, AMD Radeon (TM) R5 M320 6667, 0, AMD Radeon

[PATCH] drm/amdgpu: XGMI pstate switch initial support

2019-03-05 Thread Liu, Shaoyun
Driver vote low to high pstate switch whenever there is an outstanding XGMI mapping request. Driver vote high to low pstate when all the outstanding XGMI mapping is terminated. Change-Id: I499fb1c389077632fe9cfce4b6dc9a33deff6875 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

Re: [PATCH] drm/amdkfd: Add curly braces around idr_for_each_entry_continue loop

2019-03-05 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Tuesday, March 5, 2019 6:20 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdkfd: Add curly braces around idr_for_each_entry_continue loop From: Michel Dänzer The compiler

Re: [PATCH] drm/amdgpu: Enable XGMI mapping for peer device

2019-03-05 Thread Christian König
Am 05.03.19 um 16:49 schrieb Liu, Shaoyun: Adjust vram base offset for XGMI mapping when update the PT entry so the address will fall into correct XGMI aperture for peer device Change-Id: I78bdf244da699d2559481ef5afe9663b3e752236 Signed-off-by: shaoyunl Reviewed-by: Christian König ---

RE: [PATCH 2/2] drm/amdgpu: let amdgpu_vm_clear_bo figure out ats status v2

2019-03-05 Thread Zeng, Oak
Acked-by: Oak Zeng Regards, Oak -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Monday, March 4, 2019 11:28 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: let amdgpu_vm_clear_bo figure out ats status v2 Instead of providing it from outside

[PATCH] drm/amdgpu: Enable XGMI mapping for peer device

2019-03-05 Thread Liu, Shaoyun
Adjust vram base offset for XGMI mapping when update the PT entry so the address will fall into correct XGMI aperture for peer device Change-Id: I78bdf244da699d2559481ef5afe9663b3e752236 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 13 + 1 file changed, 9

Re: [PATCH] drm/amdgpu: reroute VMC and UMD to IH ring 1

2019-03-05 Thread Christian König
Oh, indeed. Nobody noticed so far and the patch is already committed. Christian. Am 05.03.19 um 16:25 schrieb Zeng, Oak: Is the "UMD" in the title a typo? From the comments in the code it is "UMC" Regards, Oak -Original Message- From: amd-gfx On Behalf Of Christian König Sent:

Re: [PATCH] drm/amd/amdgpu: Add ENGINE_CNTL register to vcn10 headers

2019-03-05 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Tom St Denis Sent: Tuesday, March 5, 2019 10:17 AM To: amd-gfx mailing list Subject: Re: [PATCH] drm/amd/amdgpu: Add ENGINE_CNTL register to vcn10 headers Hi, Alex can I get an RB on this :-) Thanks, Tom

RE: [PATCH] drm/amdgpu: reroute VMC and UMD to IH ring 1

2019-03-05 Thread Zeng, Oak
Is the "UMD" in the title a typo? From the comments in the code it is "UMC" Regards, Oak -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Monday, March 4, 2019 8:15 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: reroute VMC and UMD to IH ring 1

Re: [PATCH] drm/amd/amdgpu: Add ENGINE_CNTL register to vcn10 headers

2019-03-05 Thread Tom St Denis
Hi, Alex can I get an RB on this :-) Thanks, Tom On Mon, Mar 4, 2019 at 10:59 AM StDenis, Tom wrote: > Signed-off-by: Tom St Denis > --- > drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h | 2 ++ > drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h | 5 + > 2 files

[PATCH] drm/amd/display: Drop atomic_obj_lock for private obj

2019-03-05 Thread Nicholas Kazlauskas
[Why] New DRM versions manage locking for private objects for us, so this is no longer needed. This also prevents a WARN_ON from occurring when the private object is duplicated during the forced atomic commit that occurs from the HPD handler. The HPD handler calls drm_modeset_lock_all before the

[bug report] drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov

2019-03-05 Thread Dan Carpenter
Hello wentalou, The patch 2c11ee6ae553: "drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov" from Jan 30, 2019, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c:270 xgpu_ai_mailbox_flr_work() warn: impossible

[PATCH] drm/amdkfd: Add curly braces around idr_for_each_entry_continue loop

2019-03-05 Thread Michel Dänzer
From: Michel Dänzer The compiler pointed out that one if block unintentionally wasn't part of the loop: In file included from ./include/linux/kernfs.h:14, from ./include/linux/sysfs.h:16, from ./include/linux/kobject.h:20, from

Re: [PATCH] drm/amdgpu: fix kernel Oops caused by change_bit in ARM64

2019-03-05 Thread Christian König
Am 05.03.19 um 03:37 schrieb 周磊: I got this kernel Oops when running ROCm kernel in a ARM64 machine with Vega64 card. --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

Re: [PATCH] drm/amdgpu: Enable XGMI mapping for peer device

2019-03-05 Thread Christian König
Am 05.03.19 um 00:27 schrieb Liu, Shaoyun: Adjust vram base offset for XGMI mapping when update the PT entry so the address will fall into correct XGMI aperture for peer device Change-Id: I78bdf244da699d2559481ef5afe9663b3e752236 Signed-off-by: shaoyunl ---