Reviewed-by: feifei...@amd.com
-Original Message-
From: amd-gfx On Behalf Of Cui, Flora
Sent: Monday, July 1, 2019 11:37 AM
To: amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH v4] drm/amdgpu: fix scheduler timeout calc
scheduler timeout is in jiffies
v2: move timeout check
Ping...
Could anyone give me a rb?
-Original Message-
From: Cui, Flora
Sent: Thursday, July 4, 2019 11:09 AM
To: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH v4] drm/amdgpu: fix scheduler timeout calc
Ping...
-Original Message-
From: Cui, Flora
Sent: Monday, July 1, 2019
okay, thanks.
Best Regards,
Kevin
From: Zhang, Hawking
Sent: Friday, July 5, 2019 1:02:08 PM
To: Wang, Kevin(Yang); amd-gfx@lists.freedesktop.org
Cc: Xiao, Jack; kenenth.f...@amd.com
Subject: RE: [PATCH] drm/amdgpu: add mode1 (psp) reset for navi asic
if (smu_baco_is_support(smu)) {
ret = smu_baco_reset(smu);
+ } else {
+ ret = nv_asic_mode1_reset(adev);
}
We don’t need {} for single statements. With that fixed, the patch is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original
add mode1 (by psp) reset for navi asic.
Change-Id: Id2e7cb11eb7026296d1488c7c39f895b100f206c
Signed-off-by: Kevin Wang
---
drivers/gpu/drm/amd/amdgpu/nv.c | 35 +
1 file changed, 35 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c
On Sun, Jun 16, 2019 at 04:43:10PM +0200, Yrjan Skrimstad wrote:
> That is an interesting observation to me. I am actually running
> lm-sensors, although only every 15 seconds. I suppose that this might
> be the reason this happens to me.
Though I don't think this should reasonably cause problems
On Thu, Jul 04, 2019 at 03:05:12PM -0400, sunpeng...@amd.com wrote:
> From: Leo Li
>
> This can be used to create more descriptive symlinks for MST aux
> devices. Consider the following udev rule:
>
> SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{mstpath}=="?*",
>
From: Leo Li
Implement late_register and early_unregister hooks for MST connectors.
Call drm helpers for MST connector registration, which registers the
AUX devices.
Cc: Ben Skeggs
Signed-off-by: Leo Li
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 20
1 file changed, 20
From: Leo Li
Set the connector's kernel device as the parent for the aux kernel
device. This allows udev rules to access connector attributes when
creating symlinks to aux devices.
For example, the following udev rule:
SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{edid}=="*",
From: Leo Li
Hi all,
Here's the second revision of patches to enable mst aux devices.
v2 fixes an aux device unregistration issue during driver unload. See
patch 2/10 for details. Consequently, drivers supporting mst are
modified to use the new mst connector late register and early unregister
From: Leo Li
Set the connector's kernel device as the parent for the aux kernel
device. This allows udev rules to access connector attributes when
creating symlinks to aux devices.
To do so, the connector needs to be registered beforehand. Therefore,
shift aux registration to be after connector
From: Leo Li
Implement late_register and early_unregister hooks for MST connectors.
Call drm helpers for MST connector registration, which registers the
AUX devices.
Cc: Alex Deucher
Signed-off-by: Leo Li
---
drivers/gpu/drm/radeon/radeon_dp_mst.c | 22 ++
1 file changed,
From: Leo Li
Implement late_register and early_unregister hooks for MST connectors.
Call drm helpers for MST connector registration, which registers the
AUX devices.
Signed-off-by: Leo Li
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 29 +++--
1 file changed, 27
From: Ville Syrjälä
All available downstream ports - physical and logical - are exposed for
each MST device. They are listed in /dev/, following the same naming
scheme as SST devices by appending an incremental ID.
Although all downstream ports are exposed, only some will work as
expected.
From: Leo Li
In preparation for adding aux devices for DP MST, make the IDR
non-cyclic. That way, hotplug cycling MST devices won't needlessly
increment the minor version index.
Signed-off-by: Leo Li
Reviewed-by: Lyude Paul
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_dp_aux_dev.c | 3
From: Leo Li
Set the connector's kernel device as the parent for the aux kernel
device. This allows udev rules to access connector attributes when
creating symlinks to aux devices.
Cc: Ben Skeggs
Signed-off-by: Leo Li
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
1 file changed, 1
From: Leo Li
This can be used to create more descriptive symlinks for MST aux
devices. Consider the following udev rule:
SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{mstpath}=="?*",
SYMLINK+="drm_dp_aux/by-path/$attr{mstpath}"
The following symlinks will be created (depending
From: Leo Li
Implement late_register and early_unregister hooks for MST connectors.
Call drm helpers for MST connector registration, which registers the
AUX devices.
Cc: Jerry Zuo
Cc: Nicholas Kazlauskas
Signed-off-by: Leo Li
---
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 24
On 2019-07-04 1:16 p.m., Yang, Philip wrote:
> On 2019-07-04 12:02 p.m., Kuehling, Felix wrote:
>> On 2019-07-03 6:19 p.m., Yang, Philip wrote:
>>> amdgpu_noretry default value is 0, this will generate VM fault storm
>>> because the vm fault is not recovered. It may slow down the machine and
>>>
On 2019-07-04 12:02 p.m., Kuehling, Felix wrote:
> On 2019-07-03 6:19 p.m., Yang, Philip wrote:
>> amdgpu_noretry default value is 0, this will generate VM fault storm
>> because the vm fault is not recovered. It may slow down the machine and
>> need reboot after application VM fault. Maybe
On 04/07/2019 17:22, walter harms wrote:
>
>
> Am 04.07.2019 16:23, schrieb Colin King:
>> From: Colin Ian King
>>
>> Currently the check of the asic_type is always returning true because
>> of the use of ||. Fix this by using && instead. Also break overly
>> wide line.
>>
>>
Am 04.07.2019 16:23, schrieb Colin King:
> From: Colin Ian King
>
> Currently the check of the asic_type is always returning true because
> of the use of ||. Fix this by using && instead. Also break overly
> wide line.
>
> Addresses-Coverity: ("Constant expression result")
> Fixes:
From: Boyuan Zhang
Set all jpeg encode ring function pointers.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 38 +++
1 file changed, 38 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
From: Boyuan Zhang
Add jpeg encode related dpg handling.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
From: Boyuan Zhang
Add AMDGPU_RING_TYPE_VCN_JPEG_ENC ring define
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
From: Boyuan Zhang
Add and set internal and external offsets of jpeg_enc_scratch0 for ring test
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 1 +
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 3 +++
2 files changed, 4 insertions(+)
diff
From: Boyuan Zhang
Add an IB test for jpeg encode.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 76 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 1 +
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +-
3 files
From: Boyuan Zhang
Add a ring test for jpeg encode.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 29 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 ++
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +-
3 files
From: Boyuan Zhang
Enable the jpeg encode IB test.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
From: Boyuan Zhang
Start jpeg encode block, set system interrupt, and initialize registers.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 33 +++
1 file changed, 33 insertions(+)
diff --git
From: Boyuan Zhang
Add software and hardware init for jpeg encode ring.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
From: Boyuan Zhang
Add jpeg enc ring.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
index
From: Boyuan Zhang
Add jpeg encode registers offsets.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
From: Boyuan Zhang
Add AMDGPU_HW_IP_VCN_JPEG_ENC type to info query
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
From: Boyuan Zhang
Add AMDGPU_HW_IP_VCN_JPEG_ENC type to ctx
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
From: Boyuan Zhang
Implement all ring functions needed for jpeg encode ring.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 267 ++
1 file changed, 267 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
From: Boyuan Zhang
Add AMDGPU_HW_IP_VCN_JPEG_ENC type for jpeg encode CS in drm header
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
include/uapi/drm/amdgpu_drm.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/drm/amdgpu_drm.h
From: Boyuan Zhang
Add irq support for jpeg encode ring.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
From: Boyuan Zhang
Add software and hardware fini for jpeg encode ring.
Signed-off-by: Boyuan Zhang
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 ++
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 3 +++
2 files changed, 5 insertions(+)
diff --git
On 2019-07-03 6:19 p.m., Yang, Philip wrote:
> amdgpu_noretry default value is 0, this will generate VM fault storm
> because the vm fault is not recovered. It may slow down the machine and
> need reboot after application VM fault. Maybe change default value to 1?
This is the same as the current
From: Colin Ian King
Currently the check of the asic_type is always returning true because
of the use of ||. Fix this by using && instead. Also break overly
wide line.
Addresses-Coverity: ("Constant expression result")
Fixes: dab70ff24db6 ("drm/amdgpu/psp: add psp support for navi14")
Acked-by: Andrey Grodzovsky
Andrey
On 7/3/19 11:09 PM, Pan, Xinhui wrote:
> Perform a ras_suspend to disable ras on all IPs to workaround
> some ROCm stability issue.
>
> Signed-off-by: xinhui pan
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4
> 1 file changed, 4 insertions(+)
Patches to silent retry faults are already on the mailing list.
But I need to get back from vacation to take a closer look at this once more.
Christian.
Am 04.07.2019 00:19 schrieb "Yang, Philip" :
amdgpu_noretry default value is 0, this will generate VM fault storm
because the vm fault is not
43 matches
Mail list logo
