Re: [PATCH] drm/amd/powerplay: add temperature sensor support for navi10

2019-07-05 Thread Alex Deucher
On Wed, Jul 3, 2019 at 11:02 PM Wang, Kevin(Yang) wrote: > > the hwmon interface need temperature sensor type support. > 1. SENSOR_HOTSPOT_TEMP > 2. SENSOR_EDGE_TEMP(SENSOR_GPU_TEMP) > 3. SENSOR_MEM_TEMP > > Change-Id: I3db762e4032072fae67c95b7ba6d62e20ae5bead > Signed-off-by: Kevin Wang > --- >

[PATCH] drm/amdgpu: properly guard DC support in navi code

2019-07-05 Thread Alex Deucher
Need to add appropriate ifdef. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index a090e3fdc762..ee39cb740d41 100644 --- a/drivers/gpu/drm/amd/amdgpu/nv.c

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-07-05 Thread Alex Deucher
On Thu, Jul 4, 2019 at 4:15 PM Yrjan Skrimstad wrote: > > On Sun, Jun 16, 2019 at 04:43:10PM +0200, Yrjan Skrimstad wrote: > > That is an interesting observation to me. I am actually running > > lm-sensors, although only every 15 seconds. I suppose that this might > > be the reason this happens

Re: [PATCH] drm/amdgpu/ttm: make some functions static

2019-07-05 Thread Kuehling, Felix
On 2019-07-05 4:22 p.m., Russell, Kent wrote: > How would we handle that? Having a revert on amd-kfd-staging? We can > ensure that amd-staging-dkms doesn't cherrypick it in, but since KFD > merges, it would be more complicated. You could manually edit the merge commit before submitting it.

Re: [PATCH v2 07/35] drm/amdgpu: Use kmemdup rather than duplicating its implementation

2019-07-05 Thread Alex Deucher
On Wed, Jul 3, 2019 at 1:13 PM Fuqian Huang wrote: > > kmemdup is introduced to duplicate a region of memory in a neat way. > Rather than kmalloc/kzalloc + memcpy, which the programmer needs to > write the size twice (sometimes lead to mistakes), kmemdup improves > readability, leads to smaller

Re: [PATCH] drm/amdgpu/ttm: make some functions static

2019-07-05 Thread Russell, Kent
How would we handle that? Having a revert on amd-kfd-staging? We can ensure that amd-staging-dkms doesn't cherrypick it in, but since KFD merges, it would be more complicated. Kent KENT RUSSELL Sr. Software Engineer | Linux Compute Kernel 1 Commerce Valley Drive East Markham, ON L3T 7X6 O +(1)

Re: [PATCH v3 21/22] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-05 Thread Alex Deucher
On Thu, Jul 4, 2019 at 9:17 AM Andrzej Pietrasiewicz wrote: > > W dniu 02.07.2019 o 22:54, Alex Deucher pisze: > > On Fri, Jun 28, 2019 at 12:31 PM Andrzej Pietrasiewicz > > wrote: > >> > >> Use the ddc pointer provided by the generic connector. > >> > >> Signed-off-by: Andrzej Pietrasiewicz >

Re: [PATCH] drm/amd/powerplay: add temperature sensor support for navi10

2019-07-05 Thread Alex Deucher
On Wed, Jul 3, 2019 at 11:02 PM Wang, Kevin(Yang) wrote: > > the hwmon interface need temperature sensor type support. > 1. SENSOR_HOTSPOT_TEMP > 2. SENSOR_EDGE_TEMP(SENSOR_GPU_TEMP) > 3. SENSOR_MEM_TEMP > > Change-Id: I3db762e4032072fae67c95b7ba6d62e20ae5bead > Signed-off-by: Kevin Wang

[PATCH] Fix EEH during kexec

2019-07-05 Thread KyleMahlkuch
During kexec some adapters hit an EEH since they are not properly shut down in the radeon_pci_shutdown() function. Adding radeon_suspend_kms() fixes this issue. Since radeon.h is now included in radeon_drv.c radeon_init() needs a new name. I chose radeon_initl(). This can be changed if there is

Re: [PATCH 1/1] drm/amdgpu: Prepare for hmm_range_register API change

2019-07-05 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kuehling, Felix Sent: Friday, July 5, 2019 3:50 PM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip; Kuehling, Felix Subject: [PATCH 1/1] drm/amdgpu: Prepare for hmm_range_register API change From: Philip

[PATCH 1/1] drm/amdgpu: Prepare for hmm_range_register API change

2019-07-05 Thread Kuehling, Felix
From: Philip Yang An upcoming change in the hmm_range_register API requires passing in a pointer to an hmm_mirror instead of mm_struct. To access the hmm_mirror we need pass bo instead of ttm to amdgpu_ttm_tt_get_user_pages because mirror is part of amdgpu_mn structure, which is accessible from

Re: [PATCH] drm/amdgpu/ttm: make some functions static

2019-07-05 Thread Kuehling, Felix
On 2019-07-05 1:12 p.m., Alex Deucher wrote: > Noticed while reviewing the code. > > Signed-off-by: Alex Deucher Reviewed-by: Felix Kuehling We'll need to be careful not to merge this change on amd-kfd-staging and amd-staging-dkms. On those branches, this function is called from

[PATCH] drm/amdgpu/ttm: make some functions static

2019-07-05 Thread Alex Deucher
Noticed while reviewing the code. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 6 -- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

Re: Where do I file AMDGPU bugs nowadays?

2019-07-05 Thread Deucher, Alexander
That is the correct bug tracker. Thanks, Alex From: amd-gfx on behalf of Kai-Heng Feng Sent: Thursday, July 4, 2019 4:05 AM To: amd-gfx list Subject: Where do I file AMDGPU bugs nowadays? Hi AMDGPU folks, I’ve filed a bug [1] a while back, but no response so

[PATCH v2] drm/sysfs: Add mstpath attribute to connector devices

2019-07-05 Thread sunpeng.li
From: Leo Li This can be used to create more descriptive symlinks for MST aux devices. Consider the following udev rule: SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{mstpath}=="?*", SYMLINK+="drm_dp_aux/by-path/$attr{mstpath}" The following symlinks will be created (depending

Re: [PATCH 03/10] drm/sysfs: Add mstpath attribute to connector devices

2019-07-05 Thread Li, Sun peng (Leo)
On 2019-07-04 3:33 p.m., Ville Syrjälä wrote: > On Thu, Jul 04, 2019 at 03:05:12PM -0400, sunpeng...@amd.com wrote: >> From: Leo Li >> >> This can be used to create more descriptive symlinks for MST aux >> devices. Consider the following udev rule: >> >> SUBSYSTEM=="drm_dp_aux_dev",

Re: [PATCH v3 01/22] drm: Include ddc adapter pointer in struct drm_connector

2019-07-05 Thread Andrzej Hajda
On 01.07.2019 16:41, Thomas Zimmermann wrote: > Hi > > Am 01.07.19 um 15:27 schrieb Andrzej Pietrasiewicz: >> Hi Thomas, >> >> Thank you for your comments. Please see inline. >> >> W dniu 30.06.2019 o 10:12, Thomas Zimmermann pisze: >>> Hi >>> >>> I like the idea, but would prefer a more

Where do I file AMDGPU bugs nowadays?

2019-07-05 Thread Kai-Heng Feng
Hi AMDGPU folks, I’ve filed a bug [1] a while back, but no response so far. I wonder if you still use BFO? Or do you migrate to another bug tracking system? [1]https://bugs.freedesktop.org/show_bug.cgi?id=110886 Kai-Heng ___ amd-gfx mailing list

Re: [PATCH v3 00/22] Associate ddc adapters with connectors

2019-07-05 Thread Andrzej Pietrasiewicz
W dniu 28.06.2019 o 18:11, Laurent Pinchart pisze: Hi Andrzej, Just FYI, I have a patch series that reworks how bridges and connectors are handled, and it will heavily conflict with this. The purpose of the two series isn't the same, so both make sense. I will post the patches this weekend, and

Re: [PATCH v3 21/22] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-05 Thread Andrzej Pietrasiewicz
W dniu 02.07.2019 o 22:54, Alex Deucher pisze: On Fri, Jun 28, 2019 at 12:31 PM Andrzej Pietrasiewicz wrote: Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 70 ++- 1 file

Re: [PATCH v3 00/22] Associate ddc adapters with connectors

2019-07-05 Thread Laurent Pinchart
Hi Andrzej, On Fri, Jul 05, 2019 at 10:38:27AM +0200, Andrzej Pietrasiewicz wrote: > W dniu 28.06.2019 o 18:11, Laurent Pinchart pisze: > > Hi Andrzej, > > > > Just FYI, I have a patch series that reworks how bridges and connectors > > are handled, and it will heavily conflict with this. The