RE: [PATCH 1/5] drm/amd/powerplay: move smu types to smu_types.h

2019-07-24 Thread Feng, Kenneth
Reviewed-by: Kenneth Feng -Original Message- From: Wang, Kevin(Yang) Sent: Thursday, July 25, 2019 1:11 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Huang, Ray ; Deucher, Alexander ; Wang, Kevin(Yang) Subject: [PATCH 1/5] drm/amd/powerplay: move smu types to smu_types.h

[PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

2019-07-24 Thread Wang, Kevin(Yang)
1. Unified feature enable status format in sysfs 2. Rename ppfeature to pp_features to adapt other pp sysfs node name 3. this function support all asic, not asic related function. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 24 +-- drivers/gpu/drm/amd/powerplay

[PATCH 4/5] drm/amd/powerplay: move smu_feature_update_enable_state to up level

2019-07-24 Thread Wang, Kevin(Yang)
this function is not ip or asic related function, so move it to top level as public api in smu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 40 ++- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 4 +- drivers/gpu/drm/amd/powerplay/smu_v11_0.c

[PATCH 3/5] drm/amd/powerplay: add smu feature name support

2019-07-24 Thread Wang, Kevin(Yang)
add smu_get_feature_name support in smu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 13 +++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/powerplay/inc/smu_types.h | 109 +- 3 files changed, 71 insertions(+), 52 del

[PATCH 2/5] drm/amd/powerplay: add smu message name support

2019-07-24 Thread Wang, Kevin(Yang)
add smu_get_message_name support in smu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 13 ++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/powerplay/inc/smu_types.h | 205 +- drivers/gpu/drm/amd/powerplay/smu_v11_0.c

[PATCH 1/5] drm/amd/powerplay: move smu types to smu_types.h

2019-07-24 Thread Wang, Kevin(Yang)
move some enum type (message, feature, clock) to smu_types.h. these types is too long in amdgpu_smu.h, and not clearly. Signed-off-by: Kevin Wang --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 186 +--- drivers/gpu/drm/amd/powerplay/inc/smu_types.h | 210 ++ 2 fi

撤回: [PATCH 1/5] drm/amd/powerplay: move smu types to smu_types.h

2019-07-24 Thread Wang, Kevin(Yang)
Wang, Kevin(Yang) 将撤回邮件“[PATCH 1/5] drm/amd/powerplay: move smu types to smu_types.h”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

撤回: [PATCH 2/5] drm/amd/powerplay: add smu message name support

2019-07-24 Thread Wang, Kevin(Yang)
Wang, Kevin(Yang) 将撤回邮件“[PATCH 2/5] drm/amd/powerplay: add smu message name support”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

撤回: [PATCH 4/5] drm/amd/powerplay: move smu_feature_update_enable_state to up level

2019-07-24 Thread Wang, Kevin(Yang)
Wang, Kevin(Yang) 将撤回邮件“[PATCH 4/5] drm/amd/powerplay: move smu_feature_update_enable_state to up level”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

撤回: [PATCH 3/5] drm/amd/powerplay: add smu feature name support

2019-07-24 Thread Wang, Kevin(Yang)
Wang, Kevin(Yang) 将撤回邮件“[PATCH 3/5] drm/amd/powerplay: add smu feature name support”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

撤回: [PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

2019-07-24 Thread Wang, Kevin(Yang)
Wang, Kevin(Yang) 将撤回邮件“[PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

2019-07-24 Thread Wang, Kevin(Yang)
1. Unified feature enable status format in sysfs 2. Rename ppfeature to pp_features to adapt other pp sysfs node name 3. this function support all asic, not asic related function. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 6 +- drivers/gpu/drm/amd/powerplay/

[PATCH 1/5] drm/amd/powerplay: move smu types to smu_types.h

2019-07-24 Thread Wang, Kevin(Yang)
move some enum type (message, feature, clock) to smu_types.h. these types is too long in amdgpu_smu.h, and not clearly. Signed-off-by: Kevin Wang --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 186 +--- drivers/gpu/drm/amd/powerplay/inc/smu_types.h | 210 ++ 2 fi

[PATCH 4/5] drm/amd/powerplay: move smu_feature_update_enable_state to up level

2019-07-24 Thread Wang, Kevin(Yang)
this function is not ip or asic related function, so move it to top level as public api in smu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 40 ++- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 4 +- drivers/gpu/drm/amd/powerplay/smu_v11_0.c

[PATCH 3/5] drm/amd/powerplay: add smu feature name support

2019-07-24 Thread Wang, Kevin(Yang)
add smu_get_feature_name support in smu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 13 +++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/powerplay/inc/smu_types.h | 109 +- 3 files changed, 71 insertions(+), 52 del

[PATCH 2/5] drm/amd/powerplay: add smu message name support

2019-07-24 Thread Wang, Kevin(Yang)
add smu_get_message_name support in smu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 13 ++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/powerplay/inc/smu_types.h | 205 +- drivers/gpu/drm/amd/powerplay/smu_v11_0.c

[PATCH] drm/amd/powerplay: fix null pointer dereference around dpm state relates

2019-07-24 Thread Evan Quan
DPM state relates are not supported on the new SW SMU ASICs. But still it's not OK to trigger null pointer dereference on accessing them. Change-Id: I368d108fbea438ed5d9e3b849d006ddd5308052b Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 18 +- drivers/

[PATCH] drm/amd/powerplay: minor fixes around SW SMU power and fan setting

2019-07-24 Thread Evan Quan
Add checking for possible invalid input and null pointer. And drop redundant code. Change-Id: I6ebd6acd944e821fb19af77ed1eaa8c4b1d407ce Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 22 ++--- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 24 +++---

[PATCH 2/2] drm/amd/powerplay: enable SW SMU reset functionality

2019-07-24 Thread Evan Quan
Move SMU irq handler register to sw_init as that's totally software related. Otherwise, it will prevent SMU reset working. Change-Id: Ibd3e48ae9a90ab57f42b3f2ddbb736deeebc8715 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 16 +--- 1 file changed, 9 inserti

RE: [PATCH 3/3] Revert "drm/amdgpu/powerplay/vega20: call PrepareMp1ForUnload in power_off_asic"

2019-07-24 Thread Quan, Evan
Series is reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Wednesday, July 24, 2019 10:44 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 3/3] Revert "drm/amdgpu/powerplay/vega20: call > PrepareMp1ForUnload

Re: [PATCH] drm/amd/amdgpu/vcn_v2_0: Set CMD_SOURCE for RB commands

2019-07-24 Thread Liu, Leo
Please separate the patches to 2 patches. i. e. New ring test as one patch. Regards, Leo From: amd-gfx on behalf of Thai, Thong Sent: July 24, 2019 3:50:47 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amd/amdgpu/vcn_v2_0: Set CMD_SOURCE for RB comm

[pull] amdgpu, ttm drm-fixes-5.3

2019-07-24 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.3. Mostly display fixes and a few power fixes for Navi. The following changes since commit 41a5a2a8531f95d18bb4efddea581ccb469e8ee5: drm/amd/display: init res_pool dccg_ref, dchub_ref with xtalin_freq (2019-07-18 14:12:08 -0500) are available in the Git reposito

Re: [PATCH 9/9] drm/amd/display: Implement MST Aux device registration

2019-07-24 Thread Li, Sun peng (Leo)
On 2019-07-24 4:05 p.m., Kazlauskas, Nicholas wrote: > On 7/23/19 7:28 PM, sunpeng...@amd.com wrote: >> From: Leo Li >> >> Implement late_register and early_unregister hooks for MST connectors. >> Call drm helpers for MST connector registration, which registers the >> AUX devices. >> >> Cc: Jerr

Re: [PATCH 9/9] drm/amd/display: Implement MST Aux device registration

2019-07-24 Thread Kazlauskas, Nicholas
On 7/23/19 7:28 PM, sunpeng...@amd.com wrote: > From: Leo Li > > Implement late_register and early_unregister hooks for MST connectors. > Call drm helpers for MST connector registration, which registers the > AUX devices. > > Cc: Jerry Zuo > Cc: Nicholas Kazlauskas > Cc: Harry Wentland > Sign

[PATCH] drm/amd/amdgpu/vcn_v2_0: Set CMD_SOURCE for RB commands

2019-07-24 Thread Thai, Thong
Sets the CMD_SOURCE bit for VCN 2.0 decoder ring-buffer commands. This bit was previously set by the RBC HW on older versions of the firmware, and now needs to be set by the driver in order to work with the SW RBC found in newer versions of the firmware. Signed-off-by: Thong Thai --- drivers/

Re: [PATCH v19 11/15] IB/mlx4: untag user pointers in mlx4_get_umem_mr

2019-07-24 Thread Jason Gunthorpe
On Tue, Jul 23, 2019 at 07:58:48PM +0200, Andrey Konovalov wrote: > This patch is a part of a series that extends kernel ABI to allow to pass > tagged user pointers (with the top byte set to something else other than > 0x00) as syscall arguments. > > mlx4_get_umem_mr() uses provided user pointers

Re: linux-next: Tree for Jul 24 (amdgpu)

2019-07-24 Thread Randy Dunlap
On 7/23/19 9:57 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190723: > on i386: CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.o ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c: In function ‘dcn20_init_hw’: ../drivers/gpu/drm/amd/amdgpu/../dis

Re: amdgpu errors reported with kernel 5.2.2 (was Re: Problem with kernel major than 4.15.x)

2019-07-24 Thread Gilberto Nunes
Thanks Yann to redirect to the proper lists! --- Gilberto Nunes Ferreira (47) 3025-5907 (47) 99676-7530 - Whatsapp / Telegram Skype: gilberto.nunes36 Em qua, 24 de jul de 2019 às 11:59, Yann Droneaud escreveu: > > Hi, > > Le mercredi 24 juillet 2019 à 09:43 -0300, Gilberto Nunes a écrit : >

[PATCH 2/2] drm/amdkfd: Remove dead code from gfx8/gfx9 trap handlers

2019-07-24 Thread Cornwall, Jay
Signed-off-by: Jay Cornwall --- .../gpu/drm/amd/amdkfd/cwsr_trap_handler_gfx8.asm | 395 + .../gpu/drm/amd/amdkfd/cwsr_trap_handler_gfx9.asm | 375 +-- 2 files changed, 5 insertions(+), 765 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/cwsr_trap_handl

Re: [PATCH v5 18/24] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Thomas Zimmermann
Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/ast/ast_mode.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/a

Re: [PATCH v5 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Thomas Zimmermann
Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/g

Re: [PATCH v5 02/24] drm: Add drm_connector_init() variant with ddc

2019-07-24 Thread Thomas Zimmermann
Hi Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz: > Allow passing ddc adapter pointer to the init function. Even if > drm_connector_init() sometime in the future decides to e.g. memset() all > connector fields to zeros, the newly added function ensures that at its > completion the ddc member

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-07-24 Thread Vincenzo Frascino
Hi Will and Andrey, On 24/07/2019 15:20, Will Deacon wrote: > On Wed, Jul 24, 2019 at 04:16:49PM +0200, Andrey Konovalov wrote: >> On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: >>> On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: On Tue, Jul 23, 2019 at 7:59 PM Andrey K

Re: kernel panic: stack is corrupted in pointer

2019-07-24 Thread John Fastabend
Dmitry Vyukov wrote: > On Tue, Jul 23, 2019 at 7:26 PM John Fastabend > wrote: > > > > Dmitry Vyukov wrote: > > > On Wed, Jul 17, 2019 at 10:58 AM syzbot > > > wrote: > > > > > > > > Hello, > > > > > > > > syzbot found the following crash on: > > > > > > > > HEAD commit:1438cde7 Add linux-ne

Re: [PATCH v4 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

2019-07-24 Thread Grodzovsky, Andrey
On 7/24/19 11:40 AM, Michel Dänzer wrote: > On 2019-07-24 5:27 p.m., Andrey Grodzovsky wrote: >> Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in >> amdgpu_bo_do_create into standalone helper so it can be reused >> in other functions. >> >> v4: >> Switch to return bool. >> >> Signed-off-b

Re: [PATCH v4 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

2019-07-24 Thread Michel Dänzer
On 2019-07-24 5:27 p.m., Andrey Grodzovsky wrote: > Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in > amdgpu_bo_do_create into standalone helper so it can be reused > in other functions. > > v4: > Switch to return bool. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/

amdgpu errors reported with kernel 5.2.2 (was Re: Problem with kernel major than 4.15.x)

2019-07-24 Thread Yann Droneaud
Hi, Le mercredi 24 juillet 2019 à 09:43 -0300, Gilberto Nunes a écrit : > > Right now, I booted my laptop with kernel > Linux version 5.2.2-050202-generic (kernel@kathleen) (gcc version > 9.1.0 (Ubuntu 9.1.0-9ubuntu2)) #201907231250 SMP Tue Jul 23 12:53:21 > UTC 2019 > > The system boot slowly,

[PATCH v4 4/4] drm/amd/display: enable S/G for RAVEN chip

2019-07-24 Thread Andrey Grodzovsky
From: Shirish S enables gpu_vm_support in dm and adds AMDGPU_GEM_DOMAIN_GTT as supported domain v2: Move BO placement logic into amdgpu_display_supported_domains v3: Use amdgpu_bo_validate_uswc in amdgpu_display_supported_domains. v4: v2+v3 moved to standalone patch. Change-Id: If34300beaa60b

[PATCH v4 3/4] drm/amdgpu: Add check for USWC support for amdgpu_display_supported_domains

2019-07-24 Thread Andrey Grodzovsky
This verifies we don't add GTT as allowed domnain for APUs when USWC is disabled. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gp

[PATCH v4 1/4] drm/amdgpu: Fix hard hang for S/G display BOs.

2019-07-24 Thread Andrey Grodzovsky
HW requires for caching to be unset for scanout BO mappings when the BO placement is in GTT memory. Usually the flag to unset is passed from user mode but for FB mode this was missing. v2: Keep all BO placement logic in amdgpu_display_supported_domains Suggested-by: Alex Deucher Signed-off-by: A

[PATCH v4 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

2019-07-24 Thread Andrey Grodzovsky
Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in amdgpu_bo_do_create into standalone helper so it can be reused in other functions. v4: Switch to return bool. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 61 +- drivers/gp

[PATCH v4 0/4] Enable S/G for Picasso

2019-07-24 Thread Andrey Grodzovsky
First patches fixes a hard hang introduced by placing the display BO in GTT memory because of HW issues with cached mappings. Second patch does some minor reafactoring to resue code in thrid patch. Third patch adds check for USWC support as condition to placing APUs scanout BO in GTT. Last patch e

Re: [PATCH v3 1/3] drm/amdgpu: Fix hard hang for S/G display BOs.

2019-07-24 Thread Michel Dänzer
Just some cosmetic notes on this one: On 2019-07-24 4:10 p.m., Andrey Grodzovsky wrote: > HW requires for caching to be unset for scanout BO > mappings when the BO placement is in GTT memory. > Usually the flag to unset is passed from user mode > but for FB mode this was missing. > > v2: > Move

Re: [PATCH v3 3/3] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Koenig, Christian
Am 24.07.19 um 16:52 schrieb Grodzovsky, Andrey: > On 7/24/19 10:50 AM, Michel Dänzer wrote: >> On 2019-07-24 4:41 p.m., Koenig, Christian wrote: >>> Am 24.07.19 um 16:32 schrieb Grodzovsky, Andrey: On 7/24/19 10:25 AM, Koenig, Christian wrote: > Am 24.07.19 um 16:10 schrieb Andrey Grodzov

Re: [PATCH v3 3/3] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Grodzovsky, Andrey
On 7/24/19 10:50 AM, Michel Dänzer wrote: > On 2019-07-24 4:41 p.m., Koenig, Christian wrote: >> Am 24.07.19 um 16:32 schrieb Grodzovsky, Andrey: >>> On 7/24/19 10:25 AM, Koenig, Christian wrote: Am 24.07.19 um 16:10 schrieb Andrey Grodzovsky: > From: Shirish S > > enables gpu_vm

Re: [PATCH v3 3/3] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Michel Dänzer
On 2019-07-24 4:41 p.m., Koenig, Christian wrote: > Am 24.07.19 um 16:32 schrieb Grodzovsky, Andrey: >> On 7/24/19 10:25 AM, Koenig, Christian wrote: >>> Am 24.07.19 um 16:10 schrieb Andrey Grodzovsky: From: Shirish S enables gpu_vm_support in dm and adds AMDGPU_GEM_DOMAIN_GTT

Re: [PATCH v3 3/3] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Grodzovsky, Andrey
AMDGPU On 7/24/19 10:41 AM, Koenig, Christian wrote: > Am 24.07.19 um 16:32 schrieb Grodzovsky, Andrey: >> On 7/24/19 10:25 AM, Koenig, Christian wrote: >>> Am 24.07.19 um 16:10 schrieb Andrey Grodzovsky: From: Shirish S enables gpu_vm_support in dm and adds AMDGPU_GEM_DOMAIN_

[PATCH 3/3] Revert "drm/amdgpu/powerplay/vega20: call PrepareMp1ForUnload in power_off_asic"

2019-07-24 Thread Alex Deucher
This reverts commit c3b099f18c45bd8d78a51a706c648d588321c19c. Revert for now pending further discussions with power team. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmg

[PATCH 2/3] Revert "drm/amdgpu/powerplay/vega10: call PrepareMp1ForUnload in power_off_asic"

2019-07-24 Thread Alex Deucher
This reverts commit 85cde3f880092bd5a21760ebe7baaa4d6af389a9. Revert for now pending further discussions with power team. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmg

[PATCH 1/3] Revert "drm/amdgpu/powerplay/vega12: call PrepareMp1ForUnload in power_off_asic"

2019-07-24 Thread Alex Deucher
This reverts commit bc43468457623b3f772f14383455e2abddbaddaf. Revert for now pending further discussions with power team. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmg

Re: [PATCH v3 3/3] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Koenig, Christian
Am 24.07.19 um 16:32 schrieb Grodzovsky, Andrey: > On 7/24/19 10:25 AM, Koenig, Christian wrote: >> Am 24.07.19 um 16:10 schrieb Andrey Grodzovsky: >>> From: Shirish S >>> >>> enables gpu_vm_support in dm and adds >>> AMDGPU_GEM_DOMAIN_GTT as supported domain >>> >>> v2: >>> Move BO placement logi

Re: [PATCH v3 2/3] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

2019-07-24 Thread Grodzovsky, Andrey
On 7/24/19 10:24 AM, Michel Dänzer wrote: > On 2019-07-24 4:10 p.m., Andrey Grodzovsky wrote: >> Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in >> amdgpu_bo_do_create into standalone helper so it can be reused >> in other functions. >> >> Signed-off-by: Andrey Grodzovsky >> --- >> [.

Re: [PATCH v3 3/3] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Grodzovsky, Andrey
On 7/24/19 10:25 AM, Koenig, Christian wrote: > Am 24.07.19 um 16:10 schrieb Andrey Grodzovsky: >> From: Shirish S >> >> enables gpu_vm_support in dm and adds >> AMDGPU_GEM_DOMAIN_GTT as supported domain >> >> v2: >> Move BO placement logic into amdgpu_display_supported_domains >> >> v3: >> Use a

Re: [PATCH v3 2/3] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

2019-07-24 Thread Koenig, Christian
Am 24.07.19 um 16:10 schrieb Andrey Grodzovsky: > Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in > amdgpu_bo_do_create into standalone helper so it can be reused > in other functions. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 63 > +

Re: [PATCH v3 3/3] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Koenig, Christian
Am 24.07.19 um 16:10 schrieb Andrey Grodzovsky: > From: Shirish S > > enables gpu_vm_support in dm and adds > AMDGPU_GEM_DOMAIN_GTT as supported domain > > v2: > Move BO placement logic into amdgpu_display_supported_domains > > v3: > Use amdgpu_bo_validate_uswc in amdgpu_display_supported_domains.

Re: [PATCH v3 2/3] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

2019-07-24 Thread Michel Dänzer
On 2019-07-24 4:10 p.m., Andrey Grodzovsky wrote: > Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in > amdgpu_bo_do_create into standalone helper so it can be reused > in other functions. > > Signed-off-by: Andrey Grodzovsky > --- > [...] > > diff --git a/drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-07-24 Thread Will Deacon
On Wed, Jul 24, 2019 at 04:16:49PM +0200, Andrey Konovalov wrote: > On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: > > On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: > > > On Tue, Jul 23, 2019 at 7:59 PM Andrey Konovalov > > > wrote: > > > > > > > > === Overview > > > > >

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-07-24 Thread Andrey Konovalov
On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: > > Hi Andrey, > > On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: > > On Tue, Jul 23, 2019 at 7:59 PM Andrey Konovalov > > wrote: > > > > > > === Overview > > > > > > arm64 has a feature called Top Byte Ignore, which allows to

[PATCH v3 3/3] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Andrey Grodzovsky
From: Shirish S enables gpu_vm_support in dm and adds AMDGPU_GEM_DOMAIN_GTT as supported domain v2: Move BO placement logic into amdgpu_display_supported_domains v3: Use amdgpu_bo_validate_uswc in amdgpu_display_supported_domains. Change-Id: If34300beaa60be2d36170b7b5b096ec644502b20 Signed-off

[PATCH v3 2/3] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

2019-07-24 Thread Andrey Grodzovsky
Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in amdgpu_bo_do_create into standalone helper so it can be reused in other functions. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 63 +- drivers/gpu/drm/amd/amdgpu/amdgpu_obje

[PATCH v3 1/3] drm/amdgpu: Fix hard hang for S/G display BOs.

2019-07-24 Thread Andrey Grodzovsky
HW requires for caching to be unset for scanout BO mappings when the BO placement is in GTT memory. Usually the flag to unset is passed from user mode but for FB mode this was missing. v2: Move all BO placemnt logic to amdgpu_display_supported_domains Suggested-by: Alex Deucher Signed-off-by: An

[PATCH v3 0/3] Enable S/G for Picasso

2019-07-24 Thread Andrey Grodzovsky
First two patches fix a hard hang introduced by placing the display BO in GTT memory because of HW issues with cached mappings. Second patch does some minor reafactoring to resue code in thrid patch. Last patch enables S/G. Andrey Grodzovsky (2): drm/amdgpu: Fix hard hang for S/G display BOs.

[PATCH v5 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 141 +++-- 1 file changed, 105 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/r

[PATCH v5 24/24] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/i915/display/intel_hdmi.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/inte

[PATCH v5 21/24] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/ti-tfp410.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp41

[PATCH v5 20/24] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 --- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bri

[PATCH v5 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 95 ++- 1 file changed, 69 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/dr

[PATCH v5 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/du

[PATCH v5 18/24] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/ast/ast_mode.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index c792362024a5..1c8

[PATCH v5 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.

[PATCH v5 16/24] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index f03d617edc4c..33d06e0a916

[PATCH v5 15/24] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c index

[PATCH v5 14/24] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_vga.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c index 9b6

[PATCH v5 13/24] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_hdmi.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c index

[PATCH v5 12/24] drm/vc4: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/vc4/vc4_hdmi.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index ee

[PATCH v5 11/24] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-tve.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index 649515868f86..e25df

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-07-24 Thread Will Deacon
Hi Andrey, On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: > On Tue, Jul 23, 2019 at 7:59 PM Andrey Konovalov > wrote: > > > > === Overview > > > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > > tags into the top byte of each pointer. Userspace pr

[PATCH v5 09/24] drm/tegra: Provide ddc symlink in output connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tegra/drm.h| 1 - drivers/gpu/drm/tegra/hdmi.c | 7 --- drivers/gpu/drm/tegra/output.c | 12 ++-- drivers/gpu/drm/tegra/sor.c| 13 +++-- 4 files changed

[PATCH v5 10/24] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-ldb.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index de62a4cd482

[PATCH v5 06/24] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector

[PATCH v5 08/24] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c inde

[PATCH v5 07/24] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sun4i/sun4i_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 21 +++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/sun4i

[PATCH v5 04/24] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip

[PATCH v5 05/24] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/inno_hdmi.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno

[PATCH v5 03/24] drm/exynos: Provide ddc symlink in connector's sysfs

2019-07-24 Thread Andrzej Pietrasiewicz
Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdm

[PATCH v5 02/24] drm: Add drm_connector_init() variant with ddc

2019-07-24 Thread Andrzej Pietrasiewicz
Allow passing ddc adapter pointer to the init function. Even if drm_connector_init() sometime in the future decides to e.g. memset() all connector fields to zeros, the newly added function ensures that at its completion the ddc member of connector is correctly set. Signed-off-by: Andrzej Pietrasie

[PATCH v5 01/24] drm: Include ddc adapter pointer in struct drm_connector

2019-07-24 Thread Andrzej Pietrasiewicz
Add generic code which creates symbolic links in sysfs, pointing to ddc interface used by a particular video output. For example: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ -> ../../../../soc/1388.i2c/i2c-2 This ma

[PATCH v5 00/24] Associate ddc adapters with connectors

2019-07-24 Thread Andrzej Pietrasiewicz
It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have a symbolic link in connector's sysfs directory, e.g.: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0

Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Hi Thomas, W dniu 24.07.2019 o 10:01, Thomas Zimmermann pisze: Hi I think this echoes my concern about the implicit order of operation. It seems too easy to get this wrong. If you don't want to add an additional interface for setting the ddc field, why not add a dedicated initializer funct

Re: kernel panic: stack is corrupted in pointer

2019-07-24 Thread Dmitry Vyukov
On Tue, Jul 23, 2019 at 7:26 PM John Fastabend wrote: > > Dmitry Vyukov wrote: > > On Wed, Jul 17, 2019 at 10:58 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:1438cde7 Add linux-next specific files for 20190716 > > > git tree:

Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Thomas Zimmermann
Hi Am 23.07.19 um 14:44 schrieb Andrzej Pietrasiewicz: > Hi Sam, > > W dniu 23.07.2019 o 11:05, Sam Ravnborg pisze: >> Hi Andrzej >> >> On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: >>> Use the ddc pointer provided by the generic connector. >>> >>> Signed-off-by: Andrzej

Re: [PATCH 1/3] drm/amdgpu: Fix hard hang for S/G display BOs.

2019-07-24 Thread Michel Dänzer
On 2019-07-23 7:31 p.m., Grodzovsky, Andrey wrote: > On 7/23/19 12:18 PM, Michel Dänzer wrote: >> >> Anyway, this should be handled in amdgpu_display_supported_domains >> instead (e.g. by not allowing GTT if CONFIG_X86_32 is defined), > > > We have drm_arch_can_wc_memory function to cover all the

Re: [PATCH v2 2/2] drm/amd: enable S/G for RAVEN chip

2019-07-24 Thread Michel Dänzer
On 2019-07-23 8:25 p.m., Andrey Grodzovsky wrote: > From: Shirish S > > enables gpu_vm_support in dm and adds > AMDGPU_GEM_DOMAIN_GTT as supported domain > > v2: > Move BO placement logic into amdgpu_display_supported_domains > > Change-Id: If34300beaa60be2d36170b7b5b096ec644502b20 > Signed-off