[PATCH 1/1] drm/amdgpu: Fix KFD-related kernel oops on Hawaii

2019-09-05 Thread Kuehling, Felix
Hawaii needs to flush caches explicitly, submitting an IB in a user VMID from kernel mode. There is no s_fence in this case. Fixes: eb3961a57424 ("drm/amdgpu: remove fence context from the job") Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 3 ++- 1 file changed, 2

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-05 Thread Kenny Ho
On Thu, Sep 5, 2019 at 4:32 PM Daniel Vetter wrote: > *snip* > drm_dev_unregister gets called on hotunplug, so your cgroup-internal > tracking won't get out of sync any more than the drm_minor list gets > out of sync with drm_devices. The trouble with drm_minor is just that > cgroup doesn't track

[PATCH v2.1] drm/connector: Allow max possible encoders to attach to a connector

2019-09-05 Thread José Roberto de Souza
From: Dhinakaran Pandiyan Currently we restrict the number of encoders that can be linked to a connector to 3, increase it to match the maximum number of encoders that can be initialized(32). To more effiently do that lets switch from an array of encoder ids to bitmask. Also removing the

[PATCH v2] drm/connector: Allow max possible encoders to attach to a connector

2019-09-05 Thread José Roberto de Souza
From: Dhinakaran Pandiyan Currently we restrict the number of encoders that can be linked to a connector to 3, increase it to match the maximum number of encoders that can be initialized(32). To more effiently do that lets switch from an array of encoder ids to bitmask. Also removing the

Re: [PATCH 00/20] HDCP 1.4 Content Protection

2019-09-05 Thread Harry Wentland
On 2019-08-29 12:22 p.m., Bhawanpreet Lakha wrote: > This patch set introduces HDCP 1.4 capability to Asics starting with > Raven(DCN 1.0). > > This only introduces the ability to authenticate and encrypt the link. These > patches by themselves don't constitute a complete and compliant > HDCP

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-05 Thread Daniel Vetter
On Thu, Sep 5, 2019 at 10:21 PM Kenny Ho wrote: > > On Thu, Sep 5, 2019 at 4:06 PM Daniel Vetter wrote: > > > > On Thu, Sep 5, 2019 at 8:28 PM Kenny Ho wrote: > > > > > > (resent in plain text mode) > > > > > > Hi Daniel, > > > > > > This is the previous patch relevant to this discussion: > > >

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-05 Thread Kenny Ho
On Thu, Sep 5, 2019 at 4:06 PM Daniel Vetter wrote: > > On Thu, Sep 5, 2019 at 8:28 PM Kenny Ho wrote: > > > > (resent in plain text mode) > > > > Hi Daniel, > > > > This is the previous patch relevant to this discussion: > > https://patchwork.freedesktop.org/patch/314343/ > > Ah yes, thanks for

Re: [PATCH] drm/amdkfd: Support Navi14 in KFD

2019-09-05 Thread Zhao, Yong
Fixed and pushed. Thanks. Regards, Yong On 2019-09-05 3:56 p.m., Kuehling, Felix wrote: > On 2019-09-05 3:22 p.m., Zhao, Yong wrote: >> Change-Id: Ie2c6226022ff4d389eaa05b1c84afa7ae4cea0aa >> Signed-off-by: Yong Zhao > Please add a change description. With that fixed, this patch is > >

Re: [PATCH 09/20] drm/amdgpu: psp DTM init

2019-09-05 Thread Harry Wentland
On 2019-09-05 3:36 p.m., Lakha, Bhawanpreet wrote: > > On 2019-09-05 3:31 p.m., Wentland, Harry wrote: >> >> On 2019-08-29 12:22 p.m., Bhawanpreet Lakha wrote: >>> DTM is the display topology manager. This is needed to communicate with >>> psp about the display configurations. >>> >>> This patch

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-05 Thread Daniel Vetter
On Thu, Sep 5, 2019 at 8:28 PM Kenny Ho wrote: > > (resent in plain text mode) > > Hi Daniel, > > This is the previous patch relevant to this discussion: > https://patchwork.freedesktop.org/patch/314343/ Ah yes, thanks for finding that. > So before I refactored the code to leverage drm_minor, I

Re: [PATCH] drm/amdkfd: Support Navi14 in KFD

2019-09-05 Thread Kuehling, Felix
On 2019-09-05 3:22 p.m., Zhao, Yong wrote: > Change-Id: Ie2c6226022ff4d389eaa05b1c84afa7ae4cea0aa > Signed-off-by: Yong Zhao Please add a change description. With that fixed, this patch is Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 1 + >

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-05 Thread Siqueira, Rodrigo
Hi Ville, First of all, thank you very much for the review. I added some comments below. On 09/05, Wentland, Harry wrote: > On 2019-09-05 1:29 p.m., Ville Syrjälä wrote: > > On Wed, Sep 04, 2019 at 07:02:18PM +, Siqueira, Rodrigo wrote: > >> DP 1.4a specification defines Link Training

Re: [PATCH 09/20] drm/amdgpu: psp DTM init

2019-09-05 Thread Lakha, Bhawanpreet
On 2019-09-05 3:31 p.m., Wentland, Harry wrote: > > On 2019-08-29 12:22 p.m., Bhawanpreet Lakha wrote: >> DTM is the display topology manager. This is needed to communicate with >> psp about the display configurations. >> >> This patch adds >> -Loading the firmware >> -The functions and

Re: [PATCH 09/20] drm/amdgpu: psp DTM init

2019-09-05 Thread Harry Wentland
On 2019-08-29 12:22 p.m., Bhawanpreet Lakha wrote: > DTM is the display topology manager. This is needed to communicate with > psp about the display configurations. > > This patch adds > -Loading the firmware > -The functions and definitions for communication with the firmware > >

[PATCH] drm/amdkfd: Support Navi14 in KFD

2019-09-05 Thread Zhao, Yong
Change-Id: Ie2c6226022ff4d389eaa05b1c84afa7ae4cea0aa Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++ .../drm/amd/amdkfd/kfd_device_queue_manager.c | 1 +

Re: [PATCH v2 02/10] drm/amdkfd: add renoir kfd device info (v2)

2019-09-05 Thread Kuehling, Felix
On 2019-09-05 2:36 p.m., Huang, Ray wrote: > This patch inits renoir kfd device info, so we treat renoir as "dgpu" > (bypass iommu v2). Will enable needs_iommu_device till renoir iommu is ready. > > v2: rebase and align the drm-next > > Signed-off-by: Huang Rui The series is Reviewed-by: Felix

[PATCH v2 01/10] drm/amdkfd: add renoir cache info for CRAT (v2)

2019-09-05 Thread Huang, Ray
Renoir's cache info should be the same with raven and carrizo's. v2: fix missed "break" Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c

[PATCH v2 02/10] drm/amdkfd: add renoir kfd device info (v2)

2019-09-05 Thread Huang, Ray
This patch inits renoir kfd device info, so we treat renoir as "dgpu" (bypass iommu v2). Will enable needs_iommu_device till renoir iommu is ready. v2: rebase and align the drm-next Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 18 ++ 1 file changed, 18

Re: [PATCH] drm/amd/display: Move static keyword to the front of declaration

2019-09-05 Thread Harry Wentland
On 2019-09-05 2:33 p.m., Krzysztof Wilczynski wrote: > Move the static keyword to the front of declaration of DC_BUILD_ID, > and resolve the following compiler warning that can be seen when > building with warnings enabled (W=1): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1:

[PATCH] drm/amd/display: Move static keyword to the front of declaration

2019-09-05 Thread Krzysztof Wilczynski
Move the static keyword to the front of declaration of DC_BUILD_ID, and resolve the following compiler warning that can be seen when building with warnings enabled (W=1): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning: ‘static’ is not at beginning of declaration

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-05 Thread Kenny Ho
(resent in plain text mode) Hi Daniel, This is the previous patch relevant to this discussion: https://patchwork.freedesktop.org/patch/314343/ So before I refactored the code to leverage drm_minor, I kept my own list of "known" drm_device inside the controller and have explicit register and

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-05 Thread Kenny Ho
Hi Daniel, This is the previous patch relevant to this discussion: https://patchwork.freedesktop.org/patch/314343/ So before I refactored the code to leverage drm_minor, I kept my own list of "known" drm_device inside the controller and have explicit register and unregister function to init per

Re: [PATCH 1/1] drm/amdgpu: Disable retry faults in VMID0

2019-09-05 Thread Huang, Ray
On Thu, Sep 05, 2019 at 07:31:11AM +0800, Kuehling, Felix wrote: > There is no point retrying page faults in VMID0. Those faults are > always fatal. > > Signed-off-by: Felix Kuehling Thanks! I have verified it in my platform. Reviewed-and-Tested-by: Huang Rui > --- >

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-05 Thread Harry Wentland
On 2019-09-05 1:29 p.m., Ville Syrjälä wrote: > On Wed, Sep 04, 2019 at 07:02:18PM +, Siqueira, Rodrigo wrote: >> DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) > > A bunch of this stuff was already in DP 1.3 so the statement here > (and in the comment) is a bit

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-05 Thread Ville Syrjälä
On Wed, Sep 04, 2019 at 07:02:18PM +, Siqueira, Rodrigo wrote: > DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) A bunch of this stuff was already in DP 1.3 so the statement here (and in the comment) is a bit misleading. "LTTPR" is not a name that appears anywhere in

Re: [pull] amdgpu drm-next-5.4

2019-09-05 Thread Alex Deucher
On Tue, Sep 3, 2019 at 2:37 AM Dave Airlie wrote: > > On Sat, 31 Aug 2019 at 07:27, Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > Mostly bug fixes. The big addition is display support for renoir > > which is new for 5.4. I realize it's a bit late to add it but the > > rest of the code

Re: [PATCH] drm/drm_connector: add additional aspect ratio values

2019-09-05 Thread Ville Syrjälä
On Thu, Sep 05, 2019 at 02:59:53PM +, Lin, Wayne wrote: > > > > From: Ville Syrjälä > Sent: Saturday, August 24, 2019 02:41 > To: Lin, Wayne > Cc: dri-de...@lists.freedesktop.org ; > amd-gfx@lists.freedesktop.org ; Li, Sun peng > (Leo) ; Kazlauskas,

Re: [PATCH] drm/amdkfd: Fix a building error when KFD_SUPPORT_IOMMU_V2 is turned off

2019-09-05 Thread Kuehling, Felix
On 2019-09-05 11:01, Zhao, Yong wrote: > The issue was accidentally introduced recently. > > Change-Id: I3b21caa1596d4f7de1866bed1cb5d8fe1b51504c > Signed-off-by: Yong Zhao Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 -- > 1 file changed, 4

[PATCH] drm/amdkfd: Fix a building error when KFD_SUPPORT_IOMMU_V2 is turned off

2019-09-05 Thread Zhao, Yong
The issue was accidentally introduced recently. Change-Id: I3b21caa1596d4f7de1866bed1cb5d8fe1b51504c Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c

Re: [PATCH] drm/drm_connector: add additional aspect ratio values

2019-09-05 Thread Lin, Wayne
From: Ville Syrjälä Sent: Saturday, August 24, 2019 02:41 To: Lin, Wayne Cc: dri-de...@lists.freedesktop.org ; amd-gfx@lists.freedesktop.org ; Li, Sun peng (Leo) ; Kazlauskas, Nicholas Subject: Re: [PATCH] drm/drm_connector: add additional aspect ratio

Re: linux-next: Tree for Sep 4 (amd/display/)

2019-09-05 Thread Randy Dunlap
On 9/5/19 6:17 AM, Harry Wentland wrote: > > > On 2019-09-04 4:58 p.m., Randy Dunlap wrote: >> On 9/4/19 6:34 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> News: this will be the last linux-next I will release until Sept 30. >>> >>> Changes since 20190903: >>> >> >> on x86_64: >> >> In file

Re: [PATCH 1/1] drm/amdgpu: Disable retry faults in VMID0

2019-09-05 Thread Yang, Philip
VMID0 init path was missed when enabling amdgpu_noretry option. Good catch and fix. Reviewed-by: Philip Yang On 2019-09-04 7:31 p.m., Kuehling, Felix wrote: > There is no point retrying page faults in VMID0. Those faults are > always fatal. > > Signed-off-by: Felix Kuehling > --- >

Re: linux-next: Tree for Sep 4 (amd/display/)

2019-09-05 Thread Harry Wentland
On 2019-09-04 4:58 p.m., Randy Dunlap wrote: > On 9/4/19 6:34 AM, Stephen Rothwell wrote: >> Hi all, >> >> News: this will be the last linux-next I will release until Sept 30. >> >> Changes since 20190903: >> > > on x86_64: > > In file included from >

Re: [PATCH] drm/amd/display: Add stereo mux and dig programming calls for dcn21

2019-09-05 Thread Kazlauskas, Nicholas
On 2019-09-04 5:43 p.m., roman...@amd.com wrote: > From: Roman Li > > [Why] > The earlier patch "Hook up calls to do stereo mux and dig programming..." > doesn't include update for dcn21. > > [How] > Align dcn21 gpio settings with updated stereo control interface. > > Signed-off-by: Roman Li

Re: [PATCH] drm/amdgpu: fix null pointer deref in firmware header printing

2019-09-05 Thread Kevin Wang
On 9/5/19 5:41 PM, Yuan, Xiaojie wrote: > When CE's ucode_id(8) is used to get sdma_hdr, we will be accessing an > unallocated amdgpu_firmware_info instance. > > This issue appears on rhel7.7 with gcc 4.8.5. Newer compilers might have > optimized out such 'defined but not referenced' variable. >

Re: [PATCH] drm/amd/powerplay: fix 'unusedd variable' compile warning

2019-09-05 Thread Kevin Wang
Reviewed-by: Kevin Wang On 9/5/19 5:30 PM, Quan, Evan wrote: > Reviewed-by: Evan Quan > >> -Original Message- >> From: Yuan, Xiaojie >> Sent: 2019年9月5日 17:26 >> To: amd-gfx@lists.freedesktop.org >> Cc: Feng, Kenneth ; Quan, Evan >> ; Wang, Kevin(Yang) ; >> Yuan, Xiaojie >> Subject:

[PATCH] drm/amdgpu: fix null pointer deref in firmware header printing

2019-09-05 Thread Yuan, Xiaojie
When CE's ucode_id(8) is used to get sdma_hdr, we will be accessing an unallocated amdgpu_firmware_info instance. This issue appears on rhel7.7 with gcc 4.8.5. Newer compilers might have optimized out such 'defined but not referenced' variable. [ 1120.798564] BUG: unable to handle kernel NULL

RE: [PATCH] drm/amd/powerplay: fix 'unusedd variable' compile warning

2019-09-05 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: Yuan, Xiaojie > Sent: 2019年9月5日 17:26 > To: amd-gfx@lists.freedesktop.org > Cc: Feng, Kenneth ; Quan, Evan > ; Wang, Kevin(Yang) ; > Yuan, Xiaojie > Subject: [PATCH] drm/amd/powerplay: fix 'unusedd variable' compile > warning > >

[PATCH] drm/amd/powerplay: fix 'unusedd variable' compile warning

2019-09-05 Thread Yuan, Xiaojie
Signed-off-by: Xiaojie Yuan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 -- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 -- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 -- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 2 -- 4 files changed, 8 deletions(-) diff --git

Re: drm/amdgpu: remove the redundant null check

2019-09-05 Thread zhong jiang
On 2019/9/5 16:38, Markus Elfring wrote: >>> Were any source code analysis tools involved for finding >>> these update candidates? >> With the help of Coccinelle. You can find out some example in >> scripts/coccinelle/. > Thanks for such background information. > Was the script “ifnullfree.cocci”

Re: drm/amdgpu: remove the redundant null check

2019-09-05 Thread Markus Elfring
>> Were any source code analysis tools involved for finding >> these update candidates? > With the help of Coccinelle. You can find out some example in > scripts/coccinelle/. Thanks for such background information. Was the script “ifnullfree.cocci” applied here? Will it be helpful to add

Re: gnome-shell stuck because of amdgpu driver [5.3 RC5]

2019-09-05 Thread Daniel Vetter
On Thu, Sep 5, 2019 at 12:27 AM Mikhail Gavrilov wrote: > > On Wed, 4 Sep 2019 at 13:37, Daniel Vetter wrote: > > > > Extend your backtrac warning slightly like > > > > WARN(r, "we're stuck on fence %pS\n", fence->ops); > > > > Also adding Harry and Alex, I'm not really working on amdgpu

RE: [PATCH 4/4] drm/amdgpu: move the call of ras recovery_init and bad page reserve to proper place

2019-09-05 Thread Chen, Guchun
Except one spelling typo, series is: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Zhou1, Tao Sent: Thursday, September 5, 2019 12:04 PM To: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Chen, Guchun ; Li, Dennis ; Zhang, Hawking ; Clements, John Cc:

?????? ?????? ?????? Bug: amdgpu drm driver cause process into Disk sleep state

2019-09-05 Thread yanhua
Hi, Christian, I noticed that you said 'amdgpu is known to not work on arm64 until very recently'.I found the CPU related commit with drm is "drm: disable uncached DMA optimization for ARM and arm64". @@ -47,6 +47,24 @@ static inline bool drm_arch_can_wc_memory(void)

?????? ?????? ?????? Bug: amdgpu drm driver cause process into Disk sleep state

2019-09-05 Thread 78666679
Hi, Chirstian: I have issued a bug report on bugs.freedesktop.org. could you please help to look into it ? what will cause this bug happen? -- -- ??: "Koenig, Christian"; : 2019??9??3??(??) 9:19c ??:

[PATCH v2 3/3] drm/edid: no CEA v3 extension is not an error

2019-09-05 Thread Jean Delvare
It is fine for displays without audio functionality to not implement CEA v3 extension in their EDID. Do not return an error in that case, instead return 0 as if there was a CEA v3 extension with no audio or speaker block. This fixes half of bug fdo#107825:

[PATCH v2 2/3] drm/radeon: be quiet when no SAD block is found

2019-09-05 Thread Jean Delvare
It is fine for displays without audio functionality to not provide any SAD block in their EDID. Do not log an error in that case, just return quietly. Inspired by a similar fix to the amdgpu driver in the context of bug fdo#107825: https://bugs.freedesktop.org/show_bug.cgi?id=107825

[PATCH v2 1/3] drm/amd: be quiet when no SAD block is found

2019-09-05 Thread Jean Delvare
It is fine for displays without audio functionality to not provide any SAD block in their EDID. Do not log an error in that case, just return quietly. This fixes half of bug fdo#107825: https://bugs.freedesktop.org/show_bug.cgi?id=107825 Signed-off-by: Jean Delvare Cc: Alex Deucher Cc:

[PATCH v2 0/3] drm/edid: don't log errors on absent or old CEA SAD blocks

2019-09-05 Thread Jean Delvare
Hi all, This is my attempt to fix bug fdo#107825: https://bugs.freedesktop.org/show_bug.cgi?id=107825 [PATCH 1/3] drm/amd: be quiet when no SAD block is found [PATCH 2/3] drm/radeon: be quiet when no SAD block is found [PATCH 3/3] drm/edid: no CEA extension is not an error Changes since v1: *

[PATCH 5/8] drm/amdgpu: switch to gem vma offset manager

2019-09-05 Thread Gerd Hoffmann
Pass gem vma_offset_manager to ttm_bo_device_init(), so ttm uses it instead of its own embedded struct. This makes some gem functions (specifically drm_gem_object_lookup) work on ttm objects. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1

[PATCH 1/8] drm/ttm: turn ttm_bo_device.vma_manager into a pointer

2019-09-05 Thread Gerd Hoffmann
Rename the embedded struct vma_offset_manager, new name is _vma_manager. ttm_bo_device.vma_manager changed to a pointer. The ttm_bo_device_init() function gets an additional vma_manager argument which allows to initialize ttm with a different vma manager. When passing NULL the embedded

[PATCH 4/8] drm/radeon: switch to gem vma offset manager

2019-09-05 Thread Gerd Hoffmann
Pass gem vma_offset_manager to ttm_bo_device_init(), so ttm uses it instead of its own embedded struct. This makes some gem functions (specifically drm_gem_object_lookup) work on ttm objects. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- 1 file changed, 1