Re: [PATCH v3 02/14] mm/mmu_notifier: add an interval tree notifier

2019-11-22 Thread Ralph Campbell
On 11/13/19 8:46 AM, Jason Gunthorpe wrote: On Wed, Nov 13, 2019 at 05:59:52AM -0800, Christoph Hellwig wrote: +int mmu_interval_notifier_insert(struct mmu_interval_notifier *mni, + struct mm_struct *mm, unsigned long start, +

Re: [PATCH] drm/amdgpu: Apply noretry setting for mmhub9.4

2019-11-22 Thread Felix Kuehling
On 2019-11-22 5:55 p.m., Oak Zeng wrote: Config the translation retry behavior according to noretry kernel parameter Change-Id: I5b91ea77715137cf8cb84e258ccdfbb19c7a4ed1 Signed-off-by: Oak Zeng Suggested-by: Jay Cornwall Reviewed-by: Felix Kuehling ---

RE: [PATCH] drm/amdgpu: Apply noretry setting for gfx10 and mmhub9.4

2019-11-22 Thread Zeng, Oak
I didn't have new information about the retry_mode setting for gfx10. I just saw the noretry kernel parameter wasn't applied to gfx10 but I didn't know gfx10 is excluded purposely. Let me drop the gfx10 part for now. Oak -Original Message- From: Kuehling, Felix Sent: Friday, November

[PATCH] drm/amdgpu: Apply noretry setting for mmhub9.4

2019-11-22 Thread Oak Zeng
Config the translation retry behavior according to noretry kernel parameter Change-Id: I5b91ea77715137cf8cb84e258ccdfbb19c7a4ed1 Signed-off-by: Oak Zeng Suggested-by: Jay Cornwall --- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 2/2] drm/amdkfd: Move pm_create_runlist_ib() out of pm_send_runlist()

2019-11-22 Thread Zhao, Yong
[AMD Official Use Only - Internal Distribution Only] Hi Felix, There is no big picture unfortunately, just some improvements that I came to when navigating the code. Regarding your suggestion, I have a concern. With the original code in unmap_queues_cpsch(), if amdkfd_fence_wait_timeout()

[PATCH 3/4] ALSA: hda/hdmi - enable runtime pm for newer AMD display audio

2019-11-22 Thread Alex Deucher
We are able to power down the GPU and audio via the GPU driver so flag these asics as supporting runtime pm. Reviewed-by: Takashi Iwai Acked-by: Evan Quan Signed-off-by: Alex Deucher --- sound/pci/hda/hda_intel.c | 35 +++ 1 file changed, 23 insertions(+), 12

[PATCH 0/4] add runtime pm support for AMD display audio

2019-11-22 Thread Alex Deucher
These patches were originally part of a larger set of patches to enabled runtime pm support on the GPU side[1]. However, the patches are useful on their own there are really no dependencies, other than the fact that you need both for runtime pm to kick in on the GPU side. The GPU side will be

[PATCH 1/4] ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD

2019-11-22 Thread Alex Deucher
Only enable the vga_switcheroo logic on systems with the ATPX ACPI method. This logic is not needed for asics that are not part of a PX (PowerXpress)/HG (Hybrid Graphics) platform. Reviewed-by: Takashi Iwai Acked-by: Evan Quan Signed-off-by: Alex Deucher --- sound/pci/hda/hda_intel.c | 45

[PATCH 4/4] ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by default

2019-11-22 Thread Alex Deucher
So that we can power down the GPU and audio to save power. Reviewed-by: Takashi Iwai Acked-by: Evan Quan Signed-off-by: Alex Deucher --- sound/pci/hda/patch_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index

[PATCH 2/4] ALSA: hda/hdmi - Add new pci ids for AMD GPU display audio

2019-11-22 Thread Alex Deucher
These are needed so we can enable runtime pm in a subsequent patch. Reviewed-by: Takashi Iwai Signed-off-by: Alex Deucher --- sound/pci/hda/hda_intel.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index

Re: [PATCH 2/2] drm/amdkfd: Move pm_create_runlist_ib() out of pm_send_runlist()

2019-11-22 Thread Felix Kuehling
I'm not sure about this one. Looks like the interface is getting needlessly more complicated. Now the caller has to keep track of the runlist IB address and size just to pass those to another function. I could understand this if there was a use case that needs to separate the allocation of the

Re: [PATCH] drm/amdgpu: Apply noretry setting for gfx10 and mmhub9.4

2019-11-22 Thread Felix Kuehling
On 2019-11-22 3:23 p.m., Oak Zeng wrote: Config the translation retry behavior according to noretry kernel parameter Change-Id: I5b91ea77715137cf8cb84e258ccdfbb19c7a4ed1 Signed-off-by: Oak Zeng Suggested-by: Jay Cornwall --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 +++-

[pull] radeon, amdgpu drm-next-5.5

2019-11-22 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.5. The following changes since commit 17eee668b3cad423a47c090fe2275733c55db910: Merge tag 'drm-misc-next-fixes-2019-11-20' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-11-21 10:19:45 +1000) are available in the Git repository at:

[PATCH] drm/amdgpu: Apply noretry setting for gfx10 and mmhub9.4

2019-11-22 Thread Oak Zeng
Config the translation retry behavior according to noretry kernel parameter Change-Id: I5b91ea77715137cf8cb84e258ccdfbb19c7a4ed1 Signed-off-by: Oak Zeng Suggested-by: Jay Cornwall --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 +++- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 5 +++-- 2 files

Re: [PATCH] drm/amd/display: add default clocks if not able to fetch them

2019-11-22 Thread Kazlauskas, Nicholas
Reviewed-by: Nicholas Kazlauskas On 2019-11-22 1:09 p.m., Alex Deucher wrote: Ping? On Tue, Nov 19, 2019 at 3:56 PM Alex Deucher wrote: dm_pp_get_clock_levels_by_type needs to add the default clocks to the powerplay case as well. This was accidently dropped. Fixes: b3ea88fef321de

[PATCH] MAINTAINERS: Drop Rex Zhu for amdgpu powerplay

2019-11-22 Thread Alex Deucher
No longer works on the driver. Signed-off-by: Alex Deucher --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b63c291ad029..d518588b9879 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -856,7 +856,6 @@ S: Maintained F:

[PATCH v2] drm/dsc: Return unsigned long on compute offset

2019-11-22 Thread mikita.lipski
From: Mikita Lipski We shouldn't compare int with unsigned long to find the max value and since we are not expecting negative value returned from compute_offset we should make this function return unsigned long so we can compare the values when computing rc parameters. v2: Modified function

Re: [PATCH 0/2] drm/amd: Use ARRAY_SIZE

2019-11-22 Thread Alex Deucher
Applied the series. Thanks! Alex On Fri, Nov 22, 2019 at 4:01 AM zhengbin wrote: > > zhengbin (2): > drm/amd/powerplay: Use ARRAY_SIZE for smu7_profiling > drm/amdgpu: Use ARRAY_SIZE for sos_old_versions > > drivers/gpu/drm/amd/amdgpu/psp_v3_1.c| 2 +- >

Re: [PATCH v2 2/2] drm: share address space for dma bufs

2019-11-22 Thread Alex Deucher
On Fri, Nov 22, 2019 at 4:17 AM Daniel Vetter wrote: > > On Fri, Nov 22, 2019 at 7:37 AM Gerd Hoffmann wrote: > > > > Use the shared address space of the drm device (see drm_open() in > > drm_file.c) for dma-bufs too. That removes a difference betweem drm > > device mmap vmas and dma-buf mmap

Re: [PATCH] drm/amdkfd: Remove duplicate functions update_mqd_hiq()

2019-11-22 Thread Yong Zhao
Pushed. Thanks! Yong On 2019-11-21 11:21 p.m., Liu, Zhan wrote: Looks good to me. Reviewed-by: Zhan Liu -Original Message- From: amd-gfx On Behalf Of Yong Zhao Sent: 2019/November/21, Thursday 4:25 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH] drm/amdkfd:

Re: [PATCH] drm/amd/display: add default clocks if not able to fetch them

2019-11-22 Thread Alex Deucher
Ping? On Tue, Nov 19, 2019 at 3:56 PM Alex Deucher wrote: > > dm_pp_get_clock_levels_by_type needs to add the default clocks > to the powerplay case as well. This was accidently dropped. > > Fixes: b3ea88fef321de ("drm/amd/powerplay: add get_clock_by_type interface > for display") > Bug:

Re: [PATCH] drm/amdgpu: always reset asic when going into suspend

2019-11-22 Thread Alex Deucher
On Wed, Oct 16, 2019 at 3:24 AM Daniel Drake wrote: > > On Wed, Oct 16, 2019 at 2:43 AM Alex Deucher wrote: > > Is s2idle actually powering down the GPU? > > My understanding is that s2idle (at a high level) just calls all > devices suspend routines and then puts the CPU into its deepest >

Re: [PATCH v2] drm/amd/display: Fix Apple dongle cannot be successfully detected

2019-11-22 Thread Harry Wentland
On 2019-11-22 1:33 a.m., Louis Li wrote: > On Thu, Nov 21, 2019 at 08:47:50AM -0500, Kazlauskas, Nicholas wrote: >> On 2019-11-21 8:40 a.m., Kazlauskas, Nicholas wrote: >>> On 2019-11-21 3:31 a.m., Li, Ching-shih (Louis) wrote: Hi reviewers, What is the review result for this

RE: [PATCH] drm/amdgpu: invalidate mmhub semphore workaround in gmc9/gmc10

2019-11-22 Thread Zhu, Changfeng
Thanks, Ray I 'll submit the patch and continue to see the gfxhub semaphore problem. BR, Changfeng. -Original Message- From: Huang, Ray Sent: Friday, November 22, 2019 5:16 PM To: Zhu, Changfeng Cc: Koenig, Christian ; Xiao, Jack ; Zhou1, Tao ; Huang, Shimmer ;

Re: [PATCH v2 2/2] drm: share address space for dma bufs

2019-11-22 Thread Daniel Vetter
On Fri, Nov 22, 2019 at 7:37 AM Gerd Hoffmann wrote: > > Use the shared address space of the drm device (see drm_open() in > drm_file.c) for dma-bufs too. That removes a difference betweem drm > device mmap vmas and dma-buf mmap vmas and fixes corner cases like > dropping ptes (using

Re: [PATCH] drm/amdgpu: invalidate mmhub semphore workaround in gmc9/gmc10

2019-11-22 Thread Huang, Ray
[AMD Official Use Only - Internal Distribution Only] On Thu, Nov 21, 2019 at 11:47:15PM +0800, Zhu, Changfeng wrote: > From: changzhu > > It may lose gpuvm invalidate acknowldege state across power-gating off > cycle. To avoid this issue in gmc9/gmc10 invalidation, add semaphore acquire >

[PATCH 0/2] drm/amd: Use ARRAY_SIZE

2019-11-22 Thread zhengbin
zhengbin (2): drm/amd/powerplay: Use ARRAY_SIZE for smu7_profiling drm/amdgpu: Use ARRAY_SIZE for sos_old_versions drivers/gpu/drm/amd/amdgpu/psp_v3_1.c| 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4

[PATCH 1/2] drm/amd/powerplay: Use ARRAY_SIZE for smu7_profiling

2019-11-22 Thread zhengbin
Fixes coccicheck warning: drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:4946:28-29: WARNING: Use ARRAY_SIZE Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] drm/amdgpu: Use ARRAY_SIZE for sos_old_versions

2019-11-22 Thread zhengbin
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/psp_v3_1.c:182:40-41: WARNING: Use ARRAY_SIZE Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git