On 2020-01-10 7:40 p.m., Yong Zhao wrote:
The warning was introduced in
commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e
Author: Yong Zhao
Date: Fri Dec 13 11:31:48 2019 -0500
drm/amdkfd: Improve function get_sdma_rlc_reg_offset()
Change-Id: I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
The warning was introduced in
commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e
Author: Yong Zhao
Date: Fri Dec 13 11:31:48 2019 -0500
drm/amdkfd: Improve function get_sdma_rlc_reg_offset()
Change-Id: I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
Signed-off-by: Yong Zhao
---
Unused so drop it.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
index 3761c8cc1156..f51326598a8c 100644
---
Applied. Thanks!
Alex
On Thu, Jan 9, 2020 at 1:41 PM Harry Wentland wrote:
>
> On 2020-01-09 10:20 a.m., Mario Kleiner wrote:
> > read_current_link_settings_on_detect() on eDP 1.4+ may use the
> > edp_supported_link_rates table which is set up by
> > detect_edp_sink_caps(), so that function
Applied. thanks!
On Fri, Jan 10, 2020 at 4:41 PM Harry Wentland wrote:
>
> On 2020-01-10 2:16 a.m., Chen Zhou wrote:
> > The conversion to bool is not needed, remove it.
> >> Signed-off-by: Chen Zhou
>
> Reviewed-by: Harry Wentland
>
> Harry
>
> > ---
> >
If driver debugfs files are accessed, power up the GPU
when necessary.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 133 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 8 ++
2 files changed, 134 insertions(+), 7 deletions(-)
diff --git
If power management sysfs or debugfs files are accessed,
power up the GPU when necessary.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 822 ++---
1 file changed, 614 insertions(+), 208 deletions(-)
diff --git
On 2020-01-10 1:37 a.m., Huang Rui wrote:
Align with gfx v9, use map_queues packet to load hiq MQD.
Signed-off-by: Huang Rui
Please make sure you test this on a GFXv8 GPU.
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 69 ++-
On 2020-01-10 1:37 a.m., Huang Rui wrote:
To align with gfx v9, we use the map_queues packet to load hiq MQD.
Signed-off-by: Huang Rui
Please make sure you test this on a GFXv10 GPU.
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c | 82
What happens on Arcturus without this patch? Does it oops with a null
pointer dereference? If yes, then you should squash this patch into
patch 2 to avoid a broken intermediate state.
Regards,
Felix
On 2020-01-10 1:37 a.m., Huang Rui wrote:
Align with gfx v9, use the map_queues packet to
[AMD Official Use Only - Internal Distribution Only]
The most recen ones start at:
[PATCH 1/8] drm/amdgpu: Avoid reclaim fs while eviction lock
Through:
[PATCH 8/8] drm/amdgpu: replace kcq enable function on gfx_v9
Regards,
Alex Sierra
-Original Message-
From: Christian König
Sent:
On 1/10/20 11:41 AM, mikita.lip...@amd.com wrote:
> From: Mikita Lipski
>
> [why]
> Compilation error "undefined reference to `__udivdi3'" was
> thrown on i386 architecture.
>
> [how]
> Use div_u64 for unsigned long division instead of a divide operator.
>
> Reported-by: Randy Dunlap
>
From: changzhu
[ Upstream commit e0c63812352298efbce2a71483c1dab627d0c288 ]
When smu version is larger than 0x41e2b, it will load
raven_kicker_rlc.bin.To enable gfxoff for raven_kicker_rlc.bin,it
needs to avoid adev->pm.pp_feature &= ~PP_GFXOFF_MASK when it loads
raven_kicker_rlc.bin.
Hi Dave, Daniel,
Same pull as yesterday, but with a fix for 32 bit.
The following changes since commit 0f899fd466b693a129b16994c1b2b4db2fcde4a4:
drm/amdkfd: Improve kfd_process lookup in kfd_ioctl (2020-01-09 16:08:19
-0500)
are available in the Git repository at:
On 2020-01-10 2:16 a.m., Chen Zhou wrote:
> The conversion to bool is not needed, remove it.
>> Signed-off-by: Chen Zhou
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On 2020-01-10 4:16 p.m., Harry Wentland wrote:
> On 2020-01-10 1:47 p.m., Liu, Zhan wrote:
>>
>>
>>> -Original Message-
>>> From: amd-gfx On Behalf Of
>>> Christian König
>>> Sent: 2020/January/10, Friday 10:02 AM
>>> To: Siqueira, Rodrigo ; amd-
>>> g...@lists.freedesktop.org
>>> Cc: Li,
On 2020-01-10 1:47 p.m., Liu, Zhan wrote:
>
>
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Christian König
>> Sent: 2020/January/10, Friday 10:02 AM
>> To: Siqueira, Rodrigo ; amd-
>> g...@lists.freedesktop.org
>> Cc: Li, Sun peng (Leo) ; Cheng, Tony
>> ; Tsai, Martin ; Lakha,
On Fri, Jan 10, 2020 at 2:41 PM wrote:
>
> From: Mikita Lipski
>
> [why]
> Compilation error "undefined reference to `__udivdi3'" was
> thrown on i386 architecture.
>
> [how]
> Use div_u64 for unsigned long division instead of a divide operator.
>
> Reported-by: Randy Dunlap
> Signed-off-by:
It looks like we should be reducing the group size when we don't
have a plane rather than when we do.
Bug: https://gitlab.freedesktop.org/drm/amd/issues/781
Fixes: 5fc0cbfad45648 ("drm/amd/display: determine if a pipe is synced by plane
state")
Signed-off-by: Alex Deucher
---
From: Mikita Lipski
[why]
Compilation error "undefined reference to `__udivdi3'" was
thrown on i386 architecture.
[how]
Use div_u64 for unsigned long division instead of a divide operator.
Reported-by: Randy Dunlap
Signed-off-by: Mikita Lipski
---
SW scheduler is previously called non HW scheduler, or non HWS. This
message is useful when triaging issues from dmesg.
Change-Id: I625518c88c043df5f60409d1ca520e7fc032251f
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 +
1 file changed, 1 insertion(+)
> -Original Message-
> From: amd-gfx On Behalf Of
> Christian König
> Sent: 2020/January/10, Friday 10:02 AM
> To: Siqueira, Rodrigo ; amd-
> g...@lists.freedesktop.org
> Cc: Li, Sun peng (Leo) ; Cheng, Tony
> ; Tsai, Martin ; Lakha,
> Bhawanpreet ; Wentland, Harry
>
> Subject: Re:
In SRIOV, rlc_g firmware is loaded by host, guest driver won't load it which
will
cause the rlc_fw pointer is null
Change-Id: Id16f65171dd427d623af4c5bc75f674019e63dec
Signed-off-by: shaoyunl
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 9 +
1 file changed, 5 insertions(+), 4
On 1/10/20 12:07 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20200109:
>
on i386:
ld: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.o: in function
`compute_mst_dsc_configs_for_link':
amdgpu_dm_mst_types.c:(.text+0x784): undefined reference to `__udivdi3'
ld:
+ amd-gfx@lists.freedesktop.org
Hi there,
Thank you for your bug report (though from your email address seems like you
are a robot :p)
Since it's an amdgpu related bug, please also add amd-gfx@lists.freedesktop.org
for better visibility.
Thanks,
Zhan
> -Original Message-
> From:
On Fri, Jan 10, 2020 at 03:56:06PM +0200, Jani Nikula wrote:
> On Fri, 10 Jan 2020, Thomas Zimmermann wrote:
> > Hi
> >
> > Am 10.01.20 um 12:59 schrieb Jani Nikula:
> >> On Fri, 10 Jan 2020, Thomas Zimmermann wrote:
> >>> The callback struct drm_driver.get_scanout_position() is deprecated in
>
On Fri, Jan 10, 2020 at 12:30 AM Tianci Yin wrote:
>
> From: "Tianci.Yin"
>
> [why]
> In dual GPUs scenario, stolen_size is assigned to zero on the secondary GPU,
> since there is no pre-OS console using that memory. Then the bottom region of
> VRAM was allocated as GTT, unfortunately a small
Am 10.01.20 um 15:46 schrieb Rodrigo Siqueira:
From: Martin Tsai
[why]
The rapid msleep operation causes the white line garbage when
DAL check flip pending status in SetVidPnSourceVisibility.
To execute this msleep will induce context switch, and longer
delay could cause worse garbage
From: Yongqiang Sun
Only need to do surface flip for video plane via dmcub.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dc/dcn21/dcn21_hubp.c | 130 +-
From: Aric Cyr
Signed-off-by: Aric Cyr
Reviewed-by: Aric Cyr
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
From: Wenjing Liu
[why]
Currently we wait for test pattern after each pipe is programmed. For
ODM combined scenario it will cause test pattern is shown on only half
screen for 1 frame. This is not desirable.
[how]
No wait between odm pipe programming, only wait after all pipes are
programmed.
From: Wenjing Liu
[why]
DPG is used to generate both blank and test automation test pattern.
When test automation is running the requested test pattern can be
overriden by the blank or unblank call because it is using the same
hardware.
[how]
When test pattern is requested, skip blank or
From: Anthony Koo
[Why]
With different refresh rate panels, the PSR entry/exit time is
different since it is dependent on 2 frame entry time today
[How]
Make static screen num frame entry time to be calculated
such that entry time is within 30 ms instead of fixed num
frames.
Signed-off-by:
From: Martin Tsai
[why]
The rapid msleep operation causes the white line garbage when
DAL check flip pending status in SetVidPnSourceVisibility.
To execute this msleep will induce context switch, and longer
delay could cause worse garbage situation.
[how]
To replace msleep with udelay.
From: Josip Pavic
[Why]
IRAM definition needed for versions of DMCU containing ABM 2.4
[How]
Pass ABM 2.3 IRAM definition, which is compatible with ABM 2.4, to DMCU
when ABM 2.4 FW is detected
Signed-off-by: Josip Pavic
Reviewed-by: Aric Cyr
Acked-by: Harry Wentland
Acked-by: Rodrigo
From: Paul Hsieh
[Why]
Try to allocate MST payload but receive HPD short pulse with link loss
casue driver allocate payload twice. It cause monitor can't light up
successfully.
[How]
When driver receive HPD short pulse with link loss, we need to
deallocate payload then allocate payload.
Then we
From: Alvin Lee
[Why]
Currently if seamless boot is enabled, we will skip double buffer enable
for OTG_BLANK. However, we need the double buffer enable in order to
block global sync signals when OTG becomes blanked (for PSR). Blocking
global sync signals prevent pipe from requesting data.
[How]
From: Aric Cyr
Signed-off-by: Aric Cyr
Reviewed-by: Aric Cyr
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
From: Lewis Huang
[Why]
DMCU need to wait a vblank to handle psr enter command. When psr exit
coming before vblank, the psr exit command will be skip because current
psr state is disable.
[How]
remove psr state condition when psr exit case
Signed-off-by: Lewis Huang
Reviewed-by: Tony Cheng
From: Jun Lei
[why]
Need to fix DML portability issues to enable SW unit testing around DML
[how]
Move calcs into dc include folder since multiple components reference it
Remove relative paths to external dependencies
Signed-off-by: Jun Lei
Reviewed-by: Anthony Koo
Acked-by: Harry Wentland
From: Lewis Huang
[Why]
dpcd cap mismatch in 2200 vs base
[How]
Add monitor patch which using based caps to overwrite 2200
Signed-off-by: Lewis Huang
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 7 +++
From: Chris Park
Signed-off-by: Chris Park
Reviewed-by: Aric Cyr
Reviewed-by: Jordan Lazare
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 3 +++
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubbub.c | 3 +++
2 files changed, 6
From: Nicholas Kazlauskas
[Why]
We need to ensure that the DMUIF in MMHUBBUB is also in reset so we
aren't generating requests while the DMCUB is in reset.
[How]
Set DMUIF_SOFT_RESET=1 on reset and DMUIF_SOFT_RESET=0 on reset
release.
Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Tony Cheng
From: Nicholas Kazlauskas
[Why]
The inst firmware isn't necessarily fully flushed to framebuffer
memory and the DMCUB can hang due to invalid inst being parsed.
[How]
Like the fix to flush ringbuffer commands before updating the inbox
write pointer we need to read back inst memory before
From: Noah Abradjian
[Why]
When rapidly adjusting colour properties (e.g. brightness), screen tearing was
observed.
This was due to overwritten values in OCSC registers. In dcn10, this issue had
been fixed by
implementing double buffering by alternating OCSC modes.
[How]
Alternate which OCSC
From: Yongqiang Sun
Rework surface programming for RN to separate preparing parameters and
register programming.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dc/dcn21/dcn21_hubp.c | 324
From: Noah Abradjian
[Why]
When rapidly adjusting video brightness, screen tearing was observed.
This was due to overwritten values in ICSC registers. In dcn10, this issue had
been
fixed by implementing double buffering via alternating ICSC modes.
However, the second register set used in dcn1
From: Wyatt Wood
[Why]
Moving PSR from DMCU to DMCUB.
[How]
Add driverside PSR changes required to send inbox messages to fw.
These changes are non-functional until the psr structure allocation
is uncommented.
Signed-off-by: Wyatt Wood
Reviewed-by: Nicholas Kazlauskas
Acked-by: Harry
From: Wyatt Wood
[Why]
Moving PSR from DMCU to DMCUB.
[How]
Cleanup psr spec files and add PSR hw programming files.
No functionality is included in this change.
Signed-off-by: Wyatt Wood
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
From: Aric Cyr
Signed-off-by: Aric Cyr
Reviewed-by: Aric Cyr
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
From: Alvin Lee
[Why]
If dummy pstate latency is 0 we should report the actual
pstate support, and not that pstate is always supported.
[How]
Don't always program pstate support true
Signed-off-by: Alvin Lee
Reviewed-by: Jun Lei
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
From: Wenjing Liu
Test pattern should be applied to hardware when exiting set test pattern
function.
Signed-off-by: Wenjing Liu
Reviewed-by: Nikola Cornij
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 13 +
1 file
From: George Shen
[Why]
PHY will sometimes be in bad state on hotplugging display from USB-C
dongle.
[How]
Add additional calls to disable and then enable PHY before link training
starts during verify_link_cap.
Signed-off-by: George Shen
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
From: Noah Abradjian
[Why]
Recent double buffering changes for dcn2 use IX_REG_READ.
However, this macro returns the full register value, with the need to
manually shift and mask it to retrieve field data.
[How]
Create new IX_REG_GET macro that handles shift and mask.
Use this for double
From: Eric Yang
[Why]
Previous implementation we may have residual chroma address offset
if transition from wa enable -> wa disable.
[How]
Clear address offset cache when viewport updates. Also update the
vp size check condition to account for rotation angle
Signed-off-by: Eric Yang
From: Charlene Liu
Signed-off-by: Charlene Liu
Reviewed-by: Charlene Liu
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c| 4 ++--
.../gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20v2.c | 4 ++--
From: Wyatt Wood
[Why]
The DMUB PSR command IDs do not have the correct values.
[How]
Fix the command IDs and cleanup the formatting.
Signed-off-by: Wyatt Wood
Reviewed-by: Aric Cyr
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dmub/inc/dmub_cmd_dal.h |
Add registers for handling Post Gamma Color Blending (OCSC), which is
useful for conversion from RGB->YUV for HDMI.
Reviewed-by: Leo Li
Acked-by: Harry Wentland
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/include/asic_reg/dcn/dcn_2_0_0_offset.h | 4
From: Alvin Lee
Needed to reprogram vblank_start in dml properly in order to get the
correct dlg params to program VTG.
Signed-off-by: Alvin Lee
Reviewed-by: Martin Leung
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/core/dc.c| 1 -
From: Joseph Gravenor
[Why]
Don't want to start HW discovery unless we have lost power,
as doing rediscovery otherwise is both unnecessary and time consuming.
Before this change it takes 40 seconds to go in to suspend, after it
takes 27 seconds
[How]
Accelerated mode gets cleared if we lose
From: Amanda Liu
[why]
Upon exiting a fixed active VRR state, the state isn't cleared. This
leads to the variable VRR range to be calculated incorrectly.
[how]
Set fixed active state to false when updating vrr params
Signed-off-by: Amanda Liu
Reviewed-by: Anthony Koo
Acked-by: Harry Wentland
From: Michael Strauss
[WHY]
48mhz turn off feature does not work on HDMI and DVI, but the feauture
was only blocked on HDMI, this change will apply the same wa on DVI
[HOW]
Apply workaround for all TMDS signal types (HDMI, DVI single/dual link)
Signed-off-by: Michael Strauss
Reviewed-by: Eric
From: Dmytro Laktyushkin
Add more fields to support upcoming dml versions
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Jun Lei
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 35 +++-
.../dc/dml/dcn20/display_mode_vba_20.c|
From: abdoulaye berthe
Make sure that lttpr_caps has the mode set to repeater.
Signed-off-by: abdoulaye berthe
Reviewed-by: Wenjing Liu
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 13 +++--
1 file changed, 11
From: Martin Leung
[why]
While doing seamless boot I made some changes
to dcn2 hubbub functions, missed a link
[how]
link hubbub1 func to hubbub2 usage. It has already
been successfully linked in dcn1 and 3.
Signed-off-by: Martin Leung
Reviewed-by: Alvin Lee
Acked-by: Anthony Koo
Acked-by:
From: Nicholas Kazlauskas
[Why]
There's a data race that can occur between when we update the
inbox write pointer vs when the memory for the command actually gets
flushed from the map to the framebuffer.
DMCUB can read stale or partially invalid data when this race occurs.
[How]
Before
From: Yongqiang Sun
Programming surface flip addresses via dmcub uC for optimizing the data
flush.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/dc.h | 1 +
From: Sung Lee
[Why]
DML Initialization was previously done on dcn21_resource initialization.
This meant that DML soc struct was populated with hardcoded values.
[How]
Move DML initialization to after updating bounding box, to use clock table
values from SMU.
Signed-off-by: Sung Lee
From: Noah Abradjian
[Why]
When rapidly adjusting color temperature, screen tearing was observed.
This was due to overwritten values in gamut remap registers.
This issue was solved for OCSC and ICSC by alternating between "A" and
"B" registers to double buffer the writes.
[How]
Create new
This DC patchset brings improvements in multiple areas. In summary, we
highlight:
* Add OCSC improvements.
* Bug fix on chroma, Freesync dml, and DMUB.
* DMCUB improvements.
* Some code refactor.
Alvin Lee (3):
drm/amd/display: Fix 300Hz Freesync bug
drm/amd/display: Don't always set pstate
From: Nikola Cornij
[why]
If the specific monitor supports DSC, the secondary link should be
disabled, and the other way around, too: if either that monitor or
our ASIC doesn't support DSC, the secodary link should be enabled.
[how]
Add a monitor patch and disable secondary link if that monitor
From: Aric Cyr
Signed-off-by: Aric Cyr
Reviewed-by: Aric Cyr
Acked-by: Harry Wentland
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
On Thu, Jan 9, 2020 at 9:34 PM Joseph Greathouse
wrote:
>
> The only data fabric information the adev struct currently
> contains is a function pointer table. In the near future,
> we will be adding some cached DF information into adev. As
> such, this patch creates a new amdgpu_df struct for
The conversion to bool is not needed, remove it.
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
On Fri, 10 Jan 2020, Thomas Zimmermann wrote:
> Hi
>
> Am 10.01.20 um 12:59 schrieb Jani Nikula:
>> On Fri, 10 Jan 2020, Thomas Zimmermann wrote:
>>> The callback struct drm_driver.get_scanout_position() is deprecated in
>>> favor of struct drm_crtc_helper_funcs.get_scanout_position().
>>>
>>>
Le ven. 10 janv. 2020 à 10:21, Thomas Zimmermann a écrit :
>
> VBLANK callbacks in struct drm_driver are deprecated in favor of
> their equivalents in struct drm_crtc_funcs. Convert sti over.
>
Hi Thomas,
Since you remove the last calls to sti_crtc functions from sti_drv.c I
think that the
Hi
Am 10.01.20 um 12:59 schrieb Jani Nikula:
> On Fri, 10 Jan 2020, Thomas Zimmermann wrote:
>> The callback struct drm_driver.get_scanout_position() is deprecated in
>> favor of struct drm_crtc_helper_funcs.get_scanout_position().
>>
>> i915 doesn't use CRTC helpers. The patch duplicates the
On Fri, 10 Jan 2020, Thomas Zimmermann wrote:
> The callback struct drm_driver.get_scanout_position() is deprecated in
> favor of struct drm_crtc_helper_funcs.get_scanout_position().
>
> i915 doesn't use CRTC helpers. The patch duplicates the caller
> drm_calc_vbltimestamp_from_scanoutpos() for
Am 10.01.20 um 06:30 schrieb Tianci Yin:
From: "Tianci.Yin"
[why]
In dual GPUs scenario, stolen_size is assigned to zero on the secondary GPU,
since there is no pre-OS console using that memory. Then the bottom region of
VRAM was allocated as GTT, unfortunately a small region of bottom VRAM
Looks like you send that patch set out twice.
Which one is the most recent one?
Regards,
Christian.
Am 10.01.20 um 01:43 schrieb Alex Sierra:
[Why]
Avoid reclaim filesystem while eviction lock is held called from
MMU notifier.
[How]
Setting PF_MEMALLOC_NOFS flags while eviction mutex is
The end result looks good, but you should consider re-ordering this
patch set.
That would clean things up and make review much easier.
Adding code first and then removing it later on in the same patch set is
not a good practice.
Regards,
Christian.
Am 10.01.20 um 01:04 schrieb Alex Sierra:
On Fri, 10 Jan 2020, Thomas Zimmermann wrote:
> The new callback get_scanout_position() reads the current location of
> the scanout process. The operation is currentyl located in struct
> drm_driver, but really belongs to the CRTC. Drivers will be converted
> in separate patches.
>
>
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert radeon over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/radeon/radeon_display.c | 12 --
drivers/gpu/drm/radeon/radeon_drv.c | 7 --
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert stm over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/stm/drv.c | 1 -
drivers/gpu/drm/stm/ltdc.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert vkms over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/vkms/vkms_crtc.c | 9 ++---
drivers/gpu/drm/vkms/vkms_drv.c | 1 -
drivers/gpu/drm/vkms/vkms_drv.h | 4
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert sti over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/sti/sti_crtc.c | 11 ---
drivers/gpu/drm/sti/sti_crtc.h | 2 --
drivers/gpu/drm/sti/sti_drv.c | 3 ---
3
All non-legacy users of VBLANK functions in struct drm_driver have been
converted to use the respective interfaces in struct drm_crtc_funcs. The
remaining users of VBLANK callbacks in struct drm_driver are legacy drivers
with userspace modesetting.
There are no users left of
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert msm over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++
drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 2 ++
The new callback get_scanout_position() reads the current location of
the scanout process. The operation is currentyl located in struct
drm_driver, but really belongs to the CRTC. Drivers will be converted
in separate patches.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_vblank.c
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert vmwgfx over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 5 +
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 6 +++---
VBLANK interrupts can be disabled immediately or with a delay, where the
latter is the default. The former option can be selected by setting
get_vblank_timestamp, and enabling vblank_disable_immediate in struct
drm_device.
The setup is only evaluated once when DRM initializes VBLANKs. Evaluating
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert nouvean over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 3 +++
drivers/gpu/drm/nouveau/dispnv50/head.c | 4
The callback struct drm_driver.get_scanout_position() is deprecated in
favor of struct drm_crtc_helper_funcs.get_scanout_position().
i915 doesn't use CRTC helpers. The patch duplicates the caller
drm_calc_vbltimestamp_from_scanoutpos() for i915, such that the callback
function is not needed.
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert gma500 over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 3 +++
drivers/gpu/drm/gma500/psb_drv.c | 4
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert i915 over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/i915/display/intel_display.c | 7 +++
drivers/gpu/drm/i915/i915_drv.c | 2 --
The callback struct drm_driver.get_scanout_position() is deprecated in
favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm
over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/stm/drv.c | 1 -
drivers/gpu/drm/stm/ltdc.c | 65 --
The callback struct drm_driver.get_scanout_position() is deprecated in
favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert
mem over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 67 +++
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert amdgpu over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4
The callback struct drm_driver.get_scanout_position() is deprecated in
favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert vc4
over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/vc4/vc4_crtc.c | 12 +++-
drivers/gpu/drm/vc4/vc4_drv.c | 1 -
All users of struct drm_driver.get_scanout_position() have been
covnerted to the respective CRTC helper function. Remove the callback
from struct drm_driver.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_vblank.c | 13 ++---
include/drm/drm_drv.h| 52
1 - 100 of 106 matches
Mail list logo
