RE: [PATCH] drm/amdgpu: fix psp ucode not loaded in bare-metal

Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Monk Liu Sent: Friday, February 21, 2020 2:55 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH] drm/amdgpu: fix psp ucode not loaded in bare-metal for bare-metal we alawys need to load sys/sos/kdb

[PATCH] drm/amdgpu: fix psp ucode not loaded in bare-metal

for bare-metal we alawys need to load sys/sos/kdb Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index 3494966..51839ab

Re: [PATCH 09/11] drm, cgroup: Introduce lgpu as DRM cgroup resource

Thanks, I will take a look. Regards, Kenny On Wed, Feb 19, 2020 at 1:38 PM Johannes Weiner wrote: > > On Wed, Feb 19, 2020 at 11:28:48AM -0500, Kenny Ho wrote: > > On Wed, Feb 19, 2020 at 11:18 AM Johannes Weiner wrote: > > > > > > Yes, I'd go with absolute units when it comes to memory,

[PATCH] radeon, amdgpu: allow for symbolic errno output when reporting drm_edid_to_sad errors

This fixes some kernel log text when CONFIG_SYMBOLIC_ERRNAMES=Y. Signed-off-by: Darren Salt amd-dc-errname.patch Description: Binary data ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 4/8] drm/nouveau: don't use ttm bo->offset v3

On 2020-02-19 08:53, Nirmoy Das wrote: > Store ttm bo->offset in struct nouveau_bo instead. > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 6 +++--- > drivers/gpu/drm/nouveau/dispnv04/disp.c | 2 +- > drivers/gpu/drm/nouveau/dispnv04/overlay.c | 6

Re: [PATCH 2/8] drm/radeon: don't use ttm bo->offset

On 2020-02-19 08:53, Nirmoy Das wrote: > Calculate GPU offset in radeon_bo_gpu_offset without depending on > bo->offset > > Signed-off-by: Nirmoy Das > Reviewed-and-tested-by: Christian König > --- > drivers/gpu/drm/radeon/radeon.h| 1 + > drivers/gpu/drm/radeon/radeon_object.h | 16

Re: [PATCH 1/8] drm/amdgpu: move ttm bo->offset to amdgpu_bo

On 2020-02-19 08:53, Nirmoy Das wrote: > GPU address should belong to driver not in memory management. > This patch moves ttm bo.offset and gpu_offset calculation to amdgpu driver. > > Signed-off-by: Nirmoy Das > Acked-by: Huang Rui > Reviewed-by: Christian König > --- >

Re: [PATCH AUTOSEL 5.5 530/542] drm/amdgpu/smu10: fix smu10_get_clock_by_type_with_voltage

On Thu, Feb 20, 2020 at 2:26 PM Sasha Levin wrote: > > On Fri, Feb 14, 2020 at 11:31:31AM -0500, Alex Deucher wrote: > >On Fri, Feb 14, 2020 at 11:00 AM Sasha Levin wrote: > >> > >> From: Alex Deucher > >> > >> [ Upstream commit 1064ad4aeef94f51ca230ac639a9e996fb7867a0 ] > >> > >> Cull out 0

Re: [PATCH AUTOSEL 5.5 530/542] drm/amdgpu/smu10: fix smu10_get_clock_by_type_with_voltage

On Fri, Feb 14, 2020 at 11:31:31AM -0500, Alex Deucher wrote: On Fri, Feb 14, 2020 at 11:00 AM Sasha Levin wrote: From: Alex Deucher [ Upstream commit 1064ad4aeef94f51ca230ac639a9e996fb7867a0 ] Cull out 0 clocks to avoid a warning in DC. Bug:

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v2

On 2/20/20 7:09 PM, Daniel Vetter wrote: On Wed, Feb 19, 2020 at 02:53:20PM +0100, Nirmoy Das wrote: Calculate GEM VRAM bo's offset within vram-helper without depending on bo->offset Signed-off-by: Nirmoy Das --- drivers/gpu/drm/drm_gem_vram_helper.c | 17 - 1 file

Re: [PATCH 7/8] drm/bochs: use drm_gem_vram_offset to get bo offset v2

On Wed, Feb 19, 2020 at 02:53:21PM +0100, Nirmoy Das wrote: > Switch over to GEM VRAM's implementation to retrieve bo->offset > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/bochs/bochs_kms.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v2

On Wed, Feb 19, 2020 at 02:53:20PM +0100, Nirmoy Das wrote: > Calculate GEM VRAM bo's offset within vram-helper without depending on > bo->offset > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-)

Re: [PATCH AUTOSEL 5.5 408/542] drm/amdgpu: add the lost mutex_init back

On Fri, Feb 14, 2020 at 11:22:27AM -0500, Alex Deucher wrote: On Fri, Feb 14, 2020 at 10:57 AM Sasha Levin wrote: From: "Pan, Xinhui" [ Upstream commit bd0522112332663e386df1b8642052463ea9b3b9 ] Initialize notifier_lock. Bug: https://gitlab.freedesktop.org/drm/amd/issues/1016 Reviewed-by:

回复: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

Isn't from me... damn keyboard -邮件原件- 发件人: amd-gfx 代表 Liu, Monk 发送时间: 2020年2月20日 23:24 收件人: Das, Nirmoy ; amd-gfx@lists.freedesktop.org 主题: 回复: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference I don't know The patch is from me, I just think the patch is dropping a vm update

回复: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

I don't know The patch is from me, I just think the patch is dropping a vm update which looks not perfect to me -邮件原件- 发件人: amd-gfx 代表 Nirmoy 发送时间: 2020年2月20日 23:21 收件人: amd-gfx@lists.freedesktop.org 主题: Re: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference Hi Monk, How  can

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

[AMD Official Use Only - Internal Distribution Only] You can enhance amdgpu_vm_ioctl In amdgpu_vm.c to return vmid to userspace. -David From: He, Jacob Sent: Thursday, February 20, 2020 10:46 PM To: Zhou, David(ChunMing) ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: RE:

Re: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

Hi Monk, How  can I reproduce this bug ? Regards, Nirmoy On 2/20/20 4:15 PM, Nirmoy wrote: On 2/20/20 2:35 PM, Liu, Monk wrote: Sorry, my previous idea still leave RQ null, please check if below method works: 29 static struct drm_sched_rq * 130 drm_sched_entity_get_free_sched(struct

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

[AMD Official Use Only - Internal Distribution Only] Hi Christian, This patch is just for a simple scenario. Multiple SPM processes is not supported. That is saying, it’s not necessary to take MCBP or other complicated cases into account. UMD waits GPU idle right before enabling SPM trace.

Re: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

On 2/20/20 2:35 PM, Liu, Monk wrote: Sorry, my previous idea still leave RQ null, please check if below method works: 29 static struct drm_sched_rq * 130 drm_sched_entity_get_free_sched(struct drm_sched_entity *entity) 131 { 132 struct drm_sched_rq *rq = NULL; 133 unsigned int

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

amdgpu_vm_reserve_vmid doesn’t return the reserved vmid back to user space. There is no chance for user mode driver to update RLC_SPM_VMID. Thanks Jacob From: He, Jacob Sent: Thursday, February 20, 2020 6:20 PM To: Zhou, David(ChunMing);

Re: [PATCH] drm/amdgpu/discovery: make the discovery code less chatty

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Xiaojie Yuan BR, Xiaojie From: amd-gfx on behalf of Alex Deucher Sent: Thursday, February 20, 2020 2:51 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH]

回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

Sorry, my previous idea still leave RQ null, please check if below method works: 29 static struct drm_sched_rq * 130 drm_sched_entity_get_free_sched(struct drm_sched_entity *entity) 131 { 132 struct drm_sched_rq *rq = NULL; 133 unsigned int min_jobs = UINT_MAX, num_jobs; 134 int i;

Re: [PATCH] drm/amdgpu/display: fix logic inversion in program_timing_sync()

On Tue, Feb 4, 2020 at 9:06 AM Kazlauskas, Nicholas wrote: > > Comments inline. > > On 2020-02-03 4:07 p.m., Alex Deucher wrote: > > Ping? > > > > On Fri, Jan 10, 2020 at 3:11 PM Alex Deucher wrote: > >> > >> It looks like we should be reducing the group size when we don't > >> have a plane

回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

so the scenario is: KMD doing page update -> ECC -> baco reset (mute SDMA scheduler) -> drm_sched_entity_get_free_sched() return NULL -> you get your NULL pointer And your approach is to introduce a bail out in the amdgpu_vm_sdma_commit() so the original amdgpu vm update jobs will be dropped,

Re: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

On 2/20/20 9:41 AM, Li, Dennis wrote: [AMD Official Use Only - Internal Distribution Only] Hi, Christian and Monk, When doing SDMA copy, a RAS uncorrectable error happens, which will cause this issue. The RAS uncorrectable error event will trigger driver to do BACO reset which will

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

Looks like amdgpu_vm_reserve_vmid could work, let me have a try to update the RLC_SPM_VMID with pm4 packets in UMD. Thanks Jacob From: Zhou, David(ChunMing) Sent: Thursday, February 20, 2020 10:13 AM To: Koenig, Christian; He,

RE: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

[AMD Official Use Only - Internal Distribution Only] Hi, Christian and Monk, When doing SDMA copy, a RAS uncorrectable error happens, which will cause this issue. The RAS uncorrectable error event will trigger driver to do BACO reset which will set the status of SDMA scheduler to no

[PATCH] amdgpu/gmc_v9: save/restore sdpif regs during S3

fixes S3 issue with IOMMU + S/G enabled @ 64M VRAM. Suggested-by: Alex Deucher Signed-off-by: Shirish S Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 + drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 37 ++-