[PATCH] drm/amd/powerplay: determine pm_en at amd_powerplay_create

2020-04-01 Thread Tiecheng Zhou
Need to determine pm_en at amd_powerplay_create of early_init stage. Signed-off-by: Tiecheng Zhou --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 3 +++ drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] amdgpu/drm: remove psp access on navi10 for sriov

2020-04-01 Thread Felix Kuehling
Am 2020-04-01 um 6:00 p.m. schrieb Alex Sierra: > Navi ASICs don't require to access through PSP to osssys registers. > This on SR-IOV configuration. > > Signed-off-by: Alex Sierra Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 18 +- > 1 file

[PATCH] amdgpu/drm: remove psp access on navi10 for sriov

2020-04-01 Thread Alex Sierra
Navi ASICs don't require to access through PSP to osssys registers. This on SR-IOV configuration. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c

Re: [PATCH] Revert "drm/amdgpu: call psp to program ih cntl in SR-IOV for Navi"

2020-04-01 Thread Felix Kuehling
Am 2020-04-01 um 5:00 p.m. schrieb Alex Sierra: > This reverts commit 9e517bb84c282c1f06edded20f16f927426d2e40. > Navi ASICs don't require to access through PSP to osssys registers. > This on SR-IOV configuration. If you submit this change, please don't forget to add a Signed-off-by line and feel

[PATCH] Revert "drm/amdgpu: call psp to program ih cntl in SR-IOV for Navi"

2020-04-01 Thread Alex Sierra
This reverts commit 9e517bb84c282c1f06edded20f16f927426d2e40. Navi ASICs don't require to access through PSP to osssys registers. This on SR-IOV configuration. --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 89 +++--- 1 file changed, 9 insertions(+), 80 deletions(-) diff --git

[PATCH 1/2] drm/amd/display: query hdcp capability during link detect

2020-04-01 Thread Bhawanpreet Lakha
[Why] Query the hdcp caps of a link, it is useful and can be reported to the user [How] Create a query function and call it during link detect Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 56 drivers/gpu/drm/amd/display/dc/dc.h |

[PATCH 2/2] drm/amd/display: add HDCP caps debugfs

2020-04-01 Thread Bhawanpreet Lakha
Add debugfs to get HDCP capability. This is also useful for kms_content_protection igt test. Use: cat /sys/kernel/debug/dri/0/DP-1/hdcp_sink_capability cat /sys/kernel/debug/dri/0/HDMI-A-1/hdcp_sink_capability Signed-off-by: Bhawanpreet Lakha ---

Re: [PATCH] drm/amdkfd: kfree the wrong pointer

2020-04-01 Thread Felix Kuehling
Am 2020-04-01 um 8:12 a.m. schrieb Jack Zhang: > Originally, it kfrees the wrong pointer for mem_obj. > It would cause memory leak under stress test. > > Signed-off-by: Jack Zhang Reviewed-by: Felix Kuehling Thanks for catching this. Did you actually run into this code path? In that case we

Re: [PATCH] drm/amdkfd: Provide SMI events watch

2020-04-01 Thread Felix Kuehling
Am 2020-04-01 um 9:10 a.m. schrieb Amber Lin: > > Thanks Felix for the review. I have a better understanding of how > kfifo works now and have changed my code quite a bit. Couple of > questions below inline regarding the gpu_id and data arguments. > Replies inline ... > Thanks. > > Amber > > On

Re: [PATCH] drm/amd/display: remove mod_hdcp_hdcp2_get_link_encryption_status()

2020-04-01 Thread Kazlauskas, Nicholas
On 2020-04-01 3:56 p.m., Bhawanpreet Lakha wrote: It is not being used, so remove it Signed-off-by: Bhawanpreet Lakha Thanks for the follow up! Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas --- .../gpu/drm/amd/display/modules/hdcp/hdcp.h | 2 --

[PATCH] drm/amd/display: remove mod_hdcp_hdcp2_get_link_encryption_status()

2020-04-01 Thread Bhawanpreet Lakha
It is not being used, so remove it Signed-off-by: Bhawanpreet Lakha --- .../gpu/drm/amd/display/modules/hdcp/hdcp.h | 2 -- .../drm/amd/display/modules/hdcp/hdcp_psp.c | 29 --- 2 files changed, 31 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp.h

[pull] amdgpu, amdkfd drm-next-5.7

2020-04-01 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.7. The following changes since commit 59e7a8cc2dcf335116d500d684bfb34d1d97a6fe: Merge tag 'drm-msm-next-2020-03-22' of https://gitlab.freedesktop.org/drm/msm into drm-next (2020-03-31 16:34:55 +1000) are available in the Git repository at:

Re: [PATCH 0/4] drm/dp_mst: Remove ->destroy_connector() callback

2020-04-01 Thread Alex Deucher
On Tue, Mar 31, 2020 at 4:58 PM Lyude Paul wrote: > > This finishes up the work that Pankaj Bharadiya started in: > > https://patchwork.freedesktop.org/series/74412/ > > And allows us to entirely remove ->destroy_connector() > > Lyude Paul (4): > drm/amd/amdgpu_dm/mst: Remove unneeded edid

Re: [PATCH 2/2] drm/amd/dc: Kill dc_conn_log_hex_linux()

2020-04-01 Thread Alex Deucher
On Wed, Apr 1, 2020 at 9:00 AM Kazlauskas, Nicholas wrote: > > On 2020-03-31 5:22 p.m., Lyude Paul wrote: > > DRM already supports tracing DPCD transactions, there's no reason for > > the existence of this function. Also, it prints one byte per-line which > > is way too loud. So, just remove it.

Re: [PATCH][next] drm/amdgpu/vcn: fix spelling mistake "fimware" -> "firmware"

2020-04-01 Thread Alex Deucher
On Wed, Apr 1, 2020 at 12:35 PM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a dev_err error message. Fix it. > > Signed-off-by: Colin Ian King Applied. thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH][next] drm/amdgpu/vcn: fix spelling mistake "fimware" -> "firmware"

2020-04-01 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

RE: [PATCH 1/6] dma-buf: add peer2peer flag

2020-04-01 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Daniel Vetter >Sent: Wednesday, April 1, 2020 7:35 AM >To: Christian König >Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org >Subject: Re: [PATCH 1/6] dma-buf: add peer2peer flag > >On Mon, Mar 30, 2020 at 03:55:31PM

Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-04-01 Thread Nirmoy
On 4/1/20 5:02 PM, Luben Tuikov wrote: On 2020-03-31 08:46, Nirmoy wrote: On 3/31/20 3:01 AM, Luben Tuikov wrote: This patch seems to be using DOS line-endings. Strange, I don't see that in my local patch file. Not sure why "git am" complained about DOS endings the first time I downloaded

Re: [PATCH 5/5] drm/amdgpu: utilize subconnector property for DP through DisplayManager

2020-04-01 Thread Alex Deucher
On Wed, Apr 1, 2020 at 8:17 AM Jeevan B wrote: > > Since DP-specific information is stored in driver's structures, every > driver needs to implement subconnector property by itself. Display > Core already has the subconnector information, we only need to > expose it through DRM property. > >

Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-04-01 Thread Luben Tuikov
On 2020-03-31 08:46, Nirmoy wrote: > > On 3/31/20 3:01 AM, Luben Tuikov wrote: >> This patch seems to be using DOS line-endings. > > > Strange, I don't see that in my local patch file. > Not sure why "git am" complained about DOS endings the first time I downloaded it. Second time was fine.

Re: [PATCH] drm/amdkfd: Provide SMI events watch

2020-04-01 Thread Amber Lin
Thanks Felix for the review. I have a better understanding of how kfifo works now and have changed my code quite a bit. Couple of questions below inline regarding the gpu_id and data arguments. Thanks. Amber On 2020-03-26 4:53 p.m., Felix Kuehling wrote: Hi Amber, I see that this is based

Re: [PATCH 2/2] drm/amd/dc: Kill dc_conn_log_hex_linux()

2020-04-01 Thread Kazlauskas, Nicholas
On 2020-03-31 5:22 p.m., Lyude Paul wrote: DRM already supports tracing DPCD transactions, there's no reason for the existence of this function. Also, it prints one byte per-line which is way too loud. So, just remove it. Signed-off-by: Lyude Paul Thanks for helping clean this up! Series

Re: [PATCH] drm/amd/display: Guard calls to hdcp_ta and dtm_ta

2020-04-01 Thread Kazlauskas, Nicholas
On 2020-03-31 2:08 p.m., Lakha, Bhawanpreet wrote: [AMD Official Use Only - Internal Distribution Only] mod_hdcp_hdcp2_get_link_encryption_status() isn't being used, should probably remove it in a followup patch I still think it's better if you add it to the function for consistency. Feel

Re: [PATCH] drm/amdkfd: kfree the wrong pointer

2020-04-01 Thread Nirmoy
On 4/1/20 2:12 PM, Jack Zhang wrote: Originally, it kfrees the wrong pointer for mem_obj. It would cause memory leak under stress test. Signed-off-by: Jack Zhang Acked-by: Nirmoy Das --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 5/5] drm/amdgpu: utilize subconnector property for DP through DisplayManager

2020-04-01 Thread Jeevan B
Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself. Display Core already has the subconnector information, we only need to expose it through DRM property. Signed-off-by: Oleg Vasilev Tested-by: Oleg Vasilev Cc: Alex

[PATCH] drm/amdkfd: kfree the wrong pointer

2020-04-01 Thread Jack Zhang
Originally, it kfrees the wrong pointer for mem_obj. It would cause memory leak under stress test. Signed-off-by: Jack Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c

[PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Yuxian Dai
1.Using the FCLK DPM table to set the MCLK for DPM states consist of three entities: FCLK UCLK MEMCLK All these three clk change together, MEMCLK from FCLK, so use the fclk frequency. 2.we should show the current working clock freqency from clock table metric Signed-off-by: Yuxian Dai

Re: [PATCH 1/6] dma-buf: add peer2peer flag

2020-04-01 Thread Daniel Vetter
On Mon, Mar 30, 2020 at 03:55:31PM +0200, Christian König wrote: > Add a peer2peer flag noting that the importer can deal with device > resources which are not backed by pages. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-buf.c | 2 ++ > include/linux/dma-buf.h | 10

[PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Yuxian Dai
From: "yuxia...@amd.com" 1,Using the FCLK DPM table to set the MCLK for DPM states consist of three entities: FCLK UCLK MEMCLK All these three clk change together, MEMCLK from FCLK, so use the fclk frequency. 2,we should show the current working clock freqency from clock table metric

Re: [PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Yuxian Dai Sent: Wednesday, April 1, 2020 3:14 PM To: amd-gfx@lists.freedesktop.org Cc: Dai, Yuxian (David) ; Dai, Yuxian (David) Subject: [PATCH] drm/amdgpu/powerplay: using

[PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Yuxian Dai
From: "yuxia...@amd.com" 1,Using the FCLK DPM table to set the MCLK for DPM states consist of three entities: FCLK UCLK MEMCLK All these three clk change together, MEMCLK from FCLK, so use the fclk frequency. 2,we should show the current working clock freqency from clock table metric

RE: [PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Dai, Yuxian (David)
[AMD Official Use Only - Internal Distribution Only] 1,Using the FCLK DPM table to set the MCLK for DPM states consist of three entities: FCLK UCLK MEMCLK All these three clk change together, MEMCLK from FCLK, so use the fclk frequency. 2,we should show the current working clock freqency from

[PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Yuxian Dai
From: "yuxia...@amd.com" 1,Using the FCLK DPM table to set the MCLK for DPM states consist of three entities: FCLK UCLK MEMCLK All these three clk change together, MEMCLK from FCLK, so use the fclk frequency. 2,we should show the current working clock freqency from clock table metric

Re: [PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Yuxian Dai Sent: Wednesday, April 1, 2020 2:02 PM To: amd-gfx@lists.freedesktop.org Cc: Dai, Yuxian (David) ; Dai, Yuxian (David) Subject: [PATCH] drm/amdgpu/powerplay: using

[PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Yuxian Dai
From: "yuxia...@amd.com" 1,Using the FCLK DPM table to set the MCLK for DPM states consist of three entities: FCLK UCLK MEMCLK All these three clk change together, MEMCLK from FCLK, so use the fclk frequency. 2,we should show the current working clock freqency from clock table metric