Re: [PATCH] drm/amdgpu: ensure device_list is initialised before calling list_add_tail

2020-04-10 Thread Andrey Grodzovsky
On 4/10/20 6:57 PM, Colin King wrote: From: Colin Ian King Currently the call to list_add_tail will access an the uninitalised device_list.prev. Fix this by ensuring device_list is initialized before adding items to it. Addresses-Coverity: ("Uninitialized pointer read") That weird, I see

BUG: kernel NULL pointer dereference, address: 0000000000000026 after switching to 5.7 kernel

2020-04-10 Thread Mikhail Gavrilov
Hi folks. After upgrade kernel to 5.7 I see every boot in kernel log following error messages: [2.569513] [drm] Found UVD firmware ENC: 1.2 DEC: .43 Family ID: 19 [2.569538] [drm] PSP loading UVD firmware [2.570038] BUG: kernel NULL pointer dereference, address: 0026 [

[PATCH] drm/amdgpu: pass unlocked flag to params at amdgpu_vm_bo_update_mapping

2020-04-10 Thread Alex Sierra
Pass unlocked flag value to amdgpu_vm_update_params.unlocked struct member at amdgpu_vm_bo_update_mapping. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

Re: [PATCH 1/3] drm/amdgpu/ring: add no_scheduler flag

2020-04-10 Thread Christian König
Am 10.04.20 um 14:49 schrieb Alex Deucher: This allows IPs to flag whether a specific ring requires a GPU scheduler or not. E.g., sometimes instances of an IP are asymmetric and have different capabilities. Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Reviewed-by: Christian König

Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

2020-04-10 Thread Christian König
Am 09.04.20 um 22:01 schrieb Peter Zijlstra: On Thu, Apr 09, 2020 at 08:15:57PM +0200, Christian König wrote: Am 09.04.20 um 19:09 schrieb Peter Zijlstra: On Thu, Apr 09, 2020 at 05:59:56PM +0200, Peter Zijlstra wrote: [SNIP] I'll need another approach, let me consider. Christian; it says

[PATCH 1/3] drm/amdgpu/ring: add no_scheduler flag

2020-04-10 Thread Alex Deucher
This allows IPs to flag whether a specific ring requires a GPU scheduler or not. E.g., sometimes instances of an IP are asymmetric and have different capabilities. Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 ++-

[PATCH 3/3] drm/amdgpu/ring: simplify scheduler setup logic

2020-04-10 Thread Alex Deucher
Set up a GPU scheduler based on the ring flag rather than the ring type. Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c

[PATCH 2/3] drm/amdgpu/kiq: add no_scheduler flag to KIQ

2020-04-10 Thread Alex Deucher
We don't want a GPU scheduler for this ring. Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c index

[PATCH] drm/amdgpu/powerplay: get SMC FW size to a flexible way

2020-04-10 Thread Alex Deucher
From: Likun Gao Get SMC fw size before backdoor loading instead of giving an certain value, as it may different for different ASIC. Signed-off-by: Likun Gao Reviewed-by: Kenneth Feng Reviewed-by: Evan Quan Reviewed-by: Kevin Wang Signed-off-by: Alex Deucher ---

Re: [PATCH] drm/amdgpu: fix wrong vram lost counter increment

2020-04-10 Thread Alex Deucher
On Fri, Apr 10, 2020 at 4:02 AM Evan Quan wrote: > > Vram lost counter is wrongly increased by two during baco reset. > > Change-Id: I8b9959a5d1632abc774ba07d56cf295bdd8288eb > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 36 -- >

[PATCH] drm/amd/display: remove redundant assignment to variable dp_ref_clk_khz

2020-04-10 Thread Colin King
From: Colin Ian King The variable dp_ref_clk_khz is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH] drm/ttm: Break out the loops if need_resched in bo delayed delete worker

2020-04-10 Thread Koenig, Christian
Am 10.04.2020 12:58 schrieb "Pan, Xinhui" : The delayed delete list is per device which might be very huge. And in a heavy workload test, the list might always not be empty. That will trigger any RCU stall warnings or softlockups in non-preemptible kernels Lets do break out the loops in that

[PATCH] drm/ttm: Break out the loops if need_resched in bo delayed delete worker

2020-04-10 Thread xinhui pan
The delayed delete list is per device which might be very huge. And in a heavy workload test, the list might always not be empty. That will trigger any RCU stall warnings or softlockups in non-preemptible kernels Lets do break out the loops in that case. Signed-off-by: xinhui pan ---

RE: [PATCH] drm/amdgpu: refine ras related message print

2020-04-10 Thread Zhang, Hawking
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chen, Guchun Sent: Friday, April 10, 2020 15:59 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Zhou1, Tao ; Clements, John Cc: Chen, Guchun

RE: [PATCH] drm/amdgpu: add uncorrectable error count print in UMC ecc irq cb

2020-04-10 Thread Chen, Guchun
[AMD Public Use] Hi Hawking, I submitted one new patch to address these rules just now. Please review. Regards, Guchun _ From: Zhang, Hawking Sent: Friday, April 10, 2020 1:07 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Li, Dennis ; Zhou1,

[PATCH] drm/amdgpu: fix wrong vram lost counter increment

2020-04-10 Thread Evan Quan
Vram lost counter is wrongly increased by two during baco reset. Change-Id: I8b9959a5d1632abc774ba07d56cf295bdd8288eb Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 36 -- drivers/gpu/drm/amd/amdgpu/cik.c | 2 --

RE: [PATCH] drm/amdgpu: add uncorrectable error count print in UMC ecc irq cb

2020-04-10 Thread Chen, Guchun
[AMD Public Use] Hi Hawking, I submitted one new patch to address these rules just now. Please review. Regards, Guchun _ From: Zhang, Hawking Sent: Friday, April 10, 2020 1:07 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Li, Dennis ; Zhou1,

[PATCH] drm/amdgpu: refine ras related message print

2020-04-10 Thread Guchun Chen
Prefix ras related kernel message logging with PCI device info by replacing DRM_INFO/WARN/ERROR with dev_info/warn/err. This can clearly tell user about GPU device information where ras is on. And add some other RAS information printing to make it more clear and friendly as well. Suggested-by:

Re: Possibility of RX570 responsible for spontaneous reboots (MCE) with Ryzen 3700x?

2020-04-10 Thread Clemens Eisserer
Hi Someguy, I've been running with accelmethod=none and llvmpipe for opengl now for over a week (more or less using only the display engine of my rx570) and haven't experienced a single MCE during that period. However, statistically, it will take 1-2 additional weeks to be sure this is not a