[PATCH] drm/admgpu: check HDMI HPD status after ddc probe

2020-05-08 Thread Binbin Zhou
Now, we check the presence of the EDID to determine if there is a monitor present. DVI-I connectors have both analog and digital encoders and the HPD pin is only reliable on the digital part. But when I pull out the Radeon HD8570's HDMI connector, the HDMI status in system is still perform

[PATCH] drm/amd/powerplay: report correct AC/DC event based on ctxid V2

2020-05-08 Thread Evan Quan
'ctxid' is used to distinguish different events raised from SMC. 0x3 and 0x4 are for AC and DC power mode. V2: update the way to retrieve the ctxid and change the log level to debug Change-Id: I7dbcb053fe9cea7c70e0a33afc2115b3745f6186 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher ---

RE: [PATCH 1/2] drm/amdgpu: decode the ctxid for SMC to host IH

2020-05-08 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] OK. Reasonable. Will update the patches. BR, Evan -Original Message- From: Christian König Sent: Friday, May 8, 2020 6:53 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 1/2] drm/amdgpu:

Re: [PATCH] drm/amd/display: Fix vblank and pageflip event handling for FreeSync

2020-05-08 Thread Mario Kleiner
On Thu, May 7, 2020 at 7:35 PM Kazlauskas, Nicholas < nicholas.kazlaus...@amd.com> wrote: > It applies on top of Alex's amd-staging-drm-next-branch. > > It is essentially just a revert to the old behavior with > acrtc_state->active_planes == 0 special case you added on top and some > small

Re: [PATCH 2/2] drm/amd/powerplay: report correct AC/DC event based on ctxid

2020-05-08 Thread Alex Deucher
On Fri, May 8, 2020 at 6:03 AM Evan Quan wrote: > > 'ctxid' is used to distinguish different events raised from SMC. > 0x3 and 0x4 are for AC and DC power mode. > > Change-Id: I7dbcb053fe9cea7c70e0a33afc2115b3745f6186 > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/powerplay/smu_v11_0.c

Re: [PATCH] drm/amd/display: Fix pageflip event race condition for DCN. (v2)

2020-05-08 Thread Matt Coffin
Just to follow up on this, I decided not to file the report, since Nick's latest patch that "Fixes:" this has fixed my issue. Thanks for the good work on that one Nick. Might want to make sure that makes it in to the 5.7 fixes :) Thanks again guys. ~Matt On 5/5/20 11:59 AM, Kazlauskas,

RE: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-08 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Bernard Zhao >Sent: Thursday, May 7, 2020 5:13 AM >To: Alex Deucher ; Christian König >; David (ChunMing) Zhou >; David Airlie ; Daniel Vetter >; Tom St Denis ; Sam Ravnborg >; Ori Messinger ; Bernard >Zhao ;

Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-08 Thread Sam Ravnborg
On Fri, May 08, 2020 at 10:55:42AM +0100, Emil Velikov wrote: > On Fri, 8 May 2020 at 09:16, Christian König wrote: > > > > Am 07.05.20 um 20:03 schrieb Sam Ravnborg: > > > Hi Emil. > > > > > > On Thu, May 07, 2020 at 04:07:52PM +0100, Emil Velikov wrote: > > >> From: Emil Velikov > > >> > > >>

Re: [PATCH 1/2] drm/amdgpu: decode the ctxid for SMC to host IH

2020-05-08 Thread Christian König
Am 08.05.20 um 12:02 schrieb Evan Quan: Driver needs that to tell the different events raised from SMC. NAK, the ctxid is filled in by the SMC and not by the IH. We only decode fields here which are filled in by the IH. Just use src_data[0] when you need some SMC specific bits. Christian.

[PATCH 2/2] drm/amd/powerplay: report correct AC/DC event based on ctxid

2020-05-08 Thread Evan Quan
'ctxid' is used to distinguish different events raised from SMC. 0x3 and 0x4 are for AC and DC power mode. Change-Id: I7dbcb053fe9cea7c70e0a33afc2115b3745f6186 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 15 +-- 1 file changed, 13 insertions(+), 2

[PATCH 1/2] drm/amdgpu: decode the ctxid for SMC to host IH

2020-05-08 Thread Evan Quan
Driver needs that to tell the different events raised from SMC. Change-Id: I0e44e22527182fbb45a2db4fc3b1cd73fb17ba33 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 1 + drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 1 + drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 1 + 3 files

Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-08 Thread Emil Velikov
On Fri, 8 May 2020 at 09:16, Christian König wrote: > > Am 07.05.20 um 20:03 schrieb Sam Ravnborg: > > Hi Emil. > > > > On Thu, May 07, 2020 at 04:07:52PM +0100, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> The driver does not hold struct_mutex, thus using the locked version of > >> the

RE: [PATCH] Series to disallow XGMI link power down during RAS XGMI error injection

2020-05-08 Thread Clements, John
[AMD Public Use] Responses inline From: Chen, Guchun Sent: Friday, May 8, 2020 3:11 PM To: Clements, John ; amd-gfx@lists.freedesktop.org; Zhang, Hawking Subject: RE: [PATCH] Series to disallow XGMI link power down during RAS XGMI error injection [AMD Public Use] Patch 1, 1. maybe it's

Re: [PATCH] drm/amdgpu: implement soft_recovery for gfx10

2020-05-08 Thread Christian König
Am 05.05.20 um 18:42 schrieb Alex Deucher: Same as gfx9. This allows us to kill the waves for hung shaders. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [PATCH 1/1] drm/amdgpu: cleanup sysfs file handling

2020-05-08 Thread Christian König
Am 08.05.20 um 10:48 schrieb Nirmoy Das: Create sysfs file using attributes. Signed-off-by: Nirmoy Das Reviewed-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 36 -- 1 file changed, 12 insertions(+), 24 deletions(-)

[PATCH 1/1] drm/amdgpu: cleanup sysfs file handling

2020-05-08 Thread Nirmoy Das
Create sysfs file using attributes. Signed-off-by: Nirmoy Das Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 36 -- 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-08 Thread Christian König
Am 07.05.20 um 20:03 schrieb Sam Ravnborg: Hi Emil. On Thu, May 07, 2020 at 04:07:52PM +0100, Emil Velikov wrote: From: Emil Velikov The driver does not hold struct_mutex, thus using the locked version of the helper is incorrect. Cc: Alex Deucher Cc: Christian König Cc:

Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-08 Thread Christian König
Am 07.05.20 um 17:07 schrieb Emil Velikov: From: Emil Velikov The driver does not hold struct_mutex, thus using the locked version of the helper is incorrect. Cc: Alex Deucher Cc: Christian König Cc: amd-gfx@lists.freedesktop.org Fixes: a39414716ca0 ("drm/amdgpu: add independent DMA-buf

RE: [PATCH] Series to disallow XGMI link power down during RAS XGMI error injection

2020-05-08 Thread Chen, Guchun
[AMD Public Use] Patch 1, 1. maybe it's better to split it into 2, one is for header file change, and another is functional patch. 2. Can below codes be merged to one return instead? Variable 'en' can serve the function input in smu_send_smc_msg_with_param. if (en) +

RE: [PATCH] Series to disallow XGMI link power down during RAS XGMI error injection

2020-05-08 Thread Zhang, Hawking
[AMD Official Use Only - Internal Distribution Only] Patch #1 + pr_err("[AllowXgmiPowerDown] failed!\n"); Please replace pr_xxx with dev_xxx to explicitly show device bdf in kernel message especially for mGPU use case + if (smu_version < 0x365000) { Let's