Re: [PATCH] drm/amdgpu/display: drop the reduction loop when setting the sync groups

2020-05-29 Thread Kazlauskas, Nicholas
On 2020-05-29 2:04 p.m., Alex Deucher wrote: On Fri, May 29, 2020 at 9:56 AM Kazlauskas, Nicholas wrote: On 2020-05-28 10:06 a.m., Alex Deucher wrote: The logic for blanked is not the same as having a plane_state. Technically you can drive an OTG without anything connected in the front end

Re: [PATCH] drm/amdgpu/display: drop the reduction loop when setting the sync groups

2020-05-29 Thread Alex Deucher
On Fri, May 29, 2020 at 9:56 AM Kazlauskas, Nicholas wrote: > > On 2020-05-28 10:06 a.m., Alex Deucher wrote: > > The logic for blanked is not the same as having a plane_state. Technically > > you can drive an OTG without anything connected in the front end and it'll > > just draw out the back

Re: [PATCH] drm/amdgpu/display: drop the reduction loop when setting the sync groups

2020-05-29 Thread Kazlauskas, Nicholas
On 2020-05-28 10:06 a.m., Alex Deucher wrote: The logic for blanked is not the same as having a plane_state. Technically you can drive an OTG without anything connected in the front end and it'll just draw out the back color which is distinct from having the OTG be blanked. If we add planes or

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-29 Thread Souptick Joarder
On Thu, May 28, 2020 at 12:37 AM John Hubbard wrote: > > On 2020-05-27 01:51, Daniel Vetter wrote: > > On Wed, May 27, 2020 at 10:48:52AM +0200, Daniel Vetter wrote: > >> On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: > >>> On 2020-05-26 14:00, Souptick Joarder wrote: > This

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-29 Thread John Hubbard
On 2020-05-28 23:49, Souptick Joarder wrote: ... This is what case 3 was *intended* to cover, but it looks like case 3 needs to be written a little better. I'll attempt that, and Cc you on the actual patch to -mm. (I think we also need a case 5 for an unrelated scenario, too, so it's time.)

Re: [PATCH] drm/amdgpu/pm: don't bail for in_suspend

2020-05-29 Thread Michel Dänzer
On 2020-05-28 12:51 a.m., Alex Deucher wrote: > Otherwise we disable sysfs/debugfs access with runtime pm. > > Fixes: f7c8d853b029df ("drm/amdgpu/pm: return an error during GPU reset or > suspend") > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 114

Re: amdgpu doesn't do implicit sync, requires drivers to do it in IBs

2020-05-29 Thread Christian König
Am 28.05.20 um 21:35 schrieb Marek Olšák: On Thu, May 28, 2020 at 2:12 PM Christian König mailto:christian.koe...@amd.com>> wrote: Am 28.05.20 um 18:06 schrieb Marek Olšák: On Thu, May 28, 2020 at 10:40 AM Christian König mailto:christian.koe...@amd.com>> wrote: Am

[bug report] drm/amdkfd: Track SDMA utilization per process

2020-05-29 Thread Dan Carpenter
Hello Mukul Joshi, This is a semi-automatic email about new static checker warnings. The patch 522b89c63370: "drm/amdkfd: Track SDMA utilization per process" from May 26, 2020, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:109

[PATCH][next] drm/amdkfd: fix a dereference of pdd before it is null checked

2020-05-29 Thread Colin King
From: Colin Ian King Currently pointer pdd is being dereferenced when assigning pointer dpm and then pdd is being null checked. Fix this by checking if pdd is null before the dereference of pdd occurs. Addresses-Coverity: ("Dereference before null check") Fixes: 522b89c63370 ("drm/amdkfd: