[PATCH] drm/amdgpu: add ta DTM/HDCP print in amdgpu_firmware_info for apu

2020-09-08 Thread Changfeng.Zhu
From: changzhu From: Changfeng It needs to add ta DTM/HDCP print to get HDCP/DTM version info when cat amdgpu_firmware_info Change-Id: I05f20d6868ce2cac06a8496890b766dbb61de671 Signed-off-by: Changfeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 43 + 1 file

Re: [PATCH 1/2] drm/radeon: Don't use WC for VRAM if !RADEON_GEM_GTT_WC

2020-09-08 Thread Koenig, Christian
Am 09.09.2020 07:29 schrieb Huacai Chen : Though RADEON_GEM_GTT_WC is initially used for GTT, but this flag is bound to drm_arch_can_wc_memory(), and if arch doesn't support WC, then VRAM should not use WC. NAK, If System memory supports WC is completely independent from the VRAM BAR.

Re: [PATCH] drm/amdgpu: add ta DTM/HDCP print in amdgpu_firmware_info for apu

2020-09-08 Thread Huang Rui
On Tue, Sep 08, 2020 at 04:31:11PM +0800, Zhu, Changfeng wrote: > From: changzhu > > From: Changfeng > > It needs to add ta DTM/HDCP print to get HDCP/DTM version info when cat > amdgpu_firmware_info > > Change-Id: I05f20d6868ce2cac06a8496890b766dbb61de671 > Signed-off-by: Changfeng > --- >

RE: [PATCH] drm/amdgpu/pm: Account for extra separator characters in sysfs interface

2020-09-08 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Thanks. Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Matt Coffin Sent: Friday, September 4, 2020 5:06 AM To: amd-gfx@lists.freedesktop.org Cc: Matt Coffin Subject: [PATCH] drm/amdgpu/pm: Account for extra

Re: [PATCH 1/1] drm/amdgpu: Convert to using devm_drm_dev_alloc()

2020-09-08 Thread Luben Tuikov
On 2020-09-07 04:07, Daniel Vetter wrote: > On Mon, Sep 07, 2020 at 10:06:08AM +0200, Daniel Vetter wrote: >> On Sat, Sep 05, 2020 at 11:50:05AM -0400, Alex Deucher wrote: >>> On Thu, Sep 3, 2020 at 9:22 PM Luben Tuikov wrote: Convert to using devm_drm_dev_alloc(), as

Re: [PATCH 1/1] drm/amdgpu: Convert to using devm_drm_dev_alloc()

2020-09-08 Thread Luben Tuikov
On 2020-09-07 04:06, Daniel Vetter wrote: > On Sat, Sep 05, 2020 at 11:50:05AM -0400, Alex Deucher wrote: >> On Thu, Sep 3, 2020 at 9:22 PM Luben Tuikov wrote: >>> >>> Convert to using devm_drm_dev_alloc(), >>> as drm_dev_init() is going away. >>> >>> Signed-off-by: Luben Tuikov >> >> I think we

Re: [PATCH 1/1] drm/amdgpu: Convert to using devm_drm_dev_alloc()

2020-09-08 Thread Luben Tuikov
On 2020-09-05 11:50, Alex Deucher wrote: > On Thu, Sep 3, 2020 at 9:22 PM Luben Tuikov wrote: >> >> Convert to using devm_drm_dev_alloc(), >> as drm_dev_init() is going away. >> >> Signed-off-by: Luben Tuikov > > I think we can drop the final drm_put in the error case? I think the > unwinding

[PATCH 1/1] drm/amdgpu: fix a typo

2020-09-08 Thread Nirmoy Das
Fixes: 9a0154630e958a2f (drm/amdgpu: Bring back support for non-upstream FreeSync) Signed-off-by: Nirmoy Das --- include/uapi/drm/amdgpu_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index

[PATCH 1/4] drm/amdgpu: stop resetting xgmi perfmons on disable

2020-09-08 Thread Jonathan Kim
Disabling perf events does not specify reset in ABI so stop doing it in hardware. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_df.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 23 ++- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git

[PATCH 3/4] drm/amdgpu: add per device user friendly xgmi events for vega20

2020-09-08 Thread Jonathan Kim
Non-outbound data metrics are non useful so mark them as legacy. Bucket new perf counters into device and not device ip. Bind events to chip instead of IP. Report available event counters and not number of hw counter banks. Move DF public macros to private since not needed outside of IP version.

[PATCH 2/4] drm/amdgpu: fix xgmi perfmon a-b-a problem

2020-09-08 Thread Jonathan Kim
Mapping hw counters per event config will cause ABA problems so map per event instead. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_df.h | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 23 -- drivers/gpu/drm/amd/amdgpu/df_v3_6.c| 104 +++-

[PATCH 4/4] drm/amdgpu: add xgmi perfmons for arcturus

2020-09-08 Thread Jonathan Kim
Add xgmi perfmons for Arcturus. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 55 + drivers/gpu/drm/amd/amdgpu/df_v3_6.c| 3 ++ 2 files changed, 58 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c

Re: [PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-08 Thread Daniel Vetter
On Tue, Sep 08, 2020 at 12:02:53PM +0200, Gerd Hoffmann wrote: > > > > The comments I've found suggest very much not ... Or is that all very > > > > old stuff only that no one cares about anymore? > > > > > > I think these days it is possible to override dma_ops per device, which > > > in turn

Re: [PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-08 Thread Gerd Hoffmann
> > > The comments I've found suggest very much not ... Or is that all very > > > old stuff only that no one cares about anymore? > > > > I think these days it is possible to override dma_ops per device, which > > in turn allows virtio to deal with the quirks without the rest of the > > kernel

Re: [PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-08 Thread Daniel Vetter
On Tue, Sep 08, 2020 at 07:48:58AM +0200, Gerd Hoffmann wrote: > On Mon, Sep 07, 2020 at 03:53:02PM +0200, Daniel Vetter wrote: > > On Mon, Sep 7, 2020 at 1:24 PM Gerd Hoffmann wrote: > > > > > > Add drm_device argument to drm_prime_pages_to_sg(), so we can > > > call dma_max_mapping_size() to

Re: [PATCH 4/5] drm_dp_cec: add plumbing in preparation for MST support

2020-09-08 Thread Hans Verkuil
On 01/09/2020 08:22, Sam McNally wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > [sa...@chromium.org: > - rebased > - removed polling-related changes > - moved the calls to drm_dp_cec_(un)set_edid() into the next patch > ] > Signed-off-by: Sam McNally > --- > >

[PATCH] drm/amdgpu: add ta DTM/HDCP print in amdgpu_firmware_info for apu

2020-09-08 Thread Changfeng.Zhu
From: changzhu From: Changfeng It needs to add ta DTM/HDCP print to get HDCP/DTM version info when cat amdgpu_firmware_info Change-Id: I05f20d6868ce2cac06a8496890b766dbb61de671 Signed-off-by: Changfeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 27 - 1 file